D27052: Solid-device-automounter/kcm: Convert some foreach

ervin added inline comments. INLINE COMMENTS > meven wrote in DeviceAutomounter.cpp:73 > Unfortunately this is not possible line 78 requires a non-const ref to volume. const auto for volumes was possible though. I wonder if it wouldn't have made sense to have a non const ref in the loop then.

D27052: Solid-device-automounter/kcm: Convert some foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R119:efdf88ec48b4: Solid-device-automounter/kcm: Convert some foreach (authored by meven). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27052?vs=75840=75841#toc REPOSITORY R119 Plasma Desktop

D27052: Solid-device-automounter/kcm: Convert some foreach

meven added inline comments. INLINE COMMENTS > ervin wrote in DeviceAutomounter.cpp:73 > nitpick, feel free to ignore: would make sense to switch to a const ref here > since we're touching the line anyway. in the same vein, "const auto" on the > line before wouldn't be a bad idea either (if we

D27052: Solid-device-automounter/kcm: Convert some foreach

meven updated this revision to Diff 75840. meven marked an inline comment as done. meven added a comment. Add a space REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27052?vs=74803=75840 BRANCH arcpatch-D27052_1 REVISION DETAIL

D27052: Solid-device-automounter/kcm: Convert some foreach

ervin accepted this revision. ervin added a comment. This revision is now accepted and ready to land. Just a nitpick, your call if you want to tackle it or not. INLINE COMMENTS > DeviceAutomounter.cpp:73 > +const QList volumes = >

D27052: Solid-device-automounter/kcm: Convert some foreach

meven updated this revision to Diff 74803. meven added a comment. Add intermediate const variable for function REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27052?vs=74742=74803 BRANCH arcpatch-D27052 REVISION DETAIL

D27052: Solid-device-automounter/kcm: Convert some foreach

alex added a comment. > if it is a function you don't need to do anything if the function is const (keys()), if not the best practice is to introduce an intermediate const variable That makes everything clear, thank you very much ! REPOSITORY R119 Plasma Desktop REVISION DETAIL

D27052: Solid-device-automounter/kcm: Convert some foreach

meven added a comment. In D27052#603798 , @alex wrote: > Hello, > I have a question regarding your changed. > > you sometimes declare the variables you want to loop over before the loop, but sometimes in the loop. > For instance in

D27052: Solid-device-automounter/kcm: Convert some foreach

alex added a comment. Hello, I have a question regarding your changed. you sometimes declare the variables you want to loop over before the loop, but sometimes in the loop. For instance in DeviceModel.cpp line 135 it is declared as a const before the loop and in line 139 it is

D27052: Solid-device-automounter/kcm: Convert some foreach

meven created this revision. meven added reviewers: broulik, ervin, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. TEST PLAN builds REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL