D28916: fix(kded): center action OSD on wayland
This revision was automatically updated to reflect the committed changes. Closed by commit R104:b3b45721ee17: fix(kded): center action OSD on wayland (authored by bport). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28916?vs=80376=80899#toc REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28916?vs=80376=80899 REVISION DETAIL https://phabricator.kde.org/D28916 AFFECTED FILES kded/osd.cpp kded/qml/OsdSelector.qml To: bport, romangg, davidedmundson Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D28916: fix(kded): center action OSD on wayland
bport added inline comments. INLINE COMMENTS > davidedmundson wrote in OsdSelector.qml:34 > That was confusing, I'll rephrase. > > Is it so the property "x" remains unset when running under the x windowing > environment? Yes I wanted to ensure we don't change it on X Didn't found a way to do it with a binding REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D28916 To: bport, romangg, davidedmundson Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D28916: fix(kded): center action OSD on wayland
davidedmundson added inline comments. INLINE COMMENTS > davidedmundson wrote in OsdSelector.qml:34 > Why are we going for this instead of a binding? > > Is it so X and Y remain unset on X? That was confusing, I'll rephrase. Is it so the property "x" remains unset when running under the x windowing environment? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D28916 To: bport, romangg, davidedmundson Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D28916: fix(kded): center action OSD on wayland
davidedmundson added inline comments.
INLINE COMMENTS
> OsdSelector.qml:34
> +
> +onScreenGeometryChanged: {
> +root.x = screenGeometry.x + (screenGeometry.width - mainItem.width)
> / 2
Why are we going for this instead of a binding?
Is it so X and Y remain unset on X?
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D28916
To: bport, romangg, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D28916: fix(kded): center action OSD on wayland
romangg accepted this revision.
romangg added a comment.
This revision is now accepted and ready to land.
Looks good to me. Also happy @davidedmundson ?
INLINE COMMENTS
> osd.cpp:33
> +#include
> +#include
>
Correct lexicographical order on push.
> osd.cpp:143
> if (auto *rootObject = m_osdActionSelector->rootObject()) {
> +// On wayland use m_output to set action OSD position
> +if (qGuiApp->platformName() == QLatin1String("wayland")) {
Correct grammar on push.
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D28916
To: bport, romangg, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D28916: fix(kded): center action OSD on wayland
bport created this revision. bport added reviewers: romangg, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bport requested review of this revision. REVISION SUMMARY Currently on wayland action OSD is not centered on the screen. On Wayland we will center it on m_output (laptop, with fallback to primary and then to first one). X behavior is not changed. BUG: 397586 REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D28916 AFFECTED FILES kded/osd.cpp kded/qml/OsdSelector.qml To: bport, romangg, davidedmundson Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
