Re: Review Request 129203: Fixes for building plasma-framework

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129203/ --- (Updated Oct. 17, 2016, 3:46 p.m.) Status -- This change has been

Re: Review Request 129203: Fixes for building plasma-framework

> On Oct. 17, 2016, 10:20 a.m., David Edmundson wrote: > > Do you have commit access? > > Alberto Curro wrote: > I don't think so, it's my first patch and I'm newbie to the KDE > development team :) you a re welcome to get one

Re: Review Request 129203: Fixes for building plasma-framework

> On Oct. 17, 2016, 10:20 a.m., David Edmundson wrote: > > Do you have commit access? I don't think so, it's my first patch and I'm newbie to the KDE development team :) - Alberto --- This is an automatically generated e-mail. To

Re: Review Request 129203: Fixes for building plasma-framework

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129203/ --- (Updated Oct. 17, 2016, 2:53 p.m.) Review request for Plasma. Changes

Re: Review Request 129203: Fixes for building plasma-framework

> On Oct. 17, 2016, 8:37 a.m., David Edmundson wrote: > > src/declarativeimports/core/windowthumbnail.cpp, line 231 > > > > > > FWIW: https://git.reviewboard.kde.org/r/129065/ I've changed the code, given a

Re: Review Request 129203: Fixes for building plasma-framework

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129203/#review100077 --- Ship it! Do you have commit access? - David Edmundson

Re: Review Request 129203: Fixes for building plasma-framework

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129203/#review100069 --- src/declarativeimports/core/windowthumbnail.cpp (line 231)

Re: Review Request 129203: Fixes for building plasma-framework

> On Oct. 17, 2016, 4:51 a.m., Anthony Fieroni wrote: > > CMakeLists.txt, line 47 > > > > > > You can't increase minimum deps only for this framework. It's done > > automatically for all and when it's needed.

Re: Review Request 129203: Fixes for building plasma-framework

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129203/ --- (Updated Oct. 17, 2016, 7:35 a.m.) Review request for Plasma. Changes

Re: Review Request 129203: Fixes for building plasma-framework

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129203/#review100058 --- CMakeLists.txt (line 47)

Review Request 129203: Fixes for building plasma-framework

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129203/ --- Review request for Plasma. Repository: plasma-framework Description