Re: new spec (lyricue)
are you all aware who gave +1, that you should be mentoring his commits? :) On Saturday 10 November 2007 01:53:33 Aria Stewart wrote: +1 for me for commit access. On Saturday 10 November 2007 02:06:07 Krystian Tomczyk wrote: +1 On Tuesday 13 November 2007 01:56:42 Arkadiusz Patyk wrote: +1 -- glen ___ pld-devel-en mailing list pld-devel-en@lists.pld-linux.org http://lists.pld-linux.org/mailman/listinfo/pld-devel-en
Re: new spec (lyricue)
On Monday 29 March 2010 14:48:05 Caleb Maclennan wrote: Question about log messages. I noticed after I committed a bump to the version of hugin last night that most log messages for spec file commits start with a leading dash. Does this have a special meaning or is it just convention that I should follow or did I fail in some other way? it is explained in here: http://cvs.pld-linux.org/cgi-bin/cvsweb.cgi/PLD-doc/HACKING also you mind find this useful: http://cvs.pld-linux.org/cgi-bin/cvsweb.cgi/PLD-doc/BuildRequires.txt and these two (depending on your language preference) http://cvs.pld-linux.org/cgi-bin/cvsweb.cgi/PLD-doc/devel-hints-en.txt http://cvs.pld-linux.org/cgi-bin/cvsweb.cgi/PLD-doc/devel-hints-pl.txt however, these may not be exactly up to date, most of the knowledge comes imho via monitoring of spec commits. and when creating new .specs, there are somewhat useful templates: http://cvs.pld-linux.org/cgi-bin/cvsweb.cgi/template-specs/ -- glen ___ pld-devel-en mailing list pld-devel-en@lists.pld-linux.org http://lists.pld-linux.org/mailman/listinfo/pld-devel-en
Re: new spec (lyricue)
Thanks for the links to relevant current developer documentation. I'll keep an eye on those guidelines. I have to say that even having been an avid PLD user for 10+ years the lack of clear easy to find documentation (and the amount of outdated, irrelevant and contradictory documentation floating around in dozens of locations) is making me dizzy. I have subscribed to the cvs commit list and will try to keep up with what's current that way. Caleb 2010/3/29 Elan Ruusamäe g...@pld-linux.org: On Monday 29 March 2010 14:48:05 Caleb Maclennan wrote: Question about log messages. I noticed after I committed a bump to the version of hugin last night that most log messages for spec file commits start with a leading dash. Does this have a special meaning or is it just convention that I should follow or did I fail in some other way? it is explained in here: http://cvs.pld-linux.org/cgi-bin/cvsweb.cgi/PLD-doc/HACKING also you mind find this useful: http://cvs.pld-linux.org/cgi-bin/cvsweb.cgi/PLD-doc/BuildRequires.txt and these two (depending on your language preference) http://cvs.pld-linux.org/cgi-bin/cvsweb.cgi/PLD-doc/devel-hints-en.txt http://cvs.pld-linux.org/cgi-bin/cvsweb.cgi/PLD-doc/devel-hints-pl.txt however, these may not be exactly up to date, most of the knowledge comes imho via monitoring of spec commits. and when creating new .specs, there are somewhat useful templates: http://cvs.pld-linux.org/cgi-bin/cvsweb.cgi/template-specs/ -- glen ___ pld-devel-en mailing list pld-devel-en@lists.pld-linux.org http://lists.pld-linux.org/mailman/listinfo/pld-devel-en
Re: new spec (lyricue)
On Mon, Mar 29, 2010 at 3:05 PM, Caleb Maclennan ca...@pld-linux.org wrote: Thanks for the links to relevant current developer documentation. I'll keep an eye on those guidelines. I have to say that even having been an avid PLD user for 10+ years the lack of clear easy to find documentation (and the amount of outdated, irrelevant and contradictory documentation floating around in dozens of locations) is making me dizzy. I have subscribed to the cvs commit list and will try to keep up with what's current that way. Just don't be afraid to commit - there will be always someone, who will correct you - nothing wrong with that (just ignore rudeness, which may happen when someone has bad day ;). You may ask on the list or irc if not sure about some stuff. Best regards, w ___ pld-devel-en mailing list pld-devel-en@lists.pld-linux.org http://lists.pld-linux.org/mailman/listinfo/pld-devel-en
Re: new spec (lyricue)
On Sat, 10 Nov 2007 01:06:07 +0100, you wrote: Dnia 09-11-2007, Pt o godzinie 16:53 -0700, Aria Stewart pisze: On Nov 9, 2007, at 4:39 PM, Caleb Maclennan wrote: Up until now my contributions have been made by proxy through aredridel, but I have been lurking here on the devel list for some time and decided there was no reason I couldn't offer to be involved more directly. I am experienced as a systems administrator and familiar with PLD, but am fairly green as a developer. If someone is willing to help me over the humps I would be glad to become a contributor and help with specs and docs. +1 for me for commit access. +1 +1 -- Arkadiusz Patyk [areqpld-linux:org] [http://rescuecd.pld-linux.org/] [IRC:areq GG:1383 jid:arekpatyk:net] ___ pld-devel-en mailing list pld-devel-en@lists.pld-linux.org http://lists.pld-linux.org/mailman/listinfo/pld-devel-en
Re: new spec (lyricue)
On Nov 9, 2007, at 4:39 PM, Caleb Maclennan wrote: Up until now my contributions have been made by proxy through aredridel, but I have been lurking here on the devel list for some time and decided there was no reason I couldn't offer to be involved more directly. I am experienced as a systems administrator and familiar with PLD, but am fairly green as a developer. If someone is willing to help me over the humps I would be glad to become a contributor and help with specs and docs. +1 for me for commit access. ___ pld-devel-en mailing list pld-devel-en@lists.pld-linux.org http://lists.pld-linux.org/mailman/listinfo/pld-devel-en
Re: new spec (lyricue)
Dnia 09-11-2007, Pt o godzinie 16:53 -0700, Aria Stewart pisze: On Nov 9, 2007, at 4:39 PM, Caleb Maclennan wrote: Up until now my contributions have been made by proxy through aredridel, but I have been lurking here on the devel list for some time and decided there was no reason I couldn't offer to be involved more directly. I am experienced as a systems administrator and familiar with PLD, but am fairly green as a developer. If someone is willing to help me over the humps I would be glad to become a contributor and help with specs and docs. +1 for me for commit access. +1 -- Pozdrawiam Krystian T. errare humanum est... ___ pld-devel-en mailing list pld-devel-en@lists.pld-linux.org http://lists.pld-linux.org/mailman/listinfo/pld-devel-en
Re: new spec (lyricue)
Caleb Maclennan wrote:
Hello all,
Hi Caleb,
Just few hot comments on your spec:
BuildRoot:%{tmpdir}/%{name}-%{version}-root-%(id -u -n)
Patch0: %{name}-makefile.patch
Patch1: %{name}-desktop.patch
We try to keep the BuildRoot entry as the last in this section. Patch# just
after Sources.
%files
[...]
%dir %{_datadir}/lyricue
maybe just %{_datadir}/lyricue instead of 2 %files entries?
%lang(en_US) %dir %{_datadir}/locale/en_US
%lang(en_US) %dir %{_datadir}/locale/en_US/LC_MESSAGES
%lang(en_US) %{_datadir}/locale/en_US/LC_MESSAGES/lyricue.mo
Is this really different from the default C ? If no - /dev/null
%lang(es_ES) %dir %{_datadir}/locale/es_ES
%lang(es_ES) %dir %{_datadir}/locale/es_ES/LC_MESSAGES
%lang(es_ES) %{_datadir}/locale/es_ES/LC_MESSAGES/lyricue.mo
mv $RPM_BUILD_ROOT%{_datadir}/locale/es{_ES,} in %install
%lang(de) %dir %{_datadir}/locale/de
[...]
%lang(sv) %{_datadir}/locale/sv/LC_MESSAGES/lyricue.mo
... and use %find_lang in %install + %files -l ... instead of all this stuff.
Except making %files shorter, it also allows to avoid packaging of empty
translation files (if any).
%attr(755,root,root) %{_bindir}/lyricue
%attr(755,root,root) %{_bindir}/lyricue_server
%attr(755,root,root) %{_bindir}/lyricue_remote
%attr(755,root,root) %{_bindir}/import_media
Is there anything in the package that should _not_ be packaged?
Maybe %{_bindir}/* instead?
Andrzej
--
===
Andrzej M. Krzysztofowicz [EMAIL PROTECTED]
phone (48)(58) 347 19 36
Faculty of Applied Phys. Math., Gdansk University of Technology
___
pld-devel-en mailing list
pld-devel-en@lists.pld-linux.org
http://lists.pld-linux.org/mailman/listinfo/pld-devel-en
Re: new spec (lyricue)
On Nov 9, 2007, at 5:49 PM, Andrzej Krzysztofowicz wrote:
Caleb Maclennan wrote:
Hello all,
Hi Caleb,
Just few hot comments on your spec:
BuildRoot: %{tmpdir}/%{name}-%{version}-root-%(id -u -n)
Patch0: %{name}-makefile.patch
Patch1: %{name}-desktop.patch
We try to keep the BuildRoot entry as the last in this section.
Patch# just
after Sources.
Indeed. The ./adapter script in the SPECS repo does a lot of this.
___
pld-devel-en mailing list
pld-devel-en@lists.pld-linux.org
http://lists.pld-linux.org/mailman/listinfo/pld-devel-en
Re: new spec (lyricue)
On Fri, Nov 09, 2007 at 06:11:19PM -0700, Aria Stewart wrote: On Nov 9, 2007, at 5:49 PM, Andrzej Krzysztofowicz wrote: We try to keep the BuildRoot entry as the last in this section. Patch# just after Sources. Indeed. The ./adapter script in the SPECS repo does a lot of this. The adapter script did not catch that ordering, but I have fixed it in my spec. I'm trying to sort out the lang stuff Andrzej mentioned and I will resubmit. Caleb ___ pld-devel-en mailing list pld-devel-en@lists.pld-linux.org http://lists.pld-linux.org/mailman/listinfo/pld-devel-en
Re: new spec (lyricue)
Thanks for the pointers Andrzej. I am attaching an updated
spec file with your changes.
Caleb
# $Revision:$, $Date:$
Summary:The GNU Lyric Display System
Name: lyricue
Version:1.9.6
Release:0.6
License:GPL
Group: X11/Applications/Graphics
URL:http://www.adebenham.com/lyricue/
Source0:http://www.adebenham.com/debian/%{name}_%{version}.tar.gz
Patch0: %{name}-makefile.patch
Patch1: %{name}-desktop.patch
Requires: mysql-client
Requires: perl-DBD-mysql
Requires: perl-DBI
Requires: perl-Gnome2-Canvas
Requires: perl-Gtk2-GladeXML
Requires: perl-Gtk2-Spell
Requires: perl-URI
Suggests: perl-Gtk2-TrayIcon
Suggests: perl-Locale-gettext
Suggests: sword-devel
BuildRoot: %{tmpdir}/%{name}-%{version}-root-%(id -u -n)
%description
This application is used to edit/display song lyrics and passages of
text on a second screen/projector for use at live events such as
church services, concerts and seminars.
%prep
%setup -q
%patch0
%patch1
mv docs doc
%build
%{__make}
%install
rm -rf $RPM_BUILD_ROOT
%{make} install DESTDIR=$RPM_BUILD_ROOT
mv $RPM_BUILD_ROOT%{_datadir}/locale/es{_ES,}
%{find_lang} %{name}
%clean
rm -rf $RPM_BUILD_ROOT
%files -f %{name}.lang
%defattr(644,root,root,755)
%dir %{_docdir}/lyricue
%doc %{_docdir}/lyricue/*
%dir %{_sysconfdir}/lyricue
%dir %{_datadir}/lyricue
%{_datadir}/lyricue/*
%config(noreplace) %{_sysconfdir}/lyricue/*
%attr(755,root,root) %{_bindir}/*
%{_desktopdir}/*
%define date%(echo `LC_ALL=C date +%a %b %d %Y`)
%changelog
* %{date} PLD Team [EMAIL PROTECTED]
All persons listed below can be reached at cvs_login@pld-linux.org
$Log:$
___
pld-devel-en mailing list
pld-devel-en@lists.pld-linux.org
http://lists.pld-linux.org/mailman/listinfo/pld-devel-en
Re: new spec (lyricue)
On Saturday 10 November 2007 03:21:36 Caleb Maclennan wrote:
Thanks for the pointers Andrzej. I am attaching an updated
spec file with your changes.
Caleb
%dir %{_docdir}/lyricue
%doc %{_docdir}/lyricue/*
first dir should be also %doc
but rather using rpmbuildroot paths use relative %doc from builddir, then
documents get compressed too:
%doc docs/*
oh, and you can't mix
%doc relative path
and
%doc /full/path
because one or another does rm -rf :)
--
glen
___
pld-devel-en mailing list
pld-devel-en@lists.pld-linux.org
http://lists.pld-linux.org/mailman/listinfo/pld-devel-en
Re: new spec (lyricue)
On Sat, Nov 10, 2007 at 04:16:36AM +0200, Elan Ruusamäe wrote:
but rather using rpmbuildroot paths use relative %doc from builddir, then
documents get compressed too:
%doc docs/*
Ok, this didn't quite make sense to me but I think I figured out
what you were after. See if this fits the bill. It throws a warning
about unpackaged (doc) files on build, but they do end up getting
included and installed correctly so I guess it makes sense.
Thanks for the help.
Caleb
# $Revision:$, $Date:$
Summary:The GNU Lyric Display System
Name: lyricue
Version:1.9.6
Release:0.8
License:GPL
Group: X11/Applications/Graphics
URL:http://www.adebenham.com/lyricue/
Source0:http://www.adebenham.com/debian/%{name}_%{version}.tar.gz
Patch0: %{name}-makefile.patch
Patch1: %{name}-desktop.patch
Requires: mysql-client
Requires: perl-DBD-mysql
Requires: perl-DBI
Requires: perl-Gnome2-Canvas
Requires: perl-Gtk2-GladeXML
Requires: perl-Gtk2-Spell
Requires: perl-URI
Suggests: perl-Gtk2-TrayIcon
Suggests: perl-Locale-gettext
Suggests: sword-devel
BuildRoot: %{tmpdir}/%{name}-%{version}-root-%(id -u -n)
%description
This application is used to edit/display song lyrics and passages of
text on a second screen/projector for use at live events such as
church services, concerts and seminars.
%prep
%setup -q
%patch0
%patch1
%build
%{__make}
%install
rm -rf $RPM_BUILD_ROOT
%{make} install \
DESTDIR=$RPM_BUILD_ROOT
mv $RPM_BUILD_ROOT%{_datadir}/locale/es{_ES,}
%{find_lang} %{name}
%clean
rm -rf $RPM_BUILD_ROOT
%files -f %{name}.lang
%defattr(644,root,root,755)
%dir %{_sysconfdir}/lyricue
%config(noreplace) %{_sysconfdir}/lyricue/*
%attr(755,root,root) %{_bindir}/*
%dir %{_datadir}/lyricue
%{_datadir}/lyricue/*
%doc docs/*
%{_desktopdir}/lyricue.desktop
%{_desktopdir}/lyricue_server.desktop
%define date%(echo `LC_ALL=C date +%a %b %d %Y`)
%changelog
* %{date} PLD Team [EMAIL PROTECTED]
All persons listed below can be reached at cvs_login@pld-linux.org
$Log:$
___
pld-devel-en mailing list
pld-devel-en@lists.pld-linux.org
http://lists.pld-linux.org/mailman/listinfo/pld-devel-en
