Re: [Plplot-devel] Bug fix to plbuf.c

2015-06-16 Thread Phil Rosenberg
...@gmail.com Cc: Alan W. Irwin ir...@beluga.phys.uvic.ca; PLplot development list Plplot-devel@lists.sourceforge.net; Andrew Ross andrewr...@users.sourceforge.net Subject: Re: [Plplot-devel] Bug fix to plbuf.c On Jun 16, 2015, at 4:58 AM, Phil Rosenberg p.d.rosenb...@gmail.com wrote: So how

Re: [Plplot-devel] Bug fix to plbuf.c

2015-06-16 Thread Jim Dishaw
...@gmail.com Cc: Alan W. Irwin mailto:ir...@beluga.phys.uvic.ca; PLplot development list mailto:Plplot-devel@lists.sourceforge.net; Andrew Ross mailto:andrewr...@users.sourceforge.net Subject: Re: [Plplot-devel] Bug fix to plbuf.c On Jun 16, 2015, at 4:58 AM, Phil Rosenberg p.d.rosenb

Re: [Plplot-devel] Bug fix to plbuf.c

2015-06-16 Thread Phil Rosenberg
So how should we go about applying all this? Will we break some drivers when it is applied? If so do we need to have all drivers prepared so that we can apply all the fixes together? Phil On 16 June 2015 at 02:55, Jim Dishaw j...@dishaw.org wrote: And here is the wingcc patch series. I tested

Re: [Plplot-devel] Bug fix to plbuf.c

2015-06-15 Thread Jim Dishaw
And here is the wingcc patch series. I tested with cygwin and msvc and did not have the problem with multiple keypresses. The wingcc driver does seem to have a problem when the window is made small. It cuts off part of the plot. 0002-Updated-the-wingcc-driver-to-reflect-the-changes-for.patch

Re: [Plplot-devel] Bug fix to plbuf.c

2015-06-14 Thread Phil Rosenberg
to the drivers while solution 2 removes some code from the drivers. Phil From: Jim Dishaw Sent: ‎13/‎06/‎2015 17:55 To: Alan W. Irwin Cc: PLplot development list Subject: Re: [Plplot-devel] Bug fix to plbuf.c On Jun 13, 2015, at 12:03 PM, Jim Dishaw j

Re: [Plplot-devel] Bug fix to plbuf.c

2015-06-14 Thread Alan W. Irwin
On 2015-06-13 22:29-0400 Jim Dishaw wrote: On Jun 13, 2015, at 2:11 PM, Jim Dishaw j...@dishaw.org wrote: On Jun 13, 2015, at 1:13 PM, Phil Rosenberg p.d.rosenb...@gmail.com mailto:p.d.rosenb...@gmail.com wrote: Hmmm Then h some more Followed by an ummm or two. As you say Jim,

Re: [Plplot-devel] Bug fix to plbuf.c

2015-06-14 Thread Jim Dishaw
On Jun 14, 2015, at 5:19 AM, Alan W. Irwin ir...@beluga.phys.uvic.ca wrote: On 2015-06-13 22:29-0400 Jim Dishaw wrote: On Jun 13, 2015, at 2:11 PM, Jim Dishaw j...@dishaw.org wrote: On Jun 13, 2015, at 1:13 PM, Phil Rosenberg p.d.rosenb...@gmail.com mailto:p.d.rosenb...@gmail.com

Re: [Plplot-devel] Bug fix to plbuf.c

2015-06-14 Thread Alan W. Irwin
On 2015-06-14 13:40-0400 Jim Dishaw wrote: []The aqt driver is a mystery. It does not use the plot buffer nor does it look at the nopause member; however, it is an interactive driver. It should work with just a NULL in the wait handler because the EOP will be called only once. The dg300 is

Re: [Plplot-devel] Bug fix to plbuf.c

2015-06-14 Thread Jim Dishaw
On Jun 14, 2015, at 5:59 PM, Alan W. Irwin ir...@beluga.phys.uvic.ca wrote: On 2015-06-14 13:40-0400 Jim Dishaw wrote: []The aqt driver is a mystery. It does not use the plot buffer nor does it look at the nopause member; however, it is an interactive driver. It should work with

Re: [Plplot-devel] Bug fix to plbuf.c

2015-06-14 Thread Alan W. Irwin
On 2015-06-14 19:16-0400 Jim Dishaw wrote: I am planning on making a native driver for macos x, though I am not sure if I can make the cutoff for 5.11.1 Hi Jim: Such a native Mac OS X device would be quite welcome. However, that's new development where the cutoff for pushing to the master

Re: [Plplot-devel] Bug fix to plbuf.c

2015-06-14 Thread Hazen Babcock
On 06/14/2015 05:59 PM, Alan W. Irwin wrote: On 2015-06-14 13:40-0400 Jim Dishaw wrote: []The aqt driver is a mystery. It does not use the plot buffer nor does it look at the nopause member; however, it is an interactive driver. It should work with just a NULL in the wait handler

Re: [Plplot-devel] Bug fix to plbuf.c

2015-06-13 Thread Jim Dishaw
On Jun 11, 2015, at 12:29 AM, Jim Dishaw j...@dishaw.org wrote: On Jun 10, 2015, at 11:30 PM, Alan W. Irwin ir...@beluga.phys.uvic.ca wrote: snip Just to confirm that I just now played a lot with resizing of examples/c/x01c -dev xwin for 5.10.0, 5.11.0, and git master tip

Re: [Plplot-devel] Bug fix to plbuf.c

2015-06-13 Thread Phil Rosenberg
development list Plplot-devel@lists.sourceforge.net Subject: Re: [Plplot-devel] Bug fix to plbuf.c On Jun 13, 2015, at 12:03 PM, Jim Dishaw j...@dishaw.org wrote: On Jun 11, 2015, at 12:29 AM, Jim Dishaw j...@dishaw.org wrote: On Jun 10, 2015, at 11:30 PM, Alan W. Irwin ir...@beluga.phys.uvic.ca

Re: [Plplot-devel] Bug fix to plbuf.c

2015-06-13 Thread Jim Dishaw
On Jun 13, 2015, at 12:03 PM, Jim Dishaw j...@dishaw.org wrote: On Jun 11, 2015, at 12:29 AM, Jim Dishaw j...@dishaw.org mailto:j...@dishaw.org wrote: On Jun 10, 2015, at 11:30 PM, Alan W. Irwin ir...@beluga.phys.uvic.ca mailto:ir...@beluga.phys.uvic.ca wrote: snip Just to

Re: [Plplot-devel] Bug fix to plbuf.c

2015-06-13 Thread Phil Rosenberg
/‎06/‎2015 19:11 To: Phil Rosenberg p.d.rosenb...@gmail.com Cc: Alan W. Irwin ir...@beluga.phys.uvic.ca; PLplot development list Plplot-devel@lists.sourceforge.net Subject: Re: [Plplot-devel] Bug fix to plbuf.c On Jun 13, 2015, at 1:13 PM, Phil Rosenberg p.d.rosenb...@gmail.com wrote: Hmmm

Re: [Plplot-devel] Bug fix to plbuf.c

2015-06-13 Thread Jim Dishaw
: Jim Dishaw Sent: ‎13/‎06/‎2015 17:55 To: Alan W. Irwin Cc: PLplot development list Subject: Re: [Plplot-devel] Bug fix to plbuf.c On Jun 13, 2015, at 12:03 PM, Jim Dishaw j...@dishaw.org wrote: On Jun 11, 2015, at 12:29 AM, Jim Dishaw j...@dishaw.org wrote: On Jun 10, 2015, at 11

Re: [Plplot-devel] Bug fix to plbuf.c

2015-06-13 Thread Jim Dishaw
; PLplot development list Subject: Re: [Plplot-devel] Bug fix to plbuf.c On Jun 13, 2015, at 1:13 PM, Phil Rosenberg p.d.rosenb...@gmail.com wrote: Hmmm Then h some more Followed by an ummm or two. As you say Jim, clearly things are more complicated than I realised. I'm not sure what

Re: [Plplot-devel] Bug fix to plbuf.c

2015-06-13 Thread Alan W. Irwin
On 2015-06-13 17:15-0400 Jim Dishaw wrote: On Jun 13, 2015, at 3:25 PM, Phil Rosenberg p.d.rosenb...@gmail.com wrote: Okay, well if you need any help or testing let me know. Something that I haven't seen up to now (but maybe I never looked hard enough) is a spec sheet for how to write a

Re: [Plplot-devel] Bug fix to plbuf.c

2015-06-10 Thread Alan W. Irwin
On 2015-06-09 23:10-0400 Jim Dishaw wrote: On Jun 9, 2015, at 10:39 PM, Alan W. Irwin ir...@beluga.phys.uvic.ca wrote: On 2015-06-09 18:18-0400 Jim Dishaw wrote: Attached is a patch series that corrects a NUL termination bug in the plot buffer that I discovered while working on the windows

Re: [Plplot-devel] Bug fix to plbuf.c

2015-06-10 Thread Jim Dishaw
On Jun 10, 2015, at 11:30 PM, Alan W. Irwin ir...@beluga.phys.uvic.ca wrote: On 2015-06-10 19:58-0400 Jim Dishaw wrote: On Jun 10, 2015, at 3:57 AM, Alan W. Irwin ir...@beluga.phys.uvic.ca wrote: I am sufficiently concerned by your explanation of this fix above that I am now

Re: [Plplot-devel] Bug fix to plbuf.c

2015-06-10 Thread Alan W. Irwin
On 2015-06-10 19:58-0400 Jim Dishaw wrote: On Jun 10, 2015, at 3:57 AM, Alan W. Irwin ir...@beluga.phys.uvic.ca wrote: I am sufficiently concerned by your explanation of this fix above that I am now beginning to wonder a bit if it was necessary. Of course, I could be just missing something,

[Plplot-devel] Bug fix to plbuf.c

2015-06-09 Thread Jim Dishaw
Attached is a patch series that corrects a NUL termination bug in the plot buffer that I discovered while working on the windows GDI driver. I apologize that it has not been uncrustified. Is cygwin required to run the script? 0003-Fixed-a-NUL-termination-bug-in-plbuf.c.patch Description:

Re: [Plplot-devel] Bug fix to plbuf.c

2015-06-09 Thread Alan W. Irwin
On 2015-06-09 18:18-0400 Jim Dishaw wrote: Attached is a patch series that corrects a NUL termination bug in the plot buffer that I discovered while working on the windows GDI driver. Hi Jim: I applied this result to a private branch using git am, styled this result (which was very easy to do,