Hi Alan,
I do not have a particular preference for either this style or the "\n" one (I
only feel a trifle uncomfortable with this implicit concatenation ;)).
Should this style also fail, we may have to put every "variable" command in its
own call to Tcl_Eval(). But let us see whether this
Hi Arjen:
Here is the style of that code (taken from when you first committed it
and that style has been propagated to the sed script that until
my last commit generated that code).
static void set_plplot_parameters( Tcl_Interp *interp ) {
Tcl_Eval( interp, "namespace eval ::PLPLOT { \n\
#
Alan W. Irwin wrote:
>
> Andrew, once you have C++ styled according to uncrustify.cfg could you also
> use your emacs expertise to update plplot-c-style.el to be consistent with
> the styling done by uncrustify.cfg? plplot-c-style.el was taken from the
> Google SOC project and demonstrates how to
The styling of our C source code has been completed as of revision 10545 by
registering all our C source code (found using 'find -name "*.[ch]*" |grep
-v .svn |less') in scripts/style_source.sh and running
'scripts/style_source.sh --apply' repeatedly (sometimes 3 times were
required) until no more
I have been discussing the best means of moving the style project forward
with Andrew off list. He and I are both satisfied with the C style
currently in src/*.c and src/*.h that was created with uncrustify and our
current uncrustify.cfg file. In addition, everybody else seems satisfied
with the
On Thu, Sep 24, 2009 at 11:13:05AM -0700, Alan Irwin wrote:
> On 2009-09-24 16:19+0100 Andrew Ross wrote:
>
>> Alan,
>>
>> One consequence of your change is that long split lines for function
>> definitions etc now indent at the beginning of the line rather than aligning
>> on the brackets. Persona
On 2009-09-24 16:19+0100 Andrew Ross wrote:
> Alan,
>
> One consequence of your change is that long split lines for function
> definitions etc now indent at the beginning of the line rather than aligning
> on the brackets. Personally I don't like that. I'm trying to work out how
> to change this w
On 2009-09-23 22:09-0700 Alan W. Irwin wrote:
> I have compared revisions 10470 and 10456 with the coloured differences
> webpages I mentioned before (i.e.,
> http://plplot.svn.sourceforge.net/viewvc/plplot/trunk/src/?view=diff&r1=10470&r2=10456&diff_format=h)
> where is plarc.c, etc.
>
> I am no
On Wed, Sep 23, 2009 at 10:09:57PM -0700, Alan Irwin wrote:
> Here is what I have done with the style project today.
>
> I discovered that function argument list indentation was way too aggressive.
> I corrected that and some documentation issues with uncrustify.cfg in
> several commits today, but
Here is what I have done with the style project today.
I discovered that function argument list indentation was way too aggressive.
I corrected that and some documentation issues with uncrustify.cfg in
several commits today, but ultimately I also decided to deal with the ugly
line split issue. And
Hi Andrew:
The date of the next release has been been put off so if you have some time
for PLplot right now, I think this would be a good opportunity to attempt
some style cleanup using uncrustify. I feeling I get is our developers don't
care that much about coding style so long as it is consisten
On 2009-07-13 10:01+0100 Andrew Ross wrote:
> On Sun, Jul 12, 2009 at 01:21:55PM -0700, Alan Irwin wrote:
>> Well, we still need that style-conscious volunteer, but to get the ball
>> rolling I just committed uncrustify.cfg in the top-level source tree which I
>> think already does a pretty good j
On Sun, Jul 12, 2009 at 01:21:55PM -0700, Alan Irwin wrote:
> On 2009-07-12 10:19-0700 Alan W. Irwin wrote:
>
> > What is needed now is a volunteer with a keen eye for C/C++ style issues to
> > evaluate uncrustify-0.53 (and the latest versions of the others on the list
> > if uncrustify is unsuita
On 2009-07-12 10:19-0700 Alan W. Irwin wrote:
> What is needed now is a volunteer with a keen eye for C/C++ style issues to
> evaluate uncrustify-0.53 (and the latest versions of the others on the list
> if uncrustify is unsuitable) to find the combination of options which
> enforces the consensus
On 2009-07-12 11:30+0200 Werner Smekal wrote:
> Hi Alan,
>
> sorry for kicking in in this discussion late, but you'll find many more
> programs if you search for
>
> C code beautifier
>
> astyle is quite outdated and there are also some programs out there, which
> are (more) cross platform. Alth
Hi Alan,
sorry for kicking in in this discussion late, but you'll find many
more programs if you search for
C code beautifier
astyle is quite outdated and there are also some programs out there,
which are (more) cross platform. Although this is not a problem a
dedicated guy can regularily
On 2009-07-06 04:09+0300 Dmitri Gribenko wrote:
> [...]astyle is much less strict that indent and it doesn't try to re-format
> everything like indent does. Here's a script for it:
>
> #!/bin/bash
>
> exec astyle \
> --indent=spaces=2 \
> --brackets=linux \
> --indent-classes \
> --indent-swi
Alan W. Irwin writes:
> I have changed to the "style" subject line for this since it touches on
> three separate recent threads with varying subject lines involving style.
>
> On 2009-06-30 15:20-0500 Geoffrey Furnish wrote:
>
> > Oh, one more really last thing. I haven't gotten around to
On Sun, Jul 5, 2009 at 7:08 PM, Alan W. Irwin wrote:
> However, because of the strong possibility that emacs may not be suitable
> for changing the style of our old code, I started looking for other
> coding-style tool alternatives, and the first one I found (called astyle)
> looks interesting. Ple
I have changed to the "style" subject line for this since it touches on
three separate recent threads with varying subject lines involving style.
On 2009-06-30 15:20-0500 Geoffrey Furnish wrote:
> Oh, one more really last thing. I haven't gotten around to trying out Alan's
> proposal for plplot-
20 matches
Mail list logo
