Re: [Plplot-devel] Cannot compile drivers with Visual Studio 2008 (msvc9)

2008-10-09 Thread Arjen Markus
Alan W. Irwin wrote: On 2008-10-08 11:31+0200 Robert Pollak wrote: Hi Alan, Arjen, Alan wrote: Robert, what happens if you add #define PLDLLEXPORT #define PLDLLIMPORT to the #else stanza above? I predict that will fix your problem with the -DBUILD_SHARED_LIBS=OFF case.

Re: [Plplot-devel] Cannot compile drivers with Visual Studio 2008 (msvc9)

2008-10-09 Thread Robert Pollak
Alan W. Irwin wrote: On 2008-10-08 12:56+0200 Robert Pollak wrote: D:\project\PLPlot\drivers\svg.c(341) : error C2143: syntax error : missing ';' before 'type' This is fixed by simply removing the unused int i; line. Can someone please commit this change? I have no idea why that

Re: [Plplot-devel] Cannot compile drivers with Visual Studio 2008 (msvc9)

2008-10-09 Thread Werner Smekal
Hi, sorry, that I (again) kick in late in this discussion, but this change was not the right solution. Actually, the macros PLDLLEXPORT/ PLDLLIMPORT are not to be used outside pldll.h. Only PLDLLIMPEXP should be used in headers and source. This was correctly done for the plplot core

Re: [Plplot-devel] Cannot compile drivers with Visual Studio 2008 (msvc9)

2008-10-09 Thread Robert Pollak
Alan W. Irwin wrote: Could you also confirm you are using ENABLE_DYNDRIVERS=OFF? (I think that result will happen by default since libltdl is not readily available on Windows. You should get a WARNING message from cmake about that.) Yes, In the static build cmake says WARNING: Shared

Re: [Plplot-devel] Cannot compile drivers with Visual Studio 2008 (msvc9)

2008-10-09 Thread Alan W. Irwin
Hi Robert: Two points of information for you below. (Btw, the library names do not differ between Debug and Release build: plplotd.*, plplotcxxd.*, csirocsa.*. So the d ending is misleading.) For PLplot, the d stands for the double-precision version. You can build a single-precision version

Re: [Plplot-devel] Cannot compile drivers with Visual Studio 2008 (msvc9)

2008-10-09 Thread Alan W. Irwin
On 2008-10-09 16:42+0200 Werner Smekal wrote: Hi, sorry, that I (again) kick in late in this discussion, but this change was not the right solution. Actually, the macros PLDLLEXPORT/PLDLLIMPORT are not to be used outside pldll.h. Only PLDLLIMPEXP should be used in headers and source.

Re: [Plplot-devel] Cannot compile drivers with Visual Studio 2008 (msvc9)

2008-10-09 Thread Andrew Ross
On Thu, Oct 09, 2008 at 08:44:34AM -0700, Alan Irwin wrote: On 2008-10-09 16:42+0200 Werner Smekal wrote: Hi, sorry, that I (again) kick in late in this discussion, but this change was not the right solution. Actually, the macros PLDLLEXPORT/PLDLLIMPORT are not to be used outside

Re: [Plplot-devel] Cannot compile drivers with Visual Studio 2008 (msvc9)

2008-10-09 Thread Werner Smekal
Hi Andrew, This may not be quite the right long term solution. Language bindings for example might be importing some symbols from the core library and exporting others to the user. Similarly for drivers. Sure. Ok, I rephrase: this is the correct solution as it was initially considered, but

Re: [Plplot-devel] Cannot compile drivers with Visual Studio 2008 (msvc9)

2008-10-09 Thread Andrew Ross
On Thu, Oct 09, 2008 at 09:09:47PM +0200, Werner Smekal wrote: Hi Andrew, This may not be quite the right long term solution. Language bindings for example might be importing some symbols from the core library and exporting others to the user. Similarly for drivers. Sure. Ok, I

Re: [Plplot-devel] Cannot compile drivers with Visual Studio 2008 (msvc9)

2008-10-09 Thread Alan W. Irwin
On 2008-10-09 20:39+0100 Andrew Ross wrote: It's not quite a cmake issue since we need xxxMAKINGDLL for the driver source file and xxxUSINGDLL for the core header files included by the source file. At the moment these are mutually exclusive so we can't do it with just cmake options. It will

Re: [Plplot-devel] Cannot compile drivers with Visual Studio 2008 (msvc9)

2008-10-09 Thread Andrew Ross
On Thu, Oct 09, 2008 at 03:17:40PM -0700, Alan Irwin wrote: On 2008-10-09 20:39+0100 Andrew Ross wrote: It's not quite a cmake issue since we need xxxMAKINGDLL for the driver source file and xxxUSINGDLL for the core header files included by the source file. At the moment these are

Re: [Plplot-devel] Cannot compile drivers with Visual Studio 2008 (msvc9)

2008-10-08 Thread Arjen Markus
Alan W. Irwin wrote: Hi Robert: Thanks for your report for revision 8861, the latest svn trunk version of PLplot. Arjen, I have a question for you below. On 2008-10-07 17:40+0200 Robert Pollak wrote: [...] cmake -G NMake Makefiles ^ -DCMAKE_BUILD_TYPE=%BUILD_TYPE% ^

Re: [Plplot-devel] Cannot compile drivers with Visual Studio 2008 (msvc9)

2008-10-08 Thread Arjen Markus
Robert Pollak wrote: Arjen Markus wrote: Does this mean you can now properly build static libraries? Yes, I can build them with the mentioned svg.c change and with Alan's: Index: include/pldll.h === --- include/pldll.h

Re: [Plplot-devel] Cannot compile drivers with Visual Studio 2008 (msvc9)

2008-10-08 Thread Robert Pollak
Hi Alan, Arjen, Alan wrote: Robert, what happens if you add #define PLDLLEXPORT #define PLDLLIMPORT to the #else stanza above? I predict that will fix your problem with the -DBUILD_SHARED_LIBS=OFF case. Yes, this fixes the problem in this case (besides some macro redefinition

Re: [Plplot-devel] Cannot compile drivers with Visual Studio 2008 (msvc9)

2008-10-08 Thread Alan W. Irwin
On 2008-10-08 12:56+0200 Robert Pollak wrote: Hi, I wrote: Unfortunately, it makes another compile error in svg.c visible: D:\project\PLPlot\drivers\svg.c(341) : error C2143: syntax error : missing ';' before 'type' This is fixed by simply removing the unused int i; line. Can someone

Re: [Plplot-devel] Cannot compile drivers with Visual Studio 2008 (msvc9)

2008-10-08 Thread Alan W. Irwin
Hi Robert: On 2008-10-08 11:31+0200 Robert Pollak wrote: A build with BUILD_SHARED_LIBS=ON gets problems at the same location (in unmodified rev8861): What happens for revision 8864 for the BUILD_SHARED_LIBS=ON case? Could you also confirm you are using ENABLE_DYNDRIVERS=OFF? (I think that