Re: [Plplot-devel] The pls NULL fix for some Linux platforms

2016-12-18 Thread Alan W. Irwin
On 2016-12-18 15:01-0500 Pedro Vicente wrote: > to summarize, there are 3 options > > 1) Make the stream creation call happen *only* in > frame->Show(); > delete the function > wxPLplotwindow::OnCreate > > this makes the stream creation to always happen in Show(); only > > 2) Leave the code like

Re: [Plplot-devel] The pls NULL fix for some Linux platforms

2016-12-18 Thread Pedro Vicente
d resolution let me know which option you prefer -Pedro - Original Message - From: "Alan W. Irwin" <ir...@beluga.phys.uvic.ca> To: "Pedro Vicente" <pedro.vice...@space-research.org> Cc: "PLplot development list" <plplot-devel@lists.sourceforge.n

Re: [Plplot-devel] The pls NULL fix for some Linux platforms

2016-12-18 Thread Alan W. Irwin
On 2016-12-17 00:38-0800 Alan W. Irwin wrote: [...] > So if that is a good summary of the problem (the timing for when the > OnCreate event fires is not deterministic which your debug output > seems to have proved again and again) doesn't wxwidgets have a decent > way to wait for that event to

Re: [Plplot-devel] The pls NULL fix for some Linux platforms

2016-12-17 Thread Alan W. Irwin
On 2016-12-17 16:19-0500 Pedro Vicente wrote: > Hi Alan > Patch is attached, it's a good idea to have the "git format-patch" format. Hi Pedro: Commit message amended with a slightly different first line + my test Commit pushed (commit 786ff04) with thanks. Alan __ Alan

Re: [Plplot-devel] The pls NULL fix for some Linux platforms

2016-12-17 Thread Pedro Vicente
pment list" <plplot-devel@lists.sourceforge.net> Sent: Saturday, December 17, 2016 4:40 AM Subject: Re: [Plplot-devel] The pls NULL fix for some Linux platforms On 2016-12-17 03:43-0500 Pedro Vicente wrote: There's a small change that must be done in my 2nd patch here bool wxPLplot

Re: [Plplot-devel] The pls NULL fix for some Linux platforms

2016-12-17 Thread Alan W. Irwin
On 2016-12-17 01:40-0800 Alan W. Irwin wrote: > Please go ahead and make a commit to that effect, and send it to me > for pushing. Please include a tested by: paragraph identifying the > system where you did the test similar to how I have been massaging > your recent commit messages when I

Re: [Plplot-devel] The pls NULL fix for some Linux platforms

2016-12-17 Thread Alan W. Irwin
On 2016-12-17 03:43-0500 Pedro Vicente wrote: > There's a small change that must be done in my 2nd patch > > here > > bool wxPLplotwindow::Show(bool show) > { > wxLogDebug("wxPLplotwindow::Show"); > CreateStream(); > WXWINDOW::Show(show); > > } > > > it should be instead > > return

Re: [Plplot-devel] The pls NULL fix for some Linux platforms

2016-12-17 Thread Pedro Vicente
Hi Alan It's kind of late here on the East Coast, so I'll try to elaborate more on the second issue related to the bug later. > I assumed when massaging your > second commit message, that your test debug sequence was on the same > OS as you used in the commit message associated with your first

Re: [Plplot-devel] The pls NULL fix for some Linux platforms

2016-12-17 Thread Pedro Vicente
ember 16, 2016 1:30 PM Subject: Re: [Plplot-devel] The pls NULL fix for some Linux platforms > Hi Alan > > the patch with the 2nd commit with fix is attached > -Pedro > > > On 2016-12-15 20:14, Alan W. Irwin wrote: >> On 2016-12-15 18:39-0500 Pedro Vicente wro

Re: [Plplot-devel] The pls NULL fix for some Linux platforms

2016-12-17 Thread Alan W. Irwin
On 2016-12-16 13:30-0500 Pedro Vicente wrote: > Hi Alan > > the patch with the 2nd commit with fix is attached Hi Pedro: Much thanks for your revised first commit and this second one. I applied them one at a time and for each case ran git commit --amend to massage each commit message (some

Re: [Plplot-devel] The pls NULL fix for some Linux platforms

2016-12-16 Thread Pedro Vicente
Hi Alan the patch with the 2nd commit with fix is attached -Pedro On 2016-12-15 20:14, Alan W. Irwin wrote: On 2016-12-15 18:39-0500 Pedro Vicente wrote: I did what the README file said and here it is my first patch attached:-) what it has it's *just* some print messages (not my fix yet)