Re: [Plplot-devel] Cmake generation with wxWidgets on Windows

On 2016-12-17 03:30-0500 Pedro Vicente wrote: > false alarm, sorry > > what happened is that my wxWidgets libraries were not built. > > In Windows , I don't do install, but rather build software and leave it where > it was built, and sometimes delete and rebuild. > > In PLplot 5.11.1 the build

Re: [Plplot-devel] Cmake generation with wxWidgets on Windows

false alarm, sorry what happened is that my wxWidgets libraries were not built. In Windows , I don't do install, but rather build software and leave it where it was built, and sometimes delete and rebuild. In PLplot 5.11.1 the build actually did not include the wxWidgets projects and files,

Re: [Plplot-devel] The pls NULL fix for some Linux platforms

There's a small change that must be done in my 2nd patch here bool wxPLplotwindow::Show(bool show) { wxLogDebug("wxPLplotwindow::Show"); CreateStream(); WXWINDOW::Show(show); } it should be instead return WXWINDOW::Show(show); gcc let me get away with it, but it's an error in Visual

Re: [Plplot-devel] The pls NULL fix for some Linux platforms

On 2016-12-17 01:40-0800 Alan W. Irwin wrote: > Please go ahead and make a commit to that effect, and send it to me > for pushing. Please include a tested by: paragraph identifying the > system where you did the test similar to how I have been massaging > your recent commit messages when I

Re: [Plplot-devel] The pls NULL fix for some Linux platforms

On 2016-12-16 13:30-0500 Pedro Vicente wrote: > Hi Alan > > the patch with the 2nd commit with fix is attached Hi Pedro: Much thanks for your revised first commit and this second one. I applied them one at a time and for each case ran git commit --amend to massage each commit message (some

Re: [Plplot-devel] The pls NULL fix for some Linux platforms

Hi Alan It's kind of late here on the East Coast, so I'll try to elaborate more on the second issue related to the bug later. > I assumed when massaging your > second commit message, that your test debug sequence was on the same > OS as you used in the commit message associated with your first

Re: [Plplot-devel] The pls NULL fix for some Linux platforms

On 2016-12-17 03:43-0500 Pedro Vicente wrote: > There's a small change that must be done in my 2nd patch > > here > > bool wxPLplotwindow::Show(bool show) > { > wxLogDebug("wxPLplotwindow::Show"); > CreateStream(); > WXWINDOW::Show(show); > > } > > > it should be instead > > return

Re: [Plplot-devel] The pls NULL fix for some Linux platforms

Hi Alan Patch is attached, it's a good idea to have the "git format-patch" format. -Pedro - Original Message - From: "Alan W. Irwin" To: "Pedro Vicente" Cc: "PLplot development list"

[Plplot-devel] Freeze is now official

This is the official notice from your release manager that the soft freeze is in effect from now until the release. What this means in practical terms is during this test period starting now and ending with the actual release (likely ~10 days from now) you are strongly discouraged from pushing

Re: [Plplot-devel] Cmake generation with wxWidgets on Windows

Hi Alan > (3) Static PLplot libraries + device driver code embedded in our core > static library (identified by its "plplot" basename). I always use (3). I repeated what I had done before: My wxwidgets libraries are located at M:\wx\wxwidgets-3.1.0\lib\vc_lib here there are several .lib

Re: [Plplot-devel] Cmake generation with wxWidgets on Windows

attached cmake.out.txt = first cmake run without existing .libs cmake.out.2.txt = second cmake run with existing .libs - Original Message - From: "Pedro Vicente" To: "Alan W. Irwin" Cc: "PLplot development list"

Re: [Plplot-devel] Comprehensive testing

On 2016-12-16 19:00-0800 Alan W. Irwin wrote: > For your new installation of MinGW-w64/MSYS2 there is still a lot of > package installation incompleteness, see footnotes j1, C1, D1, D2, F1, > G2, H2, I1, and J1. But it is a good start that is suitable for this > release, and I will remark more

Re: [Plplot-devel] The pls NULL fix for some Linux platforms

On 2016-12-17 16:19-0500 Pedro Vicente wrote: > Hi Alan > Patch is attached, it's a good idea to have the "git format-patch" format. Hi Pedro: Commit message amended with a slightly different first line + my test Commit pushed (commit 786ff04) with thanks. Alan __ Alan

Re: [Plplot-devel] Cmake generation with wxWidgets on Windows

On 2016-12-17 19:25-0500 Pedro Vicente wrote: > > Hi Alan > >> (3) Static PLplot libraries + device driver code embedded in our core >> static library (identified by its "plplot" basename). > > I always use (3). > > I repeated what I had done before: > > My wxwidgets libraries are located at > >