Re: [Plplot-devel] Bug in notcrossed() function of plfill.c

.com] Sent: Saturday, September 17, 2016 10:58 PM To: Arjen Markus Cc: Alan W. Irwin; plplot-devel@lists.sourceforge.net Subject: Re: [Plplot-devel] Bug in notcrossed() function of plfill.c Hi Arjen I'm just emailing to say that I have now got plplot to compile with wxWidgets support on Cygwin and I

Re: [Plplot-devel] Bug in notcrossed() function of plfill.c

Phil said: > I have modified my the example that exposes the bug so that it works for svg. Please find attached. Thanks, Phil, for this revised example which I confirm does trigger the "all-fill" bug for -dev svg here (Debian Jessie platform) as well. I have no further time to work on this

Re: [Plplot-devel] Bug in notcrossed() function of plfill.c

;> >> >> >> Regards, >> >> >> >> Arjen >> >> >> >> >> >> *From:* Phil Rosenberg [mailto:p.d.rosenb...@gmail.com] >> *Sent:* Friday, September 16, 2016 4:25 PM >> *To:* Arjen Markus; Alan W. Irwin >> >&

Re: [Plplot-devel] Bug in notcrossed() function of plfill.c

m source? > > > > Sent from my Windows 10 phone > > > > *From: *Arjen Markus <arjen.mar...@deltares.nl> > *Sent: *16 September 2016 08:08 > *To: *Alan W. Irwin <ir...@beluga.phys.uvic.ca>; Phil Rosenberg > <p.d.rosenb...@gmail.com> > *Cc: *plplo

Re: [Plplot-devel] Bug in notcrossed() function of plfill.c

Hi Phil, As a package, definitely. Regards, Arjen From: Phil Rosenberg [mailto:p.d.rosenb...@gmail.com] Sent: Friday, September 16, 2016 4:25 PM To: Arjen Markus; Alan W. Irwin Cc: plplot-devel@lists.sourceforge.net Subject: RE: [Plplot-devel] Bug in notcrossed() function of plfill.c

Re: [Plplot-devel] Bug in notcrossed() function of plfill.c

Hi Arjen I'm just trying to reproduce your Cygwin problems, but I can't get plplot to build with wxWidgets on. Do you know if you installed wxWidgets as a package or from source? Sent from my Windows 10 phone From: Arjen

Re: [Plplot-devel] Bug in notcrossed() function of plfill.c

> From: Alan W. Irwin [mailto:ir...@beluga.phys.uvic.ca] > Sent: Tuesday, September 13, 2016 11:59 PM > To: Phil Rosenberg > Cc: Arjen Markus; plplot-devel@lists.sourceforge.net > Subject: Re: [Plplot-devel] Bug in notcrossed() function of plfill.c > > On 2016-09-13 10:44+0100 Phi

Re: [Plplot-devel] Bug in notcrossed() function of plfill.c

On 2016-09-13 10:44+0100 Phil Rosenberg wrote: > On 13 September 2016 at 03:27, Alan W. Irwin > wrote: >> There is a substantial testing requirement for fill changes. The >> reason for that is we have had years of mostly good user experience >> with the present fill

Re: [Plplot-devel] Bug in notcrossed() function of plfill.c

Hi Alan, Arjen On 13 September 2016 at 03:27, Alan W. Irwin wrote: > On 2016-09-12 21:39+0100 Phil Rosenberg wrote: > > I'm still of the opinion that the notcrossed function should not use > the 2 pixel fuzziness. At this point in the drawing we are dealing in

Re: [Plplot-devel] Bug in notcrossed() function of plfill.c

Oh, I didn't realise you were working on Windows Arjen. I will have to spend some time sorting out a case for the SVG driver then. Unfortunately it was about 4 hours work finding a suitable test case before, but hopefully now I understand the bug better it should be faster - but it probably won't

Re: [Plplot-devel] Bug in notcrossed() function of plfill.c

Hi Phil, > -Original Message- > From: Phil Rosenberg [mailto:p.d.rosenb...@gmail.com] > > ... > I assume this has something to do with aspect ratios of the page on the > different > devices or something. But anyway, these inconsistent sizes means it isn't > possible > to generate a

Re: [Plplot-devel] Bug in notcrossed() function of plfill.c

On 13 September 2016 at 02:13, Alan W. Irwin wrote: > On 2016-09-12 21:21+0100 Phil Rosenberg wrote: > >> Hi Alan >> I just built on Ubuntu (disabling F95 due to the issue I reported a >> short while ago). I get the same full fill issue with wxWidgets, but >> not with

Re: [Plplot-devel] Bug in notcrossed() function of plfill.c

Hi Phil, Alan, > -Original Message- > From: Alan W. Irwin [mailto:ir...@beluga.phys.uvic.ca] > > @Arjen: I am interested whether gcc on Cygwin for this current example > triggers > the bug or not. > I will test it but it may be a one or two days before I get around to it. Regards,

Re: [Plplot-devel] Bug in notcrossed() function of plfill.c

On 2016-09-12 21:39+0100 Phil Rosenberg wrote: I'm still of the opinion that the notcrossed function should not use the 2 pixel fuzziness. At this point in the drawing we are dealing in integer pixels and we need only an epsilon test I think. I think the best fix is to change

Re: [Plplot-devel] Bug in notcrossed() function of plfill.c

On 2016-09-12 21:21+0100 Phil Rosenberg wrote: > Hi Alan > I just built on Ubuntu (disabling F95 due to the issue I reported a > short while ago). I get the same full fill issue with wxWidgets, but > not with other drivers. I guess each driver may use slightly different > geometry so it ruins the

Re: [Plplot-devel] Bug in notcrossed() function of plfill.c

sorry meant "no doubt that the point" not "no count that the point" On 12 September 2016 at 21:39, Phil Rosenberg wrote: I'm still of the opinion that the notcrossed function should not use the 2 pixel fuzziness. At this point in the drawing we are dealing in

Re: [Plplot-devel] Bug in notcrossed() function of plfill.c

>>> I'm still of the opinion that the notcrossed function should not use >>> the 2 pixel fuzziness. At this point in the drawing we are dealing in >>> integer pixels and we need only an epsilon test I think. I think the >>> best fix is to change this. There are some sticking plaster solutions >>>

Re: [Plplot-devel] Bug in notcrossed() function of plfill.c

Hi Alan I just built on Ubuntu (disabling F95 due to the issue I reported a short while ago). I get the same full fill issue with wxWidgets, but not with other drivers. I guess each driver may use slightly different geometry so it ruins the example. Please could you try with wxWidgets driver or

Re: [Plplot-devel] Bug in notcrossed() function of plfill.c

Hi Phil: It was good to hear from you again. On 2016-09-12 03:06+0100 Phil Rosenberg wrote: > Hi All > It's been a while. Sorry for my lack of activity over the summer. I took quite a long break from PLplot this summer as well. So no worries about that. > > I've just picked up some Plplot

Re: [Plplot-devel] Bug in notcrossed() function of plfill.c

Hi Phil, > -Original Message- > From: Phil Rosenberg [mailto:p.d.rosenb...@gmail.com] > > In this special case the three short sides are all approximately 2 Plplot > internal units > long which fools the intersection test into thinking they are close to > parallel to the > test line.

Re: [Plplot-devel] Bug in notcrossed() function of plfill.c

Hi All It's been a while. Sorry for my lack of activity over the summer. I've just picked up some Plplot items again on my to do list, starting with the fill problem that I reported a rather long time ago. I have sorted a minimal example to reproduce the bug - see attached. it turns out that a

Re: [Plplot-devel] Bug in notcrossed() function of plfill.c

Hi Can we reopen this again please. I have just hit another case where when plotting a contour plot something goes wrong and the whole plot gets filled. Alan, you said you were going to see if you could work out why the fuzzy logic was needed and I said I would try to generate a test case. I know

Re: [Plplot-devel] Bug in notcrossed() function of plfill.c

p.d.rosenb...@gmail.com Cc: plplot-devel@lists.sourceforge.net plplot-devel@lists.sourceforge.net Subject: Re: [Plplot-devel] Bug in notcrossed() function of plfill.c Hi Phil: I have been looking carefully at the parts of the fill code that are affected by notcrossed, and I think we are dealing

Re: [Plplot-devel] Bug in notcrossed() function of plfill.c

...@beluga.phys.uvic.ca] Sent: Monday, June 15, 2015 11:59 PM To: Phil Rosenberg Cc: Arjen Markus; plplot-devel@lists.sourceforge.net Subject: RE: [Plplot-devel] Bug in notcrossed() function of plfill.c On 2015-06-15 21:07+0100 Phil Rosenberg wrote: I will have to try out git blame then. I imagined

Re: [Plplot-devel] Bug in notcrossed() function of plfill.c

/‎06/‎2015 19:18 To: Phil Rosenberg p.d.rosenb...@gmail.com Cc: Arjen Markus arjen.mar...@deltares.nl; plplot-devel@lists.sourceforge.net plplot-devel@lists.sourceforge.net Subject: Re: [Plplot-devel] Bug in notcrossed() function of plfill.c Hi Phil: git blame is your friend

Re: [Plplot-devel] Bug in notcrossed() function of plfill.c

Hi Phil, I do not remember who wrote it, I may have made some changes to it in a now distant past, but I could have a look at your fix. Regards, Arjen -Original Message- From: Phil Rosenberg [mailto:p.d.rosenb...@gmail.com] Sent: Monday, June 15, 2015 11:35 AM To:

Re: [Plplot-devel] Bug in notcrossed() function of plfill.c

Hi Arjen I've just copied the code below as I don't just have time at the moment to sort a git patch (The plot I was making is for a presentation this afternoon!). The old code has been commented out with /* */ and my new code is directly above that from the #ifdef onwards. Basically I get that

Re: [Plplot-devel] Bug in notcrossed() function of plfill.c

On Monday, June 15, 2015 at 11:18:33 (-0700) Alan W. Irwin writes: Hi Phil: git blame is your friend for figuring out who authored what, and it turns out I am virtually (except for a change by Hez) the sole author of notcrossed, but IIRC, that built on top of what Arjen had done before

Re: [Plplot-devel] Bug in notcrossed() function of plfill.c

Hi Phil: git blame is your friend for figuring out who authored what, and it turns out I am virtually (except for a change by Hez) the sole author of notcrossed, but IIRC, that built on top of what Arjen had done before with (embedded logic rather than a function) which built on top of what

Re: [Plplot-devel] Bug in notcrossed() function of plfill.c

...@beluga.phys.uvic.ca Sent: ‎15/‎06/‎2015 19:18 To: Phil Rosenberg p.d.rosenb...@gmail.com Cc: Arjen Markus arjen.mar...@deltares.nl; plplot-devel@lists.sourceforge.net plplot-devel@lists.sourceforge.net Subject: Re: [Plplot-devel] Bug in notcrossed() function of plfill.c Hi Phil: git blame is your

Re: [Plplot-devel] Bug in notcrossed() function of plfill.c

Cc: Arjen Markus arjen.mar...@deltares.nl; plplot-devel@lists.sourceforge.net plplot-devel@lists.sourceforge.net Subject: Re: [Plplot-devel] Bug in notcrossed() function of plfill.c Hi Phil: git blame is your friend for figuring out who authored what, and it turns out I am virtually (except