Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-14 Thread adhawkins
mherger wrote: > I guess I'm too late... but I'd suggest you only use numerical version > numbers, no alpha/beta etc. additions That's what I've done, started with 0.99.x for the pre-release versions. Will eventually release a 1.0 when any kinks are ironed out. Andy

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-14 Thread Michael Herger
Are we allowed descriptors like alpha, beta etc. in the version number in the repo and install.xml? I guess I'm too late... but I'd suggest you only use numerical version numbers, no alpha/beta etc. additions. -- Michael ___ plugins mailing list

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-13 Thread adhawkins
Ok, SimpleLibraryView it is then. I'll do the renaming now, and post up an updated repo at some point. Will release the next version as 0.99.0, with a view to this eventually becoming 1.0. Once this is done I'll create an announcement post to see if there's a wider interest. Are we allowed

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-13 Thread kidstypike
adhawkins wrote: > Any suggestions? > > EasyLibraryView > SimpleLibraryView > > ? > > I'd be tempted to rename all the files etc., at the end of the day I > suspect there are at most 3 people who have it installed. If I changed > the UID as well, then it'll just be a question of asking people

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-13 Thread adhawkins
mherger wrote: > And yes, I would change it. Any suggestions? EasyLibraryView SimpleLibraryView ? I'd be tempted to rename all the files etc., at the end of the day I suspect there are at most 3 people who have it installed. If I changed the UID as well, then it'll just be a question of

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-13 Thread Michael Herger
Any comment on the naming question? Is the name of the plugin Ok as it stands? If I were to rename it but keep the same UID would the server handle the transition? As long as you don't rename the perl module that should be ok. The user facing name is just a text in the XML or strings.txt file.

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-13 Thread adhawkins
Ah, so *that's* what that setting was for! :) Ok, seems to be doing the correct thing now. Any comment on the naming question? Is the name of the plugin Ok as it stands? If I were to rename it but keep the same UID would the server handle the transition? Andy

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-13 Thread Michael Herger
Should my initPlugin get run from within the scanner? It doesn't seem to be. Oops... did I tell you to remove the importmodule definition from the install.xml? That's actually required, otherwise the plugin is not loaded in the scanner... I'm sorry about the confusion. -- Michael

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-13 Thread adhawkins
Hmmm, just tried that. The scan seems to have run after changing preferences, but initPlugin wasn't executed, so the new libraries weren't registered. Something I missed? Andy adhawkins's Profile:

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-13 Thread Michael Herger
How do I trigger a scan? Slim::Control::Request::executeRequest( undef, [ 'rescan' ] ); -- Michael ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-13 Thread adhawkins
Hmmm, it appears that the new libraries aren't being registered by the scan process, based on what kidstypike has just said. Should my initPlugin get run from within the scanner? It doesn't seem to be. If it isn't, how can I ensure that the registerLibrary call is made by the scanner? Andy

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-13 Thread kidstypike
Just an observation .. ATM adding an "easy-virtual-library-test" file to an album folder doesn't actually do anything, a new and changed scan doesn't do anything either. The only way to get the album into a virtual library is to make a change on the Easy Virtual Library settings page, and click

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-13 Thread adhawkins
mherger wrote: > Yes, that's fine. But you shouldn't need to run the library creation > from there. Trigger a scan instead. Ah ok, hadn't fully understood that. How do I trigger a scan? Andy adhawkins's Profile:

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-13 Thread Michael Herger
@mherger: Point taken, but I have to register the libraries sometime, and I figured the best way to do this was after the settings had changed. If I don't do that, then the scanner won't know about the new libraries will it? Yes, that's fine. But you shouldn't need to run the library creation

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-13 Thread adhawkins
Another question, any comments on the name of the plugin? I was wondering whether 'Easy Library Views' might be more descriptive (the option in the web interface and player for selecting between them is called 'Library Views'. If I were to rename the plugin, but keep the same ID in the

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-13 Thread adhawkins
Hi, @kidstypike: I think the creation of the first library might have an issue. There are a couple of warnings in the log that refer to using an uninitialised value. I'll do some digging into it this evening to see if I can track it down. @mherger: Point taken, but I have to register the

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-13 Thread Michael Herger
So .. I created another additional virtual library "wife", and clicked apply, this took upwards of a minute for the spinney on the settings page tab to stop. Andy - you shouldn't try to build the library from within the settings pages. Just leave it to the scanner. Yes, I know it's slower. But

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-13 Thread kidstypike
Yes, I had already added "test" to the settings page, and clicked apply, I believe this then creates the virtual library "test". So .. I created another additional virtual library "wife", and clicked apply, this took upwards of a minute for the spinney on the settings page tab to stop. I now

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-13 Thread adhawkins
Excellent. I'll try to add some extra information to the plugin settings page and get a 'final' test release out. @kidstypike, did you manage to get things added to the library view by correcting the file name? Thanks Andy

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-13 Thread Michael Herger
I've added a bit more detail to the README.md on GitHub. Do you think that's sufficient? Yes. Much clearer imho. -- Michael ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-13 Thread adhawkins
Ok, understood. I think kidspype did add it to the settings page, but then got the filename wrong in the album directory (he made a .txt file, when it expects a file with no extension). I've added a bit more detail to the README.md on GitHub. Do you think that's sufficient?

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-13 Thread Michael Herger
If that's not clear enough from the GitHub README, then please let me know and I'll try to add some more details to it. I agree that the documentation on the Plugin's settings page isn't enough, but before I do too much on that page, I'd like to know if the GitHub README is considered sufficient,

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-13 Thread adhawkins
I thought that was covered in the README I pointed to at GitHub. The setting lists all of the libraries views that should exist. The file(s) in the music folder indicates which albums should be included in which view. If that's not clear enough from the GitHub README, then please let me know

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-13 Thread Michael Herger
Yes file ext. is .txt That might be the issue, the file shouldn't have an extension... Can you try renaming the file and see if it now works? I think this discussion pretty much shows what I was missing from the documentation: what exact filename is the plugin expecting? What's the setting

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-13 Thread adhawkins
kidstypike wrote: > Yes file ext. is .txt That might be the issue, the file shouldn't have an extension... Can you try renaming the file and see if it now works? Thanks Andy adhawkins's Profile:

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-13 Thread kidstypike
adhawkins wrote: > Did you add 'test' to the list of libraries in the plugin's settings > page? > > Can you change the logging settings for 'plugin.easyvirtuallibrary' to > 'debug', re-run the scan and post your server.log file here? > > Edit: The screen shot you sent doesn't show file

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-13 Thread adhawkins
kidstypike wrote: > Followed instructions and created a text file named > 'easy-virtual-library-test', and put it alongside music files within an > album folder. > > Ran "new and Changed" scan, EasyVirtualLibrary "test" created but > contains no tracks? Did you add 'test' to the list of

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-13 Thread kidstypike
adhawkins wrote: > Ok, just changed all my URLs to HTTPS and managed to install everything > correctly. It still didn't prompt me to restart the server after the > installation so, so what appears to happen is that all reference to the > plugin disappears from the plugins page... > > Regarding

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-13 Thread adhawkins
Ok, just changed all my URLs to HTTPS and managed to install everything correctly. It still didn't prompt me to restart the server after the installation so, so what appears to happen is that all reference to the plugin disappears from the plugins page... Regarding the settings page, does the

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-13 Thread Michael Herger
No problem, and glad it's been fixed. Does it also allow the repository URL to work over https:// ? Yes, it should in general. But there have been reports of installations which lacked some Perl modules required to do SSL. In those cases we fail. Is that the build I'll have downloaded this

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-13 Thread kidstypike
Just to encourage ... Seems to have installed ok ... not a clue what it does though ... :confused: +---+ |Filename: Pic03.jpg| |Download:

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-13 Thread adhawkins
mherger wrote: > Wow... I'm surprised we didn't hit this before. That's a bug in the > plugin manager. It would not accept anything but http://. That's fixed > in the next build. Thanks for the heads up! No problem, and glad it's been fixed. Does it also allow the repository URL to work over

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-13 Thread Michael Herger
I was hosting the binaries on github, and the URL in the repo was https:// Wow... I'm surprised we didn't hit this before. That's a bug in the plugin manager. It would not accept anything but http://. That's fixed in the next build. Thanks for the heads up! I tried changing it to http, and

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-12 Thread adhawkins
Ok, not sure, but I think I might have made a little progress. I was hosting the binaries on github, and the URL in the repo was https:// I tried changing it to http, and started getting 403 errors downloading from github. So, I moved it to my own server on an http URL. After much deleting of

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-12 Thread adhawkins
mherger wrote: > > Odd, if I change the repo to an HTTP URL, it gets added successfully. > > Presumably I'm missing a perl module to handle HTTPS URLs? > > I've noticed the same. Would have to further investigate to be sure > what's going on there. > Ok. That might be an issue as I might end

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-12 Thread Michael Herger
Odd, if I change the repo to an HTTP URL, it gets added successfully. Presumably I'm missing a perl module to handle HTTPS URLs? I've noticed the same. Would have to further investigate to be sure what's going on there. OTOH there have been other reports about the plugin management starting

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-12 Thread adhawkins
Odd, if I change the repo to an HTTP URL, it gets added successfully. Presumably I'm missing a perl module to handle HTTPS URLs? However, I'm now back at the stage where it gets added to the server disabled, in the 'updates available' section. If I tick that and apply, it disappears until I

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-12 Thread adhawkins
adhawkins wrote: > Rather than do that, I think I'll just generate a new VM and re-install > from scratch. > Well, I would do that, but the version in the new VM I've just created won't let me add my repo...it just doesn't save it. Grr... Andy

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-12 Thread adhawkins
Hi, mherger wrote: > I don't get it. Looking at install.xml again: remove the importmodule > value. You don't have an importer, do you? > Ummm, probably not. That install.xml file was just copied from another plugin and modified, so I may well have copied one that had an importer. I'll try

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-12 Thread Michael Herger
There might be something else I've missed? Any chance you can have another look? I don't get it. Looking at install.xml again: remove the importmodule value. You don't have an importer, do you? The id: did you create that UUID yourself? Or did you get it somewhere? - go to

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-11 Thread adhawkins
Thanks for the advice about the second server. Now running that 'live' on the same network and all seems well. I've made the change you suggest to the plugin xml file, and I think it's *nearly* there. Now, when I install it, it just disappears completely from the plugin list, with no popup

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-11 Thread Michael Herger
Can I be sure that having a second server on the network won't suddenly make my existing players start to use this second server? My daughter has her Radio running at night while she sleeps, and I'd hate any development I do to stop her music from working! Don't worry. I'm running multiple LMS

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-11 Thread Michael Herger
I'm obviously doing something wrong either in the creation of the ZIP file or the repo.xml. Don't set the defaultState to disabled (in install.xml), but enabled. It won't be installed unless the user decides to do so. And why install if you don't want to enable it anyway? This might

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-11 Thread adhawkins
Ok, I've built a test version and created a repo. The repo is here: https://software.gently.org.uk/slim-plugins/repo.xml If I add that repo to my server, I then see an entry for EasyVirtualLibrary. If I check that entry, it seems to install, but then after that it seems to hop between either

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-11 Thread adhawkins
That's great Michael, I'll try that script out this evening. Thanks also for the information regarding clearing out the library_tracks table. I just wanted to be sure I wasn't doing anything wrong or had missed a step. I might add an unregister callback to empty the table just so that I'm doing

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-10 Thread mherger
adhawkins wrote: > What's the simplest way of building the ZIP file and then an associated > repository for it? I'd ideally like to automate as much as possible. Here's my little build script. Change the file extension and the repository URL to your liking. As long as you don't have a URL it

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-10 Thread Michael Herger
Something else I've just noticed, if I unregister a Virtual Library, the entries in the library_track table remain until a clear library and rescan is carried out. Do I need to do something to have these entries cleared out? No need, I'd say. Even though the data is still there it wouldn't be

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-10 Thread adhawkins
Something else I've just noticed, if I unregister a Virtual Library, the entries in the library_track table remain until a clear library and rescan is carried out. Do I need to do something to have these entries cleared out? Andy

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-10 Thread adhawkins
Ok, think I've got something that seems to work on a test server I've spun up. I think I'm now ready to package it up, set up a repository for it and add it to my live server. What's the simplest way of building the ZIP file and then an associated repository for it? I'd ideally like to automate

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-10 Thread Michael Herger
Any pointers? I think I'll do it as a single edit field initially, give a semicolon separated list of libraries. Presumably there's a way of triggering a scan if this list of libraries changes? The CLI plugin probably has the simplest settings page:

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-10 Thread adhawkins
Doh, my bad. I was looking in the server log. Seems the entries that happen after a scan end up in scanner.log. :o Now to work out how to create a web page for preferences so that I can name the libraries to scan for... Any pointers? I think I'll do it as a single edit field initially, give a

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-10 Thread Michael Herger
Before I do this, any log settings relating to the scanner etc. that might be worth turning on as well? Try scan.import and database.virtuallibraries. -- Michael ___ plugins mailing list plugins@lists.slimdevices.com

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-10 Thread adhawkins
Hi Michael, Thanks for the response. I'm pretty sure that my functions were not being called during a rescan. I'll try to remember to have another look this evening, and post appropriate logs her in case they help. Before I do this, any log settings relating to the scanner etc. that might be

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-09 Thread Michael Herger
However, I'm finding that once I've done this, my callback is never called again. Even not during a rescan? I presume it's because the scanner logic is deciding that it doesn't need to rebuild my library, as no changes have been detected during the scan. No, any rescan should just call it.

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-09 Thread Michael Herger
Do you think there'd be any interest in this in the wider community? I I think so. Probably not by the thousands. But there have been requests for a simple way to define such a multi-library view several times. -- Michael ___ plugins mailing list

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-06 Thread adhawkins
Ok, I think I've made some progress on this. I've created a library, and in the callback for that library, I iterated over every track in the tracks table, checking if a file exists in the directory for each track. If I find the file, I add the track id and library id to the library_track table.

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-05 Thread adhawkins
Ok, I'll start out just trying to get it working, and then look at optimising it if it seems necessary. Do you think there'd be any interest in this in the wider community? I guess I could then look at adding some sort of configuration pages to allow the creation of libraries. Thinking that

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-05 Thread Michael Herger
And these libraries would be updated whenever a new scan occurred? Yes. I might be tempted to try to cache the data from the files containing library names into a database somehow. I notice that in the database directory is a database called 'PluginCache-SQLPlayList.db'. Is there some

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-05 Thread adhawkins
Ooh, that sounds promising. And these libraries would be updated whenever a new scan occurred? I might be tempted to try to cache the data from the files containing library names into a database somehow. I notice that in the database directory is a database called 'PluginCache-SQLPlayList.db'.

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-05 Thread mherger
Oh, I think this could be much easier. Create a simple plugin which has at least a sub initPlugin. In there you're going to register your libraries: Code: Slim::Music::VirtualLibraries->registerLibrary( { id => 'userA', name =>

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-05 Thread adhawkins
mherger wrote: > How did you plan to present those filtered lists to the users? As > virtual libraries? > Exactly that, yes. I just need some 'easy' way to filter tracks for those virtual libraries. An extra tag (or even perhaps re-using 'Genre') seemed like the easiest way to do this.

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-04 Thread Michael Herger
I'm considering writing a plugin to allow 'extra' tags to be read from a text file in the same directory as a music file. I want to do this to add the ability to easily filter my music for each user in our household, but don't want to modify the tags in the music files themselves, as these are

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-04 Thread adhawkins
Thanks for the pointer, looks like a good starting point. Doesn't seem to interact with the scanning process though, which I think is a key piece of the functionality I need. Looking at the Full Text Search plugin at the moment, trying to work out how that all hangs together. Andy

Re: [SlimDevices: Plugins] New plugin, where to start?

2016-05-04 Thread reinholdk
There's a plugin called Files Viewer (Song File Viewer Plugin) by Phil Meyer. Never tried it but from looking at the description, it seems that you can get some ideas from it. reinholdk's Profile:

[SlimDevices: Plugins] New plugin, where to start?

2016-05-04 Thread adhawkins
Hi all, I'm considering writing a plugin to allow 'extra' tags to be read from a text file in the same directory as a music file. I want to do this to add the ability to easily filter my music for each user in our household, but don't want to modify the tags in the music files themselves, as