Re: [pmacct-discussion] Added support for durable messages to amqp plugin

2014-02-24 Thread Nick Douma
Hi, On 22-02-14 15:07, Paolo Lucente wrote: > Thanks for the elaboration, very useful to know. Your patch has > been incorporated in current CVS code. The feature is available > via the amqp_persistent_msg configuration directive. Thanks. This version is currently running on our test setup, and h

Re: [pmacct-discussion] Added support for durable messages to amqp plugin

2014-02-22 Thread Paolo Lucente
Hi Nick, Thanks for the elaboration, very useful to know. Your patch has been incorporated in current CVS code. The feature is available via the amqp_persistent_msg configuration directive. Cheers, Paolo On Fri, Feb 21, 2014 at 09:54:40AM +0100, Nick Douma wrote: > Hi, > > On 20-02-14 16:55, Pa

Re: [pmacct-discussion] Added support for durable messages to amqp plugin

2014-02-21 Thread Nick Douma
Hi, On 20-02-14 16:55, Paolo Lucente wrote: > Thanks for your patches. Most of the minor issues were already fixed in > the CVS code; i've fixed the couple remaining. The memory leak is not a > "real" one: some structures are not free'd up in amqp_cache_purge() but > such function is called in a w

Re: [pmacct-discussion] Added support for durable messages to amqp plugin

2014-02-20 Thread Paolo Lucente
Hi Nick, Thanks for your patches. Most of the minor issues were already fixed in the CVS code; i've fixed the couple remaining. The memory leak is not a "real" one: some structures are not free'd up in amqp_cache_purge() but such function is called in a writer, ephemeral processes spawned each amq

[pmacct-discussion] Added support for durable messages to amqp plugin

2014-02-20 Thread Nick Douma
Hi, For our own use case of pmacct, I have added durable message support to the amqp plugin. I have formatted this change into a set of Quilt patches, so I can easily compile my changes into a proper Debian package. The patches introduce a new config variable for the amqp plugin called 'amqp_pers