Re: [Podofo-users] Fwd: Patch 'size matters 32/64' based on rev #1898

2018-03-01 Thread zyx
On Thu, 2018-03-01 at 09:51 +0100, Olivier Mascia wrote: > As I did not receive echo of this above post to the list... Could > some of you confirm wether it reached the list, or not ? Hi, you can check the list archives at:

Re: [Podofo-users] Abolition of old-style casts, dynamic_cast intro request

2018-03-01 Thread zyx
On Wed, 2018-02-28 at 22:54 +0100, Matthew Brincke wrote: > I hope I hadn't promised to review more than one patch Hi, well, I understood (and hoped) your statement as more than one will be done, but if it was not meant like that, then my fault. I'm sorry. Bye, zyx P.S.:

[Podofo-users] Fwd: Patch 'size matters 32/64' based on rev #1898

2018-03-01 Thread Olivier Mascia
> De: Olivier Mascia > Objet: Patch 'size matters 32/64' based on rev #1898 > Date: 27 février 2018 à 15:13:35 UTC+1 > À: podofo-users@lists.sourceforge.net > > Please consider this patch to resolve a number of 32/64 implicit conversions > which most probably trigger (without

Re: [Podofo-users] Patch 'size matters 32/64' based on rev #1898

2018-03-01 Thread Olivier Mascia
> On Tue, 2018-02-27 at 16:54 +0100, zyx wrote: > > this introduces new compiler warning in podofosign (interestingly > > only at this place, good job): > > Hi again, > I forgot to add, I do not think that implicit casts cause any real > issue, compilers are able to claim warnings when it's

Re: [Podofo-users] Fwd: Testing email flow through sourceforge...

2018-03-01 Thread Dmitry Salychev
I've got these two. It probably works at the moment. Regards, - Dmitry -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org!

[Podofo-users] Patch review/mailing list unreliability (was: Re: Abolition of old-style casts, dynamic_cast intro request)

2018-03-01 Thread Matthew Brincke
Hello zyx, hello all, > On 01 March 2018 at 09:03 zyx wrote: > > > On Wed, 2018-02-28 at 22:54 +0100, Matthew Brincke wrote: > > I hope I hadn't promised to review more than one patch > > Hi, > well, I understood (and hoped) your statement as more than one will be > done,

Re: [Podofo-users] Patch 'size matters 32/64' based on rev #1898

2018-03-01 Thread Olivier Mascia
> Le 1 mars 2018 à 11:31, Olivier Mascia a écrit : > >> this introduces new compiler warning in podofosign (interestingly only >> at this place, good job): >> >> podofosign.cpp: In function ‘void >> sign_with_signer(PoDoFo::PdfSignOutputDevice&, X509*, EVP_PKEY*)’: >>

Re: [Podofo-users] Patch review/mailing list unreliability (was: Re: Abolition of old-style casts, dynamic_cast intro request)

2018-03-01 Thread zyx
On Thu, 2018-03-01 at 13:58 +0100, Matthew Brincke wrote: > How should I review patches which add public API? Hi, I guess you mean how to deal with it in this stage, before the release. The code is not frozen yet, thus new API can be added, especially when it doesn't influence any

Re: [Podofo-users] Patch 'size matters 32/64' based on rev #1898

2018-03-01 Thread zyx
On Thu, 2018-03-01 at 11:31 +0100, Olivier Mascia wrote: > When you get used to see, and ignore, tens or hundreds of > insignificant warnings on each build, it is harder to spot those that > should trigger real concern. Hi, I agree. That's why I keep the projects I work with as much