Re: [Podofo-users] Visibility support checking in the build (was: exported symbols)

2018-02-12 Thread zyx
On Sat, 2018-02-10 at 22:47 +0100, Matthew Brincke wrote: > [ typo fixes in quoted text ] [ not changing history, not feeling good to correct anyone for any typos, due to being humans, which can make mistakes ] > I still hope that won't be necessary (@Dom or zyx: could you please > put the featur

Re: [Podofo-users] PdfInfo::GetCustomKey() ?

2018-02-12 Thread zyx
On Sun, 2018-02-11 at 23:50 +0100, Olivier Mascia wrote: > Dear, > > To parallel the standard properties setter/getter like > SetAuthor/GetAuthor,... it might be wise to add: > > const PdfString & PdfInfo::GetCustomKey(const PdfName &sName) > const; > { > return this->Ge

[Podofo-users] Switch away from libidn for stringprep

2018-02-12 Thread Daniel Macks
podofo uses libidn solely to handle passwords: PdfEncryptSHABase::PreprocessPassword in PdfEncrypt.cpp calls stringprep_profile(). The new library version of libidn no longer has the stringprep APIs, and it's not clear how long the old library version will be supported (upstream and/or by vario

Re: [Podofo-users] BUG: Erase method from PdfOutlineItem sometimes segfaults

2018-02-12 Thread zyx
On Mon, 2018-02-12 at 00:59 +0100, Matthew Brincke wrote: > > It also didn't fix a warning reported by clang's static analyzer, > > see below. > > Now fixed, I hope I tests out well. Hi, unfortunately not. I re-run the static analyzers, for revision 1888. There are two use-after-free issu