Re: [poppler] [RFC] Replace GooHash by std::unordered_map

2018-05-06 Thread Albert Astals Cid
El dijous, 3 de maig de 2018, a les 0:57:21 CEST, Albert Astals Cid va escriure: > El dimecres, 2 de maig de 2018, a les 19:11:19 CEST, Adam Reichold va > > escriure: > > Hello, > > > > Am 01.05.2018 um 23:57 schrieb Albert Astals Cid: > > > El diumenge, 4 de març de 2018, a les 22:59:20 CEST,

Re: [poppler] [RFC] Replace GooHash by std::unordered_map

2018-05-02 Thread Albert Astals Cid
El dimecres, 2 de maig de 2018, a les 19:11:19 CEST, Adam Reichold va escriure: > Hello, > > Am 01.05.2018 um 23:57 schrieb Albert Astals Cid: > > El diumenge, 4 de març de 2018, a les 22:59:20 CEST, Albert Astals Cid va > > > > escriure: > >> El dissabte, 3 de març de 2018, a les 20:51:55 CET,

Re: [poppler] [RFC] Replace GooHash by std::unordered_map

2018-05-02 Thread Adam Reichold
Hello, Am 01.05.2018 um 23:57 schrieb Albert Astals Cid: > El diumenge, 4 de març de 2018, a les 22:59:20 CEST, Albert Astals Cid va > escriure: >> El dissabte, 3 de març de 2018, a les 20:51:55 CET, Adam Reichold va > escriure: >>> Hello Albert, >>> >>> please note that in the previous patch,

Re: [poppler] [RFC] Replace GooHash by std::unordered_map

2018-05-01 Thread Albert Astals Cid
El diumenge, 4 de març de 2018, a les 22:59:20 CEST, Albert Astals Cid va escriure: > El dissabte, 3 de març de 2018, a les 20:51:55 CET, Adam Reichold va escriure: > > Hello Albert, > > > > please note that in the previous patch, I made a mistake with the move > > constructor (the ref count

Re: [poppler] [RFC] Replace GooHash by std::unordered_map

2018-03-04 Thread Albert Astals Cid
El dissabte, 3 de març de 2018, a les 20:51:55 CET, Adam Reichold va escriure: > Hello Albert, > > please note that in the previous patch, I made a mistake with the move > constructor (the ref count should not be moved/swapped since it is tied > to the instance, not its value). Attached is a

Re: [poppler] [RFC] Replace GooHash by std::unordered_map

2018-03-03 Thread Adam Reichold
Hello Albert, please note that in the previous patch, I made a mistake with the move constructor (the ref count should not be moved/swapped since it is tied to the instance, not its value). Attached is a fixed patch. I found the issue during further performance tests which however only continued

Re: [poppler] [RFC] Replace GooHash by std::unordered_map

2018-03-03 Thread Albert Astals Cid
Ha! didn't realize you had already done all that, will read/answer the other email. Cheers, Albert El dissabte, 3 de març de 2018, a les 20:25:32 CET, Albert Astals Cid va escriure: > El dimecres, 21 de febrer de 2018, a les 7:13:57 CET, Adam Reichold va > > escriure: > > Hello again, > >

Re: [poppler] [RFC] Replace GooHash by std::unordered_map

2018-03-03 Thread Albert Astals Cid
El dimecres, 21 de febrer de 2018, a les 7:13:57 CET, Adam Reichold va escriure: > Hello again, > > Am 21.02.2018 um 00:31 schrieb Albert Astals Cid: > > El dimarts, 20 de febrer de 2018, a les 8:58:24 CET, Adam Reichold va > > > > escriure: > >> Hello again, > >> > >> Am 18.02.2018 um 23:23

Re: [poppler] [RFC] Replace GooHash by std::unordered_map

2018-03-03 Thread Albert Astals Cid
El dimecres, 28 de febrer de 2018, a les 11:02:11 CET, Oliver Sander va escriure: > On 21.02.2018 00:31, Albert Astals Cid wrote: > > I'd really appreciate other people's comments on this. > > I am generally in favour of changes like this, provided there is no > significant increase in run-time

Re: [poppler] [RFC] Replace GooHash by std::unordered_map

2018-02-28 Thread Oliver Sander
On 21.02.2018 00:31, Albert Astals Cid wrote: > > I'd really appreciate other people's comments on this. I am generally in favour of changes like this, provided there is no significant increase in run-time or binary code size. I think such changes do decrease long-term maintenance costs, and

Re: [poppler] [RFC] Replace GooHash by std::unordered_map

2018-02-21 Thread Adam Reichold
Hello again, attached is an updated version of the patch that: * Improves the conversions between GooString and std::string. * Fixes the spacing (And yes, the spacing wasn't broken. I was broken. I just can't get my head around 2 spaces indentation with an 8 spaces tab. Sorry for that.) *

Re: [poppler] [RFC] Replace GooHash by std::unordered_map

2018-02-20 Thread Adam Reichold
Hello again, Am 21.02.2018 um 00:31 schrieb Albert Astals Cid: > El dimarts, 20 de febrer de 2018, a les 8:58:24 CET, Adam Reichold va > escriure: >> Hello again, >> >> Am 18.02.2018 um 23:23 schrieb Adam Reichold: >>> Am 18.02.2018 um 23:08 schrieb Albert Astals Cid: El diumenge, 18 de

Re: [poppler] [RFC] Replace GooHash by std::unordered_map

2018-02-20 Thread Albert Astals Cid
El dimarts, 20 de febrer de 2018, a les 8:58:24 CET, Adam Reichold va escriure: > Hello again, > > Am 18.02.2018 um 23:23 schrieb Adam Reichold: > > Am 18.02.2018 um 23:08 schrieb Albert Astals Cid: > >> El diumenge, 18 de febrer de 2018, a les 16:55:37 CET, Adam Reichold va > >> > >> escriure:

Re: [poppler] [RFC] Replace GooHash by std::unordered_map

2018-02-20 Thread Adam Reichold
Hello again again, I obviously forgot the attachments to the previous mail. Doh... Regards, Adam. Am 20.02.2018 um 08:58 schrieb Adam Reichold: > Hello again, > > Am 18.02.2018 um 23:23 schrieb Adam Reichold: >> >> >> Am 18.02.2018 um 23:08 schrieb Albert Astals Cid: >>> El diumenge, 18 de

Re: [poppler] [RFC] Replace GooHash by std::unordered_map

2018-02-19 Thread Adam Reichold
Hello again, Am 18.02.2018 um 23:23 schrieb Adam Reichold: > > > Am 18.02.2018 um 23:08 schrieb Albert Astals Cid: >> El diumenge, 18 de febrer de 2018, a les 16:55:37 CET, Adam Reichold va >> escriure: >>> Hello, >>> >>> the attached patch replaced Poppler's internal hash table implementation

Re: [poppler] [RFC] Replace GooHash by std::unordered_map

2018-02-18 Thread Adam Reichold
Am 18.02.2018 um 23:08 schrieb Albert Astals Cid: > El diumenge, 18 de febrer de 2018, a les 16:55:37 CET, Adam Reichold va > escriure: >> Hello, >> >> the attached patch replaced Poppler's internal hash table implementation >> GooHash by std::unordered_map found in the C++ standard library

Re: [poppler] [RFC] Replace GooHash by std::unordered_map

2018-02-18 Thread Albert Astals Cid
El diumenge, 18 de febrer de 2018, a les 16:55:37 CET, Adam Reichold va escriure: > Hello, > > the attached patch replaced Poppler's internal hash table implementation > GooHash by std::unordered_map found in the C++ standard library since > C++11. This continues Poppler's slow drift towards

[poppler] [RFC] Replace GooHash by std::unordered_map

2018-02-18 Thread Adam Reichold
Hello, the attached patch replaced Poppler's internal hash table implementation GooHash by std::unordered_map found in the C++ standard library since C++11. This continues Poppler's slow drift towards standard library containers and removes one of the home-grown data structures with the main