Re: [poppler] [PATCH] Add -jpegopt optimize option support to utils

2018-07-20 Thread Martin (gzlist)
On 20 July 2018 at 22:43, Albert Astals Cid wrote: > > Pushed, I removed the changes to the man pages that were not related to this > specific change, we can discuss them in a different thread if you think makes > sense (I kind of agree your definition of progressive was probably better, > but

Re: [poppler] [PATCH] Add -jpegopt optimize option support to utils

2018-07-20 Thread Albert Astals Cid
El dimecres, 4 de juliol de 2018, a les 20:07:10 CEST, Martin (gzlist) va escriure: > On 24 June 2018 at 23:12, Martin (gzlist) wrote: > > > > I've changed the print ones in pdftocairo, see amended patch also with > > other wording tweaks attached. > > Is there anything else I can do to help

Re: [poppler] [PATCH] Add -jpegopt optimize option support to utils

2018-07-04 Thread Martin (gzlist)
On 24 June 2018 at 23:12, Martin (gzlist) wrote: > > I've changed the print ones in pdftocairo, see amended patch also with > other wording tweaks attached. Is there anything else I can do to help you review this patch? Am happy to do another pass over the documentation as a separate change if

Re: [poppler] [PATCH] Add -jpegopt optimize option support to utils

2018-06-24 Thread Martin (gzlist)
On 24/06/2018, Albert Astals Cid wrote: > > Not an English native speaker myself, but are you sure of the > Selects vs Select change? Struggling to find a documentation style guide that actually states it, but think in general imperative is preferred over simple present. See for instance `man

Re: [poppler] [PATCH] Add -jpegopt optimize option support to utils

2018-06-24 Thread Albert Astals Cid
El dijous, 14 de juny de 2018, a les 0:27:32 CEST, Martin (gzlist) va escriure: > On 13/06/2018, Albert Astals Cid wrote: > > You probably need to update the manpages of both utils to include that? > > Done, see amended patch attached. Also updated the wording of the > other options a little,

Re: [poppler] [PATCH] Add -jpegopt optimize option support to utils

2018-06-13 Thread Martin (gzlist)
On 13/06/2018, Albert Astals Cid wrote: > You probably need to update the manpages of both utils to include that? Done, see amended patch attached. Also updated the wording of the other options a little, with reference to the jpeg-turbo documentation on the options. I note the copyright on

Re: [poppler] [PATCH] Add -jpegopt optimize option support to utils

2018-06-13 Thread Albert Astals Cid
You probably need to update the manpages of both utils to include that? Cheers, Albert El dissabte, 9 de juny de 2018, a les 19:36:47 CEST, Martin (gzlist) va escriure: > New option 'optimize=y' for utils that take a -jpegopt param, > pdftocairo and pdftoppm. This corresponds to the cjpeg