Re: sysutils/logstash/forwarder should not strip lang/go binaries

On 2016/05/05 11:29, Dmitrij D. Czarkoff wrote: > Antoine Jacoutot said: > > I am OK with this but why don't you use INSTALL_PROGRAM in the > > MODGO_INSTALL_TARGET then, instead of cp? > > I'd give us more control about the owner/mode no? > > The patch below adds this change. But pkg_create

Re: sysutils/logstash/forwarder should not strip lang/go binaries

On Thu, May 05, 2016 at 11:29:37AM +0200, Dmitrij D. Czarkoff wrote: > Antoine Jacoutot said: > > I am OK with this but why don't you use INSTALL_PROGRAM in the > > MODGO_INSTALL_TARGET then, instead of cp? > > I'd give us more control about the owner/mode no? > > The patch below adds this

Re: sysutils/logstash/forwarder should not strip lang/go binaries

Antoine Jacoutot said: > I am OK with this but why don't you use INSTALL_PROGRAM in the > MODGO_INSTALL_TARGET then, instead of cp? > I'd give us more control about the owner/mode no? The patch below adds this change. But pkg_create already resets owner/mode anyway, so I am not sure it is

Re: sysutils/logstash/forwarder should not strip lang/go binaries

On Thu, May 05, 2016 at 12:07:01AM +0200, Dmitrij D. Czarkoff wrote: > Dmitrij D. Czarkoff said: > > Stuart Henderson said: > > > On 2016/04/21 19:35, Christian Weisgerber wrote: > > >> Dmitrij D. Czarkoff: > > >> > > I think you should just set > > INSTALL_STRIP = > > in the ports

Re: sysutils/logstash/forwarder should not strip lang/go binaries

Dmitrij D. Czarkoff said: > Stuart Henderson said: > > On 2016/04/21 19:35, Christian Weisgerber wrote: > >> Dmitrij D. Czarkoff: > >> > I think you should just set > INSTALL_STRIP = > in the ports (or modules) that require it and be done with it. > No point in introducing yet

Re: sysutils/logstash/forwarder should not strip lang/go binaries

On 2016/04/21 23:10, Dmitrij D. Czarkoff wrote: > Stuart Henderson said: > > On 2016/04/21 19:35, Christian Weisgerber wrote: > >> Dmitrij D. Czarkoff: > >> > I think you should just set > INSTALL_STRIP = > in the ports (or modules) that require it and be done with it. > No

Re: sysutils/logstash/forwarder should not strip lang/go binaries

Stuart Henderson said: > On 2016/04/21 23:19, Dmitrij D. Czarkoff wrote: > > > > While at it, maybe we should move description of INSTALL_STRIP from > > mk.conf(5) to bsd.port.mk(5), as apparently it is now used this way? > > Should stay in mk.conf(5), it affects src too. To my understanding,

Re: sysutils/logstash/forwarder should not strip lang/go binaries

"Dmitrij D. Czarkoff" writes: > Dmitrij D. Czarkoff said: >> Stuart Henderson said: >> > On 2016/04/21 19:35, Christian Weisgerber wrote: >> >> Dmitrij D. Czarkoff: >> >> >> I think you should just set >> INSTALL_STRIP = >> in the ports (or modules) that

Re: sysutils/logstash/forwarder should not strip lang/go binaries

On 2016/04/21 23:19, Dmitrij D. Czarkoff wrote: > > While at it, maybe we should move description of INSTALL_STRIP from > mk.conf(5) to bsd.port.mk(5), as apparently it is now used this way? Should stay in mk.conf(5), it affects src too.

Re: sysutils/logstash/forwarder should not strip lang/go binaries

Dmitrij D. Czarkoff said: > Stuart Henderson said: > > On 2016/04/21 19:35, Christian Weisgerber wrote: > >> Dmitrij D. Czarkoff: > >> > I think you should just set > INSTALL_STRIP = > in the ports (or modules) that require it and be done with it. > No point in introducing yet

Re: sysutils/logstash/forwarder should not strip lang/go binaries

Stuart Henderson said: > On 2016/04/21 19:35, Christian Weisgerber wrote: >> Dmitrij D. Czarkoff: >> I think you should just set INSTALL_STRIP = in the ports (or modules) that require it and be done with it. No point in introducing yet another variable. >>> >>> INSTALL_STRIP

Re: sysutils/logstash/forwarder should not strip lang/go binaries

On 2016-04-21, Raul Miller wrote: [INSTALL_STRIP=""] >> A few ports already do this. > > Do those ports crash with INSTALL_STRIP=-s ? astro/xworld attaches its data as an ELF segment. I don't know if it will crash, but it certainly won't work if you strip it.

Re: sysutils/logstash/forwarder should not strip lang/go binaries

On 2016/04/21 19:35, Christian Weisgerber wrote: > Dmitrij D. Czarkoff: > > > > I think you should just set > > > INSTALL_STRIP = > > > in the ports (or modules) that require it and be done with it. > > > No point in introducing yet another variable. > > > > INSTALL_STRIP is mentioned in

Re: sysutils/logstash/forwarder should not strip lang/go binaries

On Thu, Apr 21, 2016 at 1:35 PM, Christian Weisgerber wrote: > A few ports already do this. Do those ports crash with INSTALL_STRIP=-s ? Thanks, -- Raul

Re: sysutils/logstash/forwarder should not strip lang/go binaries

Dmitrij D. Czarkoff: > > I think you should just set > > INSTALL_STRIP = > > in the ports (or modules) that require it and be done with it. > > No point in introducing yet another variable. > > INSTALL_STRIP is mentioned in mk.conf(5), so it is a user setting. > /etc/mk.conf may contain

Re: sysutils/logstash/forwarder should not strip lang/go binaries

Christian Weisgerber said: > Dmitrij D. Czarkoff: > > > --- infrastructure/mk/bsd.port.mk 20 Mar 2016 20:07:20 - 1.1310 > > +++ infrastructure/mk/bsd.port.mk 21 Apr 2016 13:10:29 - > > @@ -729,6 +729,12 @@ UNZIP ?= unzip > > BZIP2 ?= bzip2 > > > > > > +# disable stripping if

Re: sysutils/logstash/forwarder should not strip lang/go binaries

Dmitrij D. Czarkoff: > --- infrastructure/mk/bsd.port.mk 20 Mar 2016 20:07:20 - 1.1310 > +++ infrastructure/mk/bsd.port.mk 21 Apr 2016 13:10:29 - > @@ -729,6 +729,12 @@ UNZIP ?= unzip > BZIP2 ?= bzip2 > > > +# disable stripping if requested > +INSTALL_NO_STRIP ?= > +.if

Re: sysutils/logstash/forwarder should not strip lang/go binaries

Adam Wolk said: > On Thu, 21 Apr 2016 15:12:24 +0200 > "Dmitrij D. Czarkoff" wrote: > >> Dmitrij D. Czarkoff said: >>> Edd Barrett said: On Thu, Apr 21, 2016 at 01:38:54AM +0200, Adam Wolk wrote: > +# Use INSTALL_SCRIPT to prevent stripping go binaries

Re: sysutils/logstash/forwarder should not strip lang/go binaries

On Thu, 21 Apr 2016 15:12:24 +0200 "Dmitrij D. Czarkoff" wrote: > Dmitrij D. Czarkoff said: > > Edd Barrett said: > > > On Thu, Apr 21, 2016 at 01:38:54AM +0200, Adam Wolk wrote: > > > > +# Use INSTALL_SCRIPT to prevent stripping go binaries > > > > > > Is it worth

Re: sysutils/logstash/forwarder should not strip lang/go binaries

Dmitrij D. Czarkoff said: > Edd Barrett said: > > On Thu, Apr 21, 2016 at 01:38:54AM +0200, Adam Wolk wrote: > > > +# Use INSTALL_SCRIPT to prevent stripping go binaries > > > > Is it worth adding a INSTALL_GO_PROGRAM in the lang/go MODULE to avoid > > confusion? > > I'd rather go with more

Re: sysutils/logstash/forwarder should not strip lang/go binaries

Edd Barrett said: > On Thu, Apr 21, 2016 at 01:38:54AM +0200, Adam Wolk wrote: > > +# Use INSTALL_SCRIPT to prevent stripping go binaries > > Is it worth adding a INSTALL_GO_PROGRAM in the lang/go MODULE to avoid > confusion? I'd rather go with more generic change. Patch below adds

Re: sysutils/logstash/forwarder should not strip lang/go binaries

On Thu, 21 Apr 2016 12:35:41 +0100 Edd Barrett wrote: > On Thu, Apr 21, 2016 at 01:38:54AM +0200, Adam Wolk wrote: > > +# Use INSTALL_SCRIPT to prevent stripping go binaries > > Is it worth adding a INSTALL_GO_PROGRAM in the lang/go MODULE to avoid > confusion? > > I

Re: sysutils/logstash/forwarder should not strip lang/go binaries

On Thu, Apr 21, 2016 at 01:38:54AM +0200, Adam Wolk wrote: > +# Use INSTALL_SCRIPT to prevent stripping go binaries Is it worth adding a INSTALL_GO_PROGRAM in the lang/go MODULE to avoid confusion? I note that I saw such weird errors when building lang/go itself, so perhaps we should be applying

Re: sysutils/logstash/forwarder should not strip lang/go binaries

On Thu, Apr 21, 2016 at 01:38:54AM +0200, Adam Wolk wrote: > Hi, > > While testing a port for net/syncthing sthen@ noticed the following > warnings: > > 00:44 < sthen> hm, there are some funny messages from that port in > 'make fake' 00:45 < sthen> > BFD:

Re: sysutils/logstash/forwarder should not strip lang/go binaries

On Thu, 21 Apr 2016 01:54:38 +0200 "Dmitrij D. Czarkoff" wrote: > Adam Wolk said: > > I'm inlining a patch for sysutils/logstash/forwarder replacing the > > usage of INSTALL_PROGRAM with INSTALL_SCRIPT and a comment informing > > why this choice is made. Any OK's? > > OK

Re: sysutils/logstash/forwarder should not strip lang/go binaries

Adam Wolk said: > I'm inlining a patch for sysutils/logstash/forwarder replacing the > usage of INSTALL_PROGRAM with INSTALL_SCRIPT and a comment informing > why this choice is made. Any OK's? OK czarkoff@. A cleaner approach would be to set | INSTALL_STRIP= but that is a user setting which