Re: lang/node - patch for xonly

2023-01-23 Thread Jeremie Courreges-Anglas
On Sun, Jan 22 2023, Volker Schlecht wrote: > On 1/21/23 19:46, Theo Buehler wrote: >> To be clear, I'm not excluding that this is part of the solution to the >> problem. However, with this diff, I see the exact same segfault that I >> saw without any diff at all, so I do not think we should land

Re: lang/node - patch for xonly

2023-01-23 Thread Theo Buehler
On Mon, Jan 23, 2023 at 12:36:29PM +0100, Jeremie Courreges-Anglas wrote: > On Sun, Jan 22 2023, Volker Schlecht wrote: > > On 1/21/23 19:46, Theo Buehler wrote: > >> To be clear, I'm not excluding that this is part of the solution to the > >> problem. However, with this diff, I see the exact same

Re: lang/node - patch for xonly

2023-01-22 Thread Volker Schlecht
On 1/21/23 19:46, Theo Buehler wrote: To be clear, I'm not excluding that this is part of the solution to the problem. However, with this diff, I see the exact same segfault that I saw without any diff at all, so I do not think we should land this just yet. I don't have a CPU with the PKU re

Re: lang/node - patch for xonly

2023-01-21 Thread Theo Buehler
To be clear, I'm not excluding that this is part of the solution to the problem. However, with this diff, I see the exact same segfault that I saw without any diff at all, so I do not think we should land this just yet. My suggestion for a diff that would only affect the troublesome amd64 architec

Re: lang/node - patch for xonly

2023-01-21 Thread Theo de Raadt
Theo Buehler wrote: > On Sat, Jan 21, 2023 at 05:36:17PM +0100, Volker Schlecht wrote: > > Here's a patch that builds node without USE_NOEXECONLY and without those > > warnings, producing a working binary on amd64 ... I'm starting builds on > > i386 and arm64, but since I'm not sure I understand

Re: lang/node - patch for xonly

2023-01-21 Thread Theo Buehler
On Sat, Jan 21, 2023 at 05:36:17PM +0100, Volker Schlecht wrote: > Here's a patch that builds node without USE_NOEXECONLY and without those > warnings, producing a working binary on amd64 ... I'm starting builds on > i386 and arm64, but since I'm not sure I understand the problem to its full > exte

Re: lang/node - patch for xonly

2023-01-21 Thread Theo de Raadt
Stuart Henderson wrote: > On 2023/01/21 17:36, Volker Schlecht wrote: > > > > > > On 1/19/23 22:56, Theo Buehler wrote: > > > > > The trick to apply such patches is to add .diff to the > > > github link. > > Or .patch, then you get a nice header to paste into the top of > the patch file too.

Re: lang/node - patch for xonly

2023-01-21 Thread Stuart Henderson
On 2023/01/21 17:36, Volker Schlecht wrote: > > > On 1/19/23 22:56, Theo Buehler wrote: > > > The trick to apply such patches is to add .diff to the > > github link. Or .patch, then you get a nice header to paste into the top of the patch file too. > Neat! I just noted that down ... ;-) > > H

lang/node - patch for xonly

2023-01-21 Thread Volker Schlecht
On 1/19/23 22:56, Theo Buehler wrote: The trick to apply such patches is to add .diff to the github link. Neat! I just noted that down ... ;-) Here's a patch that builds node without USE_NOEXECONLY and without those warnings, producing a working binary on amd64 ... I'm starting builds on