date:20150105

Re: [PATCHES] www/w3m bug fixes

2015-01-05 Thread Brian Callahan

Hi Scarlett --

On 01/06/15 01:10, Scarlett wrote:
This archive contains patches for several problems I have found
while hacking on www/w3m, as well as several bug fixes taken from
elsewhere.

I don't have time to do more than eyeball this right now, but I just
want to make two quick comments:
1. Usually we use CVS to send patches. Lets you send a single file
instead of a whole tarball :-)
But that aside...
2. Could you put all this nice information into the patches themselves?
Partly for attribution, partly to see quickly what each patch is doing
and why, and partly because it makes it easier to track future bug fixes
from those same sources.

~Brian

Ported patches

* Use %s to printf a string, from Colin Watson at Ubuntu
http://anonscm.debian.org/cgit/collab-maint/w3m.git/commit/?h=bug/646321

* Fix a null pointer deref when parsing input type in HTML, from olh
at suse dot de
https://build.opensuse.org/package/view_file/openSUSE:Factory/w3m/w3m-closedir.patch?expand=1

* Fix a directory descriptor leak, from max at suse dot de
https://build.opensuse.org/package/view_file/openSUSE:Factory/w3m/w3m-parsetagx-crash.patch?expand=1

* exit(1) when out of memory, since malloc's return value is never checked
anywhere in the program. inspired by an old patch by dugsong@ which got
sent to the cvs attic when w3m was updated in the distant past
http://cvsweb.openbsd.org/cgi-bin/cvsweb/ports/www/w3m/patches/Attic/patch-ac

My patches

* Various printf format string fixes:

* Instead of printing a Str structure with %s, print the
char pointer inside it with %s.
* Use %ld to print long, not %d
* Use %zu to print size_t, not %d
* Use %lld to print time_t, not %ld

* Change hand-rolled and suspicious sprintf implementation in Str.c to
use asprintf() from libc.

* Move New() gc alloc macros to a header file and add overflow checks to
the allocate an array macros.

w3m's code is disgusting, and upstream is mostly dead with occasional
patches ported from debian. However, it is one of the more usable web
browsers (and the only curses browser with inline images, iirc).
Fixing its problems is good for its users.

Scarlett

Re: [PATCHES] www/w3m bug fixes

2015-01-05 Thread Scarlett

On Tue, Jan 06, 2015 at 06:10:25AM +, Scarlett wrote:
This archive contains patches for several problems I have found
while hacking on www/w3m, as well as several bug fixes taken from
elsewhere.

Ported patches

* Use %s to printf a string, from Colin Watson at Ubuntu
http://anonscm.debian.org/cgit/collab-maint/w3m.git/commit/?h=bug/646321

* Fix a null pointer deref when parsing input type in HTML, from olh
at suse dot de
https://build.opensuse.org/package/view_file/openSUSE:Factory/w3m/w3m-closedir.patch?expand=1

* Fix a directory descriptor leak, from max at suse dot de
https://build.opensuse.org/package/view_file/openSUSE:Factory/w3m/w3m-parsetagx-crash.patch?expand=1

My patches

* Various printf format string fixes:

* Instead of printing a Str structure with %s, print the
char pointer inside it with %s.
* Use %ld to print long, not %d
* Use %zu to print size_t, not %d
* Use %lld to print time_t, not %ld

* Change hand-rolled and suspicious sprintf implementation in Str.c to
use asprintf() from libc.

* Move New() gc alloc macros to a header file and add overflow checks to
the allocate an array macros.

Scarlett

Whoops, I got the two OpenSUSE links mixed up.

The first link is the patch for the directory leak, the second is the
patch for the null pointer deref.

Re: New: multimedia/mpv

2015-01-05 Thread Dmitrij D. Czarkoff

Anthony J. Bentley said:
 Doesn't build on amd64.

This is the only platform where I've built it.

 audio/decode/ad_mpg123.o(.text+0x10f): In function `decode_packet':
 audio/decode/ad_mpg123.c:241: undefined reference to `mpg123_decode_frame_64'

I forgot to disable mpg123 support.  I tested this port on a system
where mpg123 was not installed, and I intentionally didn't set
dependency on it.

 # pkg-config says smbclient's version is 0
 CONFIGURE_ARGS +=   --enable-smb \
 --extra-libs=-lsmbclient

 Is this something that should be fixed in upstream mpv? It doesn't seem
 to be a bug in our pkg-config, because FDO pkg-config behaves the same.

On OpenBSD -current (#735 amd64):

 $ pkg-config --modversion smbclient
 0

On Archlinux box:

 $ pkg-config --modversion smbclient
 0.2.1

I guess it is our samba package.

 In DESCR, I would remove the actively developed bullet. By nature those
 kinds of statements tend to go out of date. And maybe reformat DESCR to
 take up less vertical space, but that's a nitpick.

Done.

-- 
Dmitrij D. Czarkoff


mpv.tgz
Description: application/tar-gz

60 matches

Mail list logo