Re: UPDATE: mpv 0.38.0

[Jose Maldonado]

El Wed, 17 Apr 2024 22:09:06 -0400
Brad Smith  escribió:
> Here is an update to mpv 0.38.0.
> 
> https://raw.githubusercontent.com/mpv-player/mpv/master/RELEASE_NOTES
> 
> 
> Index: Makefile
> ===
> RCS file: /cvs/ports/multimedia/mpv/Makefile,v
> retrieving revision 1.99
> diff -u -p -u -p -r1.99 Makefile
> --- Makefile  21 Feb 2024 10:42:42 -  1.99
> +++ Makefile  17 Apr 2024 23:57:05 -
> @@ -2,7 +2,7 @@ COMMENT = movie player based on MPlayer
>  
>  GH_ACCOUNT = mpv-player
>  GH_PROJECT = mpv
> -GH_TAGNAME = v0.37.0
> +GH_TAGNAME = v0.38.0
>  USE_NOBTCFI =Yes
>  
>  SHARED_LIBS +=   mpv 2.0
> @@ -62,6 +62,7 @@ CONFIGURE_ARGS =-Dlua=lua${MODLUA_DEP_V
>   -Dalsa=disabled \
>   -Dandroid-media-ndk=disabled \
>   -Daudiounit=disabled \
> + -Davfoundation=disabled \
>   -Dcaca=disabled \
>   -Dcocoa=disabled \
>   -Dcoreaudio=disabled \
> @@ -72,12 +73,15 @@ CONFIGURE_ARGS =  -Dlua=lua${MODLUA_DEP_V
>   -Dd3d-hwaccel=disabled \
>   -Ddirect3d=disabled \
>   -Ddmabuf-wayland=disabled \
> + -Ddrm=disabled \
> + -Ddvbin=disabled \
>   -Degl-android=disabled \
>   -Degl-angle=disabled  \
>   -Degl-angle-lib=disabled \
>   -Degl-angle-win32=disabled \
>   -Degl-drm=disabled \
>   -Degl-wayland=disabled \
> + -Dgbm=disabled \
>   -Dgl-cocoa=disabled \
>   -Dgl-dxinterop=disabled \
>   -Dgl-dxinterop-d3d9=disabled \
> @@ -93,7 +97,6 @@ CONFIGURE_ARGS =-Dlua=lua${MODLUA_DEP_V
>   -Doss-audio=disabled \
>   -Dpipewire=disabled \
>   -Dpulse=disabled \
> - -Drpi-mmal=disabled \
>   -Drubberband=disabled \
>   -Dshaderc=disabled \
>   -Dsixel=disabled \
> @@ -106,6 +109,7 @@ CONFIGURE_ARGS =  -Dlua=lua${MODLUA_DEP_V
>   -Dvaapi-drm=disabled \
>   -Dvaapi-x11=disabled \
>   -Dvaapi-wayland=disabled \
> + -Dvaapi-win32=disabled \
>   -Dvapoursynth=disabled \
>   -Dvdpau=disabled \
>   -Dvdpau-gl-x11=disabled \
> Index: distinfo
> ===
> RCS file: /cvs/ports/multimedia/mpv/distinfo,v
> retrieving revision 1.35
> diff -u -p -u -p -r1.35 distinfo
> --- distinfo  21 Feb 2024 10:42:42 -  1.35
> +++ distinfo  17 Apr 2024 23:57:05 -
> @@ -1,2 +1,2 @@
> -SHA256 (mpv-0.37.0.tar.gz) =
> HS1K268Eii+m7hNFdQMsSy2tmn76/Vs+abiNuTWvrd8= -SIZE
> (mpv-0.37.0.tar.gz) = 3384190 +SHA256 (mpv-0.38.0.tar.gz) =
> htnvQLYFhzL2e0bQu9okoHT66GCz6q4FurMUUEEwMGY= +SIZE
> (mpv-0.38.0.tar.gz) = 3419741 Index: patches/patch-meson_build
> ===
> RCS file: /cvs/ports/multimedia/mpv/patches/patch-meson_build,v
> retrieving revision 1.7
> diff -u -p -u -p -r1.7 patch-meson_build
> --- patches/patch-meson_build 21 Feb 2024 10:42:42
> - 1.7 +++ patches/patch-meson_build   17 Apr 2024
> 23:57:05 - @@ -4,9 +4,9 @@ time if present at all, rather than
> only Index: meson.build
>  --- meson.build.orig
>  +++ meson.build
> -@@ -342,7 +342,19 @@ if features['libdl']
> +@@ -348,7 +348,19 @@ if features['libdl']
>   endif
> -
> + 
>   # C11 atomics are mandatory but linking to the library is not
> always required. -dependencies += cc.find_library('atomic', required:
> false) +if cc.links('''
> @@ -22,6 +22,6 @@ Index: meson.build
>  +else
>  +stdatomic_dep = cc.find_library('atomic')
>  +endif
> -
> + 
>   cplugins = get_option('cplugins').require(
>   win32 or (features['libdl'] and
> cc.has_link_argument('-rdynamic')), Index:
> patches/patch-osdep_threads_posix_h
> ===
> RCS file:
> /cvs/ports/multimedia/mpv/patches/patch-osdep_threads_posix_h,v
> retrieving revision 1.1 diff -u -p -u -p -r1.1
> patch-osdep_threads_posix_h ---
> patches/patch-osdep_threads_posix_h   21 Feb 2024 10:42:42
> - 1.1 +++ patches/patch-osdep_threads_posix_h 17
> Apr 2024 23:57:05 - @@ -2,10 +2,10 @@ Index:
> osdep/threads-posix.h --- osdep/threads-posix.h.orig +++
> osdep/threads-posix.h @@ -19,6 +19,7 @@ -
> + 
>   #include 
>   #include 
>  +#include 
>   #include 
> -
> + 
>   #include "common/common.h"
> Index: patches/patch-osdep_timer-linux_c
> 

Re: archivers/xz: update to 5.6.1

[Jose Maldonado]

El Fri, 29 Mar 2024 22:55:26 +0100
Christian Weisgerber  escribió:
> Christian Weisgerber:
> 
> > > It sounds like a backdoor made it into the upstream repository:
> > > https://www.openwall.com/lists/oss-security/2024/03/29/4  
> > 
> > Yes, I just learned.  I am investigating.  
> 
> The xz 5.6.1 update hasn't been committed yet, so this mostly
> concerns only me anyway.
> 
> * A malicious m4/build-to-host.m4 has been inserted and its code
>   is used in the generated configure script.
> 
> * This extracts and executes a shell script from
>   tests/files/bad-3-corrupt_lzma2.xz.
>   That script aborts if $(uname) is not Linux.  <=== IT ENDS HERE.
>   If the script continued, it would fail because it uses "head -c"
>   and "tail -c" which are a nonstandard extension that the
> corresponding OpenBSD commands don't support.
> 
> * The script extracts the next stage shell script from
>   tests/files/good-large_compressed.lzma.
>   This stage aborts again early when $(uname) is not Linux.
>   It then proceeds to manipulate the build in some way I won't waste
>   my time to figure out.
> 
> In short, it's a supply chain attack on Linux that doesn't concern
> OpenBSD.
> 
> 
> PS:
> If anybody wants to compare build-to-host.m4, here's the GNU upstream:
> https://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=blob;f=m4/build-to-host.m4;h=f928e9ab403b3633e3d1d974abcf478e65d4b0aa;hb=HEAD
> 

Good to know! Thanks for this analysis! 

-- 
*
Dios en su cielo, todo bien en la Tierra

NEW PORT: sysutils/stress-ng V0.17.06

[Jose Maldonado]

Hi, list! 

New port here, in this case sysutils/stress-ng is a mantained fork of
sysutils/stress and without conflicts with others packages (go-tools).

** Description **

stress-ng will stress test a computer system in various selectable
ways. It was designed to exercise various physical subsystems of a
computer as well as the various operating system kernel interfaces.

Build, compiled and run on amd64 without problems.

-- 
*
Dios en su cielo, todo bien en la Tierra


stress-ng.tar.gz
Description: application/gzip

Re: UPDATE: libplacebo

[Jose Maldonado]

El Tue, 19 Mar 2024 12:12:29 -0400
Brad Smith  escribió:
> After having a bug fixed with glad 2.0.6 the workaround with adding
> the header path (lib was not necessary) is no longer necessary.
> 
> 
> Index: Makefile
> ===
> RCS file: /cvs/ports/graphics/libplacebo/Makefile,v
> retrieving revision 1.12
> diff -u -p -u -p -r1.12 Makefile
> --- Makefile  20 Feb 2024 10:34:30 -  1.12
> +++ Makefile  18 Mar 2024 18:07:41 -
> @@ -3,6 +3,7 @@ COMMENT=  reusable library for GPU-accele
>  GH_ACCOUNT=  haasn
>  GH_PROJECT=  libplacebo
>  GH_TAGNAME=  v6.338.2
> +REVISION=0
>  CATEGORIES=  graphics
>  
>  SHARED_LIBS= placebo 8.0
> @@ -13,16 +14,14 @@ MAINTAINER=   Brad Smith   PERMIT_PACKAGE=  Yes
>  
>  WANTLIB +=   ${COMPILER_LIBCXX}
> -WANTLIB +=   execinfo lcms2 m pthread
> -WANTLIB +=   shaderc_shared vulkan
> +WANTLIB +=   execinfo lcms2 m pthread shaderc_shared vulkan
>  # GL and epoxy are dlopened by libplacebo
> -WANTLIB +=   epoxy GL
> -
> +WANTLIB +=   GL epoxy
>  
>  MODULES= devel/meson
>  
>  BUILD_DEPENDS=   devel/fast-float \
> - graphics/glad \
> + graphics/glad>=2.0.6 \
>   graphics/vulkan-headers
>  
>  LIB_DEPENDS= graphics/lcms2 \
> @@ -30,12 +29,6 @@ LIB_DEPENDS=   graphics/lcms2 \
>   graphics/vulkan-loader
>  
>  COMPILER=base-clang ports-gcc
> -
> -CFLAGS +=-I${X11BASE}/include
> -LDFLAGS +=   -L${X11BASE}/lib
> -
> -MODMESON_CONFIGURE_ENV +=CFLAGS="${CFLAGS}" \
> - LDFLAGS="${LDFLAGS}"
>  
>  CONFIGURE_ARGS+=-Ddefault_library=both \
>   -Dd3d11=disabled \
> 

Hi @brad!

Tested patch, not problem build libplacebo with this revision. 


-- 
*
Dios en su cielo, todo bien en la Tierra

Re: update: devel/fast-float to v6.1.1

[Jose Maldonado]

El Tue, 19 Mar 2024 15:20:16 +
Stuart Henderson  escribió:
> On 2024/03/19 11:15, Jose Maldonado wrote:
> > Hi list!
> > 
> > A simple new update for devel/fast-float to v6.1.1
> > 
> > Changelog: 
> > 
> > * Add a missing check that __uint128_t exists before using it. #243
> > [1]
> > * New release script (for internal control version)
> > 
> > [1] https://github.com/fastfloat/fast_float/pull/243
> > 
> > -- 
> > *
> > Dios en su cielo, todo bien en la Tierra
> 
> > Index: Makefile
> > ===
> > RCS file: /cvs/ports/devel/fast-float/Makefile,v
> > diff -u -p -r1.1.1.1 Makefile
> > --- Makefile13 Feb 2024 19:45:52 -  1.1.1.1
> > +++ Makefile19 Mar 2024 15:06:47 -
> > @@ -1,10 +1,11 @@
> >  COMMENT =  fast and exact implementation of from_chars for
> > float/double 
> > -V =6.1.0
> > +V =6.1.1
> >  PKGNAME =  fast-float-${V}
> >  GH_TAGNAME =   v${V}
> >  GH_ACCOUNT =   fastfloat
> >  GH_PROJECT =   fast_float
> > +DISTFILES =fast_float-{v}${V}.tar.gz
> 
> no need for DISTFILES, that was just for the previous rerolled
> distfile to change the filename (but we might as well just go for the
> update and forget about that now).
> 
> thanks, will commit.
> 

Thanks @sthen! 

-- 
*
Dios en su cielo, todo bien en la Tierra

update: graphics/glad to v2.0.6

[Jose Maldonado]

Hi list!

New update for graphics/glad to v2.0.6, this version have a few
corrections: 

* Fix eglplatform in header only build not correctly replacing the
khrplatform include
* Fix compile warning when GLAD_GLES2_USE_SYSTEM_EGL=1 
* Fix: Use include instead of find_package for CMake config
* c: don't warn on undefined GLAD_GLES2_USE_SYSTEM_EGL

Tested on amd64, all ok. 


-- 
*
Dios en su cielo, todo bien en la Tierra
Index: Makefile
===
RCS file: /cvs/ports/graphics/glad/Makefile,v
diff -u -p -r1.2 Makefile
--- Makefile	13 Feb 2024 19:50:35 -	1.2
+++ Makefile	19 Mar 2024 15:26:18 -
@@ -1,9 +1,8 @@
 COMMENT =	multi-language Vulkan/GL/GLES/EGL/GLX/WGL loader-generator
 
-GH_TAGNAME =	v2.0.5
+GH_TAGNAME =	v2.0.6
 GH_ACCOUNT =	Dav1dde
 GH_PROJECT =	glad
-REVISION =	0
 
 CATEGORIES =	graphics
 
Index: distinfo
===
RCS file: /cvs/ports/graphics/glad/distinfo,v
diff -u -p -r1.1.1.1 distinfo
--- distinfo	13 Feb 2024 16:52:49 -	1.1.1.1
+++ distinfo	19 Mar 2024 15:26:18 -
@@ -1,2 +1,2 @@
-SHA256 (glad-2.0.5.tar.gz) = hQNR8ZYPP+13XwtpbX8XYV8wa+tWvjiiBCMoRidibfE=
-SIZE (glad-2.0.5.tar.gz) = 632711
+SHA256 (glad-2.0.6.tar.gz) = YacCNNx9pGfM6wf83W3sEhPWFDobaxnMxde2TMJH6kc=
+SIZE (glad-2.0.6.tar.gz) = 633949
Index: pkg/PLIST
===
RCS file: /cvs/ports/graphics/glad/pkg/PLIST,v
diff -u -p -r1.1.1.1 PLIST
--- pkg/PLIST	13 Feb 2024 16:52:49 -	1.1.1.1
+++ pkg/PLIST	19 Mar 2024 15:26:18 -
@@ -115,13 +115,13 @@ lib/python${MODPY_VERSION}/site-packages
 lib/python${MODPY_VERSION}/site-packages/glad/sink.py
 lib/python${MODPY_VERSION}/site-packages/glad/specification.py
 lib/python${MODPY_VERSION}/site-packages/glad/util.py
-lib/python${MODPY_VERSION}/site-packages/glad2-2.0.5.dist-info/
-lib/python${MODPY_VERSION}/site-packages/glad2-2.0.5.dist-info/LICENSE
-lib/python${MODPY_VERSION}/site-packages/glad2-2.0.5.dist-info/METADATA
-lib/python${MODPY_VERSION}/site-packages/glad2-2.0.5.dist-info/RECORD
-lib/python${MODPY_VERSION}/site-packages/glad2-2.0.5.dist-info/WHEEL
-lib/python${MODPY_VERSION}/site-packages/glad2-2.0.5.dist-info/entry_points.txt
-lib/python${MODPY_VERSION}/site-packages/glad2-2.0.5.dist-info/top_level.txt
+lib/python${MODPY_VERSION}/site-packages/glad2-2.0.6.dist-info/
+lib/python${MODPY_VERSION}/site-packages/glad2-2.0.6.dist-info/LICENSE
+lib/python${MODPY_VERSION}/site-packages/glad2-2.0.6.dist-info/METADATA
+lib/python${MODPY_VERSION}/site-packages/glad2-2.0.6.dist-info/RECORD
+lib/python${MODPY_VERSION}/site-packages/glad2-2.0.6.dist-info/WHEEL
+lib/python${MODPY_VERSION}/site-packages/glad2-2.0.6.dist-info/entry_points.txt
+lib/python${MODPY_VERSION}/site-packages/glad2-2.0.6.dist-info/top_level.txt
 share/examples/glad/
 share/examples/glad/c/
 share/examples/glad/c++/

update: devel/fast-float to v6.1.1

[Jose Maldonado]

Hi list!

A simple new update for devel/fast-float to v6.1.1

Changelog: 

* Add a missing check that __uint128_t exists before using it. #243 [1]
* New release script (for internal control version)

[1] https://github.com/fastfloat/fast_float/pull/243

-- 
*
Dios en su cielo, todo bien en la Tierra
Index: Makefile
===
RCS file: /cvs/ports/devel/fast-float/Makefile,v
diff -u -p -r1.1.1.1 Makefile
--- Makefile	13 Feb 2024 19:45:52 -	1.1.1.1
+++ Makefile	19 Mar 2024 15:06:47 -
@@ -1,10 +1,11 @@
 COMMENT =	fast and exact implementation of from_chars for float/double
 
-V =		6.1.0
+V =		6.1.1
 PKGNAME =	fast-float-${V}
 GH_TAGNAME =	v${V}
 GH_ACCOUNT =	fastfloat
 GH_PROJECT =	fast_float
+DISTFILES =	fast_float-{v}${V}.tar.gz
 
 CATEGORIES =	devel
 
Index: distinfo
===
RCS file: /cvs/ports/devel/fast-float/distinfo,v
diff -u -p -r1.1.1.1 distinfo
--- distinfo	13 Feb 2024 19:45:52 -	1.1.1.1
+++ distinfo	19 Mar 2024 15:06:47 -
@@ -1,2 +1,2 @@
-SHA256 (fast_float-6.1.0.tar.gz) = qcjKjKfWjC27E0Q0BE+cZs/Uw4PV6Fw2twTTD2voJQY=
-SIZE (fast_float-6.1.0.tar.gz) = 95974
+SHA256 (fast_float-6.1.1.tar.gz) = EBWaSli6lf6TicPJf+femlQ2IqoNzBLdk1bXVempTLQ=
+SIZE (fast_float-6.1.1.tar.gz) = 97641

Re: UPDATE FIX: devel/fast_float distinfo

[Jose Maldonado via ports]

El Wed, 13 Mar 2024 18:08:04 +
Stuart Henderson  escribió:
> On 2024/03/13 13:33, Jose Maldonado wrote:
> > 
> > Hi list!
> > 
> > I've seen a new update to fast_float (library required for the new
> > libplacebo and mpv) that could affect the 7.5 and -current package
> > builds due to a change in the project's Github.  
> 
> Unimportant for release, it's on the bulk build machines already, and
> is on one of the fallback distfiles sites.

Excellent! 

> 
> > The change has been added through a commit [1] that fixes a typo in
> > the version of the project in CmakeList.txt, but from upstream
> > instead of creating a new version (6.1.1), they have decided to
> > include the change and keep calling the version as 6.1.0, breaking
> > the old distinfo.  
> 
> That's a nuisance, it would be helpful if projects wouldn't do that.

It seems like a mistake to me, they should have made a version 6.1.1,
marking the correction with it.

> 
> That's not the only change - float_common.h was modified too, so it
> will also need a REVISION bump.
> 
> https://github.com/fastfloat/fast_float/commit/55a5b3c8e136a6f55cbb13829f284bdc7150567c
>  #include 
>  #include 
>  #ifdef __has_include
> -  #if __has_include()
> +  #if __has_include() && (__cplusplus > 202002L ||
> _MSVC_LANG > 202002L) #include 
>#endif
>  #endif
> 

Sorry, I had not seen such a change in the source.

> > This patch solves the problem and unlocks the port build.  
> 
> The distfile needs to be renamed via the filename{url}sufx mechanism
> if the contents have changed. Builds are done from machines with
> varying states of the ports tree (it's common to have the build
> machine for one arch on one ports checkout and another on a newer one
> - except for the special case of release builds, this is the normal
> situation). For the main build machines there's a common distfiles
> directory shared over NFS, so it's a problem if one machine fetches a
> new file to match what it needs, while another is still building and
> expecting an old version.
> 
> A diff something like this will work, though if there's a new version
> upstream before we're ready to reopen commits we might as well just
> change to that instead.
> 
> Index: Makefile
> ===
> RCS file: /cvs/ports/devel/fast-float/Makefile,v
> diff -u -p -r1.1.1.1 Makefile
> --- Makefile  13 Feb 2024 19:45:52 -  1.1.1.1
> +++ Makefile  13 Mar 2024 18:00:59 -
> @@ -2,9 +2,11 @@ COMMENT =fast and exact implementation 
>  
>  V =  6.1.0
>  PKGNAME =fast-float-${V}
> +REVISION =   0
>  GH_TAGNAME = v${V}
>  GH_ACCOUNT = fastfloat
>  GH_PROJECT = fast_float
> +DISTFILES =  fast_float-{v}${V}-0.tar.gz
>  
>  CATEGORIES = devel
>  
> Index: distinfo
> ===
> RCS file: /cvs/ports/devel/fast-float/distinfo,v
> diff -u -p -r1.1.1.1 distinfo
> --- distinfo  13 Feb 2024 19:45:52 -  1.1.1.1
> +++ distinfo  13 Mar 2024 18:00:59 -
> @@ -1,2 +1,2 @@
> -SHA256 (fast_float-6.1.0.tar.gz) =
> qcjKjKfWjC27E0Q0BE+cZs/Uw4PV6Fw2twTTD2voJQY= -SIZE
> (fast_float-6.1.0.tar.gz) = 95974 +SHA256 (fast_float-6.1.0-0.tar.gz)
> = WmKeHxjwN60AFsQerWMOpHHMy832AjntNGbEkdjnyQg= +SIZE
> (fast_float-6.1.0-0.tar.gz) = 96104
> 

Thanks for the explanation @sthen. Regarding the possibility of a new
version of fast_float before the new version of 7.5 comes out, this is
unlikely, and we should stick to v6.1.0.

In any case, my initial concern was the fact that the builds packages
would have some problem downloading the distfile and will encounter an
error due to the change of the file, and that this will block the
construction of the packages dependent on it.

Your explanation of how build packages work eliminates this problem,
but leaves us with the problem of package evolution and its strange
decisions when listing versions.

I have tried the change you have made, all work without problem.


-- 
*
Dios en su cielo, todo bien en la Tierra

UPDATE FIX: devel/fast_float distinfo

[Jose Maldonado via ports]

Hi list!

I've seen a new update to fast_float (library required for the new
libplacebo and mpv) that could affect the 7.5 and -current package
builds due to a change in the project's Github.

The change has been added through a commit [1] that fixes a typo in the
version of the project in CmakeList.txt, but from upstream instead of
creating a new version (6.1.1), they have decided to include the change
and keep calling the version as 6.1.0, breaking the old distinfo.

This patch solves the problem and unlocks the port build.

Okay?

1.-
https://github.com/fastfloat/fast_float/commit/2f3ed44e0668b5536f3acb9bc38ed195f9e32165


-- 
*
Dios en su cielo, todo bien en la Tierra


devel_fast_float_v610
Description: Binary data

Re: [UPDATE] x11/picom - new version 11.2

[Jose Maldonado]

El Sat, 9 Mar 2024 14:54:45 -0500
Stefan Moran  escribió:
> Disclaimer, this was done on a backport to -stable.
> 
> Works fine on intel (modesetting driver), testing with glxgears and
> mpv I get some nasty frame-timing issues with the glx backend (doesn't
> matter if vsync is enabled or not). Using the --no-frame-pacing flag
> sort of fixes this, as well as using the xrender backend (which I
> prefer using anyways since it seems to perform better). This could
> very well likely be an upstream issue, but I'm giving a heads up here
> anyways.

Hi @Stefan

It is better to activate the --no-frame-pacing option, the frame pacing
option in x11/picom is new and has several problems with rendering
delays.

-- 
*
Dios en su cielo, todo bien en la Tierra

Re: [mpv] --vo=gpu not working, permission denied

[Jose Maldonado]

El Tue, 27 Feb 2024 10:35:54 -
beecdadd...@danwin1210.de escribió:
> hi sorry it was a chown problem because tty0 and fbtab, someone else
> helped thanks for time
> question: vulken error is OK if you don't have vulkaninfo installed,
> yes?
> 
> On Tue, February 27, 2024 5:49 am, Jose Maldonado wrote:
> > El Mon, 26 Feb 2024 21:54:43 -
> > beecdadd...@danwin1210.de escribió:  
> >> hi list
> >>
> >> mpv does not work OpenBSD -current updated 2 days ago, pkg_add -u
> >> was done now Thinkpad T400 laptop with Intep GPU
> >> say if you need more info than this and down
> >>
> >> mpv gives this error (+) Video --vid=1 (*) (vp8 240x424 30.000fps)
> >> (+) Audio --aid=1 --alang=eng (*) (vorbis 2ch 48000Hz)
> >> libEGL warning: MESA-LOADER: failed to retrieve device information
> >>
> >> libEGL warning: failed to open /dev/dri/card0: Permission denied
> >>
> >> libEGL warning: DRI2: could not open /dev/dri/card0 (Permission
> >> denied) [vo/gpu/opengl] Suspected software renderer or indirect
> >> context. [vo/gpu/libplacebo] EnumeratePhysicalDevices(inst, ,
> >> NULL): VK_ERROR_INITIALIZATION_FAILED
> >> (../libplacebo-6.338.2/src/vulkan/context.c:984)
> >> [vo/gpu/libplacebo] Found no suitable device, giving up.
> >> [vo/gpu/libplacebo] Failed initializing vulkan device
> >> [vo/gpu/libplacebo] EnumeratePhysicalDevices(inst, , NULL):
> >> VK_ERROR_INITIALIZATION_FAILED
> >> (../libplacebo-6.338.2/src/vulkan/context.c:984)
> >> [vo/gpu] Failed initializing any suitable GPU context!
> >> Error opening/initializing the selected video_out (--vo) device.
> >> Video: no video
> >> Exiting... (Errors when loading file)
> >>
> >>
> >>
> >>
> >> dmesg gave this error, not fresh
> >> drm:pid8053:drm_atomic_helper_wait_for_flip_done *ERROR* [drm]
> >> *ERROR* [CRTC:45:pipe A] flip_done timed out
> >> drm:pid51733:intel_pipe_update_start *ERROR* [drm] *ERROR*
> >> Potential atomic update failure on pipe A
> >>  
> >
> > Hi!
> >
> >
> > Can you provide your mpv.conf and the exact output for theses
> > commands?
> >
> > 1) mpv -v --vo=gpu --gpu-api=opengl your_video
> >
> >
> > 2) mpv -v --vo=gpu --gpu-api=vulkan your_video
> >
> >
> > 3) glxinfo
> >
> >
> > 4) vulkaninfo
> >
> >
> > Please provide the info in separate files
> >
> >
> > --
> > *
> > Dios en su cielo, todo bien en la Tierra
> >
> >
> >  
> 
> 

Not problem, and Vulkan errors are normal, it is part of the mpv
testing system, if you do not have support it will not do anything
using that backend and will use the supported one (OpenGL or X11)


-- 
*
Dios en su cielo, todo bien en la Tierra

Re: [mpv] --vo=gpu not working, permission denied

[Jose Maldonado]

El Mon, 26 Feb 2024 21:54:43 -
beecdadd...@danwin1210.de escribió:
> hi list
> 
> mpv does not work
> OpenBSD -current updated 2 days ago, pkg_add -u was done now
> Thinkpad T400 laptop with Intep GPU
> say if you need more info than this and down
> 
> mpv gives this error
>  (+) Video --vid=1 (*) (vp8 240x424 30.000fps)
>  (+) Audio --aid=1 --alang=eng (*) (vorbis 2ch 48000Hz)
> libEGL warning: MESA-LOADER: failed to retrieve device information
> 
> libEGL warning: failed to open /dev/dri/card0: Permission denied
> 
> libEGL warning: DRI2: could not open /dev/dri/card0 (Permission
> denied) [vo/gpu/opengl] Suspected software renderer or indirect
> context. [vo/gpu/libplacebo] EnumeratePhysicalDevices(inst, ,
> NULL): VK_ERROR_INITIALIZATION_FAILED
> (../libplacebo-6.338.2/src/vulkan/context.c:984)
> [vo/gpu/libplacebo] Found no suitable device, giving up.
> [vo/gpu/libplacebo] Failed initializing vulkan device
> [vo/gpu/libplacebo] EnumeratePhysicalDevices(inst, , NULL):
> VK_ERROR_INITIALIZATION_FAILED
> (../libplacebo-6.338.2/src/vulkan/context.c:984)
> [vo/gpu] Failed initializing any suitable GPU context!
> Error opening/initializing the selected video_out (--vo) device.
> Video: no video
> Exiting... (Errors when loading file)
> 
> 
> 
> dmesg gave this error, not fresh
> drm:pid8053:drm_atomic_helper_wait_for_flip_done *ERROR* [drm] *ERROR*
> [CRTC:45:pipe A] flip_done timed out
> drm:pid51733:intel_pipe_update_start *ERROR* [drm] *ERROR* Potential
> atomic update failure on pipe A
> 

Hi! 

Can you provide your mpv.conf and the exact output for theses
commands?

1) mpv -v --vo=gpu --gpu-api=opengl your_video

2) mpv -v --vo=gpu --gpu-api=vulkan your_video

3) glxinfo 

4) vulkaninfo 

Please provide the info in separate files 

-- 
*
Dios en su cielo, todo bien en la Tierra

Re: [UPDATE] x11/picom - new version 11.2

[Jose Maldonado]

El Sun, 25 Feb 2024 10:33:30 +0100
Omar Polo  escribió:
> Hello,
> 
> On 2024/02/25 01:35:08 -0400, Jose Maldonado 
> wrote:
> > El Wed, 14 Feb 2024 15:42:23 -0400
> > Jose Maldonado  escribió:
> > > Hi! I send diff for new version of picom, in this case the fixes
> > > for use libepoxy are merged in upstream, the port compile/build
> > > directly.
> > > 
> > > CC @omar because he has maintained the port for a long time.
> > > 
> > > 
> > 
> > PING
> > 
> > This is the last update for x11/picom 
> > 
> > Bug fixes:
> > 
> > * Workaround a NVIDIA problem that causes high CPU usage after
> > * Fix building on OpenBSD (#1189, #1188)
> > * Fix occasional freezes (#1040, #1145, #1166)
> > * Fix corner-radius-rules not applying sometimes (#1177)
> > * Fix window shader not having an effect (#1174)
> > * Fix binding root pixmap in case of depth mismatch (#984)
> > 
> > Reattach for convenience 
> 
> thanks for updating and taking care of fixing the issues with
> upstream. Sorry for the delay in replying, I was hoping to see some
> tests reports here before committing.  It works fine for me (amdgpu),
> so ok op@ if someone wants to go ahead and commit it, otherwise i'll
> wait a couple of days still and then commit.
> 
> 
> Thanks,
> 
> Omar Polo

I am also using amdgpu and so far nothing new. Thanks for the feedback!

-- 
*
Dios en su cielo, todo bien en la Tierra

Re: [UPDATE] x11/picom - new version 11.2

[Jose Maldonado]

El Wed, 14 Feb 2024 15:42:23 -0400
Jose Maldonado  escribió:
> Hi! I send diff for new version of picom, in this case the fixes for
> use libepoxy are merged in upstream, the port compile/build directly.
> 
> CC @omar because he has maintained the port for a long time.
> 
> 

PING

This is the last update for x11/picom 

Bug fixes:

* Workaround a NVIDIA problem that causes high CPU usage after
* Fix building on OpenBSD (#1189, #1188)
* Fix occasional freezes (#1040, #1145, #1166)
* Fix corner-radius-rules not applying sometimes (#1177)
* Fix window shader not having an effect (#1174)
* Fix binding root pixmap in case of depth mismatch (#984)

Reattach for convenience 


-- 
*
Dios en su cielo, todo bien en la Tierra
Index: Makefile
===
RCS file: /cvs/ports/x11/picom/Makefile,v
retrieving revision 1.11
diff -u -p -r1.11 Makefile
--- Makefile	24 Apr 2023 11:42:49 -	1.11
+++ Makefile	14 Feb 2024 19:41:40 -
@@ -1,19 +1,16 @@
 COMMENT =	lightweight compositor for X11
 
-GH_ACCOUNT =	yshui
-GH_PROJECT =	picom
-GH_TAGNAME =	v10.2
-REVISION =	0
+DIST_TUPLE =   github yshui picom v11.2 .
 
 CATEGORIES =	x11
 
 # MPL 2.0
 PERMIT_PACKAGE =	Yes
 
-WANTLIB += EGL GL X11 X11-xcb c config dbus-1 ev m pcre pixman-1
-WANTLIB += xcb-composite xcb-damage xcb-glx xcb-image xcb-present
+WANTLIB += EGL epoxy GL X11 X11-xcb c config dbus-1 ev m pcre2-8 pixman-1
+WANTLIB += pthread xcb-composite xcb-damage xcb-glx xcb-image xcb-present
 WANTLIB += xcb-randr xcb-render-util xcb-render xcb-shape xcb-sync
-WANTLIB += xcb-xfixes xcb-xinerama xcb
+WANTLIB += xcb-xfixes xcb-util xcb
 
 MODULES =		devel/meson
 
@@ -29,7 +26,7 @@ RUN_DEPENDS =		x11/gtk+4,-guic \
 
 LIB_DEPENDS =		devel/libconfig \
 			devel/libev \
-			devel/pcre \
+			devel/pcre2 \
 			x11/dbus
 
 CONFIGURE_ARGS	+=	-Dwith_docs=true \
@@ -50,3 +47,4 @@ post-install:
 		${PREFIX}/share/examples/picom
 
 .include 
+# DO NOT DELETE
Index: distinfo
===
RCS file: /cvs/ports/x11/picom/distinfo,v
retrieving revision 1.7
diff -u -p -r1.7 distinfo
--- distinfo	24 Dec 2022 16:35:26 -	1.7
+++ distinfo	14 Feb 2024 19:41:40 -
@@ -1,2 +1,2 @@
-SHA256 (picom-10.2.tar.gz) = l0FXffATbYor5IAFyiuT7cFZE1KOGbzreYU1ykaDNBw=
-SIZE (picom-10.2.tar.gz) = 287166
+SHA256 (yshui-picom-v11.2.tar.gz) = HBBjk2+vCe2bunJudzelYlZLel+M3vedSPza82aaTfQ=
+SIZE (yshui-picom-v11.2.tar.gz) = 308679

Re: New: volk - dynamic loader for vulkan (dependency for updating vulkan-tools)

[Jose Maldonado]

El Thu, 22 Feb 2024 22:07:29 -0500
Thomas Frohwein  escribió:
> *ping*
> 
> As this is needed for vulkan-loader update, I worry that stalling on
> this might lead to issues with ports that rely on recen vulkan API...
> 
> Re-attached for convenience.
> 
> On Tue, Feb 13, 2024 at 04:19:06PM -0500, Thomas Frohwein wrote:
> > Hi,
> > 
> > Please find attached a tarball for "volk", a meta loader for
> > vulkan. It appears to manage dynamic loading of the vulkan library
> > including simplification of extension management/loading. This is
> > now a dependency for the latest version of vulkan-tools, so I would
> > like to import this to proceed with the updates for vulkan..
> > 
> > ok?
> 
> 

I build this port for test, and work fine, not problem. 

-- 
*
Dios en su cielo, todo bien en la Tierra

Re: Remove www/youtube-dl and old ports related

[Jose Maldonado]

El Wed, 21 Feb 2024 20:23:49 +
Stuart Henderson  escribió:
> On 2024/02/21 15:45, Jose Maldonado wrote:
> > 
> > Hi!, ports list!
> > 
> > Reviewing some things with yt-dlp I have seen that in our port tree
> > we still have a mention of youtube-dl, more specifically the version
> > www/youtube-dl-2021.12.17p1 (its latest version).
> > 
> > It seemed strange to me, so I decided to install and test it
> > thinking that it was patched in some way to keep it working. It is
> > not the case. The port does not work, and as we know the
> > development of youtube-dl is abandoned, in favor of yt-dlp.
> > 
> > The same thing happens with other ports related to youtube-dl
> > 
> > 1) audio/yt-audio: abandoned since 2020, depends on youtube-dl and
> > therefore does not work.  
> 
> I think this is enough, the flags seem compatible:
> 
> Index: Makefile
> ===
> RCS file: /cvs/ports/audio/yt-audio/Makefile,v
> diff -u -p -r1.10 Makefile
> --- Makefile  13 Nov 2022 15:27:39 -  1.10
> +++ Makefile  21 Feb 2024 20:18:31 -
> @@ -3,7 +3,7 @@ COMMENT = youtube-dl wrapper to manage 
>  MODPY_EGG_VERSION =  0.1
>  DISTNAME =   yt-audio-${MODPY_EGG_VERSION}
>  CATEGORIES = audio
> -REVISION =   4
> +REVISION =   5
>  
>  MAINTAINER = Paul Irofti 
>  
> @@ -12,7 +12,7 @@ PERMIT_PACKAGE =Yes
>  
>  MODULES =lang/python
>  
> -RUN_DEPENDS =www/youtube-dl \
> +RUN_DEPENDS =www/yt-dlp \
>   graphics/ffmpeg
>  
>  MODPY_PI =   Yes
> Index: patches/patch-yt_audio_common_py
> ===
> RCS file: patches/patch-yt_audio_common_py
> diff -N patches/patch-yt_audio_common_py
> --- /dev/null 1 Jan 1970 00:00:00 -
> +++ patches/patch-yt_audio_common_py  21 Feb 2024 20:18:31 -
> @@ -0,0 +1,33 @@
> +Index: yt_audio/common.py
> +--- yt_audio/common.py.orig
>  yt_audio/common.py
> +@@ -11,9 +11,9 @@ class Common:
> + """
> + 
> + DEFAULT_ARGUMENT_VALUES = {
> +-'download_command': 'youtube-dl -x -q --print-json
> --audio-format mp3 --audio-quality 0 ' ++'download_command':
> 'yt-dlp -x -q --print-json --audio-format mp3 --audio-quality 0 '
> + '--add-metadata --embed-thumbnail -o
> "$OUTPUT$" $URL$', +-'playlist_info_command': 'youtube-dl
> --flat-playlist -J $PLAYLIST_URL$', ++
> 'playlist_info_command': 'yt-dlp --flat-playlist -J $PLAYLIST_URL$',
> + 'output_format': '%%(title)s.%%(ext)s',
> + 'ffprobe_command': 'ffprobe -v quiet -print_format json
> -show_format -hide_banner "$PATH$"',
> + 'output_directory': str(PurePath(Path.home(), "Music"))
> +@@ -88,7 +88,7 @@ class Common:
> + 
> + Parameters:
> + ==
> +-> download_command (string): youtube-dl download command
> ++> download_command (string): yt-dlp download command
> + 
> + > title_count (int): no. of titles to download
> + """
> +@@ -203,7 +203,7 @@ class Common:
> + def check_dependencies(self):
> + _dependencies = ["ffmpeg -version|avconv -version",
> +  "ffprobe -version|avprobe -version",
> +- "youtube-dl --version",
> ++ "yt-dlp --version",
> +  ]
> + for _dep in _dependencies:
> + try:
> 
> 
> 
> > 2) multimedia/py-pafy: abandoned since 2019, same situation as the
> > previous port.  
> 
> A bit more complex as it uses the Python API. Needs
> s/youtube_dl/yt_dlp/ but also accounting for other API changes (at
> least dislikes are no longer supported).
> 

Interesting changes to yt-audio, although personally I perform these
types of tasks with yt-dlp + bash.

Regarding py-pafy I also see it as complex, because YouTube has changed
the API quite a bit in the last 4 years, it would be reviewing the
entire project, but with upstream dead I doubt that will happen.


-- 
*
Dios en su cielo, todo bien en la Tierra

Remove www/youtube-dl and old ports related

[Jose Maldonado]

Hi!, ports list!

Reviewing some things with yt-dlp I have seen that in our port tree we
still have a mention of youtube-dl, more specifically the version
www/youtube-dl-2021.12.17p1 (its latest version).

It seemed strange to me, so I decided to install and test it thinking
that it was patched in some way to keep it working. It is not the case.
The port does not work, and as we know the development of youtube-dl is
abandoned, in favor of yt-dlp.

The same thing happens with other ports related to youtube-dl

1) audio/yt-audio: abandoned since 2020, depends on youtube-dl and
therefore does not work.

2) multimedia/py-pafy: abandoned since 2019, same situation as the
previous port.

I CC the maintainers of these packages to see what can be done with
them, but since they don't work, the options I see are limited (fork or
delete).

Any comments? 


-- 
*
Dios en su cielo, todo bien en la Tierra

Re: [UPDATE] multimedia/mpv - bump version v0.37.0

[Jose Maldonado]

El Wed, 21 Feb 2024 10:42:29 +
Stuart Henderson  escribió:
> On 2024/02/20 13:42, Jose Maldonado wrote:
> > El Tue, 20 Feb 2024 13:13:02 +
> > Stuart Henderson  escribió:  
> > > On 2024/02/20 08:52, Jose Maldonado wrote:  
> > > > El Tue, 20 Feb 2024 11:31:54 +
> > > > Stuart Henderson  escribió:  
> > > > > I get this:
> > > > > 
> > > > > $ make port-lib-depends-check
> > > > > 
> > > > > mpv-0.37.0(multimedia/mpv):
> > > > > Extra:  SPIRV-Tools-shared.0 Xinerama.6
> > > > > 
> > > > > Looks like upstream explicitly stopped using Xinerama so that
> > > > > one can be removed.
> > > > > 
> > > > > What's up with SPIRV-Tools-shared and the new LIB_DEPENDS on
> > > > > spirv-tools - I see that the port still uses
> > > > > -Dspirv-cross=disabled, I could have missed something but that
> > > > > does seem to disable anything to do with spirv?
> > > > >   
> > > > 
> > > > Hi @sthen!
> > > > 
> > > > In order to be consistent with the changes in x11/vlc, do we
> > > > also enable wayland support in multimedia/mpv? I can try this
> > > > along with the changes you have indicated  
> > > 
> > > wayland isn't enabled for vlc, it's just the libraries are pulled
> > > in via another dependency (gtk+3 in this case, I think) and so
> > > need to be listed. (Strangely only listed in libnotify_plugin..?)
> > > 
> > > I'd prefer to get the update in first without too many more
> > > changes, just tie up this remaining issue about the spirv libs,
> > > then we can look at whether or not to enable wayland separately
> > > afterwards.
> > > 
> > > $ objdump -p /usr/local/lib/vlc/plugins/notify/libnotify_plugin.so
> > >   
> > 
> > Ok, I understand this. At the rate things are going we will see more
> > and more dependencies on Wayland.
> > 
> > About MPV, I upload a new diff with the corrections. I detail the
> > changes:
> > 
> > 1) Removed Xinerama support (thanks @sthen)
> > 
> > 2) spirv-cross we don't need it, since from what I see in mpv's
> > meson.build, this is a feature aimed at Windows (d3d11).
> > 
> > 3) Vulkan in mpv can be activated without using spirv-tools (I
> > removed it from LIB_DEPENDS and WANTLIB). In this case, libplacebo
> > will take care of making the appropriate shader management
> > arrangements (using shaderc), as appropriate. I have already tested
> > it by playing video with shaders (FSR.glsl) and without these, it
> > works correctly (on OpenGL and Vulkan gpu-api-context)and the spirv
> > shaders are processed by libplacebo as shown in the log.  
> 
> Great, thanks. I think this is a good point to commit so I'll do so,
> happy to look at wayland as new diffs.

I'm sure wayland will continue to make good progress on OpenBSD.

As for mpv, the last time I tried wayland support I was surprised,
--vo=wlshm didn't break or show strange things, but the use of shaders
and color management contexts among other things still needed to be
polished.

Thanks for the guide @sthen


-- 
*
Dios en su cielo, todo bien en la Tierra

Re: [UPDATE] multimedia/mpv - bump version v0.37.0

[Jose Maldonado]

El Tue, 20 Feb 2024 13:13:02 +
Stuart Henderson  escribió:
> On 2024/02/20 08:52, Jose Maldonado wrote:
> > El Tue, 20 Feb 2024 11:31:54 +
> > Stuart Henderson  escribió:
> > > I get this:
> > > 
> > > $ make port-lib-depends-check
> > > 
> > > mpv-0.37.0(multimedia/mpv):
> > > Extra:  SPIRV-Tools-shared.0 Xinerama.6
> > > 
> > > Looks like upstream explicitly stopped using Xinerama so that one
> > > can be removed.
> > > 
> > > What's up with SPIRV-Tools-shared and the new LIB_DEPENDS on
> > > spirv-tools - I see that the port still uses
> > > -Dspirv-cross=disabled, I could have missed something but that
> > > does seem to disable anything to do with spirv?
> > > 
> > 
> > Hi @sthen!
> > 
> > In order to be consistent with the changes in x11/vlc, do we also
> > enable wayland support in multimedia/mpv? I can try this along with
> > the changes you have indicated
> 
> wayland isn't enabled for vlc, it's just the libraries are pulled in
> via another dependency (gtk+3 in this case, I think) and so need to be
> listed. (Strangely only listed in libnotify_plugin..?)
> 
> I'd prefer to get the update in first without too many more changes,
> just tie up this remaining issue about the spirv libs, then we can
> look at whether or not to enable wayland separately afterwards.
> 
> $ objdump -p /usr/local/lib/vlc/plugins/notify/libnotify_plugin.so
> 

Ok, I understand this. At the rate things are going we will see more
and more dependencies on Wayland.

About MPV, I upload a new diff with the corrections. I detail the
changes:

1) Removed Xinerama support (thanks @sthen)

2) spirv-cross we don't need it, since from what I see in mpv's
meson.build, this is a feature aimed at Windows (d3d11).

3) Vulkan in mpv can be activated without using spirv-tools (I removed
it from LIB_DEPENDS and WANTLIB). In this case, libplacebo will take
care of making the appropriate shader management arrangements (using
shaderc), as appropriate. I have already tested it by playing video
with shaders (FSR.glsl) and without these, it works correctly (on
OpenGL and Vulkan gpu-api-context)and the spirv shaders are processed by
libplacebo as shown in the log.



-- 
*
Dios en su cielo, todo bien en la Tierra
Index: Makefile
===
RCS file: /cvs/ports/multimedia/mpv/Makefile,v
retrieving revision 1.98
diff -u -p -r1.98 Makefile
--- Makefile	24 Jul 2023 12:40:20 -	1.98
+++ Makefile	20 Feb 2024 17:24:35 -
@@ -2,10 +2,10 @@ COMMENT =		movie player based on MPlayer
 
 GH_ACCOUNT =		mpv-player
 GH_PROJECT =		mpv
-GH_TAGNAME =		v0.36.0
+GH_TAGNAME =		v0.37.0
 USE_NOBTCFI =		Yes
 
-SHARED_LIBS +=		mpv		1.0 # 2.0
+SHARED_LIBS +=		mpv		2.0
 
 CATEGORIES =		multimedia x11
 
@@ -14,11 +14,11 @@ HOMEPAGE =		https://mpv.io/
 # GPLv2+
 PERMIT_PACKAGE =	Yes
 
-WANTLIB += EGL SDL2 X11 Xext Xinerama Xpresent Xrandr Xss Xv archive
+WANTLIB += ${MODLUA_WANTLIB}
+WANTLIB += EGL SDL2 X11 Xext Xpresent Xrandr Xss Xv archive
 WANTLIB += ass avcodec avdevice avfilter avformat avutil bluray
 WANTLIB += c cdio cdio_cdda cdio_paranoia dvdnav iconv jpeg lcms2
-WANTLIB += ${MODLUA_WANTLIB} m placebo pthread sndio swresample
-WANTLIB += swscale z zimg
+WANTLIB += m placebo pthread sndio swresample swscale vulkan z zimg
 
 MODULES =		devel/meson \
 			lang/lua \
@@ -41,6 +41,7 @@ LIB_DEPENDS =		archivers/libarchive \
 			graphics/jpeg \
 			graphics/lcms2 \
 			graphics/libplacebo \
+			graphics/vulkan-loader \
 			graphics/zimg \
 			multimedia/libass \
 			multimedia/libbluray \
@@ -48,6 +49,7 @@ LIB_DEPENDS =		archivers/libarchive \
 
 MODPY_RUNDEP =		No
 RUN_DEPENDS =		devel/desktop-file-utils \
+			graphics/vulkan-loader \
 			www/yt-dlp \
 			x11/gtk+4,-guic
 
@@ -83,10 +85,6 @@ CONFIGURE_ARGS =	-Dlua=lua${MODLUA_DEP_V
 			-Dios-gl=disabled \
 			-Djack=disabled \
 			-Djavascript=disabled \
-			-Dlibplacebo-next=disabled \
-			-Dmacos-10-11-features=disabled \
-			-Dmacos-10-12-2-features=disabled \
-			-Dmacos-10-14-features=disabled \
 			-Dmacos-cocoa-cb=disabled \
 			-Dmacos-media-player=disabled \
 			-Dmacos-touchbar=disabled \
@@ -100,28 +98,30 @@ CONFIGURE_ARGS =	-Dlua=lua${MODLUA_DEP_V
 			-Dshaderc=disabled \
 			-Dsixel=disabled \
 			-Dswift-build=disabled \
+			-Dswift-flags=disabled \
 			-Dsdl2-audio=disabled \
 			-Dspirv-cross=disabled \
 			-Duchardet=disabled \
 			-Dvaapi=disabled \
 			-Dvaapi-drm=disabled \
-			-Dvaapi-x-egl=disabled \
 			-Dvaapi-x11=disabled \
 			-Dvaapi-wayland=disabled \
 			-Dvapoursynth=disabled \
 			-Dvdpau=disabled \
 			-Dvdpau-gl-x11=disabled \
 			-Dvideotoolbox-gl=disabled \
-			-Dvulkan=disabled \
+			-Dvideotoolbox-pl=disabled \
+			-Dvulkan=enabled \

Re: [UPDATE] multimedia/mpv - bump version v0.37.0

[Jose Maldonado]

El Tue, 20 Feb 2024 11:31:54 +
Stuart Henderson  escribió:
> I get this:
> 
> $ make port-lib-depends-check
> 
> mpv-0.37.0(multimedia/mpv):
> Extra:  SPIRV-Tools-shared.0 Xinerama.6
> 
> Looks like upstream explicitly stopped using Xinerama so that one can
> be removed.
> 
> What's up with SPIRV-Tools-shared and the new LIB_DEPENDS on
> spirv-tools - I see that the port still uses -Dspirv-cross=disabled,
> I could have missed something but that does seem to disable anything
> to do with spirv?
> 

Hi @sthen!

In order to be consistent with the changes in x11/vlc, do we also
enable wayland support in multimedia/mpv? I can try this along with the
changes you have indicated

-- 
*
Dios en su cielo, todo bien en la Tierra

Re: [UPDATE] graphics/libplacebo - v6.338.2

[Jose Maldonado]

El Mon, 19 Feb 2024 22:44:58 -0500
Brad Smith  escribió:
> On 2024-02-19 3:53 p.m., Jose Maldonado wrote:
> > El Mon, 19 Feb 2024 15:30:55 +
> > Stuart Henderson  escribió:
> >> You add "WANTLIB+= ${COMPILER_LIBCXX}" while keeping
> >> COMPILER_LANGS=c, which will probably fail on base-gcc archs. I
> >> think you'll need to remove the COMPILER_LANGS line.
> > Hi @sthen!
> >
> > Fixed, I send the new diff with corrections, newly tested in amd64,
> > build and work fine.
> 
> Hi Jose,Could you move the dlopen comment to the bottom and have a 
> separate line of just "WANTLIB += GL epoxy" below the comment. The
> rest looks good. Thanks.

Hi @Brad! 

I'll send you a new diff with the changes you request.

-- 
*
Dios en su cielo, todo bien en la Tierra
Index: Makefile
===
RCS file: /cvs/ports/graphics/libplacebo/Makefile,v
retrieving revision 1.11
diff -u -p -r1.11 Makefile
--- Makefile	23 Jul 2022 05:16:05 -	1.11
+++ Makefile	20 Feb 2024 04:41:53 -
@@ -2,32 +2,52 @@ COMMENT=	reusable library for GPU-accele
 
 GH_ACCOUNT=	haasn
 GH_PROJECT=	libplacebo
-GH_TAGNAME=	v4.208.0
+GH_TAGNAME=	v6.338.2
 CATEGORIES=	graphics
 
-SHARED_LIBS=	placebo	7.0
+SHARED_LIBS=	placebo	8.0
 
 MAINTAINER=	Brad Smith 
 
 # LGPLv2.1+
 PERMIT_PACKAGE=	Yes
 
-WANTLIB=	epoxy execinfo lcms2 m pthread
+WANTLIB +=	${COMPILER_LIBCXX}
+WANTLIB +=	execinfo lcms2 m pthread
+WANTLIB +=	shaderc_shared vulkan
+# GL and epoxy are dlopened by libplacebo
+WANTLIB +=	epoxy GL
+
 
 MODULES=	devel/meson
 
-LIB_DEPENDS=	graphics/lcms2
+BUILD_DEPENDS=	devel/fast-float \
+		graphics/glad \
+		graphics/vulkan-headers
+
+LIB_DEPENDS=	graphics/lcms2 \
+		graphics/shaderc \
+		graphics/vulkan-loader
 
 COMPILER=	base-clang ports-gcc
-COMPILER_LANGS=	c
+
+CFLAGS +=		-I${X11BASE}/include
+LDFLAGS +=		-L${X11BASE}/lib
+
+MODMESON_CONFIGURE_ENV +=	CFLAGS="${CFLAGS}" \
+	LDFLAGS="${LDFLAGS}"
 
 CONFIGURE_ARGS+=-Ddefault_library=both \
 		-Dd3d11=disabled \
 		-Ddemos=false \
+		-Ddovi=disabled \
 		-Dglslang=disabled \
-		-Dshaderc=disabled \
+		-Dlibdovi=disabled \
+		-Dshaderc=enabled \
+		-Dopengl=enabled \
 		-Dunwind=disabled \
-		-Dvulkan=disabled
+		-Dvulkan=enabled \
+		-Dxxhash=disabled
 
 NO_TEST=	Yes
 
Index: distinfo
===
RCS file: /cvs/ports/graphics/libplacebo/distinfo,v
retrieving revision 1.9
diff -u -p -r1.9 distinfo
--- distinfo	23 Jul 2022 05:16:05 -	1.9
+++ distinfo	20 Feb 2024 04:41:53 -
@@ -1,2 +1,2 @@
-SHA256 (libplacebo-4.208.0.tar.gz) = UJD7rU9luclQAoweDdhtIKpm0VnAhUqJs+uNQhCWa3M=
-SIZE (libplacebo-4.208.0.tar.gz) = 647068
+SHA256 (libplacebo-6.338.2.tar.gz) = Lx5iTgnXKoydtw+RD3Vg52ShwSba5CrMWzvO+DanrsY=
+SIZE (libplacebo-6.338.2.tar.gz) = 841168
Index: pkg/PLIST
===
RCS file: /cvs/ports/graphics/libplacebo/pkg/PLIST,v
retrieving revision 1.8
diff -u -p -r1.8 PLIST
--- pkg/PLIST	11 Mar 2022 19:22:45 -	1.8
+++ pkg/PLIST	20 Feb 2024 04:41:53 -
@@ -1,20 +1,25 @@
 include/libplacebo/
+include/libplacebo/cache.h
 include/libplacebo/colorspace.h
 include/libplacebo/common.h
 include/libplacebo/config.h
-include/libplacebo/context.h
+include/libplacebo/d3d11.h
 include/libplacebo/dispatch.h
 include/libplacebo/dither.h
 include/libplacebo/dummy.h
 include/libplacebo/filters.h
+include/libplacebo/gamut_mapping.h
 include/libplacebo/gpu.h
 include/libplacebo/log.h
 include/libplacebo/opengl.h
+include/libplacebo/options.h
 include/libplacebo/renderer.h
 include/libplacebo/shaders/
 include/libplacebo/shaders.h
 include/libplacebo/shaders/colorspace.h
 include/libplacebo/shaders/custom.h
+include/libplacebo/shaders/deinterlacing.h
+include/libplacebo/shaders/dithering.h
 include/libplacebo/shaders/film_grain.h
 include/libplacebo/shaders/icc.h
 include/libplacebo/shaders/lut.h
@@ -24,10 +29,12 @@ include/libplacebo/tone_mapping.h
 include/libplacebo/utils/
 include/libplacebo/utils/dav1d.h
 include/libplacebo/utils/dav1d_internal.h
+include/libplacebo/utils/dolbyvision.h
 include/libplacebo/utils/frame_queue.h
 include/libplacebo/utils/libav.h
 include/libplacebo/utils/libav_internal.h
 include/libplacebo/utils/upload.h
+include/libplacebo/vulkan.h
 @static-lib lib/libplacebo.a
 @lib lib/libplacebo.so.${LIBplacebo_VERSION}
 lib/pkgconfig/libplacebo.pc

Re: [UPDATE] graphics/libplacebo - v6.338.2

[Jose Maldonado]

El Mon, 19 Feb 2024 15:30:55 +
Stuart Henderson  escribió:
> You add "WANTLIB+= ${COMPILER_LIBCXX}" while keeping COMPILER_LANGS=c,
> which will probably fail on base-gcc archs. I think you'll need to
> remove the COMPILER_LANGS line.

Hi @sthen! 

Fixed, I send the new diff with corrections, newly tested in amd64,
build and work fine. 

-- 
*
Dios en su cielo, todo bien en la Tierra
Index: Makefile
===
RCS file: /cvs/ports/graphics/libplacebo/Makefile,v
retrieving revision 1.11
diff -u -p -r1.11 Makefile
--- Makefile	23 Jul 2022 05:16:05 -	1.11
+++ Makefile	19 Feb 2024 20:50:24 -
@@ -2,32 +2,50 @@ COMMENT=	reusable library for GPU-accele
 
 GH_ACCOUNT=	haasn
 GH_PROJECT=	libplacebo
-GH_TAGNAME=	v4.208.0
+GH_TAGNAME=	v6.338.2
 CATEGORIES=	graphics
 
-SHARED_LIBS=	placebo	7.0
+SHARED_LIBS=	placebo	8.0
 
 MAINTAINER=	Brad Smith 
 
 # LGPLv2.1+
 PERMIT_PACKAGE=	Yes
 
-WANTLIB=	epoxy execinfo lcms2 m pthread
+# GL and epoxy are dlopened by libplacebo
+WANTLIB +=	${COMPILER_LIBCXX}
+WANTLIB +=	epoxy execinfo GL lcms2 m pthread
+WANTLIB +=	shaderc_shared vulkan 
 
 MODULES=	devel/meson
 
-LIB_DEPENDS=	graphics/lcms2
+BUILD_DEPENDS=	devel/fast-float \
+		graphics/glad \
+		graphics/vulkan-headers
+
+LIB_DEPENDS=	graphics/lcms2 \
+		graphics/shaderc \
+		graphics/vulkan-loader
 
 COMPILER=	base-clang ports-gcc
-COMPILER_LANGS=	c
+
+CFLAGS +=		-I${X11BASE}/include
+LDFLAGS +=		-L${X11BASE}/lib
+
+MODMESON_CONFIGURE_ENV +=	CFLAGS="${CFLAGS}" \
+	LDFLAGS="${LDFLAGS}"
 
 CONFIGURE_ARGS+=-Ddefault_library=both \
 		-Dd3d11=disabled \
 		-Ddemos=false \
+		-Ddovi=disabled \
 		-Dglslang=disabled \
-		-Dshaderc=disabled \
+		-Dlibdovi=disabled \
+		-Dshaderc=enabled \
+		-Dopengl=enabled \
 		-Dunwind=disabled \
-		-Dvulkan=disabled
+		-Dxxhash=disabled \
+		-Dvulkan=enabled
 
 NO_TEST=	Yes
 
Index: distinfo
===
RCS file: /cvs/ports/graphics/libplacebo/distinfo,v
retrieving revision 1.9
diff -u -p -r1.9 distinfo
--- distinfo	23 Jul 2022 05:16:05 -	1.9
+++ distinfo	19 Feb 2024 20:50:24 -
@@ -1,2 +1,2 @@
-SHA256 (libplacebo-4.208.0.tar.gz) = UJD7rU9luclQAoweDdhtIKpm0VnAhUqJs+uNQhCWa3M=
-SIZE (libplacebo-4.208.0.tar.gz) = 647068
+SHA256 (libplacebo-6.338.2.tar.gz) = Lx5iTgnXKoydtw+RD3Vg52ShwSba5CrMWzvO+DanrsY=
+SIZE (libplacebo-6.338.2.tar.gz) = 841168
Index: pkg/PLIST
===
RCS file: /cvs/ports/graphics/libplacebo/pkg/PLIST,v
retrieving revision 1.8
diff -u -p -r1.8 PLIST
--- pkg/PLIST	11 Mar 2022 19:22:45 -	1.8
+++ pkg/PLIST	19 Feb 2024 20:50:24 -
@@ -1,20 +1,25 @@
 include/libplacebo/
+include/libplacebo/cache.h
 include/libplacebo/colorspace.h
 include/libplacebo/common.h
 include/libplacebo/config.h
-include/libplacebo/context.h
+include/libplacebo/d3d11.h
 include/libplacebo/dispatch.h
 include/libplacebo/dither.h
 include/libplacebo/dummy.h
 include/libplacebo/filters.h
+include/libplacebo/gamut_mapping.h
 include/libplacebo/gpu.h
 include/libplacebo/log.h
 include/libplacebo/opengl.h
+include/libplacebo/options.h
 include/libplacebo/renderer.h
 include/libplacebo/shaders/
 include/libplacebo/shaders.h
 include/libplacebo/shaders/colorspace.h
 include/libplacebo/shaders/custom.h
+include/libplacebo/shaders/deinterlacing.h
+include/libplacebo/shaders/dithering.h
 include/libplacebo/shaders/film_grain.h
 include/libplacebo/shaders/icc.h
 include/libplacebo/shaders/lut.h
@@ -24,10 +29,12 @@ include/libplacebo/tone_mapping.h
 include/libplacebo/utils/
 include/libplacebo/utils/dav1d.h
 include/libplacebo/utils/dav1d_internal.h
+include/libplacebo/utils/dolbyvision.h
 include/libplacebo/utils/frame_queue.h
 include/libplacebo/utils/libav.h
 include/libplacebo/utils/libav_internal.h
 include/libplacebo/utils/upload.h
+include/libplacebo/vulkan.h
 @static-lib lib/libplacebo.a
 @lib lib/libplacebo.so.${LIBplacebo_VERSION}
 lib/pkgconfig/libplacebo.pc

Re: [UPDATE] x11/vlc - revision for libplacebo support

[Jose Maldonado]

El Mon, 19 Feb 2024 08:42:50 +
Stuart Henderson  escribió:
> lcms2 is not used, and the wayland libs should be listed in WANTLIB
> (not new with this diff, but other changes in the ports tree resulted
> in them being used). I think this is the correct diff.
> 

I have checked the lcms2 and it is correct, we do not need it. I have
used the diff that you have passed and everything works correctly.



-- 
*
Dios en su cielo, todo bien en la Tierra

Re: [UPDATE] x11/vlc - revision for libplacebo support

[Jose Maldonado]

El Mon, 19 Feb 2024 02:47:46 -0500
Brad Smith  escribió:
> On 2024-02-15 7:36 p.m., Jose Maldonado wrote:
> > El Thu, 15 Feb 2024 15:46:38 -0500
> > Thomas Frohwein  escribió:
> >> On Tue, Feb 13, 2024 at 09:31:32PM -0400, Jose Maldonado wrote:
> >>
> >> [...]
> >>
> >>> +WANTLIB-main += webp x264 x265 xcb xcb-composite xcb-dri2
> >>> xcb-dri3 xcb-glx xcb-keysyms +WANTLIB-main += xcb-present
> >>> xcb-randr xcb-render xcb-shm xcb-sync xcb-xfixes xcb-xv xkbcommon
> >>> xml2
> >> ^ These lines are very long now; I would usually reflow them to
> >> stay <= 80 chars wide.
> > Fixed too.
> >
> >>>   WANTLIB-main += xshmfence xvidcore z zstd ${WANTLIB-common}
> >>> ${MODLUA_WANTLIB} # v4l2 is dlopen'd
> >>>   WANTLIB-main+=  v4l2
> >>> @@ -113,8 +113,8 @@ LIB_DEPENDS-main= ${MODQT5_LIB_DEPENDS}
> >>>   devel/sdl \
> >>>   devel/sdl-image \
> >>>   graphics/ffmpeg \
> >>> + graphics/lcms2 \
> >>>   graphics/libdvbpsi \
> >>> - graphics/libplacebo \
> >>>   graphics/png \
> >>>   multimedia/libass \
> >>>   multimedia/libbluray \
> >>> @@ -173,6 +173,7 @@ CONFIGURE_ARGS+=--disable-a52 \
> >>>   --disable-kate \
> >>>   --disable-kwallet \
> >>>   --disable-libmpeg2 \
> >>> + --disable-libplacebo \
> >>>   --disable-libva \
> >>>   --disable-linsys \
> >>>   --disable-live555 \
> >>> Index: pkg/PLIST-main
> >>> ===
> >>> RCS file: /cvs/ports/x11/vlc/pkg/PLIST-main,v
> >>> retrieving revision 1.52
> >>> diff -u -p -r1.52 PLIST-main
> >>> --- pkg/PLIST-main14 May 2023 09:20:41 -  1.52
> >>> +++ pkg/PLIST-main14 Feb 2024 01:30:31 -
> >>> @@ -1,6 +1,5 @@
> >>>   @pkgpath x11/vlc
> >>>   %%amd64%%
> >>> -%%i386%%
> >>>   bin/cvlc
> >>>   bin/qvlc
> >>>   bin/rvlc
> >>> @@ -444,6 +443,7 @@ lib/vlc/plugins/video_chroma/
> >>>   @so lib/vlc/plugins/video_chroma/libi420_yuy2_plugin.so
> >>>   @so lib/vlc/plugins/video_chroma/libi422_i420_plugin.so
> >>>   @so lib/vlc/plugins/video_chroma/libi422_yuy2_plugin.so
> >>> +%%i386%%
> >>>   @so lib/vlc/plugins/video_chroma/librv32_plugin.so
> >>>   @so lib/vlc/plugins/video_chroma/libswscale_plugin.so
> >>>   @so lib/vlc/plugins/video_chroma/libyuvp_plugin.so
> >> Not sure if that's a change generated by update-plist, but probably
> >> not the right time to adjust the order of PLIST unless this is
> >> related to the libplacebo change or another compelling reason...
> >>
> > This is something that the maintainer can clarify better for us, but
> > based on the file names, this would also be related to libplacebo.
> 
> The PLIST-main part should be removed. The order is intentional.

Hi! I will fix this part

> 
> >> I don't use vlc myself, but before moving forward with the
> >> libplacebo update and this change to vlc, would need to hear from
> >> maintainer or some others if the change for vlc is justifiable
> >> here.
> > It will be the last word of the maintainer. But the truth is that as
> > things are with libplacebo and VLC, due to the latter we will not be
> > able to update mpv either, since 0.37.0 has a strong dependency on
> > libplacebo(v>=6) and with this VLC using libplacebo will not compile
> > until VLC4 arrives.
> >
> > I don't use VLC either, but as upstream indicates, not using
> > libplacebo should not remove any functionality from VLC, only that
> > color management and mapping would be done with graphics/lcms2.
> >
> > In any case, I sent you the new diff along with an image [1] showing
> > how well VLC works with the changes.
> >
> > [1] https://imgur.com/a/ZIGLB3I
> 
> 
> I am fine with the diff disabling placebo. VLC with version 3 only
> uses it for tone
> mapping if I'm not mistaken, so it is not critical if it is disabled.
> 

That's correct, it is not a functionality that interrupts the proper
functioning of VLC.


-- 
*
Dios en su cielo, todo bien en la Tierra

Re: sdl2 maintainer updates - sdl2 2.30.0, sdl2-mixer 2.8.0, and sdl2-ttf 2.22.0

[Jose Maldonado]

El Sat, 17 Feb 2024 23:24:43 -0500
Thomas Frohwein  escribió:
> Hi,
> 
> Please find attached diffs for updating sdl2, sdl2-mixer, and sdl2-ttf
> to their latest versions. API changes are minor. I've built and ran a
> few consumers without issues. Here the release notes:
> 
> sdl2-2.30.0
> ---
> 
> In addition to lots of bug fixes, here are the major changes in this
> release:
> 
> General:
> 
> * Added support for 2 bits-per-pixel indexed surface formats
> * Added the function SDL_GameControllerGetSteamHandle() to get the
> Steam API handle for a controller, if available
> * Added the event SDL_CONTROLLERSTEAMHANDLEUPDATED which is sent when
>   the Steam API handle for a controller changes. This could also
> change the name, VID, and PID of the controller.
> * Added the environment variable SDL_LOGGING to control default log
> output
> 

Good hear this, I've testing for compile and create a port for pcsx2
emulator and sdl2-2.30 is a depedencies for this. 

Thanks for this work! :)


-- 
*
Dios en su cielo, todo bien en la Tierra

Re: [UPDATE] x11/vlc - revision for libplacebo support

[Jose Maldonado]

El Thu, 15 Feb 2024 15:46:38 -0500
Thomas Frohwein  escribió:
> On Tue, Feb 13, 2024 at 09:31:32PM -0400, Jose Maldonado wrote:
> 
> [...]
> 
> > --- Makefile2 Feb 2024 20:09:08 -   1.268
> > +++ Makefile14 Feb 2024 01:30:31 -
> > @@ -5,7 +5,7 @@ V=  3.0.18
> >  DISTNAME=  vlc-${V}
> >  PKGNAME-main=  ${DISTNAME}
> >  PKGNAME-jack=  vlc-jack-${V}
> > -REVISION-main= 5
> > +REVISION-main=  6
> 
> I'm nitpicking, but please keep the same tab spacing here.

No problem, you are reviewing what I send, if I do let me know, my
point here is to improve and avoid making mistakes, after all I am a
newbie :)

> 
> >  CATEGORIES=x11
> >  SITES=
> > https://download.videolan.org/pub/videolan/vlc/${V}/
> > EXTRACT_SUFX=   .tar.xz @@ -53,20 +53,20 @@ WANTLIB-main +=
> > absl_throw_delegate absl WANTLIB-main += ass atk-1.0 atk-bridge-2.0
> > atspi avahi-client avahi-common WANTLIB-main += avcodec avformat
> > avutil b2 bluray brotlidec brotlienc WANTLIB-main += bz2 c cairo
> > cairo-gobject cddb crypto dav1d double-conversion -WANTLIB-main +=
> > drm dvbpsi dvdnav dvdread ebml epoxy execinfo expat +WANTLIB-main
> > += drm dvbpsi dvdnav dvdread ebml epoll-shim epoxy execinfo expat
> > WANTLIB-main += ffi fontconfig freetype fribidi gbm gcrypt gdk-3
> > gdk_pixbuf-2.0 WANTLIB-main += gio-2.0 glapi glib-2.0 gmodule-2.0
> > gmp gnutls gobject-2.0 WANTLIB-main += gpg-error graphite2 gsm
> > gthread-2.0 gtk-3 harfbuzz WANTLIB-main += hogweed icudata icui18n
> > icuuc idn2 jpeg lcms2 lz4 lzma WANTLIB-main += matroska mp3lame
> > nettle nfs notify ogg opus p11-kit WANTLIB-main += pango-1.0
> > pangocairo-1.0 pangoft2-1.0 pcre2-16 pcre2-8 -WANTLIB-main +=
> > pixman-1 placebo png postproc protobuf-lite rsvg-2 +WANTLIB-main +=
> > pixman-1 png postproc protobuf-lite rsvg-2 WANTLIB-main += sharpyuv
> > smb2 sndio soxr speex speexdsp ssl swresample WANTLIB-main +=
> > swscale tag tar tasn1 theoradec theoraenc tiff udfread WANTLIB-main
> > += unibreak unistring usbhid utf8_range utf8_validity -WANTLIB-main
> > += vorbis vorbisenc vpx webp x264 x265 xcb xcb-composite
> > -WANTLIB-main += xcb-dri2 xcb-dri3 xcb-glx xcb-keysyms xcb-present
> > xcb-randr -WANTLIB-main += xcb-render xcb-shm xcb-sync xcb-xfixes
> > xcb-xv xml2 +WANTLIB-main += vorbis vorbisenc vpx wayland-client
> > wayland-cursor wayland-egl 
> 
> You are adding wayland dependency/WANTLIB here.

Fixed and delete this dependencies. 

> 
> > +WANTLIB-main += webp x264 x265 xcb xcb-composite xcb-dri2 xcb-dri3
> > xcb-glx xcb-keysyms +WANTLIB-main += xcb-present xcb-randr
> > xcb-render xcb-shm xcb-sync xcb-xfixes xcb-xv xkbcommon xml2
> 
> ^ These lines are very long now; I would usually reflow them to stay
> <= 80 chars wide.

Fixed too.

> 
> >  WANTLIB-main += xshmfence xvidcore z zstd ${WANTLIB-common}
> > ${MODLUA_WANTLIB} # v4l2 is dlopen'd
> >  WANTLIB-main+= v4l2
> > @@ -113,8 +113,8 @@ LIB_DEPENDS-main= ${MODQT5_LIB_DEPENDS} 
> > devel/sdl \
> > devel/sdl-image \
> > graphics/ffmpeg \
> > +   graphics/lcms2 \
> > graphics/libdvbpsi \
> > -   graphics/libplacebo \
> > graphics/png \
> > multimedia/libass \
> > multimedia/libbluray \
> > @@ -173,6 +173,7 @@ CONFIGURE_ARGS+=--disable-a52 \
> > --disable-kate \
> > --disable-kwallet \
> > --disable-libmpeg2 \
> > +   --disable-libplacebo \
> > --disable-libva \
> > --disable-linsys \
> > --disable-live555 \
> > Index: pkg/PLIST-main
> > ===
> > RCS file: /cvs/ports/x11/vlc/pkg/PLIST-main,v
> > retrieving revision 1.52
> > diff -u -p -r1.52 PLIST-main
> > --- pkg/PLIST-main  14 May 2023 09:20:41 -  1.52
> > +++ pkg/PLIST-main  14 Feb 2024 01:30:31 -
> > @@ -1,6 +1,5 @@
> >  @pkgpath x11/vlc
> >  %%amd64%%
> > -%%i386%%
> >  bin/cvlc
> >  bin/qvlc
> >  bin/rvlc
> > @@ -444,6 +443,7 @@ lib/vlc/plugins/video_chroma/
> >  @so lib/vlc/plugins/video_chroma/libi420_yuy2_plugin.so
> >  @so lib/vlc/plugins/video_chroma/libi422_i420_plugin.so
> >  @so lib/vlc/plugins/video_chroma/libi422_yuy2_plugin.so
> > +%%i386%%
> >  @so lib/vlc/plugins/video_chroma/librv32_plugin.so
> >  @so lib/vlc/plugins/video_chroma/libswscale_plugin.so
> >  @so lib/vlc/plugins/video_chroma/libyuvp_plugin.so
> 
&g

Re: NEW: audio/deadbeef-plugin-mpris2

[Jose Maldonado]

El Wed, 14 Feb 2024 17:38:43 -0600
izder456  escribió:
> Hey,
> 
> Just wanna pop in here and clarify why i did things the way i did.
> 
> Jose Maldonado  wrote:
> > Why rename deadbeef-mpris2-plugin to deadbeef-plugin-mpris2?
> the thought process was simple here, there are other plugins that
> people may want to port for DeaDBeeF. with this naming scheme, all of
> the plugins would be prefixed by deadbeef-plugin and followed by
> -pluginname. this is more of a consistency measure in case future
> ports from me or others come about.
> 

The person who wrote that was not me, it was Klemens.

But it doesn't matter, I agree with you about renaming the package so
that it is:

deadbeef-plugin-plugin_name

It becomes more readable and since it is the first deadbeef plugin to
reach ports we can use this scheme for PKGNAMEs related to deadbeef
plugins.



-- 
*
Dios en su cielo, todo bien en la Tierra

[UPDATE] x11/picom - new version 11.2

[Jose Maldonado]

Hi! I send diff for new version of picom, in this case the fixes for
use libepoxy are merged in upstream, the port compile/build directly.

CC @omar because he has maintained the port for a long time.


-- 
*
Dios en su cielo, todo bien en la Tierra
Index: Makefile
===
RCS file: /cvs/ports/x11/picom/Makefile,v
retrieving revision 1.11
diff -u -p -r1.11 Makefile
--- Makefile	24 Apr 2023 11:42:49 -	1.11
+++ Makefile	14 Feb 2024 19:41:40 -
@@ -1,19 +1,16 @@
 COMMENT =	lightweight compositor for X11
 
-GH_ACCOUNT =	yshui
-GH_PROJECT =	picom
-GH_TAGNAME =	v10.2
-REVISION =	0
+DIST_TUPLE =   github yshui picom v11.2 .
 
 CATEGORIES =	x11
 
 # MPL 2.0
 PERMIT_PACKAGE =	Yes
 
-WANTLIB += EGL GL X11 X11-xcb c config dbus-1 ev m pcre pixman-1
-WANTLIB += xcb-composite xcb-damage xcb-glx xcb-image xcb-present
+WANTLIB += EGL epoxy GL X11 X11-xcb c config dbus-1 ev m pcre2-8 pixman-1
+WANTLIB += pthread xcb-composite xcb-damage xcb-glx xcb-image xcb-present
 WANTLIB += xcb-randr xcb-render-util xcb-render xcb-shape xcb-sync
-WANTLIB += xcb-xfixes xcb-xinerama xcb
+WANTLIB += xcb-xfixes xcb-util xcb
 
 MODULES =		devel/meson
 
@@ -29,7 +26,7 @@ RUN_DEPENDS =		x11/gtk+4,-guic \
 
 LIB_DEPENDS =		devel/libconfig \
 			devel/libev \
-			devel/pcre \
+			devel/pcre2 \
 			x11/dbus
 
 CONFIGURE_ARGS	+=	-Dwith_docs=true \
@@ -50,3 +47,4 @@ post-install:
 		${PREFIX}/share/examples/picom
 
 .include 
+# DO NOT DELETE
Index: distinfo
===
RCS file: /cvs/ports/x11/picom/distinfo,v
retrieving revision 1.7
diff -u -p -r1.7 distinfo
--- distinfo	24 Dec 2022 16:35:26 -	1.7
+++ distinfo	14 Feb 2024 19:41:40 -
@@ -1,2 +1,2 @@
-SHA256 (picom-10.2.tar.gz) = l0FXffATbYor5IAFyiuT7cFZE1KOGbzreYU1ykaDNBw=
-SIZE (picom-10.2.tar.gz) = 287166
+SHA256 (yshui-picom-v11.2.tar.gz) = HBBjk2+vCe2bunJudzelYlZLel+M3vedSPza82aaTfQ=
+SIZE (yshui-picom-v11.2.tar.gz) = 308679

Re: NEW: audio/deadbeef-plugin-mpris2

[Jose Maldonado]

El Wed, 14 Feb 2024 19:27:11 +0100
Omar Polo  escribió:
> On 2024/02/13 11:48:26 -0600, izder456  wrote:
> > Hey ports@,
> > 
> > I want to import the mpris2 plugin for the DeaDBeeF music player.
> > 
> > This allows mpris2 support in the music player, so ports like
> > multimedia/playerctl can interface with and operate DeaDBeeF.
> > 
> > A couple questions:
> > 
> > 1. I put this in CATEGORY = audio, I'm unsure if this was the
> > correct location for a plugin like this. Is there a better
> > (possibly more suitable CATEGORY for this port?)
> 
> I think audio is fine.
> 
> > 2. portcheck returns 
> >```
> >the following libraries in WANTLIB look like masked by
> > RUN_DEPENDS: gio-2.0 glib-2.0 gmodule-2.0 gobject-2.0 gthread-2.0
> > iconv intl ffi audio/deadbeef-plugin-mpris2
> >```
> >is this normal? I don't exactly know what this means or what I
> > should do to suppress it if its not OK..
> 
> it's an edge case.  TL;DR, remove deadbeef from RUN_DEPENDS, re-run
> make port-lib-depends-check, fix LIB_DEPENDS, re-add deadbeef to
> RUN_DEPENDS.
> 
> longer explanation: the port links to glib (plus a lot of other
> dependencies) and it's not listed in LIB_DEPENDS.  Yet, it's reachable
> at runtime via audio/deadbeef, so portchecks detects that you're
> missing something in LIB_DEPENDS.  The idea of "masked ldeps" means a
> LIB_DEPENDS that's not actually listed as LIB_DEPENDS.
> 
> then, some comments about the port.
> 
>  - the identation is a bit inconsistent.  make sure your editor is
>configured with tabs 8 columns wide (that's emacs default, but
> YMMV)
> 
>  - HOMEPAGE is set by DIST_TUPLE = github
> 
>  - add a missing build depends on audio/deadbeef
> 
>  - listing a library as BUILD_DEPENDS is 99.99% of the times wrong.
>libffi is a LIB_DEPENDS.
> 
>  - (matter of personal style) tidy CONFIGURE_ENV by defining some
> local variables
> 
>  - CONFIGURE_ARGS is not needed, and even if it were it would be
> --prefix ${PREFIX} or ${TRUEPREFIX}, not ${LOCALBASE}.  {TRUE,}PREFIX
> is for this very port, LOCALBASE is where other ports are installed.
>In practice the difference doesn't matter, but use the right
> variable nevertheless.
> 
>  - bump AUTOCONF_VERSION to 2.71: there are a couple of warnings about
>deprecated macros, but otherwise works.  2.69 is a bit ancient.
> 
>  - why removing the *la files?
> 
> I'm attaching an updated ports and a diff against your makefile.  The
> port looks fine to me now, but as I don't use deadbeef I haven't gone
> further than `make package'.
> 
> 
> --- Makefile.orig Wed Feb 14 18:49:28 2024
> +++ Makefile  Wed Feb 14 19:15:33 2024
> @@ -1,13 +1,11 @@
>  COMMENT =deadbeef plugin for mpris2 support
>  
> -V =  1.16
> +V =  1.16
>  DIST_TUPLE +=github DeaDBeeF-Player deadbeef-mpris2-plugin
> v${V} . PKGNAME = deadbeef-plugin-mpris2-${V}
>  
>  CATEGORIES = audio
>  
> -HOMEPAGE =
> https://github.com/DeaDBeeF-Player/deadbeef-mpris2-plugin -
>  MAINTAINER = izzy Meyer 
>  
>  # GPL v2 only
> @@ -16,30 +14,25 @@
>  WANTLIB +=   gio-2.0 glib-2.0 gmodule-2.0 gobject-2.0
> gthread-2.0 WANTLIB +=pthread iconv intl pcre2-8 z ffi
>  
> -COMPILER =   base-clang ports-gcc
> -
> -
> -LIB_DEPENDS =devel/pcre2
> -BUILD_DEPENDS =  devel/libtool \
> - devel/libffi \
> - devel/pcre2
> +LIB_DEPENDS =devel/glib2 \
> + devel/libffi \
> + devel/pcre2
> +BUILD_DEPENDS =  audio/deadbeef \
> + devel/libtool
>  RUN_DEPENDS =audio/deadbeef
>  
>  CONFIGURE_STYLE =autoreconf
>  
> -CONFIGURE_ENV += CPPFLAGS='-I${LOCALBASE}/include \
> - -I${X11BASE}/include' \
> - LDFLAGS='-L${LOCALBASE}/lib
> -L${X11BASE}/lib' \ +CPPFLAGS +=  -I${LOCALBASE}/include \
> + -I${X11BASE}/include
> +LDFLAGS +=   -L${LOCALBASE}/lib \
> + -L${X11BASE}/lib
> +CONFIGURE_ENV += CPPFLAGS='${CPPFLAGS}' \
> + LDFLAGS='${LDFLAGS}'
>  
> -CONFIGURE_ARGS = --prefix ${LOCALBASE} \
> - --disable-static
> -
>  LIBTOOL_FLAGS =  --tag=disable-static
>  
> -AUTOCONF_VERSION =   2.69
> +AUTOCONF_VERSION =   2.71
>  AUTOMAKE_VERSION =   1.16
> -
> -post-install:
> - @rm ${PREFIX}/lib/deadbeef/*.la
>  
>  .include 
> 
> 

Good observations @Omar, I have learned a lot from that! 

I have built the port and installed it with your changes, everything
works correctly.


-- 
*
Dios en su cielo, todo bien en la Tierra

Re: NEW: audio/deadbeef-plugin-mpris2

[Jose Maldonado]

El Wed, 14 Feb 2024 00:04:41 -0600
izder456  escribió:
> On Tue, 13 Feb 2024 19:21:20 -0400
> 
> I know that `make port-lib-depends-check` returns OK, I asked about
> portcheck (located at  /usr/ports/infrastructure/bin/portcheck).
> 
> It is good it works for you, but could you check via port check too? I
> dunno about what this error/warning means specifically, since things
> seem to be functional. That was more about what I was asking to be
> clarified there.
> 
> Thanks,
> 

Hello!

You are correct, trying with portcheck I have seen the error, the
required change is to add devel/glib2 in LIB_DEPENDS. I am attaching
the changes for this port.



-- 
*
Dios en su cielo, todo bien en la Tierra


deadbeef-plugin-mpris2.tar.gz
Description: application/gzip

Re: [UPDATE] multimedia/mpv - bump version v0.37.0

[Jose Maldonado]

El Mon, 12 Feb 2024 15:03:03 -0400
Jose Maldonado  escribió:
> El Mon, 12 Feb 2024 14:14:02 -0400
> Jose Maldonado  escribió:
> > Hello everyone!
> > 
> > This is an update for mpv. With the arrival of libplacebo
> > (>=v6.338.0) we can compile mpv-0.37.0 without problems. The new
> > dependencies for libplacebo and the update corresponding to this
> > port have already been sent.
> > 
> > This time I have enabled support for Vulkan in mpv. This should have
> > no problem with normal use of mpv, as it defaults to GPU and OpenGL,
> > even when Vulkan support is enabled. This makes Vulkan a backend
> > that must be activated explicitly (using --gpu-api=vulkan).
> > 
> > Compiled and tested in --current (OpenBSD 7.4 GENERIC.MP#1671 amd64)
> > without problems including the use of GLSL shaders (both using
> > OpenGL and Vulkan).
> > 
> > 
> 
> Sorry, I forget add a new patch for this version, resend the diff with
> the corrections. 
> 
> 

Hi! New revision of diff for new mpv version (0.37.0) 

portcheck ok
build and test ok


-- 
*
Dios en su cielo, todo bien en la Tierra


mpv-0_37_0
Description: Binary data

Re: [UPDATE] graphics/libplacebo - v6.338.2

[Jose Maldonado]

El Tue, 13 Feb 2024 17:58:36 -0500
Thomas Frohwein  escribió:
> On Mon, Feb 12, 2024 at 01:51:30PM -0400, Jose Maldonado wrote:
> > 
> > Hello everyone!
> > 
> > This is an update for libplacebo. Our port version (v4.208.0) is
> > already two years old and we already have to make a small bump due
> > to the arrival of a new mpv (v0.37.0).
> > 
> > This new version of libplacebo requires a series of additional
> > dependencies that I have submitted as new ports to the list:
> > devel/fast-float and graphics/glad.
> > 
> > With this new version and its dependencies we can activate support
> > for Vulkan and OpenGL in the library, aiming to take advantage of
> > these capabilities.
> > 
> > In the future, when we have Mesa-23.2.1 and ffmpeg-6.1 on OpenBSD,
> > perhaps we can take advantage of the ability of ffmpeg, mpv, and
> > libplacebo to obtain hwaccel through Vulkan (for h264, h265 and AV1,
> > without needing go through VAAPI). For now, the latter is in the
> > future, it will depend on our versions of Mesa and ffmpeg, along
> > with the appropriate support.
> 
> Thanks for the diff, a few comments below inline and then an updated
> diff from me attached. Please remember to CC maintainer as they may
> not always be subscribed to ports@.
> 
> Also important to know if ports that depend on the library have been
> tested with the new version, and if any of them might need an update
> with the API changes. I can find only mpv and vlc when looking at
> WANTLIBs in sqlports, and I rebuilt mpv and it still works FWIW.
> 
> There was trailing whitespace - it's generally recommended to run
> portcheck(1) (in /usr/ports/infrastructure/bin/) which will catch that
> (among other things).
> 
> [...]
> 
> >  MAINTAINER=Brad Smith 
> 
> [...]
> 
> > -WANTLIB=   epoxy execinfo lcms2 m pthread
> > +WANTLIB+=  ${COMPILER_LIBCXX} epoxy execinfo GL lcms2 m
> > pthread +WANTLIB+=  shaderc_shared vulkan 
> 
> $ make port-lib-depends-check
> 
> libplacebo-6.338.2(graphics/libplacebo):
> Extra:  GL.19 epoxy.4
> 
> I assume these 2 libraries are dlopen'd? In that case it would be
> preferable to add a comment about this above the WANTLIB block.
> 
> >  MODULES=   devel/meson
> >  
> > -LIB_DEPENDS=   graphics/lcms2
> > +BUILD_DEPENDS= devel/fast-float \
> > +   graphics/glad \
> > +   graphics/shaderc \
> 
> A LIB_DEPENDS is automatically also a BUILD_DEPENDS, so no need to
> list shaderc here. (see bsd.port.mk(5))
> 
> > +   graphics/vulkan-headers \
> 
> I would avoid dangling '\' at the end.
> 
> > +LIB_DEPENDS=   graphics/lcms2 \
> > +   graphics/shaderc
> > +
> > +RUN_DEPENDS=   graphics/vulkan-loader
> 
> ===>  Verifying specs: [...] Missing library for vulkan>=0.0
> 
> vulkan-loader needs to be LIB_DEPENDS given the WANTLIB entry.
> 
> 

Hi Thomas!

Following your recommendations I send you the revised diff for
libplacebo. I have put it through portcheck and without problems.

I've also followed your recommendations for the new mpv, so I'll post
the new diff in that thread.



-- 
*
Dios en su cielo, todo bien en la Tierra


libplacebo_6_338_2
Description: Binary data

[UPDATE] x11/vlc - revision for libplacebo support

[Jose Maldonado]

Hello everyone!

Here is a small update revision for x11/vlc.

In this case the revision is intended to enable the construction of
x11/vlc without libplacebo support, since VLC3 does not support
(and it seems that it will not support) libplacebo(>=6).

Building VLC with libplacebo support simply doesn't work with this new
libplacebo library. However, we need libplacebo(>=6) to be able to
update mpv (0.37.0).

In VLC upstream, the only solution they give to this problem at the
moment is to wait for the future release of VLC4 (without a defined
release date).

To solve this, I propose to compile x11/vlc without libplacebo support,
and replace its functionality with graphics/lcms2. So, we can compile a
working x11/vlc, update when necessary and build the new versions of
libplacebo and mpv.

I also take the opportunity to add libraries that "make
port-lib-depends-check" has indicated are missing (wayland stuff).

I attach the diff for the changes in x11/vlc and link [1] to upstream
VLC discussion. 



[1] https://code.videolan.org/videolan/vlc/-/merge_requests/3950


-- 
*
Dios en su cielo, todo bien en la Tierra
Index: Makefile
===
RCS file: /cvs/ports/x11/vlc/Makefile,v
retrieving revision 1.268
diff -u -p -r1.268 Makefile
--- Makefile	2 Feb 2024 20:09:08 -	1.268
+++ Makefile	14 Feb 2024 01:30:31 -
@@ -5,7 +5,7 @@ V=		3.0.18
 DISTNAME=	vlc-${V}
 PKGNAME-main=	${DISTNAME}
 PKGNAME-jack=	vlc-jack-${V}
-REVISION-main=	5
+REVISION-main=  6
 CATEGORIES=	x11
 SITES=		https://download.videolan.org/pub/videolan/vlc/${V}/
 EXTRACT_SUFX=	.tar.xz
@@ -53,20 +53,20 @@ WANTLIB-main += absl_throw_delegate absl
 WANTLIB-main += ass atk-1.0 atk-bridge-2.0 atspi avahi-client avahi-common
 WANTLIB-main += avcodec avformat avutil b2 bluray brotlidec brotlienc
 WANTLIB-main += bz2 c cairo cairo-gobject cddb crypto dav1d double-conversion
-WANTLIB-main += drm dvbpsi dvdnav dvdread ebml epoxy execinfo expat
+WANTLIB-main += drm dvbpsi dvdnav dvdread ebml epoll-shim epoxy execinfo expat
 WANTLIB-main += ffi fontconfig freetype fribidi gbm gcrypt gdk-3 gdk_pixbuf-2.0
 WANTLIB-main += gio-2.0 glapi glib-2.0 gmodule-2.0 gmp gnutls gobject-2.0
 WANTLIB-main += gpg-error graphite2 gsm gthread-2.0 gtk-3 harfbuzz
 WANTLIB-main += hogweed icudata icui18n icuuc idn2 jpeg lcms2 lz4 lzma
 WANTLIB-main += matroska mp3lame nettle nfs notify ogg opus p11-kit
 WANTLIB-main += pango-1.0 pangocairo-1.0 pangoft2-1.0 pcre2-16 pcre2-8
-WANTLIB-main += pixman-1 placebo png postproc protobuf-lite rsvg-2
+WANTLIB-main += pixman-1 png postproc protobuf-lite rsvg-2
 WANTLIB-main += sharpyuv smb2 sndio soxr speex speexdsp ssl swresample
 WANTLIB-main += swscale tag tar tasn1 theoradec theoraenc tiff udfread
 WANTLIB-main += unibreak unistring usbhid utf8_range utf8_validity
-WANTLIB-main += vorbis vorbisenc vpx webp x264 x265 xcb xcb-composite
-WANTLIB-main += xcb-dri2 xcb-dri3 xcb-glx xcb-keysyms xcb-present xcb-randr
-WANTLIB-main += xcb-render xcb-shm xcb-sync xcb-xfixes xcb-xv xml2
+WANTLIB-main += vorbis vorbisenc vpx wayland-client wayland-cursor wayland-egl 
+WANTLIB-main += webp x264 x265 xcb xcb-composite xcb-dri2 xcb-dri3 xcb-glx xcb-keysyms
+WANTLIB-main += xcb-present xcb-randr xcb-render xcb-shm xcb-sync xcb-xfixes xcb-xv xkbcommon xml2
 WANTLIB-main += xshmfence xvidcore z zstd ${WANTLIB-common} ${MODLUA_WANTLIB}
 # v4l2 is dlopen'd
 WANTLIB-main+=	v4l2
@@ -113,8 +113,8 @@ LIB_DEPENDS-main= ${MODQT5_LIB_DEPENDS} 
 		devel/sdl \
 		devel/sdl-image \
 		graphics/ffmpeg \
+		graphics/lcms2 \
 		graphics/libdvbpsi \
-		graphics/libplacebo \
 		graphics/png \
 		multimedia/libass \
 		multimedia/libbluray \
@@ -173,6 +173,7 @@ CONFIGURE_ARGS+=--disable-a52 \
 		--disable-kate \
 		--disable-kwallet \
 		--disable-libmpeg2 \
+		--disable-libplacebo \
 		--disable-libva \
 		--disable-linsys \
 		--disable-live555 \
Index: pkg/PLIST-main
===
RCS file: /cvs/ports/x11/vlc/pkg/PLIST-main,v
retrieving revision 1.52
diff -u -p -r1.52 PLIST-main
--- pkg/PLIST-main	14 May 2023 09:20:41 -	1.52
+++ pkg/PLIST-main	14 Feb 2024 01:30:31 -
@@ -1,6 +1,5 @@
 @pkgpath x11/vlc
 %%amd64%%
-%%i386%%
 bin/cvlc
 bin/qvlc
 bin/rvlc
@@ -444,6 +443,7 @@ lib/vlc/plugins/video_chroma/
 @so lib/vlc/plugins/video_chroma/libi420_yuy2_plugin.so
 @so lib/vlc/plugins/video_chroma/libi422_i420_plugin.so
 @so lib/vlc/plugins/video_chroma/libi422_yuy2_plugin.so
+%%i386%%
 @so lib/vlc/plugins/video_chroma/librv32_plugin.so
 @so lib/vlc/plugins/video_chroma/libswscale_plugin.so
 @so lib/vlc/plugins/video_chroma/libyuvp_plugin.so

Re: [UPDATE] graphics/libplacebo - v6.338.2

[Jose Maldonado]

El Tue, 13 Feb 2024 17:58:36 -0500
Thomas Frohwein  escribió:
> 
> Also important to know if ports that depend on the library have been
> tested with the new version, and if any of them might need an update
> with the API changes. I can find only mpv and vlc when looking at
> WANTLIBs in sqlports, and I rebuilt mpv and it still works FWIW.
> 

Ok, about libplacebo and VLC. Bad news, if we set libplacebo(>=6), VLC
will simply fail to compile. This issue is known in VLC upstream.

Upstream solution? Wait for VLC4 to come out, which still has no
release date. This is because making the necessary changes for VLC3 to
work with libplacebo(>=6) is very complex for them [1]

However, VLC can be compiled without libplacebo support, and instead
aim to use graphics/lcms2, as a result you get a fully functional VLC
from ports without the need for major changes.

Given this I consider that compiling VLC without libplacebo support is a
better functional solution. First, because VLC without libplacebo is
fully functional, and second, because we can continue updating VLC (in
the ports that we have 3.0.18 and are going for 3.0.20) without
hindering libplacebo and mpv updates. In the end, both software remain
in ports with their respective functionalities for whoever needs them.

I've already tested the changes for VLC and built it, I'll pass the
message with the diff in a moment.

[1]
https://code.videolan.org/videolan/vlc/-/merge_requests/3950/diffs?commit_id=9134e2079b5a14ce852ceaf84515c8e4ae35580f


-- 
*
Dios en su cielo, todo bien en la Tierra

Re: [UPDATE] graphics/libplacebo - v6.338.2

[Jose Maldonado]

El Tue, 13 Feb 2024 17:58:36 -0500
Thomas Frohwein  escribió:
> 
> Thanks for the diff, a few comments below inline and then an updated
> diff from me attached. Please remember to CC maintainer as they may
> not always be subscribed to ports@.
> 

Ok, I'll keep that in mind next time.

> Also important to know if ports that depend on the library have been
> tested with the new version, and if any of them might need an update
> with the API changes. I can find only mpv and vlc when looking at
> WANTLIBs in sqlports, and I rebuilt mpv and it still works FWIW.
> 

In this case I have tried both approaches:

1.- With mpv-0.36.0 (current version in ports) using the new libplacebo
(v6.338.2). In this case I tried with the current compilation options
(only OpenGL support, no Vulkan support) and with Vulkan activated.
Everything works fine, when playing locally, via stream (both using
OpenGL, with Vulkan and even with the use of GLSL sharders).

2.- With mpv-0.37.0 (new version) the new libplacebo (v6.338.2) it is
indeed a hard dependency. In this second case, I did the same tests as
the previous case, with OpenGL, Vulkan and GLSL shaders tests.

I haven't tried VLC, but I'll give it a look since there is a recent
bug that is related to libplacebo and VLC. I'll give you a preview as I
can test this.

> There was trailing whitespace - it's generally recommended to run
> portcheck(1) (in /usr/ports/infrastructure/bin/) which will catch that
> (among other things).
> 
> [...]
> 
> >  MAINTAINER=Brad Smith 
> 
> [...]
> 
> > -WANTLIB=   epoxy execinfo lcms2 m pthread
> > +WANTLIB+=  ${COMPILER_LIBCXX} epoxy execinfo GL lcms2 m
> > pthread +WANTLIB+=  shaderc_shared vulkan 
> 
> $ make port-lib-depends-check
> 
> libplacebo-6.338.2(graphics/libplacebo):
> Extra:  GL.19 epoxy.4
> 
> I assume these 2 libraries are dlopen'd? In that case it would be
> preferable to add a comment about this above the WANTLIB block.
> 
> >  MODULES=   devel/meson
> >  
> > -LIB_DEPENDS=   graphics/lcms2
> > +BUILD_DEPENDS= devel/fast-float \
> > +   graphics/glad \
> > +   graphics/shaderc \
> 
> A LIB_DEPENDS is automatically also a BUILD_DEPENDS, so no need to
> list shaderc here. (see bsd.port.mk(5))
> 
> > +   graphics/vulkan-headers \
> 
> I would avoid dangling '\' at the end.
> 
> > +LIB_DEPENDS=   graphics/lcms2 \
> > +   graphics/shaderc
> > +
> > +RUN_DEPENDS=   graphics/vulkan-loader
> 
> ===>  Verifying specs: [...] Missing library for vulkan>=0.0
> 
> vulkan-loader needs to be LIB_DEPENDS given the WANTLIB entry.
> 
> [...]
> > +   
> >  
> >  COMPILER=  base-clang ports-gcc
> >  COMPILER_LANGS=c
> >  
> > +CFLAGS +=  -I${X11BASE}/include
> > +LDFLAGS += -L${X11BASE}/lib
> > +
> > +MODMESON_CONFIGURE_ENV +=  LDFLAGS="${LDFLAGS}"
> > +
> >  CONFIGURE_ARGS+=-Ddefault_library=both \
> > -Dd3d11=disabled \
> > -Ddemos=false \
> > +   -Ddovi=disabled \
> > -Dglslang=disabled \
> > -   -Dshaderc=disabled \
> > +   -Dlibdovi=disabled \
> > +   -Dshaderc=enabled \
> > +   -Dopengl=enabled \
> > -Dunwind=disabled \
> > -   -Dvulkan=disabled
> > +   -Dvulkan=enabled \
> > +   -Dxxhash=disabled
> >  
> >  NO_TEST=   Yes
> >  
> > Index: distinfo
> > ===
> > RCS file: /cvs/ports/graphics/libplacebo/distinfo,v
> > retrieving revision 1.9
> > diff -u -p -r1.9 distinfo
> > --- distinfo23 Jul 2022 05:16:05 -  1.9
> > +++ distinfo12 Feb 2024 17:49:43 -
> > @@ -1,2 +1,2 @@
> > -SHA256 (libplacebo-4.208.0.tar.gz) =
> > UJD7rU9luclQAoweDdhtIKpm0VnAhUqJs+uNQhCWa3M= -SIZE
> > (libplacebo-4.208.0.tar.gz) = 647068 +SHA256
> > (libplacebo-6.338.2.tar.gz) =
> > Lx5iTgnXKoydtw+RD3Vg52ShwSba5CrMWzvO+DanrsY= +SIZE
> > (libplacebo-6.338.2.tar.gz) = 841168 Index: pkg/PLIST
> > ===
> > RCS file: /cvs/ports/graphics/libplacebo/pkg/PLIST,v retrieving
> > revision 1.8 diff -u -p -r1.8 PLIST
> > --- pkg/PLIST   11 Mar 2022 19:22:45 -  1.8
> > +++ pkg/PLIST   12 Feb 2024 17:49:43 -
> > @@ -1,20 +1,25 @@
> >  include/libplacebo/
> > +include/libplacebo/cache.h
> >  include/libplacebo/colorspace.h
> >  include/libplacebo/common.h
> >  include/libplacebo/config.h
> > -include/libplacebo/context.h
> > +include/libplacebo/d3d11.h
> >  include/libplacebo/dispatch.h
> >  include/libplacebo/dither.h
> >  include/libplacebo/dummy.h
> >  include/libplacebo/filters.h
> > +include/libplacebo/gamut_mapping.h
> >  include/libplacebo/gpu.h
> >  include/libplacebo/log.h
> >  include/libplacebo/opengl.h
> > +include/libplacebo/options.h
> >  include/libplacebo/renderer.h
> >  include/libplacebo/shaders/
> >  include/libplacebo/shaders.h
> >  include/libplacebo/shaders/colorspace.h
> >  

Re: NEW: audio/deadbeef-plugin-mpris2

[Jose Maldonado]

El Tue, 13 Feb 2024 11:48:26 -0600
izder456  escribió:
> Hey ports@,
> 
> I want to import the mpris2 plugin for the DeaDBeeF music player.
> 
> This allows mpris2 support in the music player, so ports like
> multimedia/playerctl can interface with and operate DeaDBeeF.
> 
> A couple questions:
> 
> 1. I put this in CATEGORY = audio, I'm unsure if this was the correct
> location for a plugin like this. Is there a better (possibly more
> suitable CATEGORY for this port?)
> 2. portcheck returns 
>```
>the following libraries in WANTLIB look like masked by RUN_DEPENDS:
>gio-2.0 glib-2.0 gmodule-2.0 gobject-2.0 gthread-2.0 iconv intl ffi
>audio/deadbeef-plugin-mpris2
>```
>is this normal? I don't exactly know what this means or what I
> should do to suppress it if its not OK..
> 
> Any answers to the above questions would be appreciated.
> 
> Thanks
> 
> Port is attached
> 
> --
> izzy Meyer (they/them)
> 
> https://izder456.neocities.org/

Hi! 

I build the port, not problems all work ok. 

"make port-lib-depends-check" don´t show me nothing wrong with the
libs. 


-- 
*
Dios en su cielo, todo bien en la Tierra

Re: [NEW PORT] devel/fast-float - Fast and exact implementation of the C++ from_chars functions

[Jose Maldonado]

El Tue, 13 Feb 2024 14:55:10 -0500
Thomas Frohwein  escribió:
> On Tue, Feb 13, 2024 at 02:13:24PM -0400, Jose Maldonado wrote:
> 
> [...]
> 
> > > > *
> > > > Dios en su cielo, todo bien en la Tierra
> > > 
> > > 
> > 
> > Hi Thomas! 
> > 
> > I have no problems with taking care of the maintenance of the
> > package, as you say, it is not complex maintenance as it is a
> > simple header.
> > 
> > Also, as you can see from @sthen fixes and the ones you have given,
> > I am quite new to this and I have to learn a lot, but I think that
> > is a path that I am already walking.
> 
> Thanks, that's great! I imported it with sthen@'s changes and with you
> as maintainer.
> 

Thanks! 


> > In any case, if you consider that I can take this package, I would
> > like to add the graphics/glad one as well, as well as the other new
> > port that I have uploaded.
> 
> I added you as maintainer for glad. I haven't looked at the other port
> at all I think, but unless there is already a maintainer, I think it
> shouldn't be a problem to list you there, too.
> 
> > 
> > 
> > -- 
> > *
> > Dios en su cielo, todo bien en la Tierra

graphics/glad and devel/fast-float are news ports, dependencies
for a new libplacebo(v6.338.2) and for mpv (0.37.0). 

I have been testing the changes made and the new versions on both ports
(mpv and libplacebo) and everything works correctly in amd64.

If there is a problem (especially due to the Vulkan activation request)
it will be on a specific platform due to lack of support (or incomplete
support) for this feature.


-- 
*
Dios en su cielo, todo bien en la Tierra

Re: [NEW PORT] devel/fast-float - Fast and exact implementation of the C++ from_chars functions

[Jose Maldonado]

El Tue, 13 Feb 2024 19:14:18 +
Stuart Henderson  escribió:
> I'd prefer to skip NO_BUILD unless it fails without - if a newer
> version starts doing something in that stage and you have NO_BUILD
> set and don't notice it'll end up running build stages in "make fake"
> 

That is a good observation, for now keeping NO_BUILD = Yes or removing
it does not prevent the correct creation of the package.

If at some point the package changes, then you would have to adapt it
to the new needs to build it. In any case, if I stay with the
maintenance I have to see and review that at the time when it is time
to make the corresponding updates.


-- 
*
Dios en su cielo, todo bien en la Tierra

Re: [NEW PORT] devel/fast-float - Fast and exact implementation of the C++ from_chars functions

[Jose Maldonado]

El Tue, 13 Feb 2024 12:24:43 -0500
Thomas Frohwein  escribió:
> On Mon, Feb 12, 2024 at 01:37:23PM -0400, Jose Maldonado wrote:
> > 
> > Hello everyone! New port here.
> > 
> > In this case I bring you devel/fast-float, a series of C/C++ headers
> > that seeks to offer us numerical operations 4 to 10x times faster
> > than standard libraries (GCC and Clang).
> > 
> > These libraries in question are on GitHub [1] and are part of the
> > new dependencies for libplacebo (>=v6.338.0).
> > 
> > These libraries are necessary to compile the new version of
> > libplacebo and bump new version of mpv (v0.37.0)
> > 
> > [1] https://github.com/fastfloat/fast_float
> 
> Thanks, I made some tweaks and attached an updated tarball. The
> updated tarball is ok thfr@.
> 
> Jose, why not take maintainer for the port? It's a headers-only port
> without patches, likely not a big maintenance burden with future
> updates, and those will likely be needed for libplacebo etc.
> 
> Other comments on the port that I addressed in the updated tarball:
> 
> - chmod -x Makefile pkg/DESCR
> - lower-case COMMENT
> - reduce lines by omitting V= etc, see sthen@ comments on glad
> - HOMEPAGE is set by GH_*
> - CATEGORIES=devel seems ok to me, but if someone prefers another
>   location (maybe math/ ?) then lemme know
> - BUILD_DEPENDS misspelled and not needed with MODULES=devel/cmake
> - DESCR should probably be a bit more detailed than just the same as
>   COMMENT, if possible. I expanded it a bit more from the README.md.
> > 
> > 
> > -- 
> > *
> > Dios en su cielo, todo bien en la Tierra
> 
> 

Hi Thomas! 

I have no problems with taking care of the maintenance of the package,
as you say, it is not complex maintenance as it is a simple header.

Also, as you can see from @sthen fixes and the ones you have given, I
am quite new to this and I have to learn a lot, but I think that is a
path that I am already walking.

In any case, if you consider that I can take this package, I would like
to add the graphics/glad one as well, as well as the other new port
that I have uploaded.


-- 
*
Dios en su cielo, todo bien en la Tierra

Re: [NEW PORT] graphics/glad - Multi-Language Vulkan/GL/GLES/EGL/GLX/WGL Loader-Generator

[Jose Maldonado]

El Tue, 13 Feb 2024 11:21:24 -
beecdadd...@danwin1210.de escribió:
> there is Rust code on it's github, does it have Rust as a dependency?
> if it has Rust as dependency or cargo or whatever, I am deleting mpv
> and never using it again
> 
> can I block some dependencies or langs from building/installing? I
> want that if it doesn't exist, it wouldn't be hard to write a bit of
> code to search trough the list of dependencies and check with name,
> maybe if it doesn't exist the blacklist could be in
> /usr/ports/Makefile or something? I would like to know
> thanks and sorry if there is answer on internet, I tried looking many
> times for compiling ports and flags
> 
> On Mon, February 12, 2024 5:42 pm, Jose Maldonado wrote:
> >
> 
> > Hello everyone! Another new port here!
> >
> >
> > In this case I bring graphics/glad [1] a Multi-Language
> > Vulkan/GL/GLES/EGL/GLX/WGL Loader-Generator that is part of the new
> > dependencies to build libplacebo (>=v6.338.0) and therefore
> > necessary to build mpv (v0.37.0)
> >
> > Built and tested, take a look and feedback is welcome.
> >
> >
> > [1] https://github.com/Dav1dde/glad
> >
> >
> > --
> > *
> > Dios en su cielo, todo bien en la Tierra
> >
> >
> 
> 

Yes, graphics/glad has Rust code, but we don't need it to build it,
nor to build the new libplacebo or mpv. Rust code is only necessary in
the context of a project that uses Rust, and mpv/libplacebo is outside
of that.

So for now, we can rest assured that you don't need Rust to use this,
in fact, I don't even have Rust installed on my OS (and I hope I don't
need it).


-- 
*
Dios en su cielo, todo bien en la Tierra

Re: [NEW PORT] graphics/glad - Multi-Language Vulkan/GL/GLES/EGL/GLX/WGL Loader-Generator

[Jose Maldonado]

El Tue, 13 Feb 2024 11:39:38 +
Stuart Henderson  escribió:
> On 2024/02/12 13:42, Jose Maldonado wrote:
> > 
> > Hello everyone! Another new port here!
> > 
> > In this case I bring graphics/glad [1] a Multi-Language
> > Vulkan/GL/GLES/EGL/GLX/WGL Loader-Generator that is part of the new
> > dependencies to build libplacebo (>=v6.338.0) and therefore
> > necessary to build mpv (v0.37.0)
> > 
> > Built and tested, take a look and feedback is welcome.
> 
> Some tweaks on top, new tar attached is ok sthen
> 
> : -COMMENT =  Multi-Language Vulkan/GL/GLES/EGL/GLX/WGL
> Loader-Generator : +COMMENT = multi-language
> Vulkan/GL/GLES/EGL/GLX/WGL loader-generator
> 
> prefer lowercase in COMMENT except for proper nouns/abbreviations
> 
> : -V =2.0.5
> : -PKGNAME =  glad-${V}
> : -GH_TAGNAME =   v${V}
> : +GH_TAGNAME =   v2.0.5
> :  GH_ACCOUNT =   Dav1dde
> :  GH_PROJECT =   glad
> 
> extra lines not needed, default uses the project name followed b6
> tagname with ^v stripped
> 
> : -MODULES=   lang/python
> : +MODULES =  lang/python
> 
> consistent whitespace
> 
> : -MODPY_SETUPTOOLS=  Yes
> : +MODPY_PYBUILD =setuptools
> 
> use the PEP517 build infrastructure, don't use MODPY_SETUPTOOLS for
> new ports
> 
> : -RUN_DEPENDS =  www/py-jinja2 \
> : -   textproc/py-MarkupSafe
> : +RUN_DEPENDS =  www/py-jinja2${MODPY_FLAVOR} \
> : +   textproc/py-MarkupSafe${MODPY_FLAVOR}
> 
> missing flavour extension
> 
> :  post-install:
> : -   mv -f ${WRKDIST}/example ${PREFIX}/share/examples/glad
> : +   ${INSTALL_DATA_DIR} ${PREFIX}/share/examples/glad
> : +   cp -r ${WRKDIST}/example/* ${PREFIX}/share/examples/glad
> 
> it's better not to remove things from the WRKDIST
> 
> : -NO_BUILD = Yes
> 
> that's just wrong, there is a build stage
> 
> :  Vulkan/GL/GLES/EGL/GLX/WGL Loader-Generator based on the official
> :  specifications for multiple languages.
> : -
> : -Main website: https://glad.dav1d.de/
> : -
> : -Github: https://github.com/Dav1dde/glad
> 
> WWW is added automatically from HOMEPAGE.
> Not usually worth adding github links here (it's obvious from the
> Makefile anyway).
> 
> (+ regen pkg/PLIST)
> 


Hi! Changes tested, all look good, the mpv and libplacebo builds
without issues. 

Thanks @sthen

-- 
*
Dios en su cielo, todo bien en la Tierra

Re: [UPDATE] multimedia/mpv - bump version v0.37.0

[Jose Maldonado]

El Mon, 12 Feb 2024 14:14:02 -0400
Jose Maldonado  escribió:
> Hello everyone!
> 
> This is an update for mpv. With the arrival of libplacebo (>=v6.338.0)
> we can compile mpv-0.37.0 without problems. The new dependencies for
> libplacebo and the update corresponding to this port have already been
> sent.
> 
> This time I have enabled support for Vulkan in mpv. This should have
> no problem with normal use of mpv, as it defaults to GPU and OpenGL,
> even when Vulkan support is enabled. This makes Vulkan a backend that
> must be activated explicitly (using --gpu-api=vulkan).
> 
> Compiled and tested in --current (OpenBSD 7.4 GENERIC.MP#1671 amd64)
> without problems including the use of GLSL shaders (both using OpenGL
> and Vulkan).
> 
> 

Sorry, I forget add a new patch for this version, resend the diff with
the corrections. 


-- 
*
Dios en su cielo, todo bien en la Tierra
Index: Makefile
===
RCS file: /cvs/ports/multimedia/mpv/Makefile,v
retrieving revision 1.98
diff -u -p -r1.98 Makefile
--- Makefile	24 Jul 2023 12:40:20 -	1.98
+++ Makefile	12 Feb 2024 18:57:54 -
@@ -2,10 +2,10 @@ COMMENT =		movie player based on MPlayer
 
 GH_ACCOUNT =		mpv-player
 GH_PROJECT =		mpv
-GH_TAGNAME =		v0.36.0
+GH_TAGNAME =		v0.37.0
 USE_NOBTCFI =		Yes
 
-SHARED_LIBS +=		mpv		1.0 # 2.0
+SHARED_LIBS +=		mpv		2.0
 
 CATEGORIES =		multimedia x11
 
@@ -17,8 +17,8 @@ PERMIT_PACKAGE =	Yes
 WANTLIB += EGL SDL2 X11 Xext Xinerama Xpresent Xrandr Xss Xv archive
 WANTLIB += ass avcodec avdevice avfilter avformat avutil bluray
 WANTLIB += c cdio cdio_cdda cdio_paranoia dvdnav iconv jpeg lcms2
-WANTLIB += ${MODLUA_WANTLIB} m placebo pthread sndio swresample
-WANTLIB += swscale z zimg
+WANTLIB += ${MODLUA_WANTLIB} m placebo pthread sndio SPIRV-Tools-shared
+WANTLIB += swresample swscale vulkan z zimg 
 
 MODULES =		devel/meson \
 			lang/lua \
@@ -30,6 +30,7 @@ COMPILER_LANGS =	c
 DEBUG_PACKAGES =	${BUILD_PACKAGES}
 
 BUILD_DEPENDS =		audio/ladspa \
+			graphics/libplacebo \
 			textproc/py-docutils${MODPY_FLAVOR}
 
 LIB_DEPENDS =		archivers/libarchive \
@@ -41,6 +42,7 @@ LIB_DEPENDS =		archivers/libarchive \
 			graphics/jpeg \
 			graphics/lcms2 \
 			graphics/libplacebo \
+			graphics/spirv-tools \
 			graphics/zimg \
 			multimedia/libass \
 			multimedia/libbluray \
@@ -48,6 +50,7 @@ LIB_DEPENDS =		archivers/libarchive \
 
 MODPY_RUNDEP =		No
 RUN_DEPENDS =		devel/desktop-file-utils \
+			graphics/vulkan-loader \
 			www/yt-dlp \
 			x11/gtk+4,-guic
 
@@ -83,10 +86,6 @@ CONFIGURE_ARGS =	-Dlua=lua${MODLUA_DEP_V
 			-Dios-gl=disabled \
 			-Djack=disabled \
 			-Djavascript=disabled \
-			-Dlibplacebo-next=disabled \
-			-Dmacos-10-11-features=disabled \
-			-Dmacos-10-12-2-features=disabled \
-			-Dmacos-10-14-features=disabled \
 			-Dmacos-cocoa-cb=disabled \
 			-Dmacos-media-player=disabled \
 			-Dmacos-touchbar=disabled \
@@ -100,22 +99,23 @@ CONFIGURE_ARGS =	-Dlua=lua${MODLUA_DEP_V
 			-Dshaderc=disabled \
 			-Dsixel=disabled \
 			-Dswift-build=disabled \
+			-Dswift-flags=disabled \
 			-Dsdl2-audio=disabled \
 			-Dspirv-cross=disabled \
 			-Duchardet=disabled \
 			-Dvaapi=disabled \
 			-Dvaapi-drm=disabled \
-			-Dvaapi-x-egl=disabled \
 			-Dvaapi-x11=disabled \
 			-Dvaapi-wayland=disabled \
 			-Dvapoursynth=disabled \
 			-Dvdpau=disabled \
 			-Dvdpau-gl-x11=disabled \
 			-Dvideotoolbox-gl=disabled \
-			-Dvulkan=disabled \
+			-Dvideotoolbox-pl=disabled \
+			-Dvulkan=enabled \
 			-Dvulkan-interop=disabled \
 			-Dwayland=disabled \
-			-Dwin32-internal-pthreads=disabled \
+			-Dwin32-threads=disabled \
 			-Dwasapi=disabled
 
 CFLAGS +=		-I${LOCALBASE}/include
Index: distinfo
===
RCS file: /cvs/ports/multimedia/mpv/distinfo,v
retrieving revision 1.34
diff -u -p -r1.34 distinfo
--- distinfo	24 Jul 2023 12:40:20 -	1.34
+++ distinfo	12 Feb 2024 18:57:54 -
@@ -1,2 +1,2 @@
-SHA256 (mpv-0.36.0.tar.gz) = KavET46+4BO7L5/hTYCzDbGbU0xnkFbkhRzq31pei/Y=
-SIZE (mpv-0.36.0.tar.gz) = 3409178
+SHA256 (mpv-0.37.0.tar.gz) = HS1K268Eii+m7hNFdQMsSy2tmn76/Vs+abiNuTWvrd8=
+SIZE (mpv-0.37.0.tar.gz) = 3384190
Index: patches/patch-meson_build
===
RCS file: /cvs/ports/multimedia/mpv/patches/patch-meson_build,v
retrieving revision 1.6
diff -u -p -r1.6 patch-meson_build
--- patches/patch-meson_build	24 Jul 2023 12:40:20 -	1.6
+++ patches/patch-meson_build	12 Feb 2024 18:57:54 -
@@ -4,11 +4,11 @@ time if present at all, rather than only
 Index: meson.build
 --- meson.build.orig
 +++ meson.build
-@@ -720,7 +720,19 @@ if features['sdl2-gamepad']
- sources += files('input/sdl_gamepad.c')
+@@ -342,7 +342,19 @@ if features['libdl']
  endif
- 
--stdatomic_dep = cc.find_library('atomic', required: false)
+
+ 

[UPDATE] multimedia/mpv - bump version v0.37.0

[Jose Maldonado]

Hello everyone!

This is an update for mpv. With the arrival of libplacebo (>=v6.338.0)
we can compile mpv-0.37.0 without problems. The new dependencies for
libplacebo and the update corresponding to this port have already been
sent.

This time I have enabled support for Vulkan in mpv. This should have no
problem with normal use of mpv, as it defaults to GPU and OpenGL, even
when Vulkan support is enabled. This makes Vulkan a backend that must
be activated explicitly (using --gpu-api=vulkan).

Compiled and tested in --current (OpenBSD 7.4 GENERIC.MP#1671 amd64)
without problems including the use of GLSL shaders (both using OpenGL
and Vulkan).


-- 
*
Dios en su cielo, todo bien en la Tierra
? patches/patch-osdep_threads_posix_h
Index: Makefile
===
RCS file: /cvs/ports/multimedia/mpv/Makefile,v
retrieving revision 1.98
diff -u -p -r1.98 Makefile
--- Makefile	24 Jul 2023 12:40:20 -	1.98
+++ Makefile	12 Feb 2024 18:08:35 -
@@ -2,10 +2,10 @@ COMMENT =		movie player based on MPlayer
 
 GH_ACCOUNT =		mpv-player
 GH_PROJECT =		mpv
-GH_TAGNAME =		v0.36.0
+GH_TAGNAME =		v0.37.0
 USE_NOBTCFI =		Yes
 
-SHARED_LIBS +=		mpv		1.0 # 2.0
+SHARED_LIBS +=		mpv		2.0
 
 CATEGORIES =		multimedia x11
 
@@ -17,8 +17,8 @@ PERMIT_PACKAGE =	Yes
 WANTLIB += EGL SDL2 X11 Xext Xinerama Xpresent Xrandr Xss Xv archive
 WANTLIB += ass avcodec avdevice avfilter avformat avutil bluray
 WANTLIB += c cdio cdio_cdda cdio_paranoia dvdnav iconv jpeg lcms2
-WANTLIB += ${MODLUA_WANTLIB} m placebo pthread sndio swresample
-WANTLIB += swscale z zimg
+WANTLIB += ${MODLUA_WANTLIB} m placebo pthread sndio SPIRV-Tools-shared
+WANTLIB += swresample swscale vulkan z zimg 
 
 MODULES =		devel/meson \
 			lang/lua \
@@ -30,6 +30,7 @@ COMPILER_LANGS =	c
 DEBUG_PACKAGES =	${BUILD_PACKAGES}
 
 BUILD_DEPENDS =		audio/ladspa \
+			graphics/libplacebo \
 			textproc/py-docutils${MODPY_FLAVOR}
 
 LIB_DEPENDS =		archivers/libarchive \
@@ -41,6 +42,7 @@ LIB_DEPENDS =		archivers/libarchive \
 			graphics/jpeg \
 			graphics/lcms2 \
 			graphics/libplacebo \
+			graphics/spirv-tools \
 			graphics/zimg \
 			multimedia/libass \
 			multimedia/libbluray \
@@ -48,6 +50,7 @@ LIB_DEPENDS =		archivers/libarchive \
 
 MODPY_RUNDEP =		No
 RUN_DEPENDS =		devel/desktop-file-utils \
+			graphics/vulkan-loader \
 			www/yt-dlp \
 			x11/gtk+4,-guic
 
@@ -83,10 +86,6 @@ CONFIGURE_ARGS =	-Dlua=lua${MODLUA_DEP_V
 			-Dios-gl=disabled \
 			-Djack=disabled \
 			-Djavascript=disabled \
-			-Dlibplacebo-next=disabled \
-			-Dmacos-10-11-features=disabled \
-			-Dmacos-10-12-2-features=disabled \
-			-Dmacos-10-14-features=disabled \
 			-Dmacos-cocoa-cb=disabled \
 			-Dmacos-media-player=disabled \
 			-Dmacos-touchbar=disabled \
@@ -100,22 +99,23 @@ CONFIGURE_ARGS =	-Dlua=lua${MODLUA_DEP_V
 			-Dshaderc=disabled \
 			-Dsixel=disabled \
 			-Dswift-build=disabled \
+			-Dswift-flags=disabled \
 			-Dsdl2-audio=disabled \
 			-Dspirv-cross=disabled \
 			-Duchardet=disabled \
 			-Dvaapi=disabled \
 			-Dvaapi-drm=disabled \
-			-Dvaapi-x-egl=disabled \
 			-Dvaapi-x11=disabled \
 			-Dvaapi-wayland=disabled \
 			-Dvapoursynth=disabled \
 			-Dvdpau=disabled \
 			-Dvdpau-gl-x11=disabled \
 			-Dvideotoolbox-gl=disabled \
-			-Dvulkan=disabled \
+			-Dvideotoolbox-pl=disabled \
+			-Dvulkan=enabled \
 			-Dvulkan-interop=disabled \
 			-Dwayland=disabled \
-			-Dwin32-internal-pthreads=disabled \
+			-Dwin32-threads=disabled \
 			-Dwasapi=disabled
 
 CFLAGS +=		-I${LOCALBASE}/include
Index: distinfo
===
RCS file: /cvs/ports/multimedia/mpv/distinfo,v
retrieving revision 1.34
diff -u -p -r1.34 distinfo
--- distinfo	24 Jul 2023 12:40:20 -	1.34
+++ distinfo	12 Feb 2024 18:08:35 -
@@ -1,2 +1,2 @@
-SHA256 (mpv-0.36.0.tar.gz) = KavET46+4BO7L5/hTYCzDbGbU0xnkFbkhRzq31pei/Y=
-SIZE (mpv-0.36.0.tar.gz) = 3409178
+SHA256 (mpv-0.37.0.tar.gz) = HS1K268Eii+m7hNFdQMsSy2tmn76/Vs+abiNuTWvrd8=
+SIZE (mpv-0.37.0.tar.gz) = 3384190
Index: patches/patch-meson_build
===
RCS file: /cvs/ports/multimedia/mpv/patches/patch-meson_build,v
retrieving revision 1.6
diff -u -p -r1.6 patch-meson_build
--- patches/patch-meson_build	24 Jul 2023 12:40:20 -	1.6
+++ patches/patch-meson_build	12 Feb 2024 18:08:35 -
@@ -4,11 +4,11 @@ time if present at all, rather than only
 Index: meson.build
 --- meson.build.orig
 +++ meson.build
-@@ -720,7 +720,19 @@ if features['sdl2-gamepad']
- sources += files('input/sdl_gamepad.c')
+@@ -342,7 +342,19 @@ if features['libdl']
  endif
- 
--stdatomic_dep = cc.find_library('atomic', required: false)
+
+ # C11 atomics are mandatory but linking to the library is not always required.
+-dependencies += cc.find_library('atomic', required: false)
 +if cc.links('''
 +#include 
 +int main(void) {
@@ -22,6 +22,6 @@ Index: 

[UPDATE] graphics/libplacebo - v6.338.2

[Jose Maldonado]

Hello everyone!

This is an update for libplacebo. Our port version (v4.208.0) is
already two years old and we already have to make a small bump due to
the arrival of a new mpv (v0.37.0).

This new version of libplacebo requires a series of additional
dependencies that I have submitted as new ports to the list:
devel/fast-float and graphics/glad.

With this new version and its dependencies we can activate support for
Vulkan and OpenGL in the library, aiming to take advantage of these
capabilities.

In the future, when we have Mesa-23.2.1 and ffmpeg-6.1 on OpenBSD,
perhaps we can take advantage of the ability of ffmpeg, mpv, and
libplacebo to obtain hwaccel through Vulkan (for h264, h265 and AV1,
without needing go through VAAPI). For now, the latter is in the
future, it will depend on our versions of Mesa and ffmpeg, along with
the appropriate support.


-- 
*
Dios en su cielo, todo bien en la Tierra
Index: Makefile
===
RCS file: /cvs/ports/graphics/libplacebo/Makefile,v
retrieving revision 1.11
diff -u -p -r1.11 Makefile
--- Makefile	23 Jul 2022 05:16:05 -	1.11
+++ Makefile	12 Feb 2024 17:49:43 -
@@ -2,32 +2,51 @@ COMMENT=	reusable library for GPU-accele
 
 GH_ACCOUNT=	haasn
 GH_PROJECT=	libplacebo
-GH_TAGNAME=	v4.208.0
+GH_TAGNAME=	v6.338.2
 CATEGORIES=	graphics
 
-SHARED_LIBS=	placebo	7.0
+SHARED_LIBS=	placebo	8.0
 
 MAINTAINER=	Brad Smith 
 
 # LGPLv2.1+
 PERMIT_PACKAGE=	Yes
 
-WANTLIB=	epoxy execinfo lcms2 m pthread
+WANTLIB+=	${COMPILER_LIBCXX} epoxy execinfo GL lcms2 m pthread
+WANTLIB+=	shaderc_shared vulkan 
 
 MODULES=	devel/meson
 
-LIB_DEPENDS=	graphics/lcms2
+BUILD_DEPENDS=	devel/fast-float \
+		graphics/glad \
+		graphics/shaderc \
+		graphics/vulkan-headers \
+
+LIB_DEPENDS=	graphics/lcms2 \
+		graphics/shaderc
+
+RUN_DEPENDS=	graphics/vulkan-loader
+		
 
 COMPILER=	base-clang ports-gcc
 COMPILER_LANGS=	c
 
+CFLAGS +=		-I${X11BASE}/include
+LDFLAGS +=		-L${X11BASE}/lib
+
+MODMESON_CONFIGURE_ENV +=	LDFLAGS="${LDFLAGS}"
+
 CONFIGURE_ARGS+=-Ddefault_library=both \
 		-Dd3d11=disabled \
 		-Ddemos=false \
+		-Ddovi=disabled \
 		-Dglslang=disabled \
-		-Dshaderc=disabled \
+		-Dlibdovi=disabled \
+		-Dshaderc=enabled \
+		-Dopengl=enabled \
 		-Dunwind=disabled \
-		-Dvulkan=disabled
+		-Dvulkan=enabled \
+		-Dxxhash=disabled
 
 NO_TEST=	Yes
 
Index: distinfo
===
RCS file: /cvs/ports/graphics/libplacebo/distinfo,v
retrieving revision 1.9
diff -u -p -r1.9 distinfo
--- distinfo	23 Jul 2022 05:16:05 -	1.9
+++ distinfo	12 Feb 2024 17:49:43 -
@@ -1,2 +1,2 @@
-SHA256 (libplacebo-4.208.0.tar.gz) = UJD7rU9luclQAoweDdhtIKpm0VnAhUqJs+uNQhCWa3M=
-SIZE (libplacebo-4.208.0.tar.gz) = 647068
+SHA256 (libplacebo-6.338.2.tar.gz) = Lx5iTgnXKoydtw+RD3Vg52ShwSba5CrMWzvO+DanrsY=
+SIZE (libplacebo-6.338.2.tar.gz) = 841168
Index: pkg/PLIST
===
RCS file: /cvs/ports/graphics/libplacebo/pkg/PLIST,v
retrieving revision 1.8
diff -u -p -r1.8 PLIST
--- pkg/PLIST	11 Mar 2022 19:22:45 -	1.8
+++ pkg/PLIST	12 Feb 2024 17:49:43 -
@@ -1,20 +1,25 @@
 include/libplacebo/
+include/libplacebo/cache.h
 include/libplacebo/colorspace.h
 include/libplacebo/common.h
 include/libplacebo/config.h
-include/libplacebo/context.h
+include/libplacebo/d3d11.h
 include/libplacebo/dispatch.h
 include/libplacebo/dither.h
 include/libplacebo/dummy.h
 include/libplacebo/filters.h
+include/libplacebo/gamut_mapping.h
 include/libplacebo/gpu.h
 include/libplacebo/log.h
 include/libplacebo/opengl.h
+include/libplacebo/options.h
 include/libplacebo/renderer.h
 include/libplacebo/shaders/
 include/libplacebo/shaders.h
 include/libplacebo/shaders/colorspace.h
 include/libplacebo/shaders/custom.h
+include/libplacebo/shaders/deinterlacing.h
+include/libplacebo/shaders/dithering.h
 include/libplacebo/shaders/film_grain.h
 include/libplacebo/shaders/icc.h
 include/libplacebo/shaders/lut.h
@@ -24,10 +29,12 @@ include/libplacebo/tone_mapping.h
 include/libplacebo/utils/
 include/libplacebo/utils/dav1d.h
 include/libplacebo/utils/dav1d_internal.h
+include/libplacebo/utils/dolbyvision.h
 include/libplacebo/utils/frame_queue.h
 include/libplacebo/utils/libav.h
 include/libplacebo/utils/libav_internal.h
 include/libplacebo/utils/upload.h
+include/libplacebo/vulkan.h
 @static-lib lib/libplacebo.a
 @lib lib/libplacebo.so.${LIBplacebo_VERSION}
 lib/pkgconfig/libplacebo.pc

[NEW PORT] graphics/glad - Multi-Language Vulkan/GL/GLES/EGL/GLX/WGL Loader-Generator

[Jose Maldonado]

Hello everyone! Another new port here!

In this case I bring graphics/glad [1] a Multi-Language
Vulkan/GL/GLES/EGL/GLX/WGL Loader-Generator that is part of the new
dependencies to build libplacebo (>=v6.338.0) and therefore necessary
to build mpv (v0.37.0)

Built and tested, take a look and feedback is welcome.

[1] https://github.com/Dav1dde/glad

-- 
*
Dios en su cielo, todo bien en la Tierra


glad.tar.gz
Description: application/gzip

[NEW PORT] devel/fast-float - Fast and exact implementation of the C++ from_chars functions

[Jose Maldonado]

Hello everyone! New port here.

In this case I bring you devel/fast-float, a series of C/C++ headers
that seeks to offer us numerical operations 4 to 10x times faster than
standard libraries (GCC and Clang).

These libraries in question are on GitHub [1] and are part of the new
dependencies for libplacebo (>=v6.338.0).

These libraries are necessary to compile the new version of libplacebo
and bump new version of mpv (v0.37.0)

[1] https://github.com/fastfloat/fast_float


-- 
*
Dios en su cielo, todo bien en la Tierra


fast-float.tar.gz
Description: application/gzip

[UPDATE] New version for x11/picom v11.1

[Jose Maldonado]

Hello everyone!

In picom upstream, they have accepted certain PRs that I made in order
to compile picom v11 on OpenBSD. All of this is being carried out in
the next and libepoxy branches.

This update has a small backport of the patches (maintaining
consistency with upstream code) and applies them to compile picom-v11.1.
Tested on my machine without problems (amdgpu, RX580, OpenGL backend).

Feedback is welcome.

Index: Makefile
===
RCS file: /cvs/ports/x11/picom/Makefile,v
retrieving revision 1.11
diff -u -p -r1.11 Makefile
--- Makefile	24 Apr 2023 11:42:49 -	1.11
+++ Makefile	10 Feb 2024 22:54:54 -
@@ -1,19 +1,16 @@
 COMMENT =	lightweight compositor for X11
 
-GH_ACCOUNT =	yshui
-GH_PROJECT =	picom
-GH_TAGNAME =	v10.2
-REVISION =	0
+DIST_TUPLE =   github yshui picom v11.1 .
 
 CATEGORIES =	x11
 
 # MPL 2.0
 PERMIT_PACKAGE =	Yes
 
-WANTLIB += EGL GL X11 X11-xcb c config dbus-1 ev m pcre pixman-1
-WANTLIB += xcb-composite xcb-damage xcb-glx xcb-image xcb-present
+WANTLIB += EGL GL X11 X11-xcb c config dbus-1 ev m pcre2-8 pixman-1
+WANTLIB += pthread xcb-composite xcb-damage xcb-glx xcb-image xcb-present
 WANTLIB += xcb-randr xcb-render-util xcb-render xcb-shape xcb-sync
-WANTLIB += xcb-xfixes xcb-xinerama xcb
+WANTLIB += xcb-xfixes xcb-util xcb epoxy
 
 MODULES =		devel/meson
 
@@ -29,7 +26,7 @@ RUN_DEPENDS =		x11/gtk+4,-guic \
 
 LIB_DEPENDS =		devel/libconfig \
 			devel/libev \
-			devel/pcre \
+			devel/pcre2 \
 			x11/dbus
 
 CONFIGURE_ARGS	+=	-Dwith_docs=true \
@@ -50,3 +47,4 @@ post-install:
 		${PREFIX}/share/examples/picom
 
 .include 
+# DO NOT DELETE
Index: distinfo
===
RCS file: /cvs/ports/x11/picom/distinfo,v
retrieving revision 1.7
diff -u -p -r1.7 distinfo
--- distinfo	24 Dec 2022 16:35:26 -	1.7
+++ distinfo	10 Feb 2024 22:54:54 -
@@ -1,2 +1,2 @@
-SHA256 (picom-10.2.tar.gz) = l0FXffATbYor5IAFyiuT7cFZE1KOGbzreYU1ykaDNBw=
-SIZE (picom-10.2.tar.gz) = 287166
+SHA256 (yshui-picom-v11.1.tar.gz) = lvKjOpMGSnS1V5QtAwCirHeshT9Q77v2RmhJ/MdULsg=
+SIZE (yshui-picom-v11.1.tar.gz) = 308617
Index: patches/patch-src_backend_gl_gl_common_c
===
RCS file: patches/patch-src_backend_gl_gl_common_c
diff -N patches/patch-src_backend_gl_gl_common_c
--- /dev/null	1 Jan 1970 00:00:00 -
+++ patches/patch-src_backend_gl_gl_common_c	10 Feb 2024 22:54:54 -
@@ -0,0 +1,13 @@
+Index: src/backend/gl/gl_common.c
+--- src/backend/gl/gl_common.c.orig
 src/backend/gl/gl_common.c
+@@ -1,7 +1,7 @@
+ // SPDX-License-Identifier: MPL-2.0
+ // Copyright (c) Yuxuan Shui 
+-#include 
+-#include 
++#include 
++#include 
+ #include 
+ #include 
+ #include  
Index: patches/patch-src_meson_build
===
RCS file: patches/patch-src_meson_build
diff -N patches/patch-src_meson_build
--- /dev/null	1 Jan 1970 00:00:00 -
+++ patches/patch-src_meson_build	10 Feb 2024 22:54:54 -
@@ -0,0 +1,12 @@
+Index: src/meson.build
+--- src/meson.build.orig
 src/meson.build
+@@ -23,7 +23,7 @@ required_xcb_packages = [
+ # Some XCB packages are here because their versioning differs (see check below).
+ required_packages = [
+ 	'pixman-1', 'x11', 'x11-xcb', 'xcb-image', 'xcb-renderutil', 'xcb-util',
+-	'xext'
++	'xext', 'epoxy'
+ ]
+ 
+ foreach i : required_packages
Index: patches/patch-src_picom_c
===
RCS file: patches/patch-src_picom_c
diff -N patches/patch-src_picom_c
--- /dev/null	1 Jan 1970 00:00:00 -
+++ patches/patch-src_picom_c	10 Feb 2024 22:54:54 -
@@ -0,0 +1,41 @@
+Index: src/picom.c
+--- src/picom.c.orig
 src/picom.c
+@@ -17,6 +17,7 @@
+ #include 
+ #include 
+ #include 
++#include 
+ #include 
+ #include 
+ #include 
+@@ -2557,19 +2558,24 @@ void set_rr_scheduling(void) {
+ 
+ 	int ret;
+ 	struct sched_param param;
+-
+-	ret = sched_getparam(0, );
++	int old_policy;
++	ret = pthread_getschedparam(pthread_self(), _policy, );
+ 	if (ret != 0) {
+ 		log_debug("Failed to get old scheduling priority");
+ 		return;
+ 	}
+ 
+ 	param.sched_priority = priority;
+-	ret = sched_setscheduler(0, SCHED_RR, );
++
++	ret = pthread_setschedparam(pthread_self(), SCHED_RR, );
+ 	if (ret != 0) {
+-		log_info("Failed to set real-time scheduling priority to %d.", priority);
++		log_info("Failed to set real-time scheduling priority to %d. Consider "
++		 "giving picom the CAP_SYS_NICE capability or equivalent "
++		 "support.",
++		 priority);
+ 		return;
+ 	}
++
+ 	log_info("Set real-time scheduling priority to %d", priority);
+ }
+ 
+

Re: update x11/picom to v11

[Jose Maldonado]

El Thu, 08 Feb 2024 10:22:55 +0100
Omar Polo  escribió:
> Hello,
> 
> Sorry for the delay.
> 
> I haven't tested the diff (yet), but thanks for working on it!  I find
> it curious that glGetQueryObjectuiv is exported and
> glGetQueryObjectui64v is not.  However if upstream is expecting an
> uint64, I'm not sure that silently changing it to a int is a sensible
> thing to do, especially since it seems to be a timestamp.
> 
> It would probably be safer to ask upstream about this and see if they
> have a clue.  Let me know if you prefer to do it, otherwise I can ask
> them.
> 
> 
> Thanks,
> 
> Omar Polo

Sorry, I forget attach the last diff with the changes send to upstream



-- 
*
Dios en su cielo, todo bien en la Tierra
Index: Makefile
===
RCS file: /cvs/ports/x11/picom/Makefile,v
retrieving revision 1.11
diff -u -p -r1.11 Makefile
--- Makefile	24 Apr 2023 11:42:49 -	1.11
+++ Makefile	8 Feb 2024 19:57:18 -
@@ -1,19 +1,16 @@
 COMMENT =	lightweight compositor for X11
 
-GH_ACCOUNT =	yshui
-GH_PROJECT =	picom
-GH_TAGNAME =	v10.2
-REVISION =	0
+DIST_TUPLE =   github yshui picom v11.1 .
 
 CATEGORIES =	x11
 
 # MPL 2.0
 PERMIT_PACKAGE =	Yes
 
-WANTLIB += EGL GL X11 X11-xcb c config dbus-1 ev m pcre pixman-1
-WANTLIB += xcb-composite xcb-damage xcb-glx xcb-image xcb-present
+WANTLIB += EGL GL X11 X11-xcb c config dbus-1 ev m pcre2-8 pixman-1
+WANTLIB += pthread xcb-composite xcb-damage xcb-glx xcb-image xcb-present
 WANTLIB += xcb-randr xcb-render-util xcb-render xcb-shape xcb-sync
-WANTLIB += xcb-xfixes xcb-xinerama xcb
+WANTLIB += xcb-xfixes xcb-util xcb epoxy
 
 MODULES =		devel/meson
 
@@ -29,7 +26,7 @@ RUN_DEPENDS =		x11/gtk+4,-guic \
 
 LIB_DEPENDS =		devel/libconfig \
 			devel/libev \
-			devel/pcre \
+			devel/pcre2 \
 			x11/dbus
 
 CONFIGURE_ARGS	+=	-Dwith_docs=true \
Index: distinfo
===
RCS file: /cvs/ports/x11/picom/distinfo,v
retrieving revision 1.7
diff -u -p -r1.7 distinfo
--- distinfo	24 Dec 2022 16:35:26 -	1.7
+++ distinfo	8 Feb 2024 19:57:18 -
@@ -1,2 +1,2 @@
-SHA256 (picom-10.2.tar.gz) = l0FXffATbYor5IAFyiuT7cFZE1KOGbzreYU1ykaDNBw=
-SIZE (picom-10.2.tar.gz) = 287166
+SHA256 (yshui-picom-v11.1.tar.gz) = lvKjOpMGSnS1V5QtAwCirHeshT9Q77v2RmhJ/MdULsg=
+SIZE (yshui-picom-v11.1.tar.gz) = 308617
Index: patches/patch-src_backend_gl_gl_common_c
===
RCS file: patches/patch-src_backend_gl_gl_common_c
diff -N patches/patch-src_backend_gl_gl_common_c
--- /dev/null	1 Jan 1970 00:00:00 -
+++ patches/patch-src_backend_gl_gl_common_c	8 Feb 2024 19:57:18 -
@@ -0,0 +1,16 @@
+Index: src/backend/gl/gl_common.c
+--- src/backend/gl/gl_common.c.orig
 src/backend/gl/gl_common.c
+@@ -1,7 +1,12 @@
+ // SPDX-License-Identifier: MPL-2.0
+ // Copyright (c) Yuxuan Shui 
++#ifndef __OpenBSD__
+ #include 
+ #include 
++#else
++#include 
++#include 
++#endif
+ #include 
+ #include 
+ #include 
Index: patches/patch-src_meson_build
===
RCS file: patches/patch-src_meson_build
diff -N patches/patch-src_meson_build
--- /dev/null	1 Jan 1970 00:00:00 -
+++ patches/patch-src_meson_build	8 Feb 2024 19:57:18 -
@@ -0,0 +1,16 @@
+Index: src/meson.build
+--- src/meson.build.orig
 src/meson.build
+@@ -82,8 +82,11 @@ host_system = host_machine.system()
+ if host_system == 'linux'
+ 	cflags += ['-DHAS_INOTIFY']
+ elif (host_system == 'freebsd' or host_system == 'netbsd' or
+-  host_system == 'dragonfly' or host_system == 'openbsd')
++  host_system == 'dragonfly')
+ 	cflags += ['-DHAS_KQUEUE']
++elif host_system == 'openbsd'
++	cflags += ['-DHAS_KQUEUE']
++deps += [dependency('epoxy', required: true)]
+ endif
+ 
+ subdir('backend')
Index: patches/patch-src_picom_c
===
RCS file: patches/patch-src_picom_c
diff -N patches/patch-src_picom_c
--- /dev/null	1 Jan 1970 00:00:00 -
+++ patches/patch-src_picom_c	8 Feb 2024 19:57:18 -
@@ -0,0 +1,68 @@
+Index: src/picom.c
+--- src/picom.c.orig
 src/picom.c
+@@ -2553,24 +2553,46 @@ err:
+ /// This requires the user to set up permissions for the real-time scheduling. e.g. by
+ /// setting `ulimit -r`, or giving us the CAP_SYS_NICE capability.
+ void set_rr_scheduling(void) {
+-	int priority = sched_get_priority_min(SCHED_RR);
+-
+-	int ret;
+-	struct sched_param param;
+-
+-	ret = sched_getparam(0, );
+-	if (ret != 0) {
+-		log_debug("Failed to get old scheduling priority");
+-		return;
+-	}
+-
+-	param.sched_priority = priority;
+-	ret = sched_setscheduler(0, SCHED_RR, );
+-	if (ret != 0) {
+-		log_info("Failed to set real-time scheduling priority to %d.", priority);
+-		return;
+-	}
+-	log_info("Set real-time scheduling priority to %d", priority);
++#ifndef __OpenBSD__

Re: update x11/picom to v11

[Jose Maldonado]

El Thu, 08 Feb 2024 10:22:55 +0100
Omar Polo  escribió:
> Hello,
> 
> Sorry for the delay.
> 
> I haven't tested the diff (yet), but thanks for working on it!  I find
> it curious that glGetQueryObjectuiv is exported and
> glGetQueryObjectui64v is not.  However if upstream is expecting an
> uint64, I'm not sure that silently changing it to a int is a sensible
> thing to do, especially since it seems to be a timestamp.
> 
> It would probably be safer to ask upstream about this and see if they
> have a clue.  Let me know if you prefer to do it, otherwise I can ask
> them.
> 
> 
> Thanks,
> 
> Omar Polo

Hi!

I have submitted a PR to upstream with the final changes to compile
picom on OpenBSD using libepoxy (part of Xenocara). With these changes,
the build is complete and the picom upstream code is minimally affected.

These changes enable compilation for v11, v11.1 and next branch on
OpenBSD and returns pthread scheduling support on OpenBSD.

https://github.com/yshui/picom/pull/1186


-- 
*
Dios en su cielo, todo bien en la Tierra

Re: [UPDATE] New version for mail/claws-mail-4.2.0

[Jose Maldonado]

El Sun, 4 Feb 2024 14:36:36 +
Stuart Henderson  escribió:
> I've updated WANTLIB (some libs were missing, some needed moving
> between subpackages - might not be new) and committed, thanks for the
> update.

Hi!

I tested the changes not problem, thanks for the final fixes. 

-- 
*
Dios en su cielo, todo bien en la Tierra

Re: update x11/picom to v11

[Jose Maldonado]

El Sat, 03 Feb 2024 12:25:31 +0100
Omar Polo  escribió:
> On 2024/01/24 11:07:12 +0100, Omar Polo  wrote:
> > the changelog is available here:
> > 
> > https://github.com/yshui/picom/releases/tag/v11-rc1
> > 
> > picom now tries to set itself as real-time.  I've commented out that
> > part since it uses a function we don't seem to provide
> > (sched_setscheduler), but it's not a big deal.
> > 
> > However, I had again issues with the visibility of OpenGL symbols.
> > This time the 'usual' workaround didn't work.  See the two diffs
> > below.  It's ugly, but at least I can confirm that the glx backend
> > works for me (amdgpu if it matters.)  Any help understanding this
> > is welcome :)
> 
> diff updated for 11.1, still no idea regarding the
> glGetQueryObjectui64v symbol issue.
> 

Update, I have successfully managed to compile and run picom-v11.1 with
the following changes. Take a look and feedback is welcome!


-- 
*
Dios en su cielo, todo bien en la Tierra
Index: Makefile
===
RCS file: /cvs/ports/x11/picom/Makefile,v
retrieving revision 1.11
diff -u -p -u -r1.11 Makefile
--- Makefile	24 Apr 2023 11:42:49 -	1.11
+++ Makefile	4 Feb 2024 04:35:52 -
@@ -1,19 +1,16 @@
 COMMENT =	lightweight compositor for X11
 
-GH_ACCOUNT =	yshui
-GH_PROJECT =	picom
-GH_TAGNAME =	v10.2
-REVISION =	0
+DIST_TUPLE =   github yshui picom v11.1 .
 
 CATEGORIES =	x11
 
 # MPL 2.0
 PERMIT_PACKAGE =	Yes
 
-WANTLIB += EGL GL X11 X11-xcb c config dbus-1 ev m pcre pixman-1
-WANTLIB += xcb-composite xcb-damage xcb-glx xcb-image xcb-present
+WANTLIB += EGL GL X11 X11-xcb c config dbus-1 ev m pcre2-8 pixman-1
+WANTLIB += pthread xcb-composite xcb-damage xcb-glx xcb-image xcb-present
 WANTLIB += xcb-randr xcb-render-util xcb-render xcb-shape xcb-sync
-WANTLIB += xcb-xfixes xcb-xinerama xcb
+WANTLIB += xcb-xfixes xcb-util xcb
 
 MODULES =		devel/meson
 
@@ -29,7 +26,7 @@ RUN_DEPENDS =		x11/gtk+4,-guic \
 
 LIB_DEPENDS =		devel/libconfig \
 			devel/libev \
-			devel/pcre \
+			devel/pcre2 \
 			x11/dbus
 
 CONFIGURE_ARGS	+=	-Dwith_docs=true \
Index: distinfo
===
RCS file: /cvs/ports/x11/picom/distinfo,v
retrieving revision 1.7
diff -u -p -u -r1.7 distinfo
--- distinfo	24 Dec 2022 16:35:26 -	1.7
+++ distinfo	4 Feb 2024 04:35:52 -
@@ -1,2 +1,2 @@
-SHA256 (picom-10.2.tar.gz) = l0FXffATbYor5IAFyiuT7cFZE1KOGbzreYU1ykaDNBw=
-SIZE (picom-10.2.tar.gz) = 287166
+SHA256 (yshui-picom-v11.1.tar.gz) = lvKjOpMGSnS1V5QtAwCirHeshT9Q77v2RmhJ/MdULsg=
+SIZE (yshui-picom-v11.1.tar.gz) = 308617
Index: patches/patch-src_backend_gl_gl_common_c
===
RCS file: patches/patch-src_backend_gl_gl_common_c
diff -N patches/patch-src_backend_gl_gl_common_c
--- /dev/null	1 Jan 1970 00:00:00 -
+++ patches/patch-src_backend_gl_gl_common_c	4 Feb 2024 04:35:52 -
@@ -0,0 +1,13 @@
+--- src/backend/gl/gl_common.c.orig	Sat Feb  3 23:35:29 2024
 src/backend/gl/gl_common.c	Sat Feb  3 23:35:04 2024
+@@ -1186,8 +1186,8 @@ bool gl_last_render_time(backend_t *base, struct times
+ 		return false;
+ 	}
+ 
+-	GLuint64 time;
+-	glGetQueryObjectui64v(gd->frame_timing[gd->current_frame_timing ^ 1],
++	GLuint time;
++	glGetQueryObjectuiv(gd->frame_timing[gd->current_frame_timing ^ 1],
+ 	  GL_QUERY_RESULT, );
+ 	ts->tv_sec = (long)(time / 10);
+ 	ts->tv_nsec = (long)(time % 10);
Index: patches/patch-src_picom_c
===
RCS file: patches/patch-src_picom_c
diff -N patches/patch-src_picom_c
--- /dev/null	1 Jan 1970 00:00:00 -
+++ patches/patch-src_picom_c	4 Feb 2024 04:35:52 -
@@ -0,0 +1,38 @@
+--- src/picom.c.orig	Sat Feb  3 23:35:20 2024
 src/picom.c	Sat Feb  3 23:34:40 2024
+@@ -2550,28 +2550,30 @@ err:
+ /// Make picom realtime to reduce latency, and make rendering times more predictable to
+ /// help pacing.
+ ///
+-/// This requires the user to set up permissions for the real-time scheduling. e.g. by
+-/// setting `ulimit -r`, or giving us the CAP_SYS_NICE capability.
+ void set_rr_scheduling(void) {
+ 	int priority = sched_get_priority_min(SCHED_RR);
+ 
++	int old_policy;
+ 	int ret;
+ 	struct sched_param param;
+ 
+-	ret = sched_getparam(0, );
++	ret = pthread_getschedparam(pthread_self(), _policy, );
+ 	if (ret != 0) {
+ 		log_debug("Failed to get old scheduling priority");
+ 		return;
+ 	}
+ 
+ 	param.sched_priority = priority;
+-	ret = sched_setscheduler(0, SCHED_RR, );
++	ret = pthread_setschedparam(pthread_self(), SCHED_RR, );
+ 	if (ret != 0) {
+-		log_info("Failed to set real-time scheduling priority to %d.", priority);
++		log_info("Failed to set real-time scheduling priority to %d. Consider "
++		 "giving picom the CAP_SYS_NICE capability",
++		 priority);
+ 		return;
+ 	}
+ 	

Re: update x11/picom to v11

[Jose Maldonado]

El Sat, 03 Feb 2024 12:25:31 +0100
Omar Polo  escribió:
> On 2024/01/24 11:07:12 +0100, Omar Polo  wrote:
> > the changelog is available here:
> > 
> > https://github.com/yshui/picom/releases/tag/v11-rc1
> > 
> > picom now tries to set itself as real-time.  I've commented out that
> > part since it uses a function we don't seem to provide
> > (sched_setscheduler), but it's not a big deal.
> > 
> > However, I had again issues with the visibility of OpenGL symbols.
> > This time the 'usual' workaround didn't work.  See the two diffs
> > below.  It's ugly, but at least I can confirm that the glx backend
> > works for me (amdgpu if it matters.)  Any help understanding this
> > is welcome :)
> 
> diff updated for 11.1, still no idea regarding the
> glGetQueryObjectui64v symbol issue.
> 

Hi! 

I'm working on this too (using v11.1). Searching the issue with
glGetQueryObjectui64v, I found this:

nm /usr/X11R6/lib/libGL* | grep glGetQueryObjectui

__indirect_glGetQueryObjectuiv fc50 T
__indirect_glGetQueryObjectuiv 00061fc0 t __indirect_glGetQueryObjectuiv
0008c520 T glGetQueryObjectuiv
0008c570 T glGetQueryObjectuivARB
2fd0 T glGetQueryObjectuiv
df50 T glGetQueryObjectuiv
3510 T glGetQueryObjectuiv
 U __indirect_glGetQueryObjectuiv
d810 T __indirect_glGetQueryObjectuiv

glGetQueryObjectui64v don't exist in OpenBSD GL libs ¿¿?? 


-- 
*
Dios en su cielo, todo bien en la Tierra

Re: [UPDATE] New version for mail/claws-mail-4.2.0

[Jose Maldonado]

El Wed, 31 Jan 2024 16:16:20 +
Stuart Henderson  escribió:
> On 2024/01/31 11:36, Jose Maldonado wrote:
> > El Sun, 28 Jan 2024 12:58:06 -0400
> > Jose Maldonado  escribió:  
> > > Hello list!
> > > 
> > > A little update for claws-mail, bump version from 4.1.1 to 4.2.0
> > > launched in November 2023. Port compiled and working without
> > > problems.
> > > 
> > > The new version have various bug-fixes for usability and security
> > > (OAtuh fixes). The Gdata plugin has been removed from the source
> > > code. If you used it, be aware of this, you will have to look for
> > > other alternatives.
> > > 
> > > Take a look at the diff, feedback!
> > >   
> > 
> > Ping?? 
> > 
> > -- 
> > *
> > Dios en su cielo, todo bien en la Tierra
> >   
> 
> It was only 3 days, a bit soon for a ping.
> 
> It will need some new entries in pkg/PLIST-main to handle merging in
> the obsolete plugin:
> 
> @conflict claws-mail-gdata-*
> @pkgpath mail/claws-mail,-gdata[,compface]${FLAVOR_STRING}
> 
> Otherwise reads ok but I haven't tested 

Changes tested, all OK. 

Attach the output for make install and the new diff for port with your
changes. 

Thanks! 

-- 
*
Dios en su cielo, todo bien en la Tierra


claws-mail-4.2.0-diff
Description: Binary data


claws-mail-make-install
Description: Binary data

Re: [UPDATE] New version for mail/claws-mail-4.2.0

[Jose Maldonado]

El Wed, 31 Jan 2024 16:16:20 +
Stuart Henderson  escribió:
> On 2024/01/31 11:36, Jose Maldonado wrote:
> > El Sun, 28 Jan 2024 12:58:06 -0400
> > Jose Maldonado  escribió:
> > > Hello list!
> > > 
> > > A little update for claws-mail, bump version from 4.1.1 to 4.2.0
> > > launched in November 2023. Port compiled and working without
> > > problems.
> > > 
> > > The new version have various bug-fixes for usability and security
> > > (OAtuh fixes). The Gdata plugin has been removed from the source
> > > code. If you used it, be aware of this, you will have to look for
> > > other alternatives.
> > > 
> > > Take a look at the diff, feedback!
> > > 
> > 
> > Ping?? 
> > 
> > -- 
> > *
> > Dios en su cielo, todo bien en la Tierra
> > 
> 
> It was only 3 days, a bit soon for a ping.

So sorry, I didn't know this rule. Next time I'll give it more time
before the ping (>7 days)

> 
> It will need some new entries in pkg/PLIST-main to handle merging in
> the obsolete plugin:
> 
> @conflict claws-mail-gdata-*
> @pkgpath mail/claws-mail,-gdata[,compface]${FLAVOR_STRING}
> 
> Otherwise reads ok but I haven't tested 

I will try these changes, install 4.1.1 and with the changes to
PLIST-main I will reinstall using gdata plugin to make sure it installs
correctly.

-- 
*
Dios en su cielo, todo bien en la Tierra

Re: [UPDATE] New version for mail/claws-mail-4.2.0

[Jose Maldonado]

El Sun, 28 Jan 2024 12:58:06 -0400
Jose Maldonado  escribió:
> Hello list!
> 
> A little update for claws-mail, bump version from 4.1.1 to 4.2.0
> launched in November 2023. Port compiled and working without problems.
> 
> The new version have various bug-fixes for usability and security
> (OAtuh fixes). The Gdata plugin has been removed from the source
> code. If you used it, be aware of this, you will have to look for
> other alternatives.
> 
> Take a look at the diff, feedback!
> 

Ping?? 

-- 
*
Dios en su cielo, todo bien en la Tierra

[UPDATE] New version for mail/claws-mail-4.2.0

[Jose Maldonado]

Hello list!

A little update for claws-mail, bump version from 4.1.1 to 4.2.0
launched in November 2023. Port compiled and working without problems.

The new version have various bug-fixes for usability and security
(OAtuh fixes). The Gdata plugin has been removed from the source
code. If you used it, be aware of this, you will have to look for other
alternatives.

Take a look at the diff, feedback!

-- 
*
Dios en su cielo, todo bien en la Tierra
Index: Makefile
===
RCS file: /cvs/ports/mail/claws-mail/Makefile,v
retrieving revision 1.144
diff -u -p -r1.144 Makefile
--- Makefile	14 Nov 2023 09:28:01 -	1.144
+++ Makefile	28 Jan 2024 16:51:58 -
@@ -2,20 +2,13 @@ COMMENT-main=		mail and news client
 COMMENT-bogofilter=	bogofilter plugin
 COMMENT-spamassassin=	spamassassin plugin
 COMMENT-pdfviewer=	pdfviewer plugin
-COMMENT-gdata=		gdata plugin
 
-V=			4.1.1
+V=			4.2.0
 DISTNAME=		claws-mail-${V}
 PKGNAME-main=		${DISTNAME}
 PKGNAME-bogofilter=	claws-mail-bogofilter-${V}
 PKGNAME-spamassassin=	claws-mail-spamassassin-${V}
 PKGNAME-pdfviewer=	claws-mail-pdfviewer-${V}
-PKGNAME-gdata=		claws-mail-gdata-${V}
-REVISION-bogofilter=	1
-REVISION-gdata=		2
-REVISION-main=		1
-REVISION-pdfviewer=	1
-REVISION-spamassassin=	1
 
 CATEGORIES=		mail news
 
@@ -28,7 +21,7 @@ SITES=			https://www.claws-mail.org/rele
 
 COMPILER =		base-clang ports-gcc base-gcc
 
-MULTI_PACKAGES=		-main -bogofilter -spamassassin -pdfviewer -gdata
+MULTI_PACKAGES=		-main -bogofilter -spamassassin -pdfviewer
 FLAVORS=		jpilot ldap
 FLAVOR?=
 
@@ -59,11 +52,6 @@ WANTLIB-main += notify ogg p11-kit perl 
 WANTLIB-main += tasn1 unistring vorbis vorbisfile xcb-util xml2 zstd
 WANTLIB-main += brotlidec brotlienc db_cxx
 
-WANTLIB-gdata = ${WANTLIB}
-WANTLIB-gdata += brotlicommon brotlidec gck-2 gcr-4
-WANTLIB-gdata += gcrypt gdata goa-1.0 gpg-error idn2 json-glib-1.0
-WANTLIB-gdata += lzma p11-kit psl soup-2.4 sqlite3 unistring xml2
-
 WANTLIB-pdfviewer =  ${WANTLIB}
 WANTLIB-pdfviewer += lcms2 lzma openjp2 png poppler poppler-glib tiff zstd
 
@@ -97,9 +85,6 @@ LIB_DEPENDS-main=	${LIB_DEPENDS} \
 
 LIB_DEPENDS-pdfviewer=	${LIB_DEPENDS} \
 			print/poppler
-
-LIB_DEPENDS-gdata=	${LIB_DEPENDS} \
-			devel/libgdata
 
 CONFIGURE_ARGS+=	--disable-acpi_notifier-plugin \
 			--disable-compface \
Index: distinfo
===
RCS file: /cvs/ports/mail/claws-mail/distinfo,v
retrieving revision 1.44
diff -u -p -r1.44 distinfo
--- distinfo	3 Jan 2023 16:23:08 -	1.44
+++ distinfo	28 Jan 2024 16:51:58 -
@@ -1,2 +1,2 @@
-SHA256 (claws-mail-4.1.1.tar.gz) = BKc6OIme4EDGfdgffDpK0LvI77066ATlzrkfqLLYYC4=
-SIZE (claws-mail-4.1.1.tar.gz) = 12140702
+SHA256 (claws-mail-4.2.0.tar.gz) = RGyJ8nwiBSd/COd2tT2dFRvgEyEdkefZ2gBryVwFHGA=
+SIZE (claws-mail-4.2.0.tar.gz) = 12476550
Index: pkg/DESCR-gdata
===
RCS file: pkg/DESCR-gdata
diff -N pkg/DESCR-gdata
--- pkg/DESCR-gdata	11 Oct 2013 22:14:18 -	1.1
+++ /dev/null	1 Jan 1970 00:00:00 -
@@ -1,3 +0,0 @@
-This plugin provides an interface to Google services. Currently, the
-only implemented functionality is to include Google Contacts in the
-Tab-address completion.
Index: pkg/PLIST-gdata
===
RCS file: pkg/PLIST-gdata
diff -N pkg/PLIST-gdata
--- pkg/PLIST-gdata	11 Mar 2022 19:34:33 -	1.4
+++ /dev/null	1 Jan 1970 00:00:00 -
@@ -1,3 +0,0 @@
-@pkgpath mail/claws-mail,-gdata,compface${FLAVOR_STRING}
-lib/claws-mail/plugins/gdata.la
-@so lib/claws-mail/plugins/gdata.so
Index: pkg/PLIST-main
===
RCS file: /cvs/ports/mail/claws-mail/pkg/PLIST-main,v
retrieving revision 1.47
diff -u -p -r1.47 PLIST-main
--- pkg/PLIST-main	7 Sep 2022 11:24:55 -	1.47
+++ pkg/PLIST-main	28 Jan 2024 16:51:58 -
@@ -363,6 +363,9 @@ share/locale/nb/LC_MESSAGES/claws-mail.m
 share/locale/nl/LC_MESSAGES/claws-mail.mo
 share/locale/pl/LC_MESSAGES/claws-mail.mo
 share/locale/pt_BR/LC_MESSAGES/claws-mail.mo
+share/locale/pt_PT/
+share/locale/pt_PT/LC_MESSAGES/
+share/locale/pt_PT/LC_MESSAGES/claws-mail.mo
 share/locale/ro/LC_MESSAGES/claws-mail.mo
 share/locale/ru/LC_MESSAGES/claws-mail.mo
 share/locale/sk/LC_MESSAGES/claws-mail.mo

Re: Qt5 shmget(2): create shm with mode 0666 (next try)

[Jose Maldonado]

El 1/9/23 a las 9:00, Rafael Sadowski escribió:

On Sat Jul 22, 2023 at 07:51:15AM +0200, Matthieu Herrb wrote:

On Thu, Jul 20, 2023 at 08:32:30PM +0200, Rafael Sadowski wrote:

On Thu Jul 20, 2023 at 04:31:55PM +0100, Stuart Henderson wrote:

On 2023/07/20 17:27, Rafael Sadowski wrote:

Let's start with a quote from an old try:

"Our Xorg server doesn't run under the same uid as the client, the client
needs to create the shared memory area with mode 0666.

We are doing the same in misc/screen-shm. Of course, the consequence
here would be to do it for all Qt applications."

-- https://marc.info/?l=openbsd-ports=167110468109188=2

There was a veto from sthen@, which was perfectly okay and right.  For
error analysis and to exclude that this function is not used, I need the
shm mode from time to time. I would like to solve it with an environment
variable (QT_OPENBSD_SHM_MODE).


 From that mail,

"What are the consequences of leaving this as-is? (i.e. what's broken
now that changing this would fix?)"



Nothing is broken and nothing is would fix for now. It just helps me to
debug Qt application or large ecosystem like KDE plasma. When I increase
the debug level I see that shm could not be init and therefore I can not
exclude that exactly this is a problem.

Long story short: It helps me not to always have to build Qt myself.



Are there still places in the Qt library that don't use
xcb_shm_attach_fd() to attach shared memory segments to the X server ?


No, it looks like they are using this pattern:

It starts here:

286 if (!QXcbBackingStore::createSystemVShmSegment(m_xcbConnection)) {
287 qCDebug(lcQpaXcb, "failed to create System V shared memory segment 
(remote "
288   "X11 connection?), disabling SHM");
289 m_hasShm = m_hasShmFd = false;
290 }

409 bool QXcbBackingStoreImage::createSystemVShmSegment(xcb_connection_t 
*c, size_t segmen
410 
xcb_shm_segment_info_t *shmInfo)
411 {
412const int id = shmget(IPC_PRIVATE, segmentSize, IPC_CREAT | 0600);
413 if (id == -1) {
414 qCWarning(lcQpaXcb, "shmget() failed (%d: %s) for size %zu", 
errno, strerror(e
415 return false;
416 }
417
418 void *addr = shmat(id, nullptr, 0);
419 if (addr == (void *)-1) {
420 qCWarning(lcQpaXcb, "shmat() failed (%d: %s) for id %d", errno, 
strerror(errno
421 return false;
422 }
423
424 if (shmctl(id, IPC_RMID, nullptr) == -1)
425 qCWarning(lcQpaXcb, "Error while marking the shared memory 
segment to be destr
426
427 const auto seg = xcb_generate_id(c);
428 auto cookie = xcb_shm_attach_checked(c, seg, id, false);
429 auto *error = xcb_request_check(c, cookie);
430 if (error) {
431 qCWarning(lcQpaXcb(), "xcb_shm_attach() failed");


Or in sort:

412 const int id = shmget(IPC_PRIVATE, segmentSize, IPC_CREAT | 0600);
425 const auto seg = xcb_generate_id(c);
426 auto cookie = xcb_shm_attach_checked(c, seg, id, false);
427 auto *error = xcb_request_check(c, cookie);

431 qCWarning(lcQpaXcb(), "xcb_shm_attach() failed");

https://github.com/qt/qtbase/blob/5.15/src/plugins/platforms/xcb/qxcbbackingstore.cpp#L424

There is no different path for Linux/FreeBSD here.




This was introduced more than 10 years ago, so that if the X server is
not running as root it can still access shared memory segments created
by the clients, possibly running as a different uid as the server, and
preserving the privacy of the shm contents.

In that case 600 is perfectly fine and applications don't need to
fallback on non-shm based transports.

If Qt is using xcb_shm_attach() or XShmAttach() is that only on
OpenBSD because it thinks OpenBSD doesn't have xcb_shm_attach_fd(),i
ot is it the same on Linux ? (since Linux is not running X as root
anymore either whith systemd, they would face the same issues as you).



$ dolphin # OpenBSD with ports qtbase
qt.scaling: Apply  QT_SCALE_FACTOR 1
qt.qpa.xcb: Has MIT-SHM : true
qt.qpa.xcb: Has MIT-SHM FD  : true
qt.qpa.xcb: xcb_shm_attach() failed
qt.qpa.xcb: failed to create System V shared memory segment (remote X11 
connection?), disabling SHM
qt.qpa.xcb: Using XInput version 2.2

$ dolphin # Linux Debian sid
qt.qpa.xcb: Has MIT-SHM : true
qt.qpa.xcb: Has MIT-SHM FD  : true
qt.qpa.xcb: Using XInput version 2.2



PS: I remember we once noticed that mesa was also not using
xcb_shm_attach_fd() on OpenBSD. I should have a look to confirm this,
but I'm not available for the next 2 weeks to do that, sorry.
--
Matthieu Herrb





Hi! From my ignorance I have the following question:

Is it likely that this SHM problem in QT5, has some strange interaction 
with PyQT5, programs that need access to SHM under certain conditions 
and the death of a Xenocara session?


You see, I have opened this 

Re: UPDATE: audio/picard-2.9.1

[Jose Maldonado]

El 31/8/23 a las 10:58, Stefan Hagen escribió:

Jose Maldonado wrote (2023-08-31 09:21 CEST):

El 31/8/23 a las 3:18, Stefan Hagen escribió:

Hi Jose,

Jose Maldonado wrote (2023-08-31 08:26 CEST):

Hi, this is my first contribution. Bump version for audio/picard to 2.9.1.
All tested in amd64, not problems.


You did a good job. For some reason your patch contained line breaks in
the PLIST that shouldn't be there. But no problem - I just regenerated
it.


+MODPY_EGG_VERSION =2.9.1
   DISTNAME =   picard-${MODPY_EGG_VERSION}
   REVISION =   0


When the port version is bumped up, the REVISION can be removed.
Everything else looks fine to me.

Diff below with the following changes:
- REVISION removed
- RUN_DEPENDS sorted
- Comment that pthread is needed, so the next person updating it won't
trip over it.

A runtime test was successful.

The test target runs to 38% and then get's stuck at
test/test_util_pipe.py where it loops at 100% cpu forever.

ktrace:
5861148  46436 python3.10 CALL  open(0x80316d14050,0x1)
5861149  46436 python3.10 RET   open -1 errno 2 No such file or directory
5861150  46436 python3.10 CALL  
futex(0x803b2dc4ec0,0x82,1,0,0)
5861151  46436 python3.10 RET   futex 0
5861152  46436 python3.10 CALL  
futex(0x803b2dc8210,0x82,1,0,0)
5861153  46436 python3.10 RET   futex 0
5861154  46436 python3.10 CALL  open(0x80316d14050,0x1)
5861155  46436 python3.10 RET   open -1 errno 2 No such file or directory

It seems not to hurt picard though.

Best Regards,
Stefan



Thanks for the comments, I will take them into account for the next diff.

Right now, I'm taking a look at Picard Github, to see what I can find that
gives an explanation to the problem indicated in the list.


I just opened picard 20 times in a row and clicked around without a
crash. I turned HW acceleration off in xorg.conf (amdgpu):
 Option "Accel""off"

With this option "on", roughly every third picard start would kill X.

Is this the issue others are facing too, or did I stumble at something
new?

Best regards,
Stefan


Ok I have tested this package further and found the following:

1.- Picard only crashes using the media player features (made possible 
by the use of PyQT5 and its QTMultimedia modules). If I launch Picard 
with the -M option (disabling these features), it does not crash and I 
can use the software without problems.


2.- I can replicate the problem (complete failure of Xenocara) using 
another software that I have written using PyQT5. This software uses the 
QtMultimedia modules, and I get the problem, one run and Xenocara dies.


I have read this topic 
(https://www.mail-archive.com/tech@openbsd.org/msg72531.html) and maybe 
this is related to the crashes, because this is directly related to XCB, 
DRM and Xenocara.


In fact, I have tested the latest snapshot of current, and now the 
Xenocara segfault has changed (this latest snapshot includes some 
changes in the DRM code). I am going to submit an issue to bugs mail 
list, because this looks like a bug in the Xenocara/DRM code (possibly a 
regression).


3.- I have cleaned up the pthreads in the Makefile...and Picard compiles 
and runs correctly.


Are you ok with this or are we waiting for a fix for the Xenocara crash 
problem?

rev-picard-plist-2.9.1
Description: Unix manual page


rev-picard-makefile-2.9.1
Description: Unix manual page


rev-picard-distinfo-2.9.1
Description: Unix manual page

Re: UPDATE: audio/picard-2.9.1

[Jose Maldonado]

El 31/8/23 a las 10:58, Stefan Hagen escribió:

Jose Maldonado wrote (2023-08-31 09:21 CEST):

El 31/8/23 a las 3:18, Stefan Hagen escribió:

Hi Jose,

Jose Maldonado wrote (2023-08-31 08:26 CEST):

Hi, this is my first contribution. Bump version for audio/picard to 2.9.1.
All tested in amd64, not problems.


You did a good job. For some reason your patch contained line breaks in
the PLIST that shouldn't be there. But no problem - I just regenerated
it.


+MODPY_EGG_VERSION =2.9.1
   DISTNAME =   picard-${MODPY_EGG_VERSION}
   REVISION =   0


When the port version is bumped up, the REVISION can be removed.
Everything else looks fine to me.

Diff below with the following changes:
- REVISION removed
- RUN_DEPENDS sorted
- Comment that pthread is needed, so the next person updating it won't
trip over it.

A runtime test was successful.

The test target runs to 38% and then get's stuck at
test/test_util_pipe.py where it loops at 100% cpu forever.

ktrace:
5861148  46436 python3.10 CALL  open(0x80316d14050,0x1)
5861149  46436 python3.10 RET   open -1 errno 2 No such file or directory
5861150  46436 python3.10 CALL  
futex(0x803b2dc4ec0,0x82,1,0,0)
5861151  46436 python3.10 RET   futex 0
5861152  46436 python3.10 CALL  
futex(0x803b2dc8210,0x82,1,0,0)
5861153  46436 python3.10 RET   futex 0
5861154  46436 python3.10 CALL  open(0x80316d14050,0x1)
5861155  46436 python3.10 RET   open -1 errno 2 No such file or directory

It seems not to hurt picard though.

Best Regards,
Stefan



Thanks for the comments, I will take them into account for the next diff.

Right now, I'm taking a look at Picard Github, to see what I can find that
gives an explanation to the problem indicated in the list.


I just opened picard 20 times in a row and clicked around without a
crash. I turned HW acceleration off in xorg.conf (amdgpu):
 Option "Accel""off"

With this option "on", roughly every third picard start would kill X.

Is this the issue others are facing too, or did I stumble at something
new?

Best regards,
Stefan


I have been checking the problem, and I have seen the following:


1.- It usually only appears when you run picard on more than one 
occasion using the same X11/Xenocara session. If you run it once and 
reboot, no problem. If you run it more than once you are in bingo.


2.- You end up with two errors in the logs:

- By Picard:

I: 22:40:53,623 browser/browser.start:121: Starting the browser 
integration (127.0.0.1:8000)
The X11 connection broke: I/O error (code 1) X connection to :0 broken 
(explicit kill or server shutdown).


- By Xenocara


[22813.129] (EE) Received signal 6 sent by process 0, uid 0
[ 22813.130] (EE) Fatal server error:
[ 22813.130] (EE) Caught signal 6 (Abort trap). Server aborting
[ 22813.130] (EE)
Please consult the X.Org Foundation support
 at http://wiki.x.org for help.
[22813.130] (EE) Please also check the log file at "/var/log/Xorg.0.log" 
for additional information.


3.- If you start picard with the -M option (disabling the built-in media 
player) then it stops crashing X11/Xenocara, no matter how many times 
you start picard in the same session.


This problem maybe is related with this problem

https://forum.qt.io/topic/125074/x11-connection-broken-when-using-qt-5-14

Re: UPDATE: audio/picard-2.9.1

[Jose Maldonado]

El 31/8/23 a las 3:18, Stefan Hagen escribió:

Hi Jose,

Jose Maldonado wrote (2023-08-31 08:26 CEST):

Hi, this is my first contribution. Bump version for audio/picard to 2.9.1.
All tested in amd64, not problems.


You did a good job. For some reason your patch contained line breaks in
the PLIST that shouldn't be there. But no problem - I just regenerated
it.


+MODPY_EGG_VERSION =2.9.1
  DISTNAME =picard-${MODPY_EGG_VERSION}
  REVISION =0


When the port version is bumped up, the REVISION can be removed.
Everything else looks fine to me.

Diff below with the following changes:
- REVISION removed
- RUN_DEPENDS sorted
- Comment that pthread is needed, so the next person updating it won't
   trip over it.

A runtime test was successful.

The test target runs to 38% and then get's stuck at
test/test_util_pipe.py where it loops at 100% cpu forever.

ktrace:
5861148  46436 python3.10 CALL  open(0x80316d14050,0x1)
5861149  46436 python3.10 RET   open -1 errno 2 No such file or directory
5861150  46436 python3.10 CALL  
futex(0x803b2dc4ec0,0x82,1,0,0)
5861151  46436 python3.10 RET   futex 0
5861152  46436 python3.10 CALL  
futex(0x803b2dc8210,0x82,1,0,0)
5861153  46436 python3.10 RET   futex 0
5861154  46436 python3.10 CALL  open(0x80316d14050,0x1)
5861155  46436 python3.10 RET   open -1 errno 2 No such file or directory

It seems not to hurt picard though.

Best Regards,
Stefan



Thanks for the comments, I will take them into account for the next diff.

Right now, I'm taking a look at Picard Github, to see what I can find 
that gives an explanation to the problem indicated in the list.

Re: UPDATE: audio/picard-2.9.1

[Jose Maldonado]

El 31/8/23 a las 2:34, Rafael Sadowski escribió:

On Thu Aug 31, 2023 at 02:26:59AM -0400, Jose Maldonado wrote:

Hi, this is my first contribution. Bump version for audio/picard to 2.9.1.
All tested in amd64, not problems.

Index: Makefile
===
RCS file: /cvs/ports/audio/picard/Makefile,v
retrieving revision 1.57
diff -u -p -r1.57 Makefile
--- Makefile24 Apr 2023 11:40:35 -  1.57
+++ Makefile31 Aug 2023 06:18:30 -
@@ -1,6 +1,6 @@
  COMMENT = automatic audio files tagger using the MusicBrainz database

-MODPY_EGG_VERSION =2.8.5
+MODPY_EGG_VERSION =2.9.1
  DISTNAME =picard-${MODPY_EGG_VERSION}
  REVISION =0


You missed to remove the REVISION here.

REVISION
 Revision number of the current package.  Defaults to empty (very
 first package), then numbering starts at 0.  Gets automatically
 incorporated into FULLPKGNAME as ‘p${REVISION}’ to form a full
 package-name conforming to packages-specs(7).

For more read bsd.port.mk man.




Thanks for the quick revision. I´m sending the fix in three diff files.

@SpaceHopper...thanks for the info, I take a look at this problem.

picard-diff-distinfo-2.9.1
Description: Unix manual page


picard-diff-Makefile-2.9.1
Description: Unix manual page


picard-diff-PLIST-2.9.1
Description: Unix manual page

UPDATE: audio/picard-2.9.1

[Jose Maldonado]

Hi, this is my first contribution. Bump version for audio/picard to 
2.9.1. All tested in amd64, not problems.


Index: Makefile
===
RCS file: /cvs/ports/audio/picard/Makefile,v
retrieving revision 1.57
diff -u -p -r1.57 Makefile
--- Makefile24 Apr 2023 11:40:35 -  1.57
+++ Makefile31 Aug 2023 06:18:30 -
@@ -1,6 +1,6 @@
 COMMENT =  automatic audio files tagger using the MusicBrainz database

-MODPY_EGG_VERSION =2.8.5
+MODPY_EGG_VERSION =2.9.1
 DISTNAME = picard-${MODPY_EGG_VERSION}
 REVISION = 0


Index: distinfo
===
RCS file: /cvs/ports/audio/picard/distinfo,v
retrieving revision 1.20
diff -u -p -r1.20 distinfo
--- distinfo17 Dec 2022 20:34:35 -  1.20
+++ distinfo31 Aug 2023 06:18:43 -
@@ -1,2 +1,2 @@
-SHA256 (picard-2.8.5.tar.gz) = X2gFsz462BygiKKLRP7QoPrqj1AVQToWoKPuSUhx5Bs=
-SIZE (picard-2.8.5.tar.gz) = 4519367
+SHA256 (picard-2.9.1.tar.gz) = euNlpslulBGDOywJt6Js7dOYTIdIGcRRVZKk2kdxNrg=
+SIZE (picard-2.9.1.tar.gz) = 5270234


Index: pkg/PLIST
===
RCS file: /cvs/ports/audio/picard/pkg/PLIST,v
retrieving revision 1.16
diff -u -p -r1.16 PLIST
--- pkg/PLIST   9 Sep 2022 19:12:13 -   1.16
+++ pkg/PLIST   31 Aug 2023 06:18:54 -
@@ -146,12 +146,15 @@ lib/python${MODPY_VERSION}/site-packages

${MODPY_COMMENT}lib/python${MODPY_VERSION}/site-packages/picard/disc/${MODPY_PYCACHE}/

lib/python${MODPY_VERSION}/site-packages/picard/disc/${MODPY_PYCACHE}__init__.${MODPY_PYC_MAGIC_TAG}${MODPY_PYOEXTENSION}

lib/python${MODPY_VERSION}/site-packages/picard/disc/${MODPY_PYCACHE}__init__.${MODPY_PYC_MAGIC_TAG}pyc
+lib/python${MODPY_VERSION}/site-packages/picard/disc/${MODPY_PYCACHE}dbpoweramplog.${MODPY_PYC_MAGIC_TAG}${MODPY_PYOEXTENSION}
+lib/python${MODPY_VERSION}/site-packages/picard/disc/${MODPY_PYCACHE}dbpoweramplog.${MODPY_PYC_MAGIC_TAG}pyc

lib/python${MODPY_VERSION}/site-packages/picard/disc/${MODPY_PYCACHE}eaclog.${MODPY_PYC_MAGIC_TAG}${MODPY_PYOEXTENSION}

lib/python${MODPY_VERSION}/site-packages/picard/disc/${MODPY_PYCACHE}eaclog.${MODPY_PYC_MAGIC_TAG}pyc

lib/python${MODPY_VERSION}/site-packages/picard/disc/${MODPY_PYCACHE}utils.${MODPY_PYC_MAGIC_TAG}${MODPY_PYOEXTENSION}

lib/python${MODPY_VERSION}/site-packages/picard/disc/${MODPY_PYCACHE}utils.${MODPY_PYC_MAGIC_TAG}pyc

lib/python${MODPY_VERSION}/site-packages/picard/disc/${MODPY_PYCACHE}whipperlog.${MODPY_PYC_MAGIC_TAG}${MODPY_PYOEXTENSION}

lib/python${MODPY_VERSION}/site-packages/picard/disc/${MODPY_PYCACHE}whipperlog.${MODPY_PYC_MAGIC_TAG}pyc
+lib/python${MODPY_VERSION}/site-packages/picard/disc/dbpoweramplog.py
 lib/python${MODPY_VERSION}/site-packages/picard/disc/eaclog.py
 lib/python${MODPY_VERSION}/site-packages/picard/disc/utils.py
 lib/python${MODPY_VERSION}/site-packages/picard/disc/whipperlog.py
@@ -274,12 +277,16 @@ lib/python${MODPY_VERSION}/site-packages

lib/python${MODPY_VERSION}/site-packages/picard/ui/${MODPY_PYCACHE}metadatabox.${MODPY_PYC_MAGIC_TAG}pyc

lib/python${MODPY_VERSION}/site-packages/picard/ui/${MODPY_PYCACHE}moveable_list_view.${MODPY_PYC_MAGIC_TAG}${MODPY_PYOEXTENSION}

lib/python${MODPY_VERSION}/site-packages/picard/ui/${MODPY_PYCACHE}moveable_list_view.${MODPY_PYC_MAGIC_TAG}pyc
+lib/python${MODPY_VERSION}/site-packages/picard/ui/${MODPY_PYCACHE}newuserdialog.${MODPY_PYC_MAGIC_TAG}${MODPY_PYOEXTENSION}
+lib/python${MODPY_VERSION}/site-packages/picard/ui/${MODPY_PYCACHE}newuserdialog.${MODPY_PYC_MAGIC_TAG}pyc

lib/python${MODPY_VERSION}/site-packages/picard/ui/${MODPY_PYCACHE}passworddialog.${MODPY_PYC_MAGIC_TAG}${MODPY_PYOEXTENSION}

lib/python${MODPY_VERSION}/site-packages/picard/ui/${MODPY_PYCACHE}passworddialog.${MODPY_PYC_MAGIC_TAG}pyc

lib/python${MODPY_VERSION}/site-packages/picard/ui/${MODPY_PYCACHE}playertoolbar.${MODPY_PYC_MAGIC_TAG}${MODPY_PYOEXTENSION}

lib/python${MODPY_VERSION}/site-packages/picard/ui/${MODPY_PYCACHE}playertoolbar.${MODPY_PYC_MAGIC_TAG}pyc

lib/python${MODPY_VERSION}/site-packages/picard/ui/${MODPY_PYCACHE}ratingwidget.${MODPY_PYC_MAGIC_TAG}${MODPY_PYOEXTENSION}

lib/python${MODPY_VERSION}/site-packages/picard/ui/${MODPY_PYCACHE}ratingwidget.${MODPY_PYC_MAGIC_TAG}pyc
+lib/python${MODPY_VERSION}/site-packages/picard/ui/${MODPY_PYCACHE}savewarningdialog.${MODPY_PYC_MAGIC_TAG}${MODPY_PYOEXTENSION}
+lib/python${MODPY_VERSION}/site-packages/picard/ui/${MODPY_PYCACHE}savewarningdialog.${MODPY_PYC_MAGIC_TAG}pyc

lib/python${MODPY_VERSION}/site-packages/picard/ui/${MODPY_PYCACHE}scripteditor.${MODPY_PYC_MAGIC_TAG}${MODPY_PYOEXTENSION}

lib/python${MODPY_VERSION}/site-packages/picard/ui/${MODPY_PYCACHE}scripteditor.${MODPY_PYC_MAGIC_TAG}pyc

lib/python${MODPY_VERSION}/site-packages/picard/ui/${MODPY_PYCACHE}scriptsmenu.${MODPY_PYC_MAGIC_TAG}${MODPY_PYOEXTENSION}
@@ -328,6 +335,8 @@ lib/python${MODPY_VERSION}/site-packages