Re: [new] jupyter_server
Hi everyone, would be great to get ok's to commit these new ports. I'm not able to update the jupyter stack much more until I get these into the tree. Thanks for any help! On Thu, 15 Feb 2024, Daniel Dickman wrote: > Here's jupyter_server, a new port in the jupyter stack needed for > jupyterlab and a few other things. > > The attachment contains a few things: > - py-nodeenv, a new port needed by pre-commit (jupyter_server fails at > build time without pre-commit having all the ports it needs) > - a replacement Makefile for pre-commit adding the new RDEP and bumping > the port. > - 2 new TDEPs for jupyter_server > - The new jupyter_server port itself. > > Note that jupyter_server cannot go to the 2.x series until > jupyter-notebook supports the newer version. I added a comment about that > in the Makefile. > > ok on importing all these new ports? >
Re: [new] jupyter_server
> On Feb 18, 2024, at 9:50 AM, Thomas Frohwein wrote: > > On Fri, Feb 16, 2024 at 02:04:26PM +0300, Pavel Korovin wrote: >> Hi Daniel, >> >> I don't mind the new pre-commit RDEP, though it's not actually a >> dependency: pre-commit runs fine without py-nodeenv. >> >> I'd suggest is to check if it's possible to avoid adding pre-commit >> as BDEP (along with py-nodeenv). >> >> pre-commit is a test-before-commit tool and I don't see why it becomes >> build dependency. Possibly this can be fixed in the build environment. >> >>> On 02/15, Daniel Dickman wrote: >>> Here's jupyter_server, a new port in the jupyter stack needed for >>> jupyterlab and a few other things. >>> >>> The attachment contains a few things: >>> - py-nodeenv, a new port needed by pre-commit (jupyter_server fails at >>> build time without pre-commit having all the ports it needs) >>> - a replacement Makefile for pre-commit adding the new RDEP and bumping >>> the port. >>> - 2 new TDEPs for jupyter_server >>> - The new jupyter_server port itself. >>> >>> Note that jupyter_server cannot go to the 2.x series until >>> jupyter-notebook supports the newer version. I added a comment about that >>> in the Makefile. >>> >>> ok on importing all these new ports? >> > > I'm not familiar with the whole ecosystem, but to me this is pretty > confusing and I think this will work better in smaller steps. Sure. We can just solve for pre commit first. > > *If* py-nodeenv is needed (see Pavel's comments), I replied privately to Pavel. The short story is that pre-commit supports hooks for many different languages. Node is one supported language. Unless one is using pre-commit with node you would not hit this code path from what I can tell. So either the RDEP should be added or the pre-commit node support should be removed and pyproject patched to match. I don’t see any reason to remove node support from pre-commit and would prefer to just add the missing RDEP to the ports tree. > I'm confused why such > an old version - 0.11.1 is from 2014, the most recent one on pypi.org is > 1.8.0 from 2023... As I’m going through the update of Jupyter I’m typically picking the minimum supported version. The plan is to get everything to the latest versions possible but I’ve found that a) it’s often best to pick deps that existed at the time of the port as it’s more likely that someone tried that combination and b) it’s always easier to go forward in time rather than finding problems and needing to bump EPOCH after the fact. Getting the nodeenv port imported would be a good next step if I can get an ok for that. > >> -- >> With best regards, >> Pavel Korovin >>
Re: [new] jupyter_server
On Fri, Feb 16, 2024 at 02:04:26PM +0300, Pavel Korovin wrote: > Hi Daniel, > > I don't mind the new pre-commit RDEP, though it's not actually a > dependency: pre-commit runs fine without py-nodeenv. > > I'd suggest is to check if it's possible to avoid adding pre-commit > as BDEP (along with py-nodeenv). > > pre-commit is a test-before-commit tool and I don't see why it becomes > build dependency. Possibly this can be fixed in the build environment. > > On 02/15, Daniel Dickman wrote: > > Here's jupyter_server, a new port in the jupyter stack needed for > > jupyterlab and a few other things. > > > > The attachment contains a few things: > > - py-nodeenv, a new port needed by pre-commit (jupyter_server fails at > > build time without pre-commit having all the ports it needs) > > - a replacement Makefile for pre-commit adding the new RDEP and bumping > > the port. > > - 2 new TDEPs for jupyter_server > > - The new jupyter_server port itself. > > > > Note that jupyter_server cannot go to the 2.x series until > > jupyter-notebook supports the newer version. I added a comment about that > > in the Makefile. > > > > ok on importing all these new ports? > I'm not familiar with the whole ecosystem, but to me this is pretty confusing and I think this will work better in smaller steps. *If* py-nodeenv is needed (see Pavel's comments), I'm confused why such an old version - 0.11.1 is from 2014, the most recent one on pypi.org is 1.8.0 from 2023... > -- > With best regards, > Pavel Korovin >
Re: [new] jupyter_server
Hi Daniel, I don't mind the new pre-commit RDEP, though it's not actually a dependency: pre-commit runs fine without py-nodeenv. I'd suggest is to check if it's possible to avoid adding pre-commit as BDEP (along with py-nodeenv). pre-commit is a test-before-commit tool and I don't see why it becomes build dependency. Possibly this can be fixed in the build environment. On 02/15, Daniel Dickman wrote: > Here's jupyter_server, a new port in the jupyter stack needed for > jupyterlab and a few other things. > > The attachment contains a few things: > - py-nodeenv, a new port needed by pre-commit (jupyter_server fails at > build time without pre-commit having all the ports it needs) > - a replacement Makefile for pre-commit adding the new RDEP and bumping > the port. > - 2 new TDEPs for jupyter_server > - The new jupyter_server port itself. > > Note that jupyter_server cannot go to the 2.x series until > jupyter-notebook supports the newer version. I added a comment about that > in the Makefile. > > ok on importing all these new ports? -- With best regards, Pavel Korovin
[new] jupyter_server
Here's jupyter_server, a new port in the jupyter stack needed for jupyterlab and a few other things. The attachment contains a few things: - py-nodeenv, a new port needed by pre-commit (jupyter_server fails at build time without pre-commit having all the ports it needs) - a replacement Makefile for pre-commit adding the new RDEP and bumping the port. - 2 new TDEPs for jupyter_server - The new jupyter_server port itself. Note that jupyter_server cannot go to the 2.x series until jupyter-notebook supports the newer version. I added a comment about that in the Makefile. ok on importing all these new ports? jupyter_server.tgz Description: Binary data
