Re: Update: multimedia/mpv, feedback needed

2016-11-23 Thread Jeremie Courreges-Anglas
"Dmitrij D. Czarkoff" writes: > Jeremie Courreges-Anglas wrote: > >>I don't use mpv, but the fact that it uses libsmbclient puts mpv on my >>plate when I update samba. Last time I checked I didn't find the >>smbclient support particularly useful (access files on network >>filesystems that aren'

Re: Update: multimedia/mpv, feedback needed

2016-11-23 Thread Christian Weisgerber
On 2016-11-23, "Dmitrij D. Czarkoff" wrote: > I was asked off-list to add a "lite" flavor for multimedia/mpv. This > diff introduces such version. This iteration disables the fllowing in > "lite" FLAVOR: -snip- Well, if I was using mpv (as espie urges me to), I would want some of the removed f

Re: Update: multimedia/mpv, feedback needed

2016-11-23 Thread Dmitrij D. Czarkoff
Jeremie Courreges-Anglas wrote: >I don't use mpv, but the fact that it uses libsmbclient puts mpv on my >plate when I update samba. Last time I checked I didn't find the >smbclient support particularly useful (access files on network >filesystems that aren't mounted locally). I'd be thankful if

Re: Update: multimedia/mpv, feedback needed

2016-11-23 Thread Antoine Jacoutot
On Wed, Nov 23, 2016 at 04:11:10PM +0100, Dmitrij D. Czarkoff wrote: > Antoine Jacoutot wrote: > > >>> --enable-foo needs to be explicitely set when the dependency \ > >>> is found by configure? > >> > >> And surely if that's the case for some foo, then --disable wouldn't be > >> needed for that

Re: Update: multimedia/mpv, feedback needed

2016-11-23 Thread Dmitrij D. Czarkoff
Antoine Jacoutot wrote: >>> --enable-foo needs to be explicitely set when the dependency \ >>> is found by configure? >> >> And surely if that's the case for some foo, then --disable wouldn't be >> needed for that foo.. > >--disable-foo is needed because in case a dependency is \ >there at build

Re: Update: multimedia/mpv, feedback needed

2016-11-23 Thread Antoine Jacoutot
On Wed, Nov 23, 2016 at 02:11:27PM +, Stuart Henderson wrote: > On 2016/11/23 14:30, Antoine Jacoutot wrote: > > On Wed, Nov 23, 2016 at 02:05:30PM +0100, Dmitrij D. Czarkoff wrote: > > > Antoine Jacoutot wrote: > > > > > > >> +.if ${FLAVOR:L:Mlite} > > > >> +TOGGLE =disable > > >

Re: Update: multimedia/mpv, feedback needed

2016-11-23 Thread Stuart Henderson
On 2016/11/23 14:30, Antoine Jacoutot wrote: > On Wed, Nov 23, 2016 at 02:05:30PM +0100, Dmitrij D. Czarkoff wrote: > > Antoine Jacoutot wrote: > > > > >> +.if ${FLAVOR:L:Mlite} > > >> +TOGGLE =disable > > >> +.else > > >> +TOGGLE =enable > > > > > >Why using a variable fo

Re: Update: multimedia/mpv, feedback needed

2016-11-23 Thread Antoine Jacoutot
On Wed, Nov 23, 2016 at 02:05:30PM +0100, Dmitrij D. Czarkoff wrote: > Antoine Jacoutot wrote: > > >> +.if ${FLAVOR:L:Mlite} > >> +TOGGLE =disable > >> +.else > >> +TOGGLE =enable > > > >Why using a variable for this? > >Wouldn't this work? > > > >.if ${FLAVOR:L:Mlite} > >

Re: Update: multimedia/mpv, feedback needed

2016-11-23 Thread Josh Grosse
On Wed, Nov 23, 2016 at 01:49:41AM +0100, Dmitrij D. Czarkoff wrote: > Hi! > > I was asked off-list to add a "lite" flavor for multimedia/mpv. This > diff introduces such version. This iteration disables the fllowing in > "lite" FLAVOR: > > * Lua UI and scripting > * Encoding > * DVD and Blu

Re: Update: multimedia/mpv, feedback needed

2016-11-23 Thread Dmitrij D. Czarkoff
Antoine Jacoutot wrote: >> +.if ${FLAVOR:L:Mlite} >> +TOGGLE =disable >> +.else >> +TOGGLE =enable > >Why using a variable for this? >Wouldn't this work? > >.if ${FLAVOR:L:Mlite} >CONFIGURE_ARGS += --disable-foo \ > --disable-bar >... Separate variable is supposed

Re: Update: multimedia/mpv, feedback needed

2016-11-23 Thread Marc Espie
On Wed, Nov 23, 2016 at 01:49:41AM +0100, Dmitrij D. Czarkoff wrote: > Hi! > > I was asked off-list to add a "lite" flavor for multimedia/mpv. This > diff introduces such version. This iteration disables the fllowing in > "lite" FLAVOR: > > * Lua UI and scripting > * Encoding > * DVD and Blu

Re: Update: multimedia/mpv, feedback needed

2016-11-23 Thread Stuart Henderson
You have a number of libraries repeated in WANTLIB (i.e. once for "lite" and again for "no-lite"), could you remove the second one please as it will mean things may get missed when WANTLIB are bulk-synced in the future. Should *input.conf also go to PFRAG.no-lite? I think you disabled all the

Re: Update: multimedia/mpv, feedback needed

2016-11-23 Thread Antoine Jacoutot
On Wed, Nov 23, 2016 at 01:49:41AM +0100, Dmitrij D. Czarkoff wrote: > Hi! > > I was asked off-list to add a "lite" flavor for multimedia/mpv. This > diff introduces such version. This iteration disables the fllowing in > "lite" FLAVOR: > > * Lua UI and scripting > * Encoding > * DVD and Blu

Re: Update: multimedia/mpv, feedback needed

2016-11-22 Thread trondd
On Tue, November 22, 2016 7:49 pm, Dmitrij D. Czarkoff wrote: > Hi! > > I was asked off-list to add a "lite" flavor for multimedia/mpv. This > diff introduces such version. This iteration disables the fllowing in > "lite" FLAVOR: > > * Lua UI and scripting > * Encoding > * DVD and BluRay suppo

Re: Update: multimedia/mpv, feedback needed

2016-11-22 Thread Jeremie Courreges-Anglas
"Dmitrij D. Czarkoff" writes: > Hi! > > I was asked off-list to add a "lite" flavor for multimedia/mpv. This > diff introduces such version. This iteration disables the fllowing in > "lite" FLAVOR: > > * Lua UI and scripting > * Encoding > * DVD and BluRay support > * CDDA > * Samba suppor

Update: multimedia/mpv, feedback needed

2016-11-22 Thread Dmitrij D. Czarkoff
Hi! I was asked off-list to add a "lite" flavor for multimedia/mpv. This diff introduces such version. This iteration disables the fllowing in "lite" FLAVOR: * Lua UI and scripting * Encoding * DVD and BluRay support * CDDA * Samba support * Subtitle reencoding with iconv * SDL2-based dr