Re: p5-Unix-Pledge, this time 0.006

2019-05-13 Thread Stuart Henderson 
On 2019/05/01 22:01, cho...@jtan.com wrote:
> ... this time I've got my tar incantation correct.
> 
> Matthew
> 

I've fixed it up slightly; added $OpenBSD$ markers for cvs to write its IDs.
This version is OK sthen@ if somebody would like to import.

Your tar did not include a subdirectory; for future reference please send
tars from the parent directory, e.g. so files in the archive are like this

p5-Unix-Pledge/Makefile
p5-Unix-Pledge/pkg/PLIST
[..]






p5-Unix-Pledge.tgz
Description: application/tar-gz

Re: p5-Unix-Pledge, this time 0.006

2019-05-01 Thread chohag 
... this time I've got my tar incantation correct.

Matthew



p5-Unix-Pledge-0.006.tgz
Description: p5-Unix-Pledge-0.006.tgz

Re: p5-Unix-Pledge, this time 0.006

2019-05-01 Thread chohag 
Stuart Henderson writes:
> On 2019/05/01 19:42, cho...@jtan.com wrote:
> > What would I put in WANTLIB? The only dependency this module has is
> > OpenBSD 6.4's base system (well strictly speaking, a libc with the
> > pledge and unveil calls).
>
> WANTLIB += c perl

I guess I got unlucky:

void:/usr/ports$ for k in !(pobj)/p5-*; do grep -q WANTLIB $k/Makefile || echo 
$k; done | wc -l
1446
void:/usr/ports$ for k in !(pobj)/p5-*; do grep -q WANTLIB $k/Makefile && echo 
$k; done | wc -l
 244

> check with "make port-lib-depends-check"

All good now, including after a make clean. I also ran throught the
other checklist items and the only problems are missing RCS tag lines,
which obviously I can't do anything about here:

void:/usr/ports/sysutils/p5-Unix-Pledge$ /usr/ports/infrastructure/bin/portcheck
Makefile does not have $OpenBSD$ RCS tag at the top
pkg/PLIST does not have $OpenBSD$ RCS tag at the top
sysutils/p5-Unix-Pledge

> > I can't find examples of license markers I could use. Of the half dozen
> > or so ports I checked, none had anything like it in their Makefile.
> > bsd.port.mk(5) also has nothing to say about it.
>
> Nearly every port has one on a comment on the line immediately before
> the PERMIT_xxx lines.

I should probably have looked at more than just perl ports. Quite
obvious now what the '# perl' I glossed over was for.

I think that's all now. Tarball attached.

Cheers,

Matthew



p5-Unix-Pledge-0.006.tgz
Description: p5-Unix-Pledge-0.006.tgz

Re: p5-Unix-Pledge, this time 0.006

2019-05-01 Thread Ingo Schwarze 
Hi Matthew,

cho...@jtan.com wrote on Wed, May 01, 2019 at 07:42:40PM +0300:
> Stuart Henderson writes:

>> Missing license marker and WANTLIB.

> What would I put in WANTLIB?  The only dependency this module has is
> OpenBSD 6.4's base system (well strictly speaking, a libc with the
> pledge and unveil calls).
> 
> I can't find examples of license markers I could use. Of the half dozen
> or so ports I checked, none had anything like it in their Makefile.
> bsd.port.mk(5) also has nothing to say about it.

https://www.openbsd.org/faq/ports/guide.html

Regarding WANTLIB, look at step 26 "Verify shared library dependencies".

Regarding licensing, look at step 9 and at
/usr/ports/infrastructure/templates/Makefile.template .

Every port has a license marker.
It's the comment line above PERMIT_*.

For even more information, commands like

  $ man -k Ev=WANTLIB

can be helpful.

Yours,
  Ingo

Re: p5-Unix-Pledge, this time 0.006

2019-05-01 Thread Stuart Henderson 
On 2019/05/01 19:42, cho...@jtan.com wrote:
> Stuart Henderson writes:
> > Please send tars not diffs for new ports.
> 
> Will do.
> 
> > Missing license marker and WANTLIB.
> 
> What would I put in WANTLIB? The only dependency this module has is
> OpenBSD 6.4's base system (well strictly speaking, a libc with the
> pledge and unveil calls).

WANTLIB += c perl

check with "make port-lib-depends-check"

> I can't find examples of license markers I could use. Of the half dozen
> or so ports I checked, none had anything like it in their Makefile.
> bsd.port.mk(5) also has nothing to say about it.

Nearly every port has one on a comment on the line immediately before
the PERMIT_xxx lines.

> Cheers,
> 
> Matthew
>

Re: p5-Unix-Pledge, this time 0.006

2019-05-01 Thread chohag 
Stuart Henderson writes:
> Please send tars not diffs for new ports.

Will do.

> Missing license marker and WANTLIB.

What would I put in WANTLIB? The only dependency this module has is
OpenBSD 6.4's base system (well strictly speaking, a libc with the
pledge and unveil calls).

I can't find examples of license markers I could use. Of the half dozen
or so ports I checked, none had anything like it in their Makefile.
bsd.port.mk(5) also has nothing to say about it.

Cheers,

Matthew

Re: p5-Unix-Pledge, this time 0.006

2019-05-01 Thread Stuart Henderson 
On 2019/05/01 12:40, cho...@jtan.com wrote:
> I've sat on this for a while because a) my email setup broke when I
> upgraded my mail client, and b) while I was dealing with that I got a
> message from the upstream author indicating that he's incorporating my
> patch, which makes the diff included below an awful lot smaller.
> 
> On balance, saying that a package called pledge uses pledge seems a bit
> redundant, but them's the rules.
> 
> Cheers,
> 
> Matthew
> 
> diff -urN /tmp/empty/Makefile ./Makefile

Please send tars not diffs for new ports.

> --- /tmp/empty/Makefile Thu Jan  1 03:00:00 1970
> +++ ./Makefile  Wed May  1 12:28:30 2019
> @@ -0,0 +1,14 @@
> +COMMENT=   call pledge(2) and unveil(2) from perl
> +
> +CPAN_AUTHOR=   REF
> +MODULES=   cpan
> +
> +DISTNAME=  Unix-Pledge-0.006
> +CATEGORIES=sysutils
> +# uses pledge()
> +
> +TEST_DEPENDS=  devel/p5-BSD-Resource
> +
> +PERMIT_PACKAGE_CDROM=  Yes

Missing license marker and WANTLIB.

> +
> +.include 
> diff -urN /tmp/empty/distinfo ./distinfo
> --- /tmp/empty/distinfo Thu Jan  1 03:00:00 1970
> +++ ./distinfo  Wed May  1 12:19:38 2019
> @@ -0,0 +1,2 @@
> +SHA256 (Unix-Pledge-0.006.tar.gz) = 
> bWpXSFZd1K24lJIOV8B7GjWFaBSGDXKJI6KzEJvPklA=
> +SIZE (Unix-Pledge-0.006.tar.gz) = 5609
> diff -urN /tmp/empty/pkg/DESCR ./pkg/DESCR
> --- /tmp/empty/pkg/DESCRThu Jan  1 03:00:00 1970
> +++ ./pkg/DESCR Thu Apr 18 19:28:41 2019
> @@ -0,0 +1 @@
> +Call pledge(2) and unveil(2) from perl using Unix::Pledge.
> diff -urN /tmp/empty/pkg/PLIST ./pkg/PLIST
> --- /tmp/empty/pkg/PLISTThu Jan  1 03:00:00 1970
> +++ ./pkg/PLIST Fri Apr 19 08:00:08 2019
> @@ -0,0 +1,3 @@
> +${P5ARCH}/Unix/Pledge.pm
> +${P5ARCH}/auto/Unix/Pledge/Pledge.so
> +@man man/man3p/Unix::Pledge.3p
>

p5-Unix-Pledge, this time 0.006

2019-05-01 Thread chohag 
I've sat on this for a while because a) my email setup broke when I
upgraded my mail client, and b) while I was dealing with that I got a
message from the upstream author indicating that he's incorporating my
patch, which makes the diff included below an awful lot smaller.

On balance, saying that a package called pledge uses pledge seems a bit
redundant, but them's the rules.

Cheers,

Matthew

diff -urN /tmp/empty/Makefile ./Makefile
--- /tmp/empty/Makefile Thu Jan  1 03:00:00 1970
+++ ./Makefile  Wed May  1 12:28:30 2019
@@ -0,0 +1,14 @@
+COMMENT=   call pledge(2) and unveil(2) from perl
+
+CPAN_AUTHOR=   REF
+MODULES=   cpan
+
+DISTNAME=  Unix-Pledge-0.006
+CATEGORIES=sysutils
+# uses pledge()
+
+TEST_DEPENDS=  devel/p5-BSD-Resource
+
+PERMIT_PACKAGE_CDROM=  Yes
+
+.include 
diff -urN /tmp/empty/distinfo ./distinfo
--- /tmp/empty/distinfo Thu Jan  1 03:00:00 1970
+++ ./distinfo  Wed May  1 12:19:38 2019
@@ -0,0 +1,2 @@
+SHA256 (Unix-Pledge-0.006.tar.gz) = 
bWpXSFZd1K24lJIOV8B7GjWFaBSGDXKJI6KzEJvPklA=
+SIZE (Unix-Pledge-0.006.tar.gz) = 5609
diff -urN /tmp/empty/pkg/DESCR ./pkg/DESCR
--- /tmp/empty/pkg/DESCRThu Jan  1 03:00:00 1970
+++ ./pkg/DESCR Thu Apr 18 19:28:41 2019
@@ -0,0 +1 @@
+Call pledge(2) and unveil(2) from perl using Unix::Pledge.
diff -urN /tmp/empty/pkg/PLIST ./pkg/PLIST
--- /tmp/empty/pkg/PLISTThu Jan  1 03:00:00 1970
+++ ./pkg/PLIST Fri Apr 19 08:00:08 2019
@@ -0,0 +1,3 @@
+${P5ARCH}/Unix/Pledge.pm
+${P5ARCH}/auto/Unix/Pledge/Pledge.so
+@man man/man3p/Unix::Pledge.3p