Re: patch: perl.port.mk to support Module::Build::Tiny

2016-03-11 Thread Nigel Taylor
On 03/11/16 21:01, Stuart Henderson wrote: > Here's an updated Module::Build port based on both of ours, plus the > other diffs. I've done it all as an inline diff because the directory > was present previously so it's easier to just cvs add it than import > and fix conflicts. > > We have to keep

Re: patch: perl.port.mk to support Module::Build::Tiny

2016-03-11 Thread Stuart Henderson
Here's an updated Module::Build port based on both of ours, plus the other diffs. I've done it all as an inline diff because the directory was present previously so it's easier to just cvs add it than import and fix conflicts. We have to keep 4 digits or set EPOCH from the start (the port was

Re: patch: perl.port.mk to support Module::Build::Tiny

2016-03-11 Thread Stuart Henderson
On 2016/03/11 12:14, Abel Abraham Camarillo Ojeda wrote: > so right now we can use your provided Module::Build port, then > what is required now is to do some bulk building/testing and see > if anything breaks? I already did a bulk build with Module::Build moved back to ports a few months ago,

Re: patch: perl.port.mk to support Module::Build::Tiny

2016-03-11 Thread Abel Abraham Camarillo Ojeda
On Thu, Mar 10, 2016 at 2:13 PM, Nigel Taylor wrote: > On 03/10/16 01:39, Stuart Henderson wrote: >> On 2016/03/09 15:26, Nigel Taylor wrote: >>> Attached revised perl.port.mk diff >> >> Looks sane, testing this (and cpan.port.mk diff) in a full build now. >> >>>

Re: patch: perl.port.mk to support Module::Build::Tiny

2016-03-10 Thread Nigel Taylor
On 03/10/16 01:39, Stuart Henderson wrote: > On 2016/03/09 15:26, Nigel Taylor wrote: >> Attached revised perl.port.mk diff > > Looks sane, testing this (and cpan.port.mk diff) in a full build now. > >> perl.port.mk.diff_p522 - extras diffs I am using. > > Let's clear Module::Build (which

Re: patch: perl.port.mk to support Module::Build::Tiny

2016-03-09 Thread Stuart Henderson
On 2016/03/09 15:26, Nigel Taylor wrote: > Attached revised perl.port.mk diff Looks sane, testing this (and cpan.port.mk diff) in a full build now. > perl.port.mk.diff_p522 - extras diffs I am using. Let's clear Module::Build (which already triggers warnings and breaks with 5.22) before we look

Re: patch: perl.port.mk to support Module::Build::Tiny

2016-03-09 Thread Abel Abraham Camarillo Ojeda
On Wed, Mar 9, 2016 at 9:26 AM, Nigel Taylor wrote: > On 03/09/16 09:28, Stuart Henderson wrote: >> On 2016/03/09 01:34, Nigel Taylor wrote: >>> This is for later there is no p5-Module-Build yet in the tree, I >>> have one locally in my openbsd-wip. >> >> Me too.

Re: patch: perl.port.mk to support Module::Build::Tiny

2016-03-09 Thread Nigel Taylor
On 03/09/16 09:28, Stuart Henderson wrote: > On 2016/03/09 01:34, Nigel Taylor wrote: >> This is for later there is no p5-Module-Build yet in the tree, I >> have one locally in my openbsd-wip. > > Me too. We could do with getting that committed actually, I'd like to > do a test build with

Re: patch: perl.port.mk to support Module::Build::Tiny

2016-03-09 Thread Stuart Henderson
On 2016/03/09 01:34, Nigel Taylor wrote: > This is for later there is no p5-Module-Build yet in the tree, I > have one locally in my openbsd-wip. Me too. We could do with getting that committed actually, I'd like to do a test build with 5.22 and it's much easier not to have diffs stacked in

Re: patch: perl.port.mk to support Module::Build::Tiny

2016-03-08 Thread Nigel Taylor
On 03/08/16 22:29, Stuart Henderson wrote: > On 2016/03/08 16:41, Nigel Taylor wrote: >> modbuild shouldn't be used but maybe a modtiny style adding an extra >> style doesn't impact existing modbuild ports. > > My build is still running, but no problems to report yet. If nothing > shows up as a

Re: patch: perl.port.mk to support Module::Build::Tiny

2016-03-08 Thread Stuart Henderson
On 2016/03/08 16:41, Nigel Taylor wrote: > modbuild shouldn't be used but maybe a modtiny style adding an extra > style doesn't impact existing modbuild ports. My build is still running, but no problems to report yet. If nothing shows up as a problem I don't see why we couldn't use the same

Re: patch: perl.port.mk to support Module::Build::Tiny

2016-03-08 Thread Nigel Taylor
On 03/08/16 17:01, Abel Abraham Camarillo Ojeda wrote: > On Tue, Mar 8, 2016 at 10:41 AM, Nigel Taylor > wrote: > >> >> Had a better look, depending on how the distribution is generated a >> Makefile.PL may or may not exist. If Makefile.PL doesn't exist Build.PL >>

Re: patch: perl.port.mk to support Module::Build::Tiny

2016-03-08 Thread Abel Abraham Camarillo Ojeda
On Tue, Mar 8, 2016 at 12:29 PM, Nigel Taylor wrote: > On 03/08/16 17:01, Abel Abraham Camarillo Ojeda wrote: >> On Tue, Mar 8, 2016 at 10:41 AM, Nigel Taylor >> wrote: >> >>> >>> Had a better look, depending on how the distribution is

Re: patch: perl.port.mk to support Module::Build::Tiny

2016-03-08 Thread Nigel Taylor
On 03/08/16 15:58, Abel Abraham Camarillo Ojeda wrote: > On Tue, Mar 8, 2016 at 4:18 AM, Nigel Taylor > wrote: >> On 03/08/16 04:52, Abel Abraham Camarillo Ojeda wrote: >>> Module::Build::Tiny according to its docs: >>> >>>Incompatibilities >>>• Argument

Re: patch: perl.port.mk to support Module::Build::Tiny

2016-03-08 Thread Abel Abraham Camarillo Ojeda
On Tue, Mar 8, 2016 at 10:41 AM, Nigel Taylor wrote: > > Had a better look, depending on how the distribution is generated a > Makefile.PL may or may not exist. If Makefile.PL doesn't exist Build.PL > has to be used. These generate a Makefile. > > >

Re: patch: perl.port.mk to support Module::Build::Tiny

2016-03-08 Thread Nigel Taylor
On 03/08/16 10:18, Nigel Taylor wrote: > On 03/08/16 04:52, Abel Abraham Camarillo Ojeda wrote: >> Module::Build::Tiny according to its docs: >> >>Incompatibilities >>• Argument parsing >> >>Module::Build has an extremely permissive way of argument >> handling, >>

Re: patch: perl.port.mk to support Module::Build::Tiny

2016-03-08 Thread Stuart Henderson
On 2016/03/08 09:58, Abel Abraham Camarillo Ojeda wrote: > I don't particularly think the changes I sent could be pushed as-is, but > wanted to discuss about it with a diff in hand :) I think it probably could, as long as the test build works out.

Re: patch: perl.port.mk to support Module::Build::Tiny

2016-03-08 Thread Abel Abraham Camarillo Ojeda
On Tue, Mar 8, 2016 at 4:18 AM, Nigel Taylor wrote: > On 03/08/16 04:52, Abel Abraham Camarillo Ojeda wrote: >> Module::Build::Tiny according to its docs: >> >>Incompatibilities >>• Argument parsing >> >>Module::Build has an extremely

Re: patch: perl.port.mk to support Module::Build::Tiny

2016-03-08 Thread Nigel Taylor
On 03/08/16 04:52, Abel Abraham Camarillo Ojeda wrote: > Module::Build::Tiny according to its docs: > >Incompatibilities >• Argument parsing > >Module::Build has an extremely permissive way of argument handling, >Module::Build::Tiny only supports a (sane)

patch: perl.port.mk to support Module::Build::Tiny

2016-03-07 Thread Abel Abraham Camarillo Ojeda
Module::Build::Tiny according to its docs: Incompatibilities • Argument parsing Module::Build has an extremely permissive way of argument handling, Module::Build::Tiny only supports a (sane) subset of that. In particular, "./Build destdir=/foo" does