Re: [NEW] security/cfssl

2019-12-17 Thread karlis . mikelsons

> do-test:
>cd ${WRKSRC}; ${MODGO_CMD} test github.com/cloudflare/cfssl/...
Thanks for your help and suggestions!

I've adjusted port sent Aaron Bieber following way:
1) removed VERSION variable, use GH_TAGNAME only;


Honestly I preferred that the other way, or you could do something
like

GH_TAGNAME= vXXX
VERSION=${GH_TAGNAME:S/v//}


I updated port to include VERSION variable and also added NO_TEST, 
please see

attached file.

Kind regards,
Karlis

cfssl-v3.tar.gz
Description: GNU Zip compressed data


Re: [NEW] security/cfssl

2019-12-16 Thread Stuart Henderson
On 2019/12/16 16:50, karlis.mikels...@lf.lv wrote:
> > > > post-build:
> > > > rm ${MODGO_WORKSPACE}/bin/example
> > > > mv ${MODGO_WORKSPACE}/bin/mkbundle \
> > > > ${MODGO_WORKSPACE}/bin/cfssl-mkbundle
> > > >
> > > > Naming mkbundle cfssl-mkbundle removes the conflict with mono:
> > > >
> > > >   mono-5.20.1.34p0:lang/mono:/usr/local/bin/mkbundle
> > > >
> > > > Protip: having pkglocatedb installed lets the ports framework warn you 
> > > > of
> > > > such conflicts on 'make plist'!
> > > >
> > > > I have re-attached with the above changes.
> > > 
> > > I think that should use
> > > 
> > > do-build:
> > > cd ${WRKSRC}; ${MODGO_BUILD_CMD}
> > > github.com/cloudflare/cfssl/...
> > > 
> > > otherwise it doesn't use the standard flags (-v, -j #) .. and remove
> > > the
> > > MODGO_FLAGS=-mod=vendor line which AFAIK is currently unused but the
> > > above
> > > brings it in and breaks things.
> > > 
> > > Also either needs NO_TEST or fixing tests.
> > 
> > Ah, good catch. We can still do the tests with this (though, we get some
> > "executable not found in $PATH" failures :P):
> > 
> > do-test:
> > cd ${WRKSRC}; ${MODGO_CMD} test github.com/cloudflare/cfssl/...
> Thanks for your help and suggestions!
> 
> I've adjusted port sent Aaron Bieber following way:
> 1) removed VERSION variable, use GH_TAGNAME only;

Honestly I preferred that the other way, or you could do something
like

GH_TAGNAME= vXXX
VERSION=${GH_TAGNAME:S/v//}

up top in the Makefile, it's a bit unexpected to use ${GH_TAGNAME} lower
in the Makefile so that makes it a bit more obvious.

> 2) removed MODGO_FLAGS;
> 3) build and test commands are now:
> 
> do-build:
> cd ${WRKSRC} && ${MODGO_BUILD_CMD} github.com/cloudflare/cfssl/...
> 
> post-build:
> rm ${MODGO_WORKSPACE}/bin/example
> mv ${MODGO_WORKSPACE}/bin/mkbundle \
> ${MODGO_WORKSPACE}/bin/cfssl-mkbundle
> 
> do-test:
> cd ${WRKSRC} && ${MODGO_TEST_CMD} github.com/cloudflare/cfssl/...
> 
> Unfortunately these tests do not seem to work as one of them prints garbage
> to the console output, and one of them just hangs.
> 
> Kind regards,
> Karlis



Re: [NEW] security/cfssl

2019-12-16 Thread karlis . mikelsons

> post-build:
>rm ${MODGO_WORKSPACE}/bin/example
>mv ${MODGO_WORKSPACE}/bin/mkbundle \
>${MODGO_WORKSPACE}/bin/cfssl-mkbundle
>
> Naming mkbundle cfssl-mkbundle removes the conflict with mono:
>
>   mono-5.20.1.34p0:lang/mono:/usr/local/bin/mkbundle
>
> Protip: having pkglocatedb installed lets the ports framework warn you of
> such conflicts on 'make plist'!
>
> I have re-attached with the above changes.

I think that should use

do-build:
cd ${WRKSRC}; ${MODGO_BUILD_CMD} 
github.com/cloudflare/cfssl/...


otherwise it doesn't use the standard flags (-v, -j #) .. and remove 
the
MODGO_FLAGS=-mod=vendor line which AFAIK is currently unused but the 
above

brings it in and breaks things.

Also either needs NO_TEST or fixing tests.


Ah, good catch. We can still do the tests with this (though, we get 
some

"executable not found in $PATH" failures :P):

do-test:
cd ${WRKSRC}; ${MODGO_CMD} test github.com/cloudflare/cfssl/...

Thanks for your help and suggestions!

I've adjusted port sent Aaron Bieber following way:
1) removed VERSION variable, use GH_TAGNAME only;
2) removed MODGO_FLAGS;
3) build and test commands are now:

do-build:
cd ${WRKSRC} && ${MODGO_BUILD_CMD} github.com/cloudflare/cfssl/...

post-build:
rm ${MODGO_WORKSPACE}/bin/example
mv ${MODGO_WORKSPACE}/bin/mkbundle \
${MODGO_WORKSPACE}/bin/cfssl-mkbundle

do-test:
cd ${WRKSRC} && ${MODGO_TEST_CMD} github.com/cloudflare/cfssl/...

Unfortunately these tests do not seem to work as one of them prints 
garbage

to the console output, and one of them just hangs.

Kind regards,
Karlis


cfssl-v2.tar.gz
Description: GNU Zip compressed data


Re: [NEW] security/cfssl

2019-12-16 Thread Aaron Bieber
On Mon, 16 Dec 2019 at 14:56:53 +, Stuart Henderson wrote:
> On 2019/12/16 07:32, Aaron Bieber wrote:
> > On Mon, 16 Dec 2019 at 11:18:24 +0100, karlis.mikels...@lf.lv wrote:
> > > Hello,
> > > 
> > > Please find attached port for CFSSL latest stable version:
> > > "CFSSL is CloudFlare's PKI/TLS swiss army knife. It is both a command
> > > line tool and an HTTP API server for signing, verifying, and bundling
> > > TLS certificates."
> > 
> > The do-build and do-install bits can be simplified/replaced a bit:
> > 
> > do-build:
> > cd ${WRKSRC}; ${MODGO_CMD} install github.com/cloudflare/cfssl/...
> > 
> > post-build:
> > rm ${MODGO_WORKSPACE}/bin/example
> > mv ${MODGO_WORKSPACE}/bin/mkbundle \
> > ${MODGO_WORKSPACE}/bin/cfssl-mkbundle
> > 
> > Naming mkbundle cfssl-mkbundle removes the conflict with mono:
> > 
> >   mono-5.20.1.34p0:lang/mono:/usr/local/bin/mkbundle
> > 
> > Protip: having pkglocatedb installed lets the ports framework warn you of
> > such conflicts on 'make plist'!
> > 
> > I have re-attached with the above changes.
> 
> I think that should use
> 
> do-build:
> cd ${WRKSRC}; ${MODGO_BUILD_CMD} github.com/cloudflare/cfssl/...
> 
> otherwise it doesn't use the standard flags (-v, -j #) .. and remove the
> MODGO_FLAGS=-mod=vendor line which AFAIK is currently unused but the above
> brings it in and breaks things.
> 
> Also either needs NO_TEST or fixing tests.

Ah, good catch. We can still do the tests with this (though, we get some
"executable not found in $PATH" failures :P):

do-test:
cd ${WRKSRC}; ${MODGO_CMD} test github.com/cloudflare/cfssl/...

-- 
PGP: 0x1F81112D62A9ADCE / 3586 3350 BFEA C101 DB1A  4AF0 1F81 112D 62A9 ADCE



Re: [NEW] security/cfssl

2019-12-16 Thread Stuart Henderson
On 2019/12/16 07:32, Aaron Bieber wrote:
> On Mon, 16 Dec 2019 at 11:18:24 +0100, karlis.mikels...@lf.lv wrote:
> > Hello,
> > 
> > Please find attached port for CFSSL latest stable version:
> > "CFSSL is CloudFlare's PKI/TLS swiss army knife. It is both a command
> > line tool and an HTTP API server for signing, verifying, and bundling
> > TLS certificates."
> 
> The do-build and do-install bits can be simplified/replaced a bit:
> 
> do-build:
>   cd ${WRKSRC}; ${MODGO_CMD} install github.com/cloudflare/cfssl/...
> 
> post-build:
>   rm ${MODGO_WORKSPACE}/bin/example
>   mv ${MODGO_WORKSPACE}/bin/mkbundle \
>   ${MODGO_WORKSPACE}/bin/cfssl-mkbundle
> 
> Naming mkbundle cfssl-mkbundle removes the conflict with mono:
> 
>   mono-5.20.1.34p0:lang/mono:/usr/local/bin/mkbundle
> 
> Protip: having pkglocatedb installed lets the ports framework warn you of
> such conflicts on 'make plist'!
> 
> I have re-attached with the above changes.

I think that should use

do-build:
cd ${WRKSRC}; ${MODGO_BUILD_CMD} github.com/cloudflare/cfssl/...

otherwise it doesn't use the standard flags (-v, -j #) .. and remove the
MODGO_FLAGS=-mod=vendor line which AFAIK is currently unused but the above
brings it in and breaks things.

Also either needs NO_TEST or fixing tests.



Re: [NEW] security/cfssl

2019-12-16 Thread Aaron Bieber
On Mon, 16 Dec 2019 at 11:18:24 +0100, karlis.mikels...@lf.lv wrote:
> Hello,
> 
> Please find attached port for CFSSL latest stable version:
> "CFSSL is CloudFlare's PKI/TLS swiss army knife. It is both a command
> line tool and an HTTP API server for signing, verifying, and bundling
> TLS certificates."

The do-build and do-install bits can be simplified/replaced a bit:

do-build:
cd ${WRKSRC}; ${MODGO_CMD} install github.com/cloudflare/cfssl/...

post-build:
rm ${MODGO_WORKSPACE}/bin/example
mv ${MODGO_WORKSPACE}/bin/mkbundle \
${MODGO_WORKSPACE}/bin/cfssl-mkbundle

Naming mkbundle cfssl-mkbundle removes the conflict with mono:

  mono-5.20.1.34p0:lang/mono:/usr/local/bin/mkbundle

Protip: having pkglocatedb installed lets the ports framework warn you of
such conflicts on 'make plist'!

I have re-attached with the above changes.

OK abieber@ to import if anyone wants to :D

> 
> Kind regards,
> Karlis



-- 
PGP: 0x1F81112D62A9ADCE / 3586 3350 BFEA C101 DB1A  4AF0 1F81 112D 62A9 ADCE


cfssl.tgz
Description: Binary data