Re: Parallel cmake (diff to review)

2012-12-14 Thread Kent R. Spillner
Hey, dude- Our make passes -j through MAKEFLAGS. The way it handles recursive invocation is documented. Read the end of make(1): Thanks for the cluestick! I apologize for not seeing that paragraph earlier. I'm corresponding with Amit privately to try and track down the root cause. Best,

Re: using cmake in parallel builds, Re: Parallel cmake (diff to review)

2012-12-13 Thread Stuart Henderson
I think we now have the critical path to libreoffice building quickly enough that it's not going to reduce the overall dpb build time (the problem DPB_PROPERTIES=parallel intends to solve is waiting for libreoffice to finish when everything else is done. Moving to gmake may actually increase

Re: using cmake in parallel builds, Re: Parallel cmake (diff to review)

2012-12-13 Thread Marc Espie
On Wed, Dec 12, 2012 at 06:21:43PM -0600, Amit Kulkarni wrote: I thought you guys were talking about building cmake proper in parallel. We did. cmake proper first builds a minimal bootstrap cmake, then rebuilds itself with it, so getting cmake proper to build in parallel *is* the same

Re: Parallel cmake (diff to review)

2012-12-13 Thread Marc Espie
On Wed, Dec 12, 2012 at 09:32:23AM -0600, Kent R. Spillner wrote: Hey, dude- On Dec 12, 2012, at 7:51, David Coppa dco...@gmail.com wrote: Thanks. I'll wait for useful pointers... I don't think CMake does anything specifically to handle parallel recursive builds. It works with GNU

Re: using cmake in parallel builds, Re: Parallel cmake (diff to review)

2012-12-13 Thread Amit Kulkarni
No, our make is not ignoring -j, and it's passed to submakes. Using standard posix mechanisms. That is, it's passed through the environment, using MAKEFLAGS. There are two ways to defeat that mechanism: either by explicitly wiping out the environment, or by passing another -j somewhere.

Re: using cmake in parallel builds, Re: Parallel cmake (diff to review)

2012-12-13 Thread David Coppa
On Thu, Dec 13, 2012 at 3:39 PM, Amit Kulkarni amitk...@gmail.com wrote: No, our make is not ignoring -j, and it's passed to submakes. Using standard posix mechanisms. That is, it's passed through the environment, using MAKEFLAGS. There are two ways to defeat that mechanism: either by

Re: Parallel cmake (diff to review)

2012-12-12 Thread David Coppa
On Tue, 11 Dec 2012, Amit Kulkarni wrote: I tried with USE_GMAKE = Yes and it drives all cores so I think please add CONFIGURE_ARGS = --parallel=${MAKE_JOBS} and USE_GMAKE = Yes and then both configure and build will go parallel. ... The use of GNU make like this seems

Re: Parallel cmake (diff to review)

2012-12-12 Thread Landry Breuil
On Wed, Dec 12, 2012 at 12:48:09PM +0100, David Coppa wrote: On Tue, 11 Dec 2012, Amit Kulkarni wrote: I tried with USE_GMAKE = Yes and it drives all cores so I think please add CONFIGURE_ARGS = --parallel=${MAKE_JOBS} and USE_GMAKE = Yes and then both configure and

Re: Parallel cmake (diff to review)

2012-12-12 Thread Vadim Zhukov
12.12.2012 15:55 пользователь David Coppa dco...@gmail.com написал: On Tue, 11 Dec 2012, Amit Kulkarni wrote: I tried with USE_GMAKE = Yes and it drives all cores so I think please add CONFIGURE_ARGS = --parallel=${MAKE_JOBS} and USE_GMAKE = Yes and then both configure

Re: Parallel cmake (diff to review)

2012-12-12 Thread David Coppa
On Wed, Dec 12, 2012 at 1:09 PM, Vadim Zhukov persg...@gmail.com wrote: Until this go in (if ever), could please anyone make clear a few things? 1. USE_GMAKE=Yes in CMake's port enables parallel build of CMake itself only, or does it equate to setting USE_GMAKE=Yes to all CMake-based ports

Re: Parallel cmake (diff to review)

2012-12-12 Thread Stuart Henderson
On 2012/12/12 15:09, Vadim Zhukov wrote: 2. Do we have to set USE_GMAKE=Yes for each CMake-based port where we want to achieve parallel building (at least until problem with our make and CMake is fixed)? in testing, it seems so. weird though, I was pretty sure I'd seen an improvement from

Re: Parallel cmake (diff to review)

2012-12-12 Thread Amit Kulkarni
2. Do we have to set USE_GMAKE=Yes for each CMake-based port where we want to achieve parallel building (at least until problem with our make and CMake is fixed)? in testing, it seems so. weird though, I was pretty sure I'd seen an improvement from doing this in the past, so either I was

Re: Parallel cmake (diff to review)

2012-12-12 Thread David Coppa
On Wed, Dec 12, 2012 at 2:44 PM, Amit Kulkarni amitk...@gmail.com wrote: 2. Do we have to set USE_GMAKE=Yes for each CMake-based port where we want to achieve parallel building (at least until problem with our make and CMake is fixed)? in testing, it seems so. weird though, I was pretty

using cmake in parallel builds, Re: Parallel cmake (diff to review)

2012-12-12 Thread Marc Espie
Very bad subject line, I almost did not read the thread, because I thought you guys were talking about building cmake proper in parallel. Anyways, there are TWO distinct points: - problems with make -j. - cmake not writing correct makefiles for parallel building without gmake. I haven't looked

Re: using cmake in parallel builds, Re: Parallel cmake (diff to review)

2012-12-12 Thread David Coppa
On Wed, 12 Dec 2012, Marc Espie wrote: Very bad subject line, I almost did not read the thread, because I thought you guys were talking about building cmake proper in parallel. Anyways, there are TWO distinct points: - problems with make -j. - cmake not writing correct makefiles for

Re: using cmake in parallel builds, Re: Parallel cmake (diff to review)

2012-12-12 Thread Christian Weisgerber
Marc Espie: I thought you guys were talking about building cmake proper in parallel. We did. cmake proper first builds a minimal bootstrap cmake, then rebuilds itself with it, so getting cmake proper to build in parallel *is* the same problem as getting any other cmake-using port to build in

Re: using cmake in parallel builds, Re: Parallel cmake (diff to review)

2012-12-12 Thread Marc Espie
On Wed, Dec 12, 2012 at 04:52:17PM +0100, Christian Weisgerber wrote: Marc Espie: I thought you guys were talking about building cmake proper in parallel. We did. cmake proper first builds a minimal bootstrap cmake, then rebuilds itself with it, so getting cmake proper to build in

Re: Parallel cmake (diff to review)

2012-12-12 Thread Kent R. Spillner
Hey, dude- On Dec 12, 2012, at 7:51, David Coppa dco...@gmail.com wrote: Thanks. I'll wait for useful pointers... I don't think CMake does anything specifically to handle parallel recursive builds. It works with GNU make because when invoked with -jX the top level gmake sets some

Re: using cmake in parallel builds, Re: Parallel cmake (diff to review)

2012-12-12 Thread Kent R. Spillner
Hey, dude- On Dec 12, 2012, at 9:30, Marc Espie es...@nerim.net wrote: Anyways, there are TWO distinct points: - problems with make -j. - cmake not writing correct makefiles for parallel building without gmake. The second one is the problem here. CMake doesn't do anything special for

Re: using cmake in parallel builds, Re: Parallel cmake (diff to review)

2012-12-12 Thread Amit Kulkarni
On Wed, Dec 12, 2012 at 9:48 AM, Kent R. Spillner kspill...@acm.org wrote: Hey, dude- On Dec 12, 2012, at 9:30, Marc Espie es...@nerim.net wrote: Anyways, there are TWO distinct points: - problems with make -j. - cmake not writing correct makefiles for parallel building without gmake.

Re: using cmake in parallel builds, Re: Parallel cmake (diff to review)

2012-12-12 Thread Amit Kulkarni
I thought you guys were talking about building cmake proper in parallel. We did. cmake proper first builds a minimal bootstrap cmake, then rebuilds itself with it, so getting cmake proper to build in parallel *is* the same problem as getting any other cmake-using port to build in parallel.

Re: using cmake in parallel builds, Re: Parallel cmake (diff to review)

2012-12-12 Thread Vadim Zhukov
13.12.2012 4:22 пользователь Amit Kulkarni amitk...@gmail.com написал: I thought you guys were talking about building cmake proper in parallel. We did. cmake proper first builds a minimal bootstrap cmake, then rebuilds itself with it, so getting cmake proper to build in parallel *is*

Re: using cmake in parallel builds, Re: Parallel cmake (diff to review)

2012-12-12 Thread David Coppa
On Thu, Dec 13, 2012 at 7:01 AM, Vadim Zhukov persg...@gmail.com wrote: 13.12.2012 4:22 пользователь Amit Kulkarni amitk...@gmail.com написал: I thought you guys were talking about building cmake proper in parallel. We did. cmake proper first builds a minimal bootstrap cmake, then