Re: UPDATE: graphics/farbfeld 3 -> 4

2018-04-28 Thread Stuart Henderson
Btw (as was done in the certain that got committed), as long as it doesn't call make recursively, just use MAKE_FLAGS and it overrides variables from the file, so there's no need to patch with ?=. -- Sent from a phone, apologies for poor formatting. On 28 April 2018 16:40:39 Kaashif Hymabaccus

Re: UPDATE: graphics/farbfeld 3 -> 4

2018-04-28 Thread Kaashif Hymabaccus
On Sat, Apr 28, 2018 at 03:11:08PM +0100, Stuart Henderson wrote: > Please don't rely on the cc wrapper. It's a hack for certain situations. > Also it's easier to verify that a port does the right thing if CC is > passed correctly. OK, here is a diff that leaves the CC stuff as it was, passed in M

Re: UPDATE: graphics/farbfeld 3 -> 4

2018-04-28 Thread Stuart Henderson
On 2018/04/28 00:07, Kaashif Hymabaccus wrote: > On Sat, Apr 14, 2018 at 01:03:09AM +0200, Klemens Nanni wrote: > > > > [...] > > > > Now that you're rolling your own do-install, this hunk is obsolete. > > > > [...] > > > > CC is already passed in MAKE_ENV, this can go, too. > > > > Addressed th

Re: UPDATE: graphics/farbfeld 3 -> 4

2018-04-28 Thread Solene Rapenne
Klemens Nanni writes: > On Sat, Apr 28, 2018 at 12:07:14AM +0100, Kaashif Hymabaccus wrote: >> On Sat, Apr 14, 2018 at 01:03:09AM +0200, Klemens Nanni wrote: >> > >> > [...] >> > >> > Now that you're rolling your own do-install, this hunk is obsolete. >> > >> > [...] >> > >> > CC is already pass

Re: UPDATE: graphics/farbfeld 3 -> 4

2018-04-28 Thread Klemens Nanni
On Sat, Apr 28, 2018 at 12:07:14AM +0100, Kaashif Hymabaccus wrote: > On Sat, Apr 14, 2018 at 01:03:09AM +0200, Klemens Nanni wrote: > > > > [...] > > > > Now that you're rolling your own do-install, this hunk is obsolete. > > > > [...] > > > > CC is already passed in MAKE_ENV, this can go, too. >

Re: UPDATE: graphics/farbfeld 3 -> 4

2018-04-27 Thread Kaashif Hymabaccus
On Sat, Apr 14, 2018 at 01:03:09AM +0200, Klemens Nanni wrote: > > [...] > > Now that you're rolling your own do-install, this hunk is obsolete. > > [...] > > CC is already passed in MAKE_ENV, this can go, too. > Addressed these comments. Also there was a hardcoded -Os in the CFLAGS I patched ou

Re: UPDATE: graphics/farbfeld 3 -> 4

2018-04-13 Thread Klemens Nanni
On Fri, Apr 13, 2018 at 11:09:07PM +0100, Kaashif Hymabaccus wrote: > On Thu, Apr 12, 2018 at 10:23:56AM +0200, Klemens Nanni wrote: > > On Thu, Apr 12, 2018 at 01:52:48AM +0100, Kaashif Hymabaccus wrote: > > > This is an update to graphics/farbfeld. The main change to the port is > > > that USE_GM

Re: UPDATE: graphics/farbfeld 3 -> 4

2018-04-13 Thread Kaashif Hymabaccus
On Thu, Apr 12, 2018 at 10:23:56AM +0200, Klemens Nanni wrote: > On Thu, Apr 12, 2018 at 01:52:48AM +0100, Kaashif Hymabaccus wrote: > > This is an update to graphics/farbfeld. The main change to the port is > > that USE_GMAKE isn't needed any more. > > > > Works fine for me on amd64 (converted so

Re: UPDATE: graphics/farbfeld 3 -> 4

2018-04-12 Thread Klemens Nanni
On Thu, Apr 12, 2018 at 01:52:48AM +0100, Kaashif Hymabaccus wrote: > This is an update to graphics/farbfeld. The main change to the port is > that USE_GMAKE isn't needed any more. > > Works fine for me on amd64 (converted some images to ff and back, > still seems to work). Can you provide a simpl

UPDATE: graphics/farbfeld 3 -> 4

2018-04-11 Thread Kaashif Hymabaccus
Hello ports@ This is an update to graphics/farbfeld. The main change to the port is that USE_GMAKE isn't needed any more. Works fine for me on amd64 (converted some images to ff and back, still seems to work). diff --git Makefile Makefile index 8d499d1ad33..1b49fcc3fa1 100644 --- Makefile +++ Ma