Btw (as was done in the certain that got committed), as long as it doesn't
call make recursively, just use MAKE_FLAGS and it overrides variables from
the file, so there's no need to patch with ?=.
--
Sent from a phone, apologies for poor formatting.
On 28 April 2018 16:40:39 Kaashif Hymabaccus
On Sat, Apr 28, 2018 at 03:11:08PM +0100, Stuart Henderson wrote:
> Please don't rely on the cc wrapper. It's a hack for certain situations.
> Also it's easier to verify that a port does the right thing if CC is
> passed correctly.
OK, here is a diff that leaves the CC stuff as it was, passed in
M
On 2018/04/28 00:07, Kaashif Hymabaccus wrote:
> On Sat, Apr 14, 2018 at 01:03:09AM +0200, Klemens Nanni wrote:
> >
> > [...]
> >
> > Now that you're rolling your own do-install, this hunk is obsolete.
> >
> > [...]
> >
> > CC is already passed in MAKE_ENV, this can go, too.
> >
>
> Addressed th
Klemens Nanni writes:
> On Sat, Apr 28, 2018 at 12:07:14AM +0100, Kaashif Hymabaccus wrote:
>> On Sat, Apr 14, 2018 at 01:03:09AM +0200, Klemens Nanni wrote:
>> >
>> > [...]
>> >
>> > Now that you're rolling your own do-install, this hunk is obsolete.
>> >
>> > [...]
>> >
>> > CC is already pass
On Sat, Apr 28, 2018 at 12:07:14AM +0100, Kaashif Hymabaccus wrote:
> On Sat, Apr 14, 2018 at 01:03:09AM +0200, Klemens Nanni wrote:
> >
> > [...]
> >
> > Now that you're rolling your own do-install, this hunk is obsolete.
> >
> > [...]
> >
> > CC is already passed in MAKE_ENV, this can go, too.
>
On Sat, Apr 14, 2018 at 01:03:09AM +0200, Klemens Nanni wrote:
>
> [...]
>
> Now that you're rolling your own do-install, this hunk is obsolete.
>
> [...]
>
> CC is already passed in MAKE_ENV, this can go, too.
>
Addressed these comments. Also there was a hardcoded -Os in the CFLAGS
I patched ou
On Fri, Apr 13, 2018 at 11:09:07PM +0100, Kaashif Hymabaccus wrote:
> On Thu, Apr 12, 2018 at 10:23:56AM +0200, Klemens Nanni wrote:
> > On Thu, Apr 12, 2018 at 01:52:48AM +0100, Kaashif Hymabaccus wrote:
> > > This is an update to graphics/farbfeld. The main change to the port is
> > > that USE_GM
On Thu, Apr 12, 2018 at 10:23:56AM +0200, Klemens Nanni wrote:
> On Thu, Apr 12, 2018 at 01:52:48AM +0100, Kaashif Hymabaccus wrote:
> > This is an update to graphics/farbfeld. The main change to the port is
> > that USE_GMAKE isn't needed any more.
> >
> > Works fine for me on amd64 (converted so
On Thu, Apr 12, 2018 at 01:52:48AM +0100, Kaashif Hymabaccus wrote:
> This is an update to graphics/farbfeld. The main change to the port is
> that USE_GMAKE isn't needed any more.
>
> Works fine for me on amd64 (converted some images to ff and back,
> still seems to work).
Can you provide a simpl
Hello ports@
This is an update to graphics/farbfeld. The main change to the port is
that USE_GMAKE isn't needed any more.
Works fine for me on amd64 (converted some images to ff and back,
still seems to work).
diff --git Makefile Makefile
index 8d499d1ad33..1b49fcc3fa1 100644
--- Makefile
+++ Ma
10 matches
Mail list logo