[pfx-dev] Re: Typos

2024-04-20 Thread Wietse Venema via Postfix-devel
Thanks for the improvements. I'm considering to discontinue the web pages with third-party links. It was a nice idea but thinks are out of date in no time. Wietse ___ Postfix-devel mailing list -- postfix-devel@postfix.org To unsubscribe send an

[pfx-dev] Re: MongoDB support

2024-02-15 Thread Wietse Venema via Postfix-devel
Wietse Venema via Postfix-devel: > And there is an even simpler workaround: an empty statement. > > case BSON_TYPE_ARRAY: >/* Empty statement for pre-C23 Clang. */ ; >const uint8_t *dataBuffer = NULL; >/* other existing code */ > default

[pfx-dev] Re: MongoDB support

2024-02-15 Thread Wietse Venema via Postfix-devel
Herbert J. Skuhra via Postfix-devel: > Hi Wietse, > > On Thu, 15 Feb 2024 15:18:20 +0100, Wietse Venema via Postfix-devel wrote: > > > > Herbert J. Skuhra via Postfix-devel: > > > Hi, > > > > > > I am trying to build Postfix-3.9 (20240213) with Mo

[pfx-dev] Re: MongoDB support

2024-02-15 Thread Wietse Venema via Postfix-devel
Herbert J. Skuhra via Postfix-devel: > Hi, > > I am trying to build Postfix-3.9 (20240213) with MongoDB support. > Using clang the build fails: > > dict_mongodb.c:258:6: error: expected expression > 258 | const uint8_t *dataBuffer = NULL; > | ^ uint8_t is defined

[pfx-dev] Re: pfx 3.8.4 build noise: "warning: missing braces around initializer [-Wmissing-braces]"

2023-12-26 Thread Wietse Venema via Postfix-devel
Viktor Dukhovni via Postfix-devel: > On Tue, Dec 26, 2023 at 04:16:18PM -0500, Viktor Dukhovni via Postfix-devel > wrote: > > > If I enable "-Wall", I get the noisy warnings, and they can all be > > disabled by adding: > > > > -Wno-missing-braces > > -Wmaybe-uninitialized > >

[pfx-dev] Re: pfx 3.8.4 build noise: "warning: missing braces around initializer [-Wmissing-braces]"

2023-12-26 Thread Wietse Venema via Postfix-devel
pgnd via Postfix-devel: > grep missing-braces tmp.txt > dict.c:627:38: warning: missing braces around initializer > [-Wmissing-braces] > dict_open.c:371:48: warning: missing braces around initializer > [-Wmissing-braces] You are building Postfix from source

[pfx-dev] dict_mongodb update

2023-12-08 Thread Wietse Venema via Postfix-devel
I added RFC 4627 JSON string quoting for the %letter substitutions in the (query_)filter MongoDB parameter. For this, I updated the existing json quoting function that was implemented for "postqueue -j", and made it a library function (src/util/quote_for_json.c). This means you can't just copy

[pfx-dev] Re: dict_mongodb (projections)

2023-12-06 Thread Wietse Venema via Postfix-devel
Sorry, I was confusing query and result processing. The first needs to be secured. The second is garbage in, garbage out. Wietse ___ Postfix-devel mailing list -- postfix-devel@postfix.org To unsubscribe send an email to

[pfx-dev] Re: dict_mongodb (projections)

2023-12-06 Thread Wietse Venema via Postfix-devel
I have been adding text to the mongodb_table that any text pasted in the place of a %letter directive in result_format will be subject to escaping, that is, Postfix inserts a backslash character before a double quote or backslash character. This ensures that the result will have the same

[pfx-dev] Re: dict_mongodb

2023-12-06 Thread Wietse Venema via Postfix-devel
Hamid Maadani via Postfix-devel: > Ok, compiled with driver 1.23.4 and have no more linking issues. > I noticed if I have docker_va_filter parameter, it throws: > Dec 06 22:32:49 mail postfix/proxymap[202]: fatal: bad string length 0 < 1: > docker_va_query_filter = > > I think line 168 needs to

[pfx-dev] Re: dict_mongodb

2023-12-06 Thread Wietse Venema via Postfix-devel
Hamid Maadani: > > If the configuration says $$or, what code shall responsible for > > treating this as $or? The Postfix cfg_parser does not do that, and > > dict_mongodb.c will pass $$or into the mongo-c library. > > It does not? I might totally be me misunderstanding the documentation, Only

[pfx-dev] Re: dict_mongodb

2023-12-06 Thread Wietse Venema via Postfix-devel
Viktor Dukhovni via Postfix-devel: > On Wed, Dec 06, 2023 at 08:10:22PM +, Hamid Maadani via Postfix-devel > wrote: > > > now, in my case, I'm using a docker container, and am using parameters > > in main.cf , a sample below: > > docker_va_uri = $docker_dburi > > docker_va_dbname =

[pfx-dev] Re: dict_mongodb

2023-12-06 Thread Wietse Venema via Postfix-devel
Hamid Maadani via Postfix-devel: > > What code is supposed to pay attention to '$' characters? The Postfix > > client? > > The MongoC library? > > In MQL, you have operators like "$or", or you can use the value of a field > like "$field". These are instances that the person configuring postfix

[pfx-dev] Re: dict_mongodb

2023-12-06 Thread Wietse Venema via Postfix-devel
Wietse Venema via Postfix-devel: > Hamid Maadani via Postfix-devel: > > > There was a missing update to the makedefs script (in the top-level > > > directory). The updated code is at > > > https://github.com/wietse-postfix/postfix-dukhovni/tree/mongodb > >

[pfx-dev] Re: dict_mongodb

2023-12-06 Thread Wietse Venema via Postfix-devel
Hamid Maadani via Postfix-devel: > > There was a missing update to the makedefs script (in the top-level > > directory). The updated code is at > > https://github.com/wietse-postfix/postfix-dukhovni/tree/mongodb > > hmm.. I'm still getting the same type of error after a rebuild: > Dec 06 17:32:07

[pfx-dev] Re: dict_mongodb

2023-12-06 Thread Wietse Venema via Postfix-devel
Hamid Maadani via Postfix-devel: > > Can you copy the dict_mongodb.* files into your environment and see > > what I broke? They should still build with postfix-3.8-20220527. > > I just did, and they build fine. However, I get a linking error when trying > to use the library: > "Dec 05 23:45:05

[pfx-dev] Re: dict_mongodb

2023-12-05 Thread Wietse Venema via Postfix-devel
Hamid Maadani via Postfix-devel: > > Can you copy the dict_mongodb.* files into your environment and see > > what I broke? They should still build with postfix-3.8-20220527. > > I just did, and they build fine. However, I get a linking error when trying > to use the library: > "Dec 05 23:45:05

[pfx-dev] Re: dict_mongodb

2023-12-03 Thread Wietse Venema via Postfix-devel
Hamid Maadani via Postfix-devel: > Yes sir. the last two commit in this branch should cover everything needed: > https://github.com/21stcaveman/postfix/tree/mongodb I forked Viktor's repo and added a version of your code and documentation relative to the last Postfix 3.9 development release. The

[pfx-dev] Re: dict_mongodb

2023-11-30 Thread Wietse Venema via Postfix-devel
Hamid Maadani via Postfix-devel: > Yes sir. the last two commit in this branch should cover everything needed: > https://github.com/21stcaveman/postfix/tree/mongodb Got it. The diffs of this code against postfix-3.8-20220527 will apply easily to Postfix 3.9. I'm making first pass over the code

[pfx-dev] Re: dict_mongodb

2023-11-29 Thread Wietse Venema via Postfix-devel
Viktor Dukhovni (27 Jun 2022): > After that, Wietse and I will have to find some time for code > review. This may take a bit of time, but should ideally happen in > time for 3.8.0, and so naturally would need to be complete a few > snapshots earlier. hamid via Postfix-devel: > Was doing some

[pfx-dev] Re: Bug in Dovecot SASL driver: authentication failure reason is wrong

2023-11-02 Thread Wietse Venema via Postfix-devel
Stephan Bosch via Postfix-devel: > Looks like Postfix [...] somehow uses the data from the previous CONT auth > service > response as the reason. Does this patch address the problem? It resets any previous Dovecot auth service response before parsing the next Dovecot auth server response.

[pfx-dev] Re: Bug in Dovecot SASL driver: authentication failure reason is wrong

2023-11-01 Thread Wietse Venema via Postfix-devel
Just to be 100% clear, is the problem that the error message is wrong, or that the fail/pass status is wrong, or both, or something else? Wietse ___ Postfix-devel mailing list -- postfix-devel@postfix.org To unsubscribe send an email to

[pfx-dev] Re: redis patch

2023-10-01 Thread Wietse Venema via Postfix-devel
Christophe Kalt via Postfix-devel: > Hi folks, > > https://www.mail-archive.com/postfix-devel@postfix.org/msg00952.html has > what looks like a nearly complete patch to support redis from 2.5 years > ago. Wondering whether this didn't get included in a subsequent release > because of the TODOs,

[pfx-dev] Re: Submission service lookup support

2023-05-16 Thread Wietse Venema via Postfix-devel
Wietse Venema via Postfix-devel: > > There is an unnecessary double check of the "addr_list" pointer for null > > (twice). It does no harm, and a good compiler will remove that test. > Generally, I don't worry about repeated tests like this. They make > Postfix c

[pfx-dev] Re: Submission service lookup support

2023-05-16 Thread Wietse Venema via Postfix-devel
Tomas Korbar via Postfix-devel: > Hi guys, > I am continuing in this thread since it's related to the SRV resolution > feature. > During incorporation of this feature to Fedora and RHEL, static analysis > found some > minor flaws that I want to report and propose addressing them. > > There is an

[pfx-dev] Re: NIT: compile warning for implicit truncation

2023-03-19 Thread Wietse Venema via Postfix-devel
Eray Aslan via Postfix-devel: > Hi, > > With postfix-3.8-20230314: > > clang -fPIC -I. -I../../include -DHAS_PCRE=2 -DUSE_TLS -DHAS_LMDB -DNO_NIS > -DNO_DB -DDEF_DB_TYPE=\"lmdb\" -DHAS_CDB -I/usr/include/cdb -DHAS_DEV_URANDOM > -DSNAPSHOT -DDEF_SHLIB_DIR=\"/usr/lib64/postfix/\${mail_version}\"

[P-D] Postfix lists have migrated to a new list manager

2023-03-07 Thread Wietse Venema via Postfix-devel
The Postfix mailing list migration should be complete by now, except for some old messages that may still be queued on some mail servers. I'll manually handle any sub/unsubscribe requests that may still arrive at the old address. See below for the pre-migration announcement, with a summary of