Re: Parameter name code/doc mismatch: tlsproxy_client_level != tlsproxy_client_security_level tlsproxy_client_level

2021-12-20 Thread Wietse Venema
Raj, I'm taking some time during the end-of-year break to work on your documentation etc. fixes. First I did a global analysis of of tlsproxy parameter names, both the client and server side, how they differ from the corresponding smtpd_ or smtp_ parameter names. This revealed one more parameter

Re: Parameter name code/doc mismatch: tlsproxy_client_level != tlsproxy_client_security_level tlsproxy_client_level

2021-09-24 Thread raf
On Fri, Sep 24, 2021 at 11:54:29AM -0400, Viktor Dukhovni wrote: > On Sat, Sep 25, 2021 at 01:08:29AM +1000, raf wrote: > > > Also, the following look like they are defined in > > mail_params.h but they aren't in postconf.proto > > (20210815 snapshot). This might be wrong. It's just a > >

Re: Parameter name code/doc mismatch: tlsproxy_client_level != tlsproxy_client_security_level tlsproxy_client_level

2021-09-24 Thread Viktor Dukhovni
> On 24 Sep 2021, at 12:57 pm, Wietse Venema wrote: > >> It is perhaps time to drop support for some of the Postfix <= 2.2 >> TLS parameters. Which can simplify the pile of booleans to just >> a single security level and then perhaps simply: >> >>tlsproxy_client_enable = >>

Re: Parameter name code/doc mismatch: tlsproxy_client_level != tlsproxy_client_security_level tlsproxy_client_level

2021-09-24 Thread Wietse Venema
Viktor Dukhovni: > It is perhaps time to drop support for some of the Postfix <= 2.2 > TLS parameters. Which can simplify the pile of booleans to just > a single security level and then perhaps simply: > > tlsproxy_client_enable = > ${smtp_tls_policy_maps ? {yes} : >

Re: Parameter name code/doc mismatch: tlsproxy_client_level != tlsproxy_client_security_level tlsproxy_client_level

2021-09-24 Thread Viktor Dukhovni
On Sat, Sep 25, 2021 at 01:08:29AM +1000, raf wrote: > Also, the following look like they are defined in > mail_params.h but they aren't in postconf.proto > (20210815 snapshot). This might be wrong. It's just a > quick hacky audit. Some of them might not be real > parameters. There is no

Re: Parameter name code/doc mismatch: tlsproxy_client_level != tlsproxy_client_security_level tlsproxy_client_level

2021-09-24 Thread raf
On Fri, Sep 24, 2021 at 09:49:49AM -0400, Wietse Venema wrote: > raf: > > Hi, > > > > I think there's a parameter name that is rightish/better > > in the documentation but wrong/worse in the code. > > Added to the queue. > > Wietse Thanks. Similarly, there's a parameter called

Re: Parameter name code/doc mismatch: tlsproxy_client_level != tlsproxy_client_security_level tlsproxy_client_level

2021-09-24 Thread Wietse Venema
raf: > Hi, > > I think there's a parameter name that is rightish/better > in the documentation but wrong/worse in the code. Added to the queue. Wietse > $ postconf -d | grep security_level > lmtp_tls_security_level = > postscreen_tls_security_level = $smtpd_tls_security_level >

Parameter name code/doc mismatch: tlsproxy_client_level != tlsproxy_client_security_level tlsproxy_client_level

2021-09-24 Thread raf
Hi, I think there's a parameter name that is rightish/better in the documentation but wrong/worse in the code. $ postconf -d | grep security_level lmtp_tls_security_level = postscreen_tls_security_level = $smtpd_tls_security_level smtp_tls_security_level = smtpd_tls_security_level =