Re: milter library for PHP (libMilterPHP)

2022-12-14 Thread mailmary
Thank you, I'll take a look! On Wed, 14 Dec 2022 11:29:05 -0500 (EST) Wietse Venema wrote: > mailm...@ionos.gr: > > > > The milter-8.c file you mention has a lot of information that I was > > missing, thank you for that! > > > > One important part is missing, milter response codes are

Re: milter library for PHP (libMilterPHP)

2022-12-14 Thread Wietse Venema
mailm...@ionos.gr: > > The milter-8.c file you mention has a lot of information that I was missing, > thank you for that! > > One important part is missing, milter response codes are categorised as: > - "modification" There are not "final". They add a header, recipient, change sender, etc. >

Re: milter library for PHP (libMilterPHP)

2022-12-14 Thread mailmary
The milter-8.c file you mention has a lot of information that I was missing, thank you for that! One important part is missing, milter response codes are categorised as: - "modification" - "accept/reject" - "asynchronous" But these 3 codes are not mentioned anywhere: SMFIR_CONN_FAIL

Re: milter library for PHP (libMilterPHP)

2022-12-14 Thread Wietse Venema
mailm...@ionos.gr: > > I used the "milter-protocol.txt" file that I found everywhere. It > is for protocol version 2 only. So I based my implementation on > that. > > Later on, I used archive.org to download a copy of libmilter-docs.tar.gz. > I expected the documentation to explain the differences

Re: milter library for PHP (libMilterPHP)

2022-12-13 Thread mailmary
I used the "milter-protocol.txt" file that I found everywhere. It is for protocol version 2 only. So I based my implementation on that. Later on, I used archive.org to download a copy of libmilter-docs.tar.gz. I expected the documentation to explain the differences between versions (eg going

Re: milter library for PHP (libMilterPHP)

2022-12-13 Thread Jean-François Bachelet
Hello ^^) Le 13/12/2022 à 21:03, mailm...@ionos.gr a écrit : I try to match my coding style to PSR12, so I used PSR12 as a base with 5-6 modifications. There are some things that I haven't tested as much as I want to, for example I haven't found a way to simulate pipelining from postfix.

Re: milter library for PHP (libMilterPHP)

2022-12-13 Thread mailmary
Thank you for those links, I'll take a look. On Tue, 13 Dec 2022 15:44:26 -0500 (EST) Wietse Venema wrote: > Wietse Venema: > > When I implemented Postfix Milter protocol support, I followed the > > file milter-protocol.txt (for protocol verion 2). > > > > For newer protocol versions I

Re: milter library for PHP (libMilterPHP)

2022-12-13 Thread Wietse Venema
Wietse Venema: > mailm...@ionos.gr: > > > > I try to match my coding style to PSR12, so I used PSR12 as a base > > with 5-6 modifications. > > > > There are some things that I haven't tested as much as I want to, > > for example I haven't found a way to simulate pipelining from > > postfix. > > >

Re: milter library for PHP (libMilterPHP)

2022-12-13 Thread Wietse Venema
mailm...@ionos.gr: > > I try to match my coding style to PSR12, so I used PSR12 as a base > with 5-6 modifications. > > There are some things that I haven't tested as much as I want to, > for example I haven't found a way to simulate pipelining from > postfix. > > It is sad that there is no real

Re: milter library for PHP (libMilterPHP)

2022-12-13 Thread mailmary
I try to match my coding style to PSR12, so I used PSR12 as a base with 5-6 modifications. There are some things that I haven't tested as much as I want to, for example I haven't found a way to simulate pipelining from postfix. It is sad that there is no real milter documentation, I did find

Re: milter library for PHP (libMilterPHP)

2022-12-13 Thread Wietse Venema
Mehmet Avcioglu: > Looks great. I'll definitely give it a try. > > Just a small initial feedback; I am a big fan of PSR4 and PSR12, they > make PHP look cool :) Also, it does not have this week's Sendmail::PMilter bug. It does not reply to SMFIC_ABORT (the user would have to write a handler that

Re: milter library for PHP (libMilterPHP)

2022-12-13 Thread Mehmet Avcioglu
Looks great. I'll definitely give it a try. Just a small initial feedback; I am a big fan of PSR4 and PSR12, they make PHP look cool :) -- Mehmet On Tue, Dec 13, 2022 at 1:02 PM wrote: > > Hey everyone, > > I wrote a milter library for PHP, because I wanted to create a bunch of > different