Re: [Potlatch-dev] State of play

2012-03-10 Thread Tom Hughes
On 11/03/12 00:01, Steve Bennett wrote: On Sat, Mar 10, 2012 at 6:41 PM, Tom Hughes wrote: I would just delete them once they aren't needed anymore. Delete them locally, you mean? Do you then need to push the deletion? Well the two things actually separate. You can delete a local branch wi

Re: [Potlatch-dev] State of play

2012-03-10 Thread Steve Bennett
On Sat, Mar 10, 2012 at 6:41 PM, Tom Hughes wrote: > I would just delete them once they aren't needed anymore. Delete them locally, you mean? Do you then need to push the deletion? Steve ___ Potlatch-dev mailing list Potlatch-dev@openstreetmap.org htt

Re: [Potlatch-dev] State of play

2012-03-09 Thread Tom Hughes
On 10/03/12 03:08, Steve Bennett wrote: One thing I'm not sure about in this whole approach is what you're supposed to do with the zillions of branches you end up creating. Assuming that the pull requests all get accepted, am I then supposed to delete or archive these old branches? Seems like ev

Re: [Potlatch-dev] State of play

2012-03-09 Thread Steve Bennett
On Mon, Mar 5, 2012 at 3:01 PM, Steve Bennett wrote: > My Git-fu is gradually improving to the point where I think I can > probably decompose them. I'll try and cherry pick them apart and > resubmit as individual pull requests. Ok, done. For general education, here's what I did: 1) git pull syst

Re: [Potlatch-dev] State of play

2012-03-05 Thread Andy Allan
On 5 March 2012 04:01, Steve Bennett wrote: >> "undo on creating way" fix, > > Definitely worthy of review - it's totally possible that I broke > something else. Anyone else want to have a look at it? I guess we > don't have any tests? We don't have any tests that cover starting drawing a new wa

Re: [Potlatch-dev] State of play

2012-03-04 Thread Steve Bennett
On Mon, Mar 5, 2012 at 11:54 AM, Richard Fairhurst wrote: > Today's commit log is at: > https://github.com/systemed/potlatch2/commits/master Thanks for the update. It's nice to get acknowledgement of our work, even if it's not merged yet. > I've not yet merged in Steve's highway=proposed/constru

Re: [Potlatch-dev] State of play

2012-03-04 Thread Richard Fairhurst
Current most obvious bug that I can see is that (in en-GB at least) the dreaded "[object Object]" is back on the GPS menu. Oh, and landuse=cemetery renders as a black opaque area. Appropriate I guess but probably not great for editing. :) cheers Richard _