Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra-dtest/pull/41#discussion_r245848691
--- Diff: upgrade_tests/thrift_upgrade_test.py ---
@@ -350,29 +469,41 @@ def test_sparse_supercolumn_with_renames(self
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra-dtest/pull/41#discussion_r245846732
--- Diff: requirements.txt ---
@@ -1,6 +1,6 @@
-e
git+https://github.com/datastax/python-driver.git@cassandra-test#egg=cassandra-driver
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra-dtest/pull/41#discussion_r245848315
--- Diff: upgrade_tests/thrift_upgrade_test.py ---
@@ -10,99 +10,182 @@
ColumnParent
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra-dtest/pull/41#discussion_r245846129
--- Diff: conftest.py ---
@@ -409,13 +429,16 @@ def pytest_collection_modifyitems(items, config):
This function is called upon during
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra-dtest/pull/41#discussion_r245848375
--- Diff: upgrade_tests/thrift_upgrade_test.py ---
@@ -10,99 +10,182 @@
ColumnParent
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra-dtest/pull/41#discussion_r245846879
--- Diff: sstable_generation_loading_test.py ---
@@ -27,45 +28,68 @@ def fixture_add_additional_log_patterns(self,
fixture_dtest_setup
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra-dtest/pull/41#discussion_r243218570
--- Diff: upgrade_tests/upgrade_through_versions_test.py ---
@@ -794,31 +800,33 @@ def create_upgrade_class(clsname, version_metas
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/292#discussion_r241232030
--- Diff: src/java/org/apache/cassandra/io/compress/ZSTDCompressor.java ---
@@ -0,0 +1,138 @@
+/*
+ * Licensed to the Apache Software
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra-dtest/pull/41#discussion_r240824209
--- Diff: sstable_generation_loading_test.py ---
@@ -141,6 +166,16 @@ def load_sstable_with_configuration(self,
pre_compression=None
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra-dtest/pull/41#discussion_r240827199
--- Diff: upgrade_tests/paging_test.py ---
@@ -503,22 +513,31 @@ def test_basic_compound_paging(self
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra-dtest/pull/41#discussion_r240827110
--- Diff: upgrade_tests/paging_test.py ---
@@ -457,21 +458,30 @@ def test_basic_paging(self
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra-dtest/pull/41#discussion_r240823234
--- Diff: dtest_setup.py ---
@@ -454,22 +463,14 @@ def maybe_setup_jacoco(self, cluster_name='test'):
@staticmethod
def
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra-dtest/pull/41#discussion_r240827177
--- Diff: upgrade_tests/paging_test.py ---
@@ -503,22 +513,31 @@ def test_basic_compound_paging(self
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra-dtest/pull/41#discussion_r240823966
--- Diff: sstable_generation_loading_test.py ---
@@ -27,45 +27,68 @@ def fixture_add_additional_log_patterns(self,
fixture_dtest_setup
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra-dtest/pull/41#discussion_r240828717
--- Diff: upgrade_tests/upgrade_manifest.py ---
@@ -70,22 +89,19 @@ def clone_with_local_env_version(self):
return self
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/290#discussion_r229892479
--- Diff: src/java/org/apache/cassandra/gms/Gossiper.java ---
@@ -136,6 +139,38 @@
private volatile long lastProcessedMessageAt
Github user dineshjoshi commented on the issue:
https://github.com/apache/cassandra/pull/279
Hi @jonmeredith, the changes look good. I just had a minor comment but
other than that, I think we're good
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/279#discussion_r227581961
--- Diff:
test/burn/org/apache/cassandra/utils/memory/LongBufferPoolTest.java ---
@@ -36,9 +36,34 @@
import static org.junit.Assert
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/279#discussion_r226129933
--- Diff:
test/burn/org/apache/cassandra/utils/memory/LongBufferPoolTest.java ---
@@ -327,24 +371,35 @@ BufferCheck sample
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/279#discussion_r226129803
--- Diff:
test/burn/org/apache/cassandra/utils/memory/LongBufferPoolTest.java ---
@@ -181,7 +222,7 @@ void checkpoint()
void
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/279#discussion_r225404206
--- Diff:
test/burn/org/apache/cassandra/utils/memory/LongBufferPoolTest.java ---
@@ -327,24 +373,41 @@ BufferCheck sample
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/279#discussion_r225404225
--- Diff:
test/burn/org/apache/cassandra/utils/memory/LongBufferPoolTest.java ---
@@ -327,24 +373,41 @@ BufferCheck sample
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/279#discussion_r225404189
--- Diff:
test/burn/org/apache/cassandra/utils/memory/LongBufferPoolTest.java ---
@@ -327,24 +373,41 @@ BufferCheck sample
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/279#discussion_r225403619
--- Diff:
test/burn/org/apache/cassandra/utils/memory/LongBufferPoolTest.java ---
@@ -88,37 +110,51 @@ public void testAllocate(int threadCount, long
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/253#discussion_r216088059
--- Diff: src/java/org/apache/cassandra/net/MessageIn.java ---
@@ -231,4 +241,437 @@ public String toString()
sbuf.append("FROM:&quo
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/253#discussion_r216103691
--- Diff: src/java/org/apache/cassandra/net/async/MessageInHandler.java ---
@@ -18,143 +18,296 @@
package org.apache.cassandra.net.async
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/253#discussion_r216105848
--- Diff: src/java/org/apache/cassandra/net/MessageOut.java ---
@@ -180,6 +199,73 @@ public String toString()
return sbuf.toString
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/253#discussion_r216106796
--- Diff: src/java/org/apache/cassandra/net/MessageOut.java ---
@@ -180,6 +199,73 @@ public String toString()
return sbuf.toString
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/253#discussion_r216102238
--- Diff:
test/unit/org/apache/cassandra/net/MessageInProcessorPre40Test.java ---
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/253#discussion_r216086521
--- Diff:
src/java/org/apache/cassandra/net/async/RebufferingByteBufDataInputPlus.java ---
@@ -36,6 +37,11 @@
public class
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/253#discussion_r216047177
--- Diff: src/java/org/apache/cassandra/net/async/MessageOutHandler.java ---
@@ -140,8 +125,17 @@ public void write(ChannelHandlerContext ctx, Object
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/253#discussion_r215733891
--- Diff:
src/java/org/apache/cassandra/net/async/RebufferingByteBufDataInputPlus.java ---
@@ -36,6 +37,11 @@
public class
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/253#discussion_r215735492
--- Diff:
src/java/org/apache/cassandra/streaming/async/NettyStreamingMessageSender.java
---
@@ -393,6 +393,18 @@ private Channel getOrCreateChannel
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/253#discussion_r215739220
--- Diff: src/java/org/apache/cassandra/net/MessageIn.java ---
@@ -231,4 +241,437 @@ public String toString()
sbuf.append("FROM:&quo
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/253#discussion_r215733539
--- Diff: src/java/org/apache/cassandra/net/async/MessageOutHandler.java ---
@@ -140,8 +125,17 @@ public void write(ChannelHandlerContext ctx, Object
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/253#discussion_r215734926
--- Diff:
src/java/org/apache/cassandra/net/async/RebufferingByteBufDataInputPlus.java ---
@@ -183,6 +195,11 @@ public int available() throws
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/255#discussion_r213558154
--- Diff: src/java/org/apache/cassandra/tools/fqltool/QueryReplayer.java ---
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache Software
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/255#discussion_r213557602
--- Diff: src/java/org/apache/cassandra/tools/fqltool/QueryReplayer.java ---
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache Software
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/255#discussion_r213559247
--- Diff: src/java/org/apache/cassandra/tools/fqltool/FQLQueryIterator.java
---
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/255#discussion_r213557051
--- Diff: src/java/org/apache/cassandra/tools/fqltool/QueryReplayer.java ---
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache Software
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/255#discussion_r213564852
--- Diff: src/java/org/apache/cassandra/tools/fqltool/ResultStore.java ---
@@ -0,0 +1,144 @@
+/*
+ * Licensed to the Apache Software
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/255#discussion_r213562282
--- Diff: src/java/org/apache/cassandra/tools/fqltool/DriverResultSet.java
---
@@ -0,0 +1,253 @@
+/*
+ * Licensed to the Apache Software
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/255#discussion_r213563398
--- Diff: src/java/org/apache/cassandra/tools/fqltool/FQLQuery.java ---
@@ -0,0 +1,263 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/255#discussion_r213562501
--- Diff: src/java/org/apache/cassandra/tools/fqltool/FQLQuery.java ---
@@ -0,0 +1,263 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/255#discussion_r213558579
--- Diff: src/java/org/apache/cassandra/tools/fqltool/QueryReplayer.java ---
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache Software
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/255#discussion_r213558075
--- Diff: src/java/org/apache/cassandra/tools/fqltool/QueryReplayer.java ---
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache Software
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/255#discussion_r213563877
--- Diff: src/java/org/apache/cassandra/tools/fqltool/FQLQueryReader.java
---
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the Apache Software
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/255#discussion_r213564246
--- Diff: src/java/org/apache/cassandra/tools/fqltool/ResultComparator.java
---
@@ -0,0 +1,122 @@
+/*
+ * Licensed to the Apache Software
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/255#discussion_r213562548
--- Diff: src/java/org/apache/cassandra/tools/fqltool/FQLQuery.java ---
@@ -0,0 +1,263 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/255#discussion_r213564366
--- Diff: src/java/org/apache/cassandra/tools/fqltool/ResultHandler.java ---
@@ -0,0 +1,124 @@
+/*
+ * Licensed to the Apache Software
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/255#discussion_r213558547
--- Diff: src/java/org/apache/cassandra/tools/fqltool/QueryReplayer.java ---
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache Software
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/255#discussion_r213562817
--- Diff: src/java/org/apache/cassandra/tools/fqltool/FQLQuery.java ---
@@ -0,0 +1,263 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/244#discussion_r210488658
--- Diff: src/java/org/apache/cassandra/metrics/MaxSampler.java ---
@@ -0,0 +1,59 @@
+package org.apache.cassandra.metrics;
+
+import
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/244#discussion_r210487768
--- Diff: src/java/org/apache/cassandra/db/ReadExecutionController.java ---
@@ -132,6 +145,15 @@ public void close
Github user dineshjoshi commented on the issue:
https://github.com/apache/cassandra/pull/244
Stepping back a bit, I see the samplers are stateful classes that are
enabled and disabled. This means, if there is an exception in the rmi thread
that is executing the `beginLocalSampling
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/244#discussion_r207697381
--- Diff: src/java/org/apache/cassandra/metrics/FrequencySampler.java ---
@@ -0,0 +1,105 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/244#discussion_r207697017
--- Diff: src/java/org/apache/cassandra/metrics/TableMetrics.java ---
@@ -281,7 +301,7 @@ public Long getValue()
public final Meter
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/244#discussion_r207697707
--- Diff: src/java/org/apache/cassandra/metrics/Sampler.java ---
@@ -0,0 +1,67 @@
+package org.apache.cassandra.metrics;
+
+import
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/244#discussion_r207697487
--- Diff: src/java/org/apache/cassandra/metrics/Sampler.java ---
@@ -0,0 +1,67 @@
+package org.apache.cassandra.metrics;
+
+import
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/244#discussion_r207697651
--- Diff: src/java/org/apache/cassandra/tools/nodetool/ProfileLoad.java ---
@@ -0,0 +1,178 @@
+package org.apache.cassandra.tools.nodetool
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/244#discussion_r207697217
--- Diff: src/java/org/apache/cassandra/db/ReadExecutionController.java ---
@@ -113,6 +123,11 @@ static ReadExecutionController forCommand(ReadCommand
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/244#discussion_r207697430
--- Diff: src/java/org/apache/cassandra/metrics/FrequencySampler.java ---
@@ -0,0 +1,105 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/244#discussion_r207697637
--- Diff: src/java/org/apache/cassandra/tools/nodetool/ProfileLoad.java ---
@@ -0,0 +1,178 @@
+package org.apache.cassandra.tools.nodetool
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/244#discussion_r207697287
--- Diff: src/java/org/apache/cassandra/db/ReadExecutionController.java ---
@@ -132,6 +147,17 @@ public void close
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/244#discussion_r207697244
--- Diff: src/java/org/apache/cassandra/db/ReadExecutionController.java ---
@@ -113,6 +123,11 @@ static ReadExecutionController forCommand(ReadCommand
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/244#discussion_r207697297
--- Diff: src/java/org/apache/cassandra/db/ReadExecutionController.java ---
@@ -132,6 +147,17 @@ public void close
Github user dineshjoshi commented on the issue:
https://github.com/apache/cassandra/pull/239
@iamaleksey made a few more changes -
1. Got rid of `IStreamWriter`
2. Ensured we're logging the configuration warning only once at start up
iff zero copy streaming is enabled
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/239#discussion_r205646170
--- Diff: src/java/org/apache/cassandra/db/streaming/ComponentManifest.java
---
@@ -0,0 +1,130 @@
+/*
+ * Licensed to the Apache Software
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/239#discussion_r205639791
--- Diff:
src/java/org/apache/cassandra/db/streaming/CassandraBlockStreamReader.java ---
@@ -0,0 +1,173 @@
+/*
+ * Licensed to the Apache
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/239#discussion_r205532095
--- Diff:
src/java/org/apache/cassandra/db/streaming/CassandraBlockStreamWriter.java ---
@@ -0,0 +1,122 @@
+/*
+ * Licensed to the Apache
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/239#discussion_r205532049
--- Diff:
test/unit/org/apache/cassandra/db/streaming/CassandraStreamHeaderTest.java ---
@@ -43,8 +51,38 @@ public void serializerTest
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/239#discussion_r205532001
--- Diff:
src/java/org/apache/cassandra/db/streaming/CassandraStreamHeader.java ---
@@ -183,9 +261,26 @@ public CassandraStreamHeader deserialize
Github user dineshjoshi commented on the issue:
https://github.com/apache/cassandra/pull/239
@iamaleksey I've addressed your comments including the one about disabling
faster streaming for legacy counter shards.
I did add a much less expensive check for STCS. It won't get all
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/239#discussion_r205339231
--- Diff:
src/java/org/apache/cassandra/db/streaming/CassandraBlockStreamWriter.java ---
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/239#discussion_r205299016
--- Diff:
src/java/org/apache/cassandra/db/streaming/CassandraBlockStreamWriter.java ---
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/239#discussion_r205298316
--- Diff:
src/java/org/apache/cassandra/db/streaming/CassandraBlockStreamWriter.java ---
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/239#discussion_r205298028
--- Diff:
src/java/org/apache/cassandra/db/streaming/CassandraBlockStreamWriter.java ---
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/239#discussion_r205297956
--- Diff:
src/java/org/apache/cassandra/db/streaming/CassandraBlockStreamWriter.java ---
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/239#discussion_r205297558
--- Diff: src/java/org/apache/cassandra/db/streaming/ComponentManifest.java
---
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the Apache Software
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/239#discussion_r205297151
--- Diff: src/java/org/apache/cassandra/db/streaming/ComponentManifest.java
---
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the Apache Software
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/239#discussion_r205297184
--- Diff: src/java/org/apache/cassandra/db/streaming/ComponentManifest.java
---
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the Apache Software
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/239#discussion_r205283093
--- Diff:
src/java/org/apache/cassandra/io/sstable/format/big/BigTableBlockWriter.java ---
@@ -0,0 +1,221 @@
+/*
+ * Licensed to the Apache
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/239#discussion_r205282807
--- Diff:
src/java/org/apache/cassandra/io/sstable/format/big/BigTableBlockWriter.java ---
@@ -0,0 +1,221 @@
+/*
+ * Licensed to the Apache
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/239#discussion_r205282784
--- Diff:
src/java/org/apache/cassandra/io/sstable/format/big/BigTableBlockWriter.java ---
@@ -0,0 +1,221 @@
+/*
+ * Licensed to the Apache
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/239#discussion_r205277660
--- Diff:
src/java/org/apache/cassandra/db/streaming/CassandraBlockStreamReader.java ---
@@ -0,0 +1,177 @@
+/*
+ * Licensed to the Apache
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/239#discussion_r205277545
--- Diff:
src/java/org/apache/cassandra/db/streaming/CassandraBlockStreamReader.java ---
@@ -0,0 +1,177 @@
+/*
+ * Licensed to the Apache
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/239#discussion_r205277492
--- Diff:
src/java/org/apache/cassandra/db/streaming/CassandraBlockStreamReader.java ---
@@ -0,0 +1,177 @@
+/*
+ * Licensed to the Apache
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/239#discussion_r205276519
--- Diff:
src/java/org/apache/cassandra/db/streaming/CassandraBlockStreamReader.java ---
@@ -0,0 +1,177 @@
+/*
+ * Licensed to the Apache
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/239#discussion_r205276269
--- Diff:
src/java/org/apache/cassandra/io/sstable/format/big/BigTableBlockWriter.java ---
@@ -0,0 +1,221 @@
+/*
+ * Licensed to the Apache
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/239#discussion_r205276122
--- Diff:
src/java/org/apache/cassandra/db/streaming/CassandraBlockStreamReader.java ---
@@ -0,0 +1,177 @@
+/*
+ * Licensed to the Apache
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/239#discussion_r205275130
--- Diff: src/java/org/apache/cassandra/db/compaction/Verifier.java ---
@@ -361,12 +361,26 @@ public RangeOwnHelper(List>
normalizedRan
Github user dineshjoshi commented on the issue:
https://github.com/apache/cassandra/pull/239
@iamaleksey I *think* I've resolved all your comments. The last dtest was
all green. I'm not sure about the latest push but I don't forsee any breakages.
Please let me know if there are more
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/239#discussion_r204998639
--- Diff:
src/java/org/apache/cassandra/db/streaming/CassandraOutgoingFile.java ---
@@ -62,7 +90,23 @@ public CassandraOutgoingFile(StreamOperation
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/239#discussion_r204955316
--- Diff:
src/java/org/apache/cassandra/db/streaming/CassandraOutgoingFile.java ---
@@ -114,13 +155,51 @@ public void write(StreamSession session
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/239#discussion_r204955090
--- Diff: src/java/org/apache/cassandra/db/streaming/ComponentInfo.java ---
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apache Software
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/239#discussion_r204955043
--- Diff: src/java/org/apache/cassandra/db/lifecycle/LogFile.java ---
@@ -66,7 +66,7 @@
private final LogReplicaSet replicas = new
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/239#discussion_r204954805
--- Diff:
src/java/org/apache/cassandra/db/streaming/CassandraBlockStreamReader.java ---
@@ -0,0 +1,184 @@
+/*
+ * Licensed to the Apache
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/239#discussion_r204954749
--- Diff: src/java/org/apache/cassandra/config/DatabaseDescriptor.java ---
@@ -2260,6 +2260,20 @@ public static int getStreamingConnectionsPerHost
Github user dineshjoshi commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/239#discussion_r204954729
--- Diff: src/java/org/apache/cassandra/db/streaming/ComponentInfo.java ---
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apache Software
Github user dineshjoshi commented on the issue:
https://github.com/apache/cassandra/pull/239
@iamaleksey I have resolved most of your comments. I still have a couple to
go. I will update this PR when I am done with those and get a clean dtest run
1 - 100 of 121 matches
Mail list logo
