[GitHub] cassandra pull request #239: Optimize Streaming

2018-07-10 Thread belliottsmith
Github user belliottsmith commented on a diff in the pull request: https://github.com/apache/cassandra/pull/239#discussion_r201463505 --- Diff: src/java/org/apache/cassandra/net/async/RebufferingByteBufDataInputPlus.java --- @@ -249,4 +253,50 @@ public ByteBufAllocator

[GitHub] cassandra pull request #239: Optimize Streaming

2018-07-10 Thread belliottsmith
Github user belliottsmith commented on a diff in the pull request: https://github.com/apache/cassandra/pull/239#discussion_r201461568 --- Diff: src/java/org/apache/cassandra/net/async/RebufferingByteBufDataInputPlus.java --- @@ -249,4 +253,50 @@ public ByteBufAllocator

[GitHub] cassandra pull request #265: 14705

2018-09-12 Thread belliottsmith
Github user belliottsmith commented on a diff in the pull request: https://github.com/apache/cassandra/pull/265#discussion_r216913492 --- Diff: src/java/org/apache/cassandra/locator/ReplicaPlan.java --- @@ -249,12 +229,32 @@ public int requiredParticipants() * we

[GitHub] cassandra pull request #265: 14705

2018-09-12 Thread belliottsmith
Github user belliottsmith commented on a diff in the pull request: https://github.com/apache/cassandra/pull/265#discussion_r216913748 --- Diff: src/java/org/apache/cassandra/locator/ReplicaPlan.java --- @@ -249,12 +229,32 @@ public int requiredParticipants() * we

[GitHub] cassandra pull request #265: 14705

2018-09-12 Thread belliottsmith
Github user belliottsmith commented on a diff in the pull request: https://github.com/apache/cassandra/pull/265#discussion_r216916456 --- Diff: src/java/org/apache/cassandra/locator/ReplicaLayout.java --- @@ -194,14 +198,97 @@ public Token token() public static

[GitHub] cassandra pull request #265: 14705

2018-09-12 Thread belliottsmith
Github user belliottsmith commented on a diff in the pull request: https://github.com/apache/cassandra/pull/265#discussion_r216912914 --- Diff: src/java/org/apache/cassandra/service/reads/AbstractReadExecutor.java --- @@ -184,30 +185,28 @@ public static AbstractReadExecutor

[GitHub] cassandra pull request #288: In BufferPool, make allocating thread receive a...

2018-10-26 Thread belliottsmith
Github user belliottsmith commented on a diff in the pull request: https://github.com/apache/cassandra/pull/288#discussion_r228448169 --- Diff: src/java/org/apache/cassandra/utils/memory/BufferPool.java --- @@ -237,23 +237,25 @@ void check() /** Return a chunk

[GitHub] cassandra pull request #271: 14726

2018-10-01 Thread belliottsmith
Github user belliottsmith commented on a diff in the pull request: https://github.com/apache/cassandra/pull/271#discussion_r221526704 --- Diff: src/java/org/apache/cassandra/locator/ReplicaMultimap.java --- @@ -39,21 +39,28 @@ public abstract C get(K key); public

[GitHub] cassandra pull request #271: 14726

2018-10-01 Thread belliottsmith
Github user belliottsmith commented on a diff in the pull request: https://github.com/apache/cassandra/pull/271#discussion_r221530400 --- Diff: src/java/org/apache/cassandra/locator/EndpointsByRange.java --- @@ -54,9 +55,13 @@ public void putAll(Range range, EndpointsForRange

[GitHub] cassandra pull request #267: Consolidate batch write code

2018-09-20 Thread belliottsmith
Github user belliottsmith commented on a diff in the pull request: https://github.com/apache/cassandra/pull/267#discussion_r219131794 --- Diff: src/java/org/apache/cassandra/service/StorageProxy.java --- @@ -1021,18 +1021,18 @@ private static void syncWriteToBatchlog(Collection

[GitHub] cassandra pull request #267: Consolidate batch write code

2018-09-20 Thread belliottsmith
Github user belliottsmith commented on a diff in the pull request: https://github.com/apache/cassandra/pull/267#discussion_r219133467 --- Diff: src/java/org/apache/cassandra/locator/ReplicaPlans.java --- @@ -61,26 +73,62 @@ return forSingleReplicaWrite(keyspace, token

[GitHub] cassandra pull request #267: Consolidate batch write code

2018-09-20 Thread belliottsmith
Github user belliottsmith commented on a diff in the pull request: https://github.com/apache/cassandra/pull/267#discussion_r219129563 --- Diff: src/java/org/apache/cassandra/locator/ReplicaPlans.java --- @@ -61,26 +73,62 @@ return forSingleReplicaWrite(keyspace, token

[GitHub] cassandra pull request #267: Consolidate batch write code

2018-09-20 Thread belliottsmith
Github user belliottsmith commented on a diff in the pull request: https://github.com/apache/cassandra/pull/267#discussion_r219128835 --- Diff: src/java/org/apache/cassandra/locator/ReplicaPlans.java --- @@ -61,26 +73,62 @@ return forSingleReplicaWrite(keyspace, token

[GitHub] cassandra pull request #267: Consolidate batch write code

2018-09-20 Thread belliottsmith
Github user belliottsmith commented on a diff in the pull request: https://github.com/apache/cassandra/pull/267#discussion_r219138039 --- Diff: src/java/org/apache/cassandra/locator/ReplicaPlans.java --- @@ -61,26 +73,62 @@ return forSingleReplicaWrite(keyspace, token

[GitHub] cassandra pull request #273: Fix overflow of 32-bit integer during compactio...

2018-09-21 Thread belliottsmith
Github user belliottsmith commented on a diff in the pull request: https://github.com/apache/cassandra/pull/273#discussion_r219557162 --- Diff: src/java/org/apache/cassandra/utils/streamhist/StreamingTombstoneHistogramBuilder.java --- @@ -595,12 +600,22 @@ private boolean tryCell

[GitHub] cassandra pull request #273: Fix overflow of 32-bit integer during compactio...

2018-09-21 Thread belliottsmith
Github user belliottsmith commented on a diff in the pull request: https://github.com/apache/cassandra/pull/273#discussion_r219557250 --- Diff: src/java/org/apache/cassandra/utils/streamhist/StreamingTombstoneHistogramBuilder.java --- @@ -595,12 +600,22 @@ private boolean tryCell

[GitHub] cassandra pull request #271: 14726

2018-09-28 Thread belliottsmith
Github user belliottsmith commented on a diff in the pull request: https://github.com/apache/cassandra/pull/271#discussion_r221306464 --- Diff: src/java/org/apache/cassandra/locator/AbstractReplicaCollection.java --- @@ -58,45 +63,332

[GitHub] cassandra pull request #293: 14855 - 3.0 backport immediate flusher

2018-11-22 Thread belliottsmith
Github user belliottsmith commented on a diff in the pull request: https://github.com/apache/cassandra/pull/293#discussion_r235729649 --- Diff: conf/cassandra.yaml --- @@ -1003,3 +1003,9 @@ windows_timer_interval: 1 # An interval of 0 disables any wait time, which

[GitHub] cassandra pull request #265: 14705

2018-09-12 Thread belliottsmith
Github user belliottsmith commented on a diff in the pull request: https://github.com/apache/cassandra/pull/265#discussion_r217112723 --- Diff: src/java/org/apache/cassandra/locator/ReplicaLayout.java --- @@ -18,364 +18,296 @@ package org.apache.cassandra.locator

[GitHub] cassandra pull request #265: 14705

2018-09-12 Thread belliottsmith
Github user belliottsmith commented on a diff in the pull request: https://github.com/apache/cassandra/pull/265#discussion_r217175374 --- Diff: src/java/org/apache/cassandra/service/reads/repair/BlockingReadRepair.java --- @@ -53,15 +53,16 @@ protected final Queue repairs

[GitHub] cassandra pull request #270: 14759

2018-09-18 Thread belliottsmith
Github user belliottsmith commented on a diff in the pull request: https://github.com/apache/cassandra/pull/270#discussion_r218488201 --- Diff: src/java/org/apache/cassandra/locator/ReplicaLayout.java --- @@ -275,7 +275,24 @@ public ForTokenWrite(EndpointsForToken natural

[GitHub] cassandra pull request #270: 14759

2018-09-18 Thread belliottsmith
GitHub user belliottsmith opened a pull request: https://github.com/apache/cassandra/pull/270 14759 You can merge this pull request into a Git repository by running: $ git pull https://github.com/belliottsmith/cassandra 14759 Alternatively you can review and apply

[GitHub] cassandra pull request #269: Review tr range movements

2018-09-18 Thread belliottsmith
Github user belliottsmith commented on a diff in the pull request: https://github.com/apache/cassandra/pull/269#discussion_r218387701 --- Diff: src/java/org/apache/cassandra/db/SystemKeyspace.java --- @@ -1288,24 +1288,25 @@ public static synchronized void updateAvailableRanges

[GitHub] cassandra pull request #269: Review tr range movements

2018-09-18 Thread belliottsmith
Github user belliottsmith commented on a diff in the pull request: https://github.com/apache/cassandra/pull/269#discussion_r218383055 --- Diff: src/java/org/apache/cassandra/dht/RangeStreamer.java --- @@ -337,165 +364,167 @@ else if (useStrictConsistency

[GitHub] cassandra pull request #269: Review tr range movements

2018-09-18 Thread belliottsmith
Github user belliottsmith commented on a diff in the pull request: https://github.com/apache/cassandra/pull/269#discussion_r218382891 --- Diff: src/java/org/apache/cassandra/dht/RangeStreamer.java --- @@ -87,8 +85,8 @@ private final InetAddressAndPort address

[GitHub] cassandra pull request #269: Review tr range movements

2018-09-18 Thread belliottsmith
Github user belliottsmith commented on a diff in the pull request: https://github.com/apache/cassandra/pull/269#discussion_r218388108 --- Diff: src/java/org/apache/cassandra/dht/StreamStateStore.java --- @@ -54,8 +56,10 @@ public RangesAtEndpoint getAvailableRanges(String keyspace

[GitHub] cassandra pull request #269: Review tr range movements

2018-09-18 Thread belliottsmith
Github user belliottsmith commented on a diff in the pull request: https://github.com/apache/cassandra/pull/269#discussion_r218383166 --- Diff: src/java/org/apache/cassandra/dht/RangeStreamer.java --- @@ -337,165 +364,167 @@ else if (useStrictConsistency

[GitHub] cassandra pull request #269: Review tr range movements

2018-09-18 Thread belliottsmith
Github user belliottsmith commented on a diff in the pull request: https://github.com/apache/cassandra/pull/269#discussion_r218387370 --- Diff: src/java/org/apache/cassandra/streaming/StreamPlan.java --- @@ -70,6 +70,16 @@ public StreamPlan(StreamOperation streamOperation, int

[GitHub] cassandra pull request #269: Review tr range movements

2018-09-18 Thread belliottsmith
Github user belliottsmith commented on a diff in the pull request: https://github.com/apache/cassandra/pull/269#discussion_r218371266 --- Diff: test/unit/org/apache/cassandra/dht/BootStrapperTest.java --- @@ -125,21 +125,19 @@ public boolean isAlive(InetAddressAndPort ep

[GitHub] cassandra pull request #269: Review tr range movements

2018-09-18 Thread belliottsmith
Github user belliottsmith commented on a diff in the pull request: https://github.com/apache/cassandra/pull/269#discussion_r218382719 --- Diff: src/java/org/apache/cassandra/dht/RangeStreamer.java --- @@ -328,7 +356,6 @@ else if (useStrictConsistency) * Get a map of all

[GitHub] cassandra pull request #269: Review tr range movements

2018-09-18 Thread belliottsmith
Github user belliottsmith commented on a diff in the pull request: https://github.com/apache/cassandra/pull/269#discussion_r218470693 --- Diff: src/java/org/apache/cassandra/streaming/StreamPlan.java --- @@ -70,6 +70,16 @@ public StreamPlan(StreamOperation streamOperation, int