Re: [prosody-dev] Feedback on adding last-message-priority to mod_cloud_notify

2017-07-28 Thread Chris Ballinger
You're correct! So far no response on the standards mailing list. Good call
on the other events, but I'm not familiar enough with the Prosody code base
to idiomatically add those other events. Can I just add checks for them to
the existing if statement, or do I need to add hooks elsewhere as well?

One problem though... for the muc invites and pubsub events, having them as
high priority will still result in a generic "New Message" alert, at least
in my implementation. That brings us back around to needing a message
"type" instead of priority. :-\

That said, I have it deployed on my personal server at the moment and it's
working quite well. You can test it live w/ the latest ChatSecure App Store
or TestFlight build by running my mod_cloud_notify patch.

On Fri, Jul 28, 2017 at 8:45 AM, 'Thilo Molitor' via prosody-dev <
prosody-dev@googlegroups.com> wrote:

> Hi Chris,
>
> I think you are referring to this post
> https://mail.jabber.org/pipermail/standards/2017-July/033085.html
> and this post is itself refering to the discussion here:
> https://github.com/ChatSecure/ChatSecure-iOS/issues/637#
> issuecomment-285828038
>
> Is that right?
> If so, and assuming that your posting on the standards list generates
> positive
> feedback, I'd be happy to merge your patch :)
>
> Regarding the patch: muc invites should have a high priority, too.
> Andy maybe you should also consider adding pubsub events as high priority.
>
>
> - tmolitor
>
>
>
> Am Donnerstag, 27. Juli 2017, 18:18:37 schrieb Chris Ballinger:
> > This adds an optional "high" and "low" priority value, where "high"
> depends
> > on whether the message contains a  or  (OMEMO) element.
> > This helps limit overly verbose push notifications for things like typing
> > notifications, without requiring transmission of anything about the
> message
> > contents.
> >
> > Anyone have feedback for this approach?
> >
> > https://bitbucket.org/chrisballinger/prosody-modules/branches/compare/
> 12b438
> > 7..b1c5b0c#diff
> >
> > Thanks!
>
> --
> You received this message because you are subscribed to the Google Groups
> "prosody-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to prosody-dev+unsubscr...@googlegroups.com.
> To post to this group, send email to prosody-dev@googlegroups.com.
> Visit this group at https://groups.google.com/group/prosody-dev.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"prosody-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to prosody-dev+unsubscr...@googlegroups.com.
To post to this group, send email to prosody-dev@googlegroups.com.
Visit this group at https://groups.google.com/group/prosody-dev.
For more options, visit https://groups.google.com/d/optout.


Re: [prosody-dev] Feedback on adding last-message-priority to mod_cloud_notify

2017-07-28 Thread 'Thilo Molitor' via prosody-dev
Hi Chris,

I think you are referring to this post 
https://mail.jabber.org/pipermail/standards/2017-July/033085.html
and this post is itself refering to the discussion here: 
https://github.com/ChatSecure/ChatSecure-iOS/issues/637#issuecomment-285828038

Is that right?
If so, and assuming that your posting on the standards list generates positive 
feedback, I'd be happy to merge your patch :)

Regarding the patch: muc invites should have a high priority, too.
Andy maybe you should also consider adding pubsub events as high priority.


- tmolitor



Am Donnerstag, 27. Juli 2017, 18:18:37 schrieb Chris Ballinger:
> This adds an optional "high" and "low" priority value, where "high" depends
> on whether the message contains a  or  (OMEMO) element.
> This helps limit overly verbose push notifications for things like typing
> notifications, without requiring transmission of anything about the message
> contents.
> 
> Anyone have feedback for this approach?
> 
> https://bitbucket.org/chrisballinger/prosody-modules/branches/compare/12b438
> 7..b1c5b0c#diff
> 
> Thanks!

-- 
You received this message because you are subscribed to the Google Groups 
"prosody-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to prosody-dev+unsubscr...@googlegroups.com.
To post to this group, send email to prosody-dev@googlegroups.com.
Visit this group at https://groups.google.com/group/prosody-dev.
For more options, visit https://groups.google.com/d/optout.