Re: [protobuf] VC++ 2008 : Run-Time Check Failure #1

2010-04-05 Thread Kenton Varda
Revision 325 is equivalent to your patch, but I decided to arrange it a little differently. Thanks! Sorry for the long delay. On Wed, Mar 24, 2010 at 11:38 AM, Nathan McDaniel nmcdanie...@gmail.comwrote: Hi Kenton, The attached patch patches two files: - coded_stream.h: disables cast to

Re: [protobuf] VC++ 2008 : Run-Time Check Failure #1

2010-03-24 Thread Nathan McDaniel
Hi Kenton, The attached patch patches two files: - coded_stream.h: disables cast to smaller types runtime checks in that file, for Visual C++ = 2003. This was the least invasive fix. I can change it if you prefer. - common.h: sets the __BYTE_ORDER to __LITTLE_ENDIAN for MSVC, which enables

Re: [protobuf] VC++ 2008 : Run-Time Check Failure #1

2010-03-23 Thread Kenton Varda
The loss of data is intentional. I've never seen MSVC or any other compiler complain about this before. Feel free to send a patch adding the bit masks it asks for. On Tue, Mar 23, 2010 at 8:47 AM, Nathan McDaniel nmcdanie...@gmail.comwrote: I am getting the following run-time check failure