Re: build fix for protobuf-c

2009-03-05 Thread Antony Dovgal
On 04.03.2009 20:22, lahike...@gmail.com wrote: Well, it seems like all your technical problems will be solved by my configure check -- which will nicely tell the user that the need to install protobuf or modify their CFLAGS/LDFLAGS. Why make user do that manually if there is a much more

Re: build fix for protobuf-c

2009-03-04 Thread Antony Dovgal
On 03.03.2009 21:18, lahike...@gmail.com wrote: It seems like you should be using CXXFLAGS=-I/my/install/path/include \ LDFLAGS=-L/my/install/path/lib \ ./configure instead. Why do that manually? And how do you expect an average user to know that? And by the way, that's exactly

Re: build fix for protobuf-c

2009-03-04 Thread lahiker42
Large complex systems are exactly why LDFLAGS and CFLAGS are better... you can set them ONCE and build the entire system to another location. do you really want to do --lib-a=$PREFIX --lib-b=$PREFIX for 50 libraries for 50 packages? - dave On Mar 4, 1:31 am, Antony Dovgal t...@daylessday.org

Re: build fix for protobuf-c

2009-03-04 Thread lahiker42
Well, it seems like all your technical problems will be solved by my configure check -- which will nicely tell the user that the need to install protobuf or modify their CFLAGS/LDFLAGS. I'm sorry that you prefer a custom option to the standard automake solution- as a maintainer [*], i disagree.

Re: build fix for protobuf-c

2009-03-04 Thread lahiker42
I have made a patch; i hadn't committed (or fully tested) it yet. -- but so it can be reviewed i committed it: http://code.google.com/p/protobuf-c/source/diff?spec=svn168r=168format=sidepath=/trunk/configure.ac I have a few other little fixes (issue 15 and some rpc/tcp fixes) and so on i

Re: build fix for protobuf-c

2009-03-03 Thread lahiker42
It seems like you should be using CXXFLAGS=-I/my/install/path/include \ LDFLAGS=-L/my/install/path/lib \ ./configure instead. --with-libdir is fairly ambiguous with --libdir (a standard automake option which defines where to put libraries, rather than where to look for them). Perhaps

Re: build fix for protobuf-c

2009-03-03 Thread Dave Bailey
We use a --with-protobuf option in protobuf-perlxs. http://code.google.com/p/protobuf-perlxs/source/browse/trunk/configure.ac I actually copy-pasted the configure.ac part that implements --with- protobuf into the protobuf-c configure.ac so I could build protobuf-c in my environment recently.