[protobuf] Re: Issue 658 in protobuf: use cmake for builds

2014-08-04 Thread protobuf


Comment #2 on issue 658 by paleozogt: use cmake for builds
http://code.google.com/p/protobuf/issues/detail?id=658

With CMake you can generically build across platforms with a single  
command: "cmake --build .", which will invoke make/msbuild/nmake/etc as  
appropriate.  Surely this is useful even if the users aren't using CMake  
themselves.


CMake is directly analogous to autoconf, except that its more  
cross-platform.


"just a few clicks" to get it to work on Windows is a big problem for  
automated builds.  ie, if the user is pulling in gtest as a submodule, or  
automatically downloading/unzipping/building as part of their build.  We've  
had to internally fork protobuf so that it has the upgraded msvc proj files.





--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups "Protocol 
Buffers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 658 in protobuf: use cmake for builds

2014-08-04 Thread protobuf


Comment #1 on issue 658 by xiaof...@google.com: use cmake for builds
http://code.google.com/p/protobuf/issues/detail?id=658

My understanding is that using CMake will allow us to use one set of build  
configuration files for all platforms so it probably will make it easier to  
maintain.


I don't see the benefit of using CMake from the users' point of view  
though. Even with CMake, users still need to "to build with mingw, run  
CMake with these parameters and make; to build with VC, run CMake with  
those parameters and open the generated sln file". Unless the user already  
uses CMake in his project, using CMake just adds another step to their  
build process. The sln/vcproj files we provide being behind the latest MSVC  
version doesn't seem a problem to me. Upgrading is just one or two clicks.  
The one-off fixes you mentioned are needed any way regardless of whether  
CMake is used.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups "Protocol 
Buffers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 471 in protobuf: automake-1.12 warning "archiver requires 'AM_PROG_AR' in 'configure.ac'"

2014-08-04 Thread protobuf

Updates:
Status: Started
Owner: jie...@google.com
Labels: FixedIn-2.6.0

Comment #2 on issue 471 by jie...@google.com: automake-1.12  
warning "archiver requires 'AM_PROG_AR' in 'configure.ac'"

http://code.google.com/p/protobuf/issues/detail?id=471

(No comment was entered for this change.)

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups "Protocol 
Buffers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Issue 658 in protobuf: use cmake for builds

2014-08-04 Thread protobuf

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 658 by paleozogt: use cmake for builds
http://code.google.com/p/protobuf/issues/detail?id=658

The MSVC project is way behind the latest MSVC version, which forces devs  
on windows to do project upgrades, and lots of one-off fixes (for example,  
#531).


Additionally, building gtest in a project (say as a git submodule) has lots  
of platform-dependent code: if we're on *nix, build it like this, if we're  
on win, build it like this.


protobuf should switch to using CMake so that there's one way to build the  
project.  This will put any msvc issues to bed, and make building the  
project as a submodule trivial.


See gtest for an example of another google project that is successfully  
using CMake.







--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups "Protocol 
Buffers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 455 in protobuf: google/protobuf/message.cc is missing #include

2014-08-04 Thread protobuf


Comment #10 on issue 455 by k06aaa: google/protobuf/message.cc is missing  
#include 

http://code.google.com/p/protobuf/issues/detail?id=455

Works!

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups "Protocol 
Buffers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.