[protobuf] Re: Issue 245 in protobuf: index package conflicts with index argument name
Comment #1 on issue 245 by yanghatespam: index package conflicts with index argument name http://code.google.com/p/protobuf/issues/detail?id=245 This is with svn r93 -- You received this message because you are subscribed to the Google Groups Protocol Buffers group. To post to this group, send email to proto...@googlegroups.com. To unsubscribe from this group, send email to protobuf+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/protobuf?hl=en.
[protobuf] Re: Issue 245 in protobuf: index package conflicts with index argument name
Updates: Status: WontFix Comment #2 on issue 245 by ken...@google.com: index package conflicts with index argument name http://code.google.com/p/protobuf/issues/detail?id=245 The Java package naming convention says that the first component of a package name should be a TLD. index is not a TLD. AFAIK, there is no way we can completely avoid the possibility of conflicts here. The only thing we could possibly do is add obfuscation to all private names in generated code to make conflicts less likely. I don't think this is a big enough problem to warrant the tedious work involved, especially given that the package naming convention should prevent conflicts already, therefore I am marking this won't fix. That said, if you really, truly need your top-level package to be named index, feel free to send me a patch against the Java code generator to rename this one variable. -- You received this message because you are subscribed to the Google Groups Protocol Buffers group. To post to this group, send email to proto...@googlegroups.com. To unsubscribe from this group, send email to protobuf+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/protobuf?hl=en.
[protobuf] Re: Issue 245 in protobuf: index package conflicts with index argument name
Comment #3 on issue 245 by yanghatespam: index package conflicts with index argument name http://code.google.com/p/protobuf/issues/detail?id=245 We've already changed our code (you gave us a good impetus for finally renaming that poorly named package), but it *is* legal Java. Perhaps adding a quite note to the documentation would be a nice resolution? -- You received this message because you are subscribed to the Google Groups Protocol Buffers group. To post to this group, send email to proto...@googlegroups.com. To unsubscribe from this group, send email to protobuf+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/protobuf?hl=en.
[protobuf] Re: Issue 245 in protobuf: index package conflicts with index argument name
Comment #4 on issue 245 by ken...@google.com: index package conflicts with index argument name http://code.google.com/p/protobuf/issues/detail?id=245 index is just one of many names that will cause this problem. And package names are only one kind of problem. If you name a field descriptor, you'll see a different kind of problem. We don't have an exhaustive list of these, and creating one would be almost as tedious as just fixing them all. So I'm not sure what to put in the note... Some valid .proto files may generate code that doesn't compile cleanly in some languages.? Seems not very helpful... -- You received this message because you are subscribed to the Google Groups Protocol Buffers group. To post to this group, send email to proto...@googlegroups.com. To unsubscribe from this group, send email to protobuf+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/protobuf?hl=en.
