zero_copy_stream_unittest.cc doesn't compile with msvc 7.1/2003

2009-07-06 Thread Cosmin Cremarenco
Hi When compiling zero_copy_stream_unittest.cc from the last version 2.1.0 msvc complains about the type "_invalid_parameter_handler" (I don't think it is supported in 7.1): Compiling... zero_copy_stream_unittest.cc \tmp\protobuf-2.1.0-vc71\src\google\protobuf\io \zero_copy_stream_unittest.cc(475

GoogleOnceType showing up as a memory leak

2009-07-06 Thread Alex Black
I'm using a memory leak detection tool (ms crtdbg). It runs at the end of the program (after main has exited), and is reporting 7 40byte leaks, each of which corresponds to a new call in GoogleOnceType, they're each one of these two: GoogleOnceType::GoogleOnceType() { // internal_ may be non-N

Re: GoogleOnceType showing up as a memory leak

2009-07-06 Thread Kenton Varda
Yes, this is a known bug resulting from the fact that I developed the shutdown code on Linux rather than Windows -- this bug only exists on Windows. It's still not a real leak unless you are dynamically loading and unloading the protobuf library as a DLL. In any case, this has been fixed in SVN a

Re: zero_copy_stream_unittest.cc doesn't compile with msvc 7.1/2003

2009-07-06 Thread Kenton Varda
This is with MSVC 7.1? Which version of Visual Studio does that correspond to? I can never keep these straight. On Mon, Jul 6, 2009 at 7:27 AM, Cosmin Cremarenco < cosmin.cremare...@gmail.com> wrote: > > Hi > > When compiling zero_copy_stream_unittest.cc from the last version > 2.1.0 msvc compl

Re: zero_copy_stream_unittest.cc doesn't compile with msvc 7.1/2003

2009-07-06 Thread Cosmin Cremarenco
It is Visual Studio 2003 - Version 7.1.6030. I think the .1 minor comes from the installation of sp1 over 7.0 Cosmin On Jul 6, 7:33 pm, Kenton Varda wrote: > This is with MSVC 7.1?  Which version of Visual Studio does that correspond > to?  I can never keep these straight. > > On Mon, Jul 6, 20

Re: Parser fails silently if first numeric field has value zero.

2009-07-06 Thread Kenton Varda
This is most likely a bug in your code -- you probably aren't transmitting the message correctly. Please make sure that the bytes you give to the protobuf parser on the receiving end are exactly the same bytes that were produced by the serializer at the sending end -- both the size and contents mu

RE: GoogleOnceType showing up as a memory leak

2009-07-06 Thread Alex Black
Thanks. From: Kenton Varda [mailto:ken...@google.com] Sent: Monday, July 06, 2009 1:32 PM To: Alex Black Cc: Protocol Buffers Subject: Re: GoogleOnceType showing up as a memory leak Yes, this is a known bug resulting from the fact that I developed the shutdown

Re: zero_copy_stream_unittest.cc doesn't compile with msvc 7.1/2003

2009-07-06 Thread Kenton Varda
What's the _MSC_VER for that version? On Mon, Jul 6, 2009 at 10:37 AM, Cosmin Cremarenco < cosmin.cremare...@gmail.com> wrote: > > It is Visual Studio 2003 - Version 7.1.6030. > I think the .1 minor comes from the installation of sp1 over 7.0 > > Cosmin > > On Jul 6, 7:33 pm, Kenton Varda wrote: