[protobuf] protobuf 3 without threadlocal

I have a target which is old enough that it doesn't support thread local variables. I'd like to build the protobuf3 libraries for it. It looks like all I need to do is trigger arena.h and arena.cc to use the version of thread_cache that is used by Android which uses pthread_key_create. One wa

Re: [protobuf] protobuf 3 without threadlocal

i, Jun 5, 2015 at 7:02 PM, Austin Schuh > wrote: > >> I have a target which is old enough that it doesn't support thread local >> variables. I'd like to build the protobuf3 libraries for it. >> >> It looks like all I need to do is trigger arena.h and are

[protobuf] Clang's MSAN reports issue with statusor_test.cc

I built the protobuf compiler and test suites today with the MemorySanitizer in Clang, and ran into an issue with uninitialized variables in protobuf/src/google/protobuf/stubs/statusor_test.cc. Both StatusOr.TestPointerCopyCtorStatusNotOkConverting and StatusOr.TestPointerAssignmentStatusNotOkConv

Re: [protobuf] Clang's MSAN reports issue with statusor_test.cc

https://github.com/google/protobuf/issues/693 On Wed, Aug 5, 2015 at 1:29 PM Feng Xiao wrote: > On Mon, Aug 3, 2015 at 7:00 PM, Austin Schuh > wrote: > >> I built the protobuf compiler and test suites today with the >> MemorySanitizer in Clang, and ran into an iss

[protobuf] Error checking with arena allocators

I discovered while writing some code that if you pre-allocate an arena that is too small, you get an out of bounds access, and then (if you are lucky), a crash. The following pull request adds a check. https://github.com/google/protobuf/pull/727 Thanks, Austin -- You received this message be

[protobuf] Re: Error checking with arena allocators

What would it take to get this merged? Austin On Tue, Aug 25, 2015 at 8:42 PM Austin Schuh wrote: > I discovered while writing some code that if you pre-allocate an arena > that is too small, you get an out of bounds access, and then (if you are > lucky), a crash. The following pul

Re: [protobuf] Re: Error checking with arena allocators

Wohoo! In the future, should I poke you guys again in a couple days/week if I don't hear back? Austin On Thu, Sep 24, 2015 at 5:42 PM Feng Xiao wrote: > Just merged it :) > > On Thu, Sep 24, 2015 at 3:51 PM, Austin Schuh > wrote: > >> What would it take to get

[protobuf] Strings and Arenas

Hi, I've got an application where I can't allocate memory while using protobufs. Arenas have been awesome for doing that. I'm able to allocate a big block of memory at startup time or stack allocate memory for the arena, and then use that for allocating protobufs. Thanks! I'd like to be able t

Re: [protobuf] Strings and Arenas

On Fri, Jan 15, 2016 at 11:32 AM Feng Xiao wrote: > On Thu, Jan 14, 2016 at 6:06 PM, Austin Schuh > wrote: > >> Hi, >> >> I've got an application where I can't allocate memory while using >> protobufs. Arenas have been awesome for doing that. I

Re: [protobuf] Strings and Arenas

On Fri, Jan 15, 2016 at 1:30 PM Feng Xiao wrote: > On Fri, Jan 15, 2016 at 11:50 AM, Austin Schuh > wrote: > >> On Fri, Jan 15, 2016 at 11:32 AM Feng Xiao wrote: >> >>> On Thu, Jan 14, 2016 at 6:06 PM, Austin Schuh >>> wrote: >>> >>