On Mon, Jan 11, 2010 at 10:45 PM, Kenton Varda wrote:
> On Mon, Jan 11, 2010 at 10:08 PM, edan wrote:
>
>> No, I can't imagine there is. But what you could do is create a unit test
>> that runs during "make check" whose sole purpose is to include all the
>> headers, and compile with "-Werror".
On Mon, Jan 11, 2010 at 10:08 PM, edan wrote:
> No, I can't imagine there is. But what you could do is create a unit test
> that runs during "make check" whose sole purpose is to include all the
> headers, and compile with "-Werror". Then you would catch any warnings in
> the headers and be abl
Is there a GCC flag which would allow me to compile the protobuf package
> itself with different warning settings for headers vs. source files?
>
No, I can't imagine there is. But what you could do is create a unit test
that runs during "make check" whose sole purpose is to include all the
heade
Documentation has been updated.
On Fri, Jan 8, 2010 at 4:51 PM, Kenton Varda wrote:
> I've pushed the final release of Protobuf 2.3.0:
>
> http://code.google.com/p/protobuf/downloads/list
>
> Documentation updates are still in review but I hope to have them up
> Monday.
>
> 2009-01-08 version 2.
On Mon, Jan 11, 2010 at 11:03 AM, Christopher Smith wrote:
> I hate to quibble on this, but strictly speaking:
>
>
> for (int i = 0; i < some_vector.size(); i++)
>
> is not perfectly valid unless you have verified that some_vector.size() <
> static_cast(std::numeric_limits::max());
>
Good point,
On Mon, Jan 11, 2010 at 11:02 AM, wrote:
> You make very valid points. I will consider using the -isystem flag.
> However i would like to point out that i am not expecting protobuf itself to
> compile with all the same warnings strictures that my code does - indeed
> that would be unreasonable. B
I hate to quibble on this, but strictly speaking:
for (int i = 0; i < some_vector.size(); i++)
is not perfectly valid unless you have verified that some_vector.size() <
static_cast(std::numeric_limits::max());
This would be broken in cases of a very large vector (possible with a
vector on 32-bi
ssage-
Subject: Re: [protobuf] Re: 2.3.0 released
From: Kenton Varda
Date: 11.01.2010 20.35
We get a lot of complaints about warnings in our code. When the warnings
occur in generated code, I generally fix them (because generated code
generally must be compiled using your project's flags
Fixed at revision 302.
On Mon, Jan 11, 2010 at 10:35 AM, Kenton Varda wrote:
> We get a lot of complaints about warnings in our code. When the warnings
> occur in generated code, I generally fix them (because generated code
> generally must be compiled using your project's flags), but for warni
We get a lot of complaints about warnings in our code. When the warnings
occur in generated code, I generally fix them (because generated code
generally must be compiled using your project's flags), but for warnings in
protobuf code my answer is that you need to include the protobuf headers as
sys
I looks like a good workaround - thanks for the info.
I will wait and see if Kenton is planning to fix this, then decide my next
steps.
--edan
On Sun, Jan 10, 2010 at 10:59 AM, Monty Taylor wrote:
>
>
> edan wrote:
> > I happily upgraded to 2.3.0 - I always like to take the latest and
> greatest
edan wrote:
> I happily upgraded to 2.3.0 - I always like to take the latest and greatest.
> Unfortunately, and I think for the first time ever while upgrading
> protobuf, I ran into a problem!
> We compile our code with "-Werror", and this bombed out on a header file:
We build with errors on in
I happily upgraded to 2.3.0 - I always like to take the latest and greatest.
Unfortunately, and I think for the first time ever while upgrading protobuf,
I ran into a problem!
We compile our code with "-Werror", and this bombed out on a header file:
cc1plus: warnings being treated as errors
../../
On Fri, Jan 8, 2010 at 4:51 PM, Kenton Varda wrote:
> 2009-01-08 version 2.3.0:
>
> Aaaand, there's my one screw-up for this release.
--
You received this message because you are subscribed to the Google Groups "Protocol Buffers" group.
To post to this group, send email to proto...@googlegroup
14 matches
Mail list logo
