Re: [protobuf] Re: Comparing "Any" type protobufs (C++)

2017-06-09 Thread Alex Shaver
Yes, I came to realize that a little after I posted, so I'd deleted the original post. We were using 3.0.2, and now I'm trying to get buy in for 3.3 On Thursday, June 8, 2017 at 3:29:57 PM UTC-4, Bo Yang wrote: > > Which version are you using? > It seems the bug has been fixed in the latest

Re: [protobuf] Re: Comparing "Any" type protobufs (C++)

2017-06-08 Thread 'Bo Yang' via Protocol Buffers
Which version are you using? It seems the bug has been fixed in the latest release. https://github.com/google/protobuf/blob/2f4489a3e504e0a4aaffee69b551c6acc9e08374/src/google/protobuf/util/message_differencer.cc#L470 On Wed, Jun 7, 2017 at 2:29 PM Alex Shaver wrote: >

[protobuf] Re: Comparing "Any" type protobufs (C++)

2017-06-07 Thread Alex Shaver
Reading through the source, it does seem like when Compare hits UnpackAny, that 'GetDescriptor' check should avoid the fatal check. However, I'm looking at source from a contemporary git pull, and the version in my software may be an older one, if this is a recent change. On Wednesday, June 7,