[protobuf] Re: Issue 211 in protobuf: common.cc calls "abort" on FATAL messages
Comment #8 on issue 211 by goo...@thenuthand.com: common.cc calls "abort" on FATAL messages http://code.google.com/p/protobuf/issues/detail?id=211 Looks good. Thank you. -- You received this message because you are subscribed to the Google Groups "Protocol Buffers" group. To post to this group, send email to proto...@googlegroups.com. To unsubscribe from this group, send email to protobuf+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/protobuf?hl=en.
[protobuf] Re: Issue 211 in protobuf: common.cc calls "abort" on FATAL messages
Comment #6 on issue 211 by liuj...@google.com: common.cc calls "abort" on FATAL messages http://code.google.com/p/protobuf/issues/detail?id=211 OK, will do. -- You received this message because you are subscribed to the Google Groups "Protocol Buffers" group. To post to this group, send email to proto...@googlegroups.com. To unsubscribe from this group, send email to protobuf+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/protobuf?hl=en.
[protobuf] Re: Issue 211 in protobuf: common.cc calls "abort" on FATAL messages
Comment #5 on issue 211 by goo...@thenuthand.com: common.cc calls "abort" on FATAL messages http://code.google.com/p/protobuf/issues/detail?id=211 Putting the parameters of the log statement would also be great, or at least the error message (message_) that was written. -- You received this message because you are subscribed to the Google Groups "Protocol Buffers" group. To post to this group, send email to proto...@googlegroups.com. To unsubscribe from this group, send email to protobuf+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/protobuf?hl=en.
[protobuf] Re: Issue 211 in protobuf: common.cc calls "abort" on FATAL messages
Updates: Status: Accepted Owner: liuj...@google.com Labels: -FixedIn-2.4.0 Comment #4 on issue 211 by temporal: common.cc calls "abort" on FATAL messages http://code.google.com/p/protobuf/issues/detail?id=211 Yes, you're right. We should define a subclass of std::exception and throw that. -- You received this message because you are subscribed to the Google Groups "Protocol Buffers" group. To post to this group, send email to proto...@googlegroups.com. To unsubscribe from this group, send email to protobuf+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/protobuf?hl=en.
[protobuf] Re: Issue 211 in protobuf: common.cc calls "abort" on FATAL messages
Comment #3 on issue 211 by goo...@thenuthand.com: common.cc calls "abort" on FATAL messages http://code.google.com/p/protobuf/issues/detail?id=211 Though better than abort, "throw -1" is not an extremely helpful exception: it won'y be possible to locate the source of the exception. A simply derived class from std::exception would be best (to allow catching just that exception), or at least using one of the standard exceptions. -- You received this message because you are subscribed to the Google Groups "Protocol Buffers" group. To post to this group, send email to proto...@googlegroups.com. To unsubscribe from this group, send email to protobuf+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/protobuf?hl=en.
[protobuf] Re: Issue 211 in protobuf: common.cc calls "abort" on FATAL messages
Updates: Status: Accepted Comment #1 on issue 211 by ken...@google.com: common.cc calls "abort" on FATAL messages http://code.google.com/p/protobuf/issues/detail?id=211 FATAL errors only happen in places that would otherwise crash. We do not use exceptions in C++ code at Google. Our reasons are described here: http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Exceptions That said, I suppose it would not be that hard to throw an exception in the FATAL logging code in the open source version of the code. Clients who use exceptions will be able to catch it; those who don't will just get the existing behavior. Note that all our production servers at Google use this code. -- You received this message because you are subscribed to the Google Groups "Protocol Buffers" group. To post to this group, send email to proto...@googlegroups.com. To unsubscribe from this group, send email to protobuf+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/protobuf?hl=en.
