[protobuf] Re: Issue 238 in protobuf: Support of comment in Python text-format parser
Updates:
Status: Invalid
Comment #4 on issue 238 by ken...@google.com: Support of comment in Python
text-format parser
http://code.google.com/p/protobuf/issues/detail?id=238
Well if it makes you feel better, I looked at the code and incorrectly
concluded that your bug report was correct because I couldn't find where
comments were removed, nor could I find any tests for it. However, looking
again, I see:
_WHITESPACE = re.compile('(\\s|(#.*$))+', re.MULTILINE)
It's bad that there's no test case covering this, but yeah, it does appear
that there is no bug.
--
You received this message because you are subscribed to the Google Groups Protocol
Buffers group.
To post to this group, send email to proto...@googlegroups.com.
To unsubscribe from this group, send email to
protobuf+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/protobuf?hl=en.
[protobuf] Re: Issue 238 in protobuf: Support of comment in Python text-format parser
Updates: Summary: Support of comment in Python text-format parser Status: Accepted Comment #1 on issue 238 by temporal: Support of comment in Python text-format parser http://code.google.com/p/protobuf/issues/detail?id=238 Wow. Apparently the author of the Python text-format code completely forgot about comments. The C++ and Java parser support shell-style comments. I can't believe this was not noticed earlier... -- You received this message because you are subscribed to the Google Groups Protocol Buffers group. To post to this group, send email to proto...@googlegroups.com. To unsubscribe from this group, send email to protobuf+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/protobuf?hl=en.
[protobuf] Re: Issue 238 in protobuf: Support of comment in Python text-format parser
Comment #2 on issue 238 by ken...@google.com: Support of comment in Python text-format parser http://code.google.com/p/protobuf/issues/detail?id=238 (That was me. Wrong account.) -- You received this message because you are subscribed to the Google Groups Protocol Buffers group. To post to this group, send email to proto...@googlegroups.com. To unsubscribe from this group, send email to protobuf+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/protobuf?hl=en.
[protobuf] Re: Issue 238 in protobuf: Support of comment in Python text-format parser
Comment #3 on issue 238 by zyangmath: Support of comment in Python text-format parser http://code.google.com/p/protobuf/issues/detail?id=238 Please mark it as invalid. So sorry to have made a mistake. In my latest test, it seems that the C++ style comments are not supported but in the shell-style comments, it IS SUPPORTED indeed. In the last test, I made a mistake by pasting a fake blank to the input file so the parse issued an strange error. Sorry ... -- You received this message because you are subscribed to the Google Groups Protocol Buffers group. To post to this group, send email to proto...@googlegroups.com. To unsubscribe from this group, send email to protobuf+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/protobuf?hl=en.
