[protobuf] Re: Issue 464 in protobuf: Inefficient Java handling of repeated list of primitive types
Comment #5 on issue 464 by ryan.fog...@gmail.com: Inefficient Java handling of repeated list of primitive types https://code.google.com/p/protobuf/issues/detail?id=464 In case anyone is wondering. I just diffed GPB versions 1.6.0 and 1.6.1 and there is no significant changes that would trip up the patch file. I.e. the patch derived from TwoSigma's solution and posted Sep14 should work just fine for 2.6.1. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "Protocol Buffers" group. To unsubscribe from this group and stop receiving emails from it, send an email to protobuf+unsubscr...@googlegroups.com. To post to this group, send email to protobuf@googlegroups.com. Visit this group at http://groups.google.com/group/protobuf. For more options, visit https://groups.google.com/d/optout.
[protobuf] Re: Issue 464 in protobuf: Inefficient Java handling of repeated list of primitive types
Comment #4 on issue 464 by hypn...@donarproject.org: Inefficient Java handling of repeated list of primitive types https://code.google.com/p/protobuf/issues/detail?id=464 Hello, for those who want to patch protobuf 2.6.0, here is the patch_no_autobox for protobuf 2.6.0. Hope this will be fixed in a further release. Thanks -- François Attachments: java_primitive_field.cc.patch 14.9 KB -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "Protocol Buffers" group. To unsubscribe from this group and stop receiving emails from it, send an email to protobuf+unsubscr...@googlegroups.com. To post to this group, send email to protobuf@googlegroups.com. Visit this group at http://groups.google.com/group/protobuf. For more options, visit https://groups.google.com/d/optout.
[protobuf] Re: Issue 464 in protobuf: Inefficient Java handling of repeated list of primitive types
Comment #3 on issue 464 by won...@gmail.com: Inefficient Java handling of repeated list of primitive types http://code.google.com/p/protobuf/issues/detail?id=464 Hi, We had the same issue at Two Sigma, so we developed a patch that *does not* adds any dependency. It passes all the unit tests, preserves the immutability, and provides a way to get access to the non-boxed primitive types. Thanks, Jean-Baptiste Attachments: patch_no_autobox 14.6 KB -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "Protocol Buffers" group. To unsubscribe from this group and stop receiving emails from it, send an email to protobuf+unsubscr...@googlegroups.com. To post to this group, send email to protobuf@googlegroups.com. Visit this group at http://groups.google.com/group/protobuf. For more options, visit https://groups.google.com/d/optout.
[protobuf] Re: Issue 464 in protobuf: Inefficient Java handling of repeated list of primitive types
Comment #2 on issue 464 by anno.lan...@gmail.com: Inefficient Java handling of repeated list of primitive types http://code.google.com/p/protobuf/issues/detail?id=464 I produced a different fix that preserves the immutability of the non-builders and, specifically, does not expose the underlying array in the interface. This solution, drags in a dependency to fastutil. I think the people who are concerned about this issue would actually approve of fastutil in their classpath. General protobuf users might be harder to motivate for the additional dependency. Attachments: fastutil-list-types-for-repeated-primitive-field.patch.bz2 2.9 KB -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "Protocol Buffers" group. To unsubscribe from this group and stop receiving emails from it, send an email to protobuf+unsubscr...@googlegroups.com. To post to this group, send email to protobuf@googlegroups.com. Visit this group at http://groups.google.com/group/protobuf. For more options, visit https://groups.google.com/groups/opt_out.
[protobuf] Re: Issue 464 in protobuf: Inefficient Java handling of repeated list of primitive types
Comment #1 on issue 464 by chuckmar...@gmail.com: Inefficient Java handling of repeated list of primitive types http://code.google.com/p/protobuf/issues/detail?id=464 This is a SERIOUS performance deficiency in the current generated java code! Please raise the priority to High. I know of development shops that are deciding AGAINST GPB for java because of this issue !!! -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "Protocol Buffers" group. To unsubscribe from this group and stop receiving emails from it, send an email to protobuf+unsubscr...@googlegroups.com. To post to this group, send email to protobuf@googlegroups.com. Visit this group at http://groups.google.com/group/protobuf. For more options, visit https://groups.google.com/groups/opt_out.
