Re: [protobuf] Contribution Guide?

2017-07-18 Thread Brian Bustamante
Makes sense. Thank you for the explanation. On Tuesday, July 18, 2017 at 3:28:17 PM UTC-4, Feng Xiao wrote: > > > > On Tue, Jul 18, 2017 at 7:04 AM, Brian Bustamante > wrote: > >> Hi Adam, >> >> Who would be the best person to talk about possibly adding support for a >> new language to the proto

Re: [protobuf] Contribution Guide?

2017-07-18 Thread 'Feng Xiao' via Protocol Buffers
On Tue, Jul 18, 2017 at 7:04 AM, Brian Bustamante wrote: > Hi Adam, > > Who would be the best person to talk about possibly adding support for a > new language to the protobuf compiler? > I have opened a mostly feature complete proto3 PR for F#: > https://github.com/google/protobuf/pull/3378 > We

Re: [protobuf] Contribution Guide?

2017-07-18 Thread Brian Bustamante
Hi Adam, Who would be the best person to talk about possibly adding support for a new language to the protobuf compiler? I have opened a mostly feature complete proto3 PR for F#: https://github.com/google/protobuf/pull/3378 Thanks, Brian On Monday, July 17, 2017 at 3:14:01 PM UTC-4, Adam Cozz

Re: [protobuf] Contribution Guide?

2017-07-17 Thread 'Adam Cozzette' via Protocol Buffers
I think for these small tweaks and fixes it doesn't matter much to us whether there's an associated GitHub issue or not, so whichever way you prefer is fine with me! On Mon, Jul 17, 2017 at 11:03 AM, Brad Larson wrote: > > > On Monday, July 17, 2017 at 12:20:22 PM UTC-5, Adam Cozzette wrote: >>

Re: [protobuf] Contribution Guide?

2017-07-17 Thread Brad Larson
On Monday, July 17, 2017 at 12:20:22 PM UTC-5, Adam Cozzette wrote: > > Hi Brad, > > We don't have any real contribution guide but just accept pull requests > fairly informally. Probably the one really important guideline is that if > you want to add a substantial new feature or make a major ch

Re: [protobuf] Contribution Guide?

2017-07-17 Thread 'Adam Cozzette' via Protocol Buffers
Hi Brad, We don't have any real contribution guide but just accept pull requests fairly informally. Probably the one really important guideline is that if you want to add a substantial new feature or make a major change, it's best to talk to us (the protobuf team) first before spending much time i