Re: Engine API naming

2012-12-13 Thread Weston M. Price
On Dec 13, 2012, at 7:23 PM, Rob Godfrey wrote: > On 14 December 2012 01:02, Weston M. Price wrote: > >> >> On Dec 13, 2012, at 6:22 PM, Rob Godfrey wrote: >> >>> A couple of comments... >>> >>> On 13 December 2012 23:37, Justin wrote: >>> API usability is important and deserves att

Re: Engine API naming

2012-12-13 Thread Rob Godfrey
On 14 December 2012 01:02, Weston M. Price wrote: > > On Dec 13, 2012, at 6:22 PM, Rob Godfrey wrote: > > > A couple of comments... > > > > On 13 December 2012 23:37, Justin wrote: > > > >> API usability is important and deserves attention. > >> > >> > > > > > > > >> > >> pn_link_drain > >> >

Re: Engine API naming

2012-12-13 Thread Weston M. Price
On Dec 13, 2012, at 6:22 PM, Rob Godfrey wrote: > A couple of comments... > > On 13 December 2012 23:37, Justin wrote: > >> API usability is important and deserves attention. >> >> > > > >> >> pn_link_drain >> >>Existing C name:pn_link_drain >>Proposed C name:pn_link_r

Re: Engine API naming

2012-12-13 Thread Rob Godfrey
A couple of comments... On 13 December 2012 23:37, Justin wrote: > API usability is important and deserves attention. > > > > pn_link_drain > > Existing C name:pn_link_drain > Proposed C name:pn_link_rescind_credit > Existing Java name: Receiver.drain > Proposed Java

Re: Engine API naming

2012-12-13 Thread Weston M. Price
Nice suggestions actually. I think some of the discrepancy has to do with the difference between languages and the idioms that have long been fossilized int the different naming conventions. Again, all suggestions on proposed look good to me. Regards, -W On Dec 13, 2012, at 5:37 PM, Justin

[jira] [Commented] (PROTON-185) Can't build proton-c - undefined symbols ERR_get_error etc

2012-12-13 Thread Andrew Stitcher (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13531592#comment-13531592 ] Andrew Stitcher commented on PROTON-185: I've fixed this in accordance with Ken's

[jira] [Resolved] (PROTON-185) Can't build proton-c - undefined symbols ERR_get_error etc

2012-12-13 Thread Andrew Stitcher (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Stitcher resolved PROTON-185. Resolution: Fixed Fix Version/s: 0.3 > Can't build proton-c - undefined symbols

Engine API naming

2012-12-13 Thread Justin
API usability is important and deserves attention. Take, for instance, DeliveryState versus Disposition. That only serves to confuse people. It's a difference that has no content. I also think link.drained and link.offered are very unclear. I've found the whole process of proposing API rev

[jira] [Commented] (PROTON-26) Engine api naming proposal

2012-12-13 Thread Justin Ross (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-26?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13531571#comment-13531571 ] Justin Ross commented on PROTON-26: --- That's really not the case. Rejecting it is fine, b

[jira] [Commented] (PROTON-185) Can't build proton-c - undefined symbols ERR_get_error etc

2012-12-13 Thread Andrew Stitcher (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13531570#comment-13531570 ] Andrew Stitcher commented on PROTON-185: Ah - it's not VERSION_LESS thats not defi

[jira] [Resolved] (PROTON-164) Messenger not handling connection errors properly

2012-12-13 Thread Rafael H. Schloming (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rafael H. Schloming resolved PROTON-164. Resolution: Fixed Assignee: Rafael H. Schloming > Messenger not handling

[jira] [Resolved] (PROTON-163) On connection open @ is appended to the hostname

2012-12-13 Thread Rafael H. Schloming (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rafael H. Schloming resolved PROTON-163. Resolution: Fixed Fix Version/s: 0.3 Assignee: Rafael H. Schloming

[jira] [Closed] (PROTON-26) Engine api naming proposal

2012-12-13 Thread Rafael H. Schloming (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-26?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rafael H. Schloming closed PROTON-26. - Resolution: Fixed Fix Version/s: 0.2 Assignee: Rafael H. Schloming I belie

[jira] [Resolved] (PROTON-43) Provides messenger send/receive examples in C

2012-12-13 Thread Rafael H. Schloming (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-43?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rafael H. Schloming resolved PROTON-43. --- Resolution: Fixed Fix Version/s: 0.2 > Provides messenger send/receive exam

[jira] [Resolved] (PROTON-10) Need a means of specifying error details when detaching a link

2012-12-13 Thread Rafael H. Schloming (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-10?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rafael H. Schloming resolved PROTON-10. --- Resolution: Fixed Fix Version/s: 0.3 > Need a means of specifying error det

[jira] [Assigned] (PROTON-10) Need a means of specifying error details when detaching a link

2012-12-13 Thread Rafael H. Schloming (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-10?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rafael H. Schloming reassigned PROTON-10: - Assignee: Rafael H. Schloming > Need a means of specifying error details when

[jira] [Commented] (PROTON-185) Can't build proton-c - undefined symbols ERR_get_error etc

2012-12-13 Thread Andrew Stitcher (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13531534#comment-13531534 ] Andrew Stitcher commented on PROTON-185: One problem is that VERSION_LESS seems no

[jira] [Assigned] (PROTON-185) Can't build proton-c - undefined symbols ERR_get_error etc

2012-12-13 Thread Ken Giusti (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti reassigned PROTON-185: - Assignee: Andrew Stitcher (was: Ken Giusti) > Can't build proton-c - undefined symbols ERR_g

[jira] [Commented] (PROTON-185) Can't build proton-c - undefined symbols ERR_get_error etc

2012-12-13 Thread Ken Giusti (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13531527#comment-13531527 ] Ken Giusti commented on PROTON-185: --- That patch isn't production quality - hardcoding th

[jira] [Resolved] (PROTON-180) The driver needs to be able to manage the application's non-AMQP file descriptors

2012-12-13 Thread Ted Ross (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Ross resolved PROTON-180. - Resolution: Fixed > The driver needs to be able to manage the application's non-AMQP file > descript

[jira] [Updated] (PROTON-185) Can't build proton-c - undefined symbols ERR_get_error etc

2012-12-13 Thread Ken Giusti (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti updated PROTON-185: -- Attachment: GITDIFF.txt Turns out, old (pre 2.8.0) versions of Cmake don't add crypto to the set of re

[jira] [Resolved] (PROTON-127) Rename the org.apache.qpid.proton.type package for nicer Scala support

2012-12-13 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey resolved PROTON-127. Resolution: Fixed Fix Version/s: 0.3 The type package has been removed. The public API clas

[jira] [Assigned] (PROTON-127) Rename the org.apache.qpid.proton.type package for nicer Scala support

2012-12-13 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey reassigned PROTON-127: -- Assignee: Rob Godfrey > Rename the org.apache.qpid.proton.type package for nicer Scala supp

[jira] [Commented] (PROTON-186) Message encode should always return the number of bytes needed to fully encode the message

2012-12-13 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13531400#comment-13531400 ] Rob Godfrey commented on PROTON-186: Patch applied (with modifications) to add the enc

[jira] [Updated] (PROTON-186) Message encode should always return the number of bytes needed to fully encode the message

2012-12-13 Thread Hiram Chirino (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiram Chirino updated PROTON-186: - Attachment: (was: PROTON-186.patch) > Message encode should always return the number of b

[jira] [Updated] (PROTON-186) Message encode should always return the number of bytes needed to fully encode the message

2012-12-13 Thread Hiram Chirino (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiram Chirino updated PROTON-186: - Attachment: PROTON-186v2.patch > Message encode should always return the number of bytes need

[jira] [Updated] (PROTON-186) Message encode should always return the number of bytes needed to fully encode the message

2012-12-13 Thread Hiram Chirino (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiram Chirino updated PROTON-186: - Attachment: PROTON-186v2.patch Attaching updated patch that does not change the current encode be

[jira] [Updated] (PROTON-186) Message encode should always return the number of bytes needed to fully encode the message

2012-12-13 Thread Hiram Chirino (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiram Chirino updated PROTON-186: - Attachment: (was: PROTON-186v2.patch) > Message encode should always return the number of

[jira] [Updated] (PROTON-186) Message encode should always return the number of bytes needed to fully encode the message

2012-12-13 Thread Hiram Chirino (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiram Chirino updated PROTON-186: - Attachment: PROTON-186.patch Attaching patch which implements this for proton-j

[jira] [Created] (PROTON-186) Message encode should always return the number of bytes needed to fully encode the message

2012-12-13 Thread Hiram Chirino (JIRA)
Hiram Chirino created PROTON-186: Summary: Message encode should always return the number of bytes needed to fully encode the message Key: PROTON-186 URL: https://issues.apache.org/jira/browse/PROTON-186

[jira] [Updated] (PROTON-186) Message encode should always return the number of bytes needed to fully encode the message

2012-12-13 Thread Hiram Chirino (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiram Chirino updated PROTON-186: - Issue Type: Improvement (was: Bug) > Message encode should always return the number of bytes

[jira] [Commented] (PROTON-136) Add support for SSL session resumption

2012-12-13 Thread Rafael H. Schloming (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13531124#comment-13531124 ] Rafael H. Schloming commented on PROTON-136: Yes I think those changes would b

[jira] [Commented] (PROTON-136) Add support for SSL session resumption

2012-12-13 Thread Ken Giusti (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13531121#comment-13531121 ] Ken Giusti commented on PROTON-136: --- Rafi has mentioned a minor change to the proposed A

[jira] [Updated] (PROTON-185) Can't build proton-c - undefined symbols ERR_get_error etc

2012-12-13 Thread Andrew Stitcher (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Stitcher updated PROTON-185: --- Assignee: Ken Giusti > Can't build proton-c - undefined symbols ERR_get_error etc > -

[jira] [Resolved] (PROTON-48) Adds the PROTON_INSTALL_LIBDIR macro to the Cmake environment

2012-12-13 Thread Andrew Stitcher (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-48?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Stitcher resolved PROTON-48. --- Resolution: Fixed Fix Version/s: 0.3 > Adds the PROTON_INSTALL_LIBDIR macro to the

[jira] [Commented] (PROTON-181) SSL layer - deprecate old per-connection credentials API, introduce new top-level configuration domain

2012-12-13 Thread Philip Harvey (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13530810#comment-13530810 ] Philip Harvey commented on PROTON-181: -- The Python and Java changes have been committ