+1. I've also wondered why this one codebase was written with 2-space
indentation. My editors are all set up for 4-spaces so doing any work
in this code is a pain.
I'm in favor of converting all of it to comply with the 4-space convention.
-Ted
On 03/14/2013 09:18 AM, Ken Giusti wrote:
+1
It would be good to make this configurable, but in the absence of
configurability, we should turn Nagle off by default.
-Ted
On 03/14/2013 03:25 PM, Rafael Schloming wrote:
I think in most of the other network code at qpid we tend to disable nagle
as you suggest, so I expect it would
[
https://issues.apache.org/jira/browse/PROTON-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13603366#comment-13603366
]
Alan Conway commented on PROTON-215:
We also need Perl tests.
Add
Yes! I'd love to give it a whack.
Right after I kill a pesky SEV1 bug I'm working on
- Original Message -
Can you post the code for the scenario you describe?
--Rafael
On Wed, Mar 13, 2013 at 11:19 AM, Michael Goulish mgoul...@redhat.comwrote:
What would you think about having
FYI - I'm looking into this.
- Forwarded Message -
From: Apache Jenkins Server jenk...@builds.apache.org
To: notificati...@qpid.apache.org
Sent: Thursday, March 14, 2013 10:38:17 PM
Subject: Build failed in Jenkins: Qpid-proton-c #34
See
On 03/14/2013 04:39 PM, Michael Goulish wrote:
Checked in at
trunk/docs/messenger/message_disposition.md
This one has it all !
Windows! Trackers! The joy of message acceptance
and the crushing disappointment of message rejection!
lie
Flash animation! Soundtrack featuring local indie
Excellent points, thanks !
- Original Message -
Just had a read through and it looks good overall. A few minor comments in
no particular order:
- The note at the end about rejected messages is not quite right.
Rejection does imply that the rejecting recipient will never be able to
Thanks! I will answer these questions in next version.
- Original Message -
On 03/14/2013 04:39 PM, Michael Goulish wrote:
Checked in at
trunk/docs/messenger/message_disposition.md
This one has it all !
Windows! Trackers! The joy of message acceptance
and the crushing
I'm feeling a bit guilty about this one because I suspect it was my
indentation-related review comments on some of Ken's recent soak test work
that may have been the catalyst for this thread.
We've got a few options about what to do, each bringing their own special
kind of pain.
I would be in
