[GitHub] qpid-proton pull request: NO-JIRA: Fix break in Javascript binding...

2016-03-31 Thread prestona
Github user prestona commented on the pull request: https://github.com/apache/qpid-proton/pull/72#issuecomment-203982961 Hi @astitcher - I've added a second commit which uses ${Proton_SOURCE_DIR}, as per your comment. If the CI builds complete successfully then: yes I

[GitHub] qpid-proton pull request: NO-JIRA: Fix break in Javascript binding...

2016-03-31 Thread prestona
GitHub user prestona opened a pull request: https://github.com/apache/qpid-proton/pull/72 NO-JIRA: Fix break in Javascript bindings build Attempting to build Proton with Emscripten on the path fails with the following message: /home/prestona/git/qpid-proton/examples/c

[GitHub] qpid-proton pull request: PROTON-881: Make connect a non-blocking ...

2015-07-07 Thread prestona
Github user prestona closed the pull request at: https://github.com/apache/qpid-proton/pull/40 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] qpid-proton pull request: PROTON-881: Make connect a non-blocking ...

2015-07-07 Thread prestona
Github user prestona commented on the pull request: https://github.com/apache/qpid-proton/pull/40#issuecomment-119125236 Closing as merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] qpid-proton pull request: PROTON-881: Make connect a non-blocking ...

2015-07-01 Thread prestona
GitHub user prestona opened a pull request: https://github.com/apache/qpid-proton/pull/40 PROTON-881: Make connect a non-blocking operation Previously connecting was a blocking operation which meant that if the server being connected to took a long time to accept the connection

[GitHub] qpid-proton pull request: PROTON-881: Graceful handling of runtime...

2015-07-01 Thread prestona
Github user prestona closed the pull request at: https://github.com/apache/qpid-proton/pull/37 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] qpid-proton pull request: PROTON-881: Graceful handling of runtime...

2015-07-01 Thread prestona
Github user prestona commented on the pull request: https://github.com/apache/qpid-proton/pull/37#issuecomment-117609566 This was merged by @rhs as cd42324 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] qpid-proton pull request: PROTON-881: Graceful handling of runtime...

2015-06-16 Thread prestona
Github user prestona commented on the pull request: https://github.com/apache/qpid-proton/pull/37#issuecomment-112419828 (Not sure what is happening with the Travis CI build - as I can't reproduce the test case failure if I pull the reactor branch and build locally) --- If

[GitHub] qpid-proton pull request: Reactor

2015-06-15 Thread prestona
Github user prestona commented on the pull request: https://github.com/apache/qpid-proton/pull/38#issuecomment-112227979 Sorry. Finger trouble. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] qpid-proton pull request: Reactor

2015-06-15 Thread prestona
Github user prestona closed the pull request at: https://github.com/apache/qpid-proton/pull/38 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] qpid-proton pull request: Reactor

2015-06-15 Thread prestona
GitHub user prestona opened a pull request: https://github.com/apache/qpid-proton/pull/38 Reactor You can merge this pull request into a Git repository by running: $ git pull https://github.com/prestona/qpid-proton reactor Alternatively you can review and apply these changes

[GitHub] qpid-proton pull request: PROTON-881: Graceful handling of runtime...

2015-06-15 Thread prestona
GitHub user prestona opened a pull request: https://github.com/apache/qpid-proton/pull/37 PROTON-881: Graceful handling of runtime exceptions thrown within han… …dlers When a runtime (unchecked) exceptions is thrown within a handler, the reactor now catches it and

[GitHub] qpid-proton pull request: PROTON-881: Graceful handling of runtime...

2015-06-03 Thread prestona
Github user prestona closed the pull request at: https://github.com/apache/qpid-proton/pull/34 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] qpid-proton pull request: PROTON-881: Graceful handling of runtime...

2015-06-03 Thread prestona
Github user prestona commented on the pull request: https://github.com/apache/qpid-proton/pull/34#issuecomment-108472809 No problem. I'll re-work and submit another PR based around HandlerException being unchecked. --- If your project is set up for it, you can reply to this

[GitHub] qpid-proton pull request: PROTON-881: Graceful handling of runtime...

2015-05-25 Thread prestona
GitHub user prestona opened a pull request: https://github.com/apache/qpid-proton/pull/34 PROTON-881: Graceful handling of runtime exceptions thrown within han… Adds support for more gracefully handling runtime exceptions thrown from within a handler. When a runtime

[GitHub] qpid-proton pull request: PROTON-881: make unittests check for Jav...

2015-05-18 Thread prestona
GitHub user prestona opened a pull request: https://github.com/apache/qpid-proton/pull/31 PROTON-881: make unittests check for Java I/O object leaks This implements an interface which is similar to pn_io - so that the various Java I/O resources (e.g. Selector, Pipe, SocketChannel

[GitHub] qpid-proton pull request: Reactor

2015-05-06 Thread prestona
GitHub user prestona opened a pull request: https://github.com/apache/qpid-proton/pull/30 Reactor This is an initial implementation of a proton-j version of the reactor. It comes with samples, unit tests and interoperation tests. It should be good enough to "kick the tyres

[GitHub] qpid-proton pull request: Reactor

2015-05-06 Thread prestona
Github user prestona closed the pull request at: https://github.com/apache/qpid-proton/pull/29 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] qpid-proton pull request: Reactor

2015-05-06 Thread prestona
Github user prestona commented on the pull request: https://github.com/apache/qpid-proton/pull/29#issuecomment-99640540 Closing. Will submit again against proton-j-reactor --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] qpid-proton pull request: Reactor

2015-05-06 Thread prestona
GitHub user prestona opened a pull request: https://github.com/apache/qpid-proton/pull/29 Reactor This is an initial implementation of a proton-j version of the reactor. It comes with samples, unit tests and interoperation tests. It should be good enough to "kick the tyres