Github user alanconway closed the pull request at:
https://github.com/apache/qpid-proton/pull/35
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user alanconway commented on the pull request:
https://github.com/apache/qpid-proton/pull/35#issuecomment-172062911
Out of date, latest is on master branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user gemmellr commented on the pull request:
https://github.com/apache/qpid-proton/pull/35#issuecomment-172041707
Can we close this old PR, doesnt seem like its being used anymore?
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user alanconway commented on the pull request:
https://github.com/apache/qpid-proton/pull/35#issuecomment-109426860
On Fri, 2015-06-05 at 13:05 -0700, Andrew Stitcher wrote:
> There are a number of places in the API where the API has something
> like:
> void setXXX(c
Github user astitcher commented on the pull request:
https://github.com/apache/qpid-proton/pull/35#issuecomment-109423155
There are a number of places in the API where the API has something like:
`void setXXX(const char* bytes, size_t size);` this isn't very C++ like -
in fact it a
Github user astitcher commented on the pull request:
https://github.com/apache/qpid-proton/pull/35#issuecomment-109421363
Another general point (I can't exactly see where to attach it in the
changes):
As well as using a class hierarchy to get callbacks, we should think about
Github user astitcher commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/35#discussion_r31844888
--- Diff: proton-c/bindings/CMakeLists.txt ---
@@ -109,6 +109,11 @@ if (EMSCRIPTEN_FOUND)
set (DEFAULT_JAVASCRIPT ON)
endif (EMSCRIPTEN_FOUND
Github user astitcher commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/35#discussion_r31844585
--- Diff: proton-c/bindings/cpp/include/proton/cpp/Acceptor.h ---
@@ -0,0 +1,50 @@
+#ifndef PROTON_CPP_ACCEPTOR_H
+#define PROTON_CPP_ACCEPTOR_H
Github user astitcher commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/35#discussion_r31844356
--- Diff: CMakeLists.txt ---
@@ -20,16 +20,15 @@ cmake_minimum_required (VERSION 2.6)
project (Proton C)
+# Enable C++ now for examp
Github user alanconway commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/35#discussion_r31844238
--- Diff: proton-c/bindings/cpp/include/proton/cpp/Acceptor.h ---
@@ -0,0 +1,50 @@
+#ifndef PROTON_CPP_ACCEPTOR_H
+#define PROTON_CPP_ACCEPTOR_H
Github user alanconway commented on the pull request:
https://github.com/apache/qpid-proton/pull/35#issuecomment-109413137
On Fri, 2015-06-05 at 10:37 -0700, Andrew Stitcher wrote:
> There seem to be a couple of extraneous go example files that have
> snuck into this PR
> รข
Github user astitcher commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/35#discussion_r31843690
--- Diff: proton-c/bindings/cpp/include/proton/cpp/Acceptor.h ---
@@ -0,0 +1,50 @@
+#ifndef PROTON_CPP_ACCEPTOR_H
+#define PROTON_CPP_ACCEPTOR_H
Github user alanconway commented on the pull request:
https://github.com/apache/qpid-proton/pull/35#issuecomment-109412800
On Fri, 2015-06-05 at 11:13 -0700, Andrew Stitcher wrote:
> Some overall comments (from a not yet thorough) read through:
> I really don't like using set/ge
Github user alanconway commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/35#discussion_r31842854
--- Diff: proton-c/bindings/cpp/README.md ---
@@ -0,0 +1,24 @@
+# C++ binding for proton.
+
+This is a C++ wrapper for the proton reactor AP
Github user alanconway commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/35#discussion_r31842778
--- Diff: proton-c/bindings/CMakeLists.txt ---
@@ -109,6 +109,11 @@ if (EMSCRIPTEN_FOUND)
set (DEFAULT_JAVASCRIPT ON)
endif (EMSCRIPTEN_FOUN
Github user alanconway commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/35#discussion_r31842586
--- Diff: CMakeLists.txt ---
@@ -20,16 +20,15 @@ cmake_minimum_required (VERSION 2.6)
project (Proton C)
+# Enable C++ now for exam
Github user alanconway commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/35#discussion_r31840954
--- Diff: examples/cpp/example_test.py ---
@@ -0,0 +1,105 @@
+#
--- End diff --
No, it is a test script that runs the C++ examples and
Github user astitcher commented on the pull request:
https://github.com/apache/qpid-proton/pull/35#issuecomment-109383948
Some overall comments (from a not yet thorough) read through:
* I really don't like using set/get in a C++ API. It's not idiomatic C++
API style; it's not
Github user astitcher commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/35#discussion_r31834639
--- Diff: proton-c/bindings/cpp/README.md ---
@@ -0,0 +1,24 @@
+# C++ binding for proton.
+
+This is a C++ wrapper for the proton reactor API
Github user astitcher commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/35#discussion_r31834366
--- Diff: proton-c/bindings/CMakeLists.txt ---
@@ -109,6 +109,11 @@ if (EMSCRIPTEN_FOUND)
set (DEFAULT_JAVASCRIPT ON)
endif (EMSCRIPTEN_FOUND
Github user astitcher commented on the pull request:
https://github.com/apache/qpid-proton/pull/35#issuecomment-109372427
There seem to be a couple of extraneous go example files that have snuck
into this PR
---
If your project is set up for it, you can reply to this email and have y
Github user astitcher commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/35#discussion_r31833264
--- Diff: examples/cpp/example_test.py ---
@@ -0,0 +1,105 @@
+#
--- End diff --
Is this file being added by mistake? (It seems to be a p
Github user astitcher commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/35#discussion_r31832198
--- Diff: CMakeLists.txt ---
@@ -20,16 +20,15 @@ cmake_minimum_required (VERSION 2.6)
project (Proton C)
+# Enable C++ now for examp
GitHub user alanconway opened a pull request:
https://github.com/apache/qpid-proton/pull/35
C++ binding for proton.
Cliff Jansen has been working on an event-driven C++ binding for proton,
similar to the python binding.
The work is not complete but I think it is almost ready to
24 matches
Mail list logo
